Skip to content

fix(dialog): keep Settings open when nested dialogs shift focus + BYOK secrets E2E - #13510

Merged
mattmillerai merged 13 commits into
mainfrom
matt/be-2593-f14-fe-add-list-delete-e2e
Jul 9, 2026
Merged

mattmillerai merged 13 commits into
mainfrom
matt/be-2593-f14-fe-add-list-delete-e2e

Conversation

@mattmillerai

@mattmillerai mattmillerai commented Jul 8, 2026 •

Copy link
Copy Markdown
Member

ELI-5

The settings screen now has a "Secrets" panel where you can save API keys for
model/AI providers. This PR does two things. First, it fixes a real bug the new
test caught: confirming a delete inside Settings made the whole Settings window
close itself — like a cashier abandoning the register because you put your
receipt in your pocket. Second, it adds an end-to-end test that plays out the
whole story like a real user: open the panel, add a key, watch it show up in
the list, then delete it — and checks the key you typed is never shown back
to you afterward.

What

Product fix: Settings no longer dismisses itself when a nested dialog closes

fix(dialog): the Settings dialog is non-modal (it must be, to host nested
confirm/edit dialogs). When a nested dialog closed and the element it had
focused was removed from the DOM (e.g. confirming a Secrets delete removes the
focused list row), browser focus fell to an ordinary app element — and the
non-modal Reka dialog read that programmatic focus shift as an outside
interaction and dismissed itself.

  • rekaPrimeVueBridge.ts / GlobalDialog.vue: onRekaFocusOutside now accepts
    a per-dialog dismissOnFocusOutside opt-out (escape and outside pointer
    clicks still dismiss).
  • useSettingsDialog.ts: Settings opts out of focus-outside dismissal.
  • dialogStore.ts: plumbs the new dialog prop.
  • Small review-feedback nits on the secret form (useSecretForm.ts,
    SecretFormDialog.vue, locale string).

E2E: BYOK secret add / list / delete flow

Adds browser_tests/tests/cloudSecrets.spec.ts, a Playwright spec covering the
secrets (API keys) surface in the cloud app:

  • Entitled account, full CRUD round-trip: empty state -> add a provider key
    (pick provider, name, secret value, save) -> the key appears in the list ->
    delete it via the confirm dialog -> back to empty state.
  • Secret value is write-only: asserts the create request carried the
    plaintext value, but the value is never echoed back into the DOM (the
    list-response schema is metadata-only).
  • Entitlement gate: an account whose provider allowlist is empty never sees
    the gated providers anywhere in the add dialog.

Follows the existing cloud E2E conventions: drives a raw page and reuses the
mockCloudBoot / bootCloud helpers so the app boots signed-in against fully
mocked endpoints. A small stateful in-memory handler backs the secrets endpoints
(list / create / delete + the provider allowlist) so the flow is deterministic
and never touches a real backend.

Why

Verification capstone for the secrets settings surface — proves the add / list /
delete flow works against the documented API behavior and locks in the two
contracts that matter: the secret value is never returned after creation, and
the provider allowlist is the only thing that surfaces gated providers to the
user. The dialog fix ships in the same PR because the E2E discovered it: the
delete step of the CRUD round-trip could not pass while Settings dismissed
itself, so the test and the fix are verified together.

Tests

  • browser_tests/tests/cloudSecrets.spec.ts — new, tagged @cloud; the delete
    step doubles as the regression test for the dialog fix.
  • GlobalDialog.test.ts — new unit case pinning dismissOnFocusOutside: false
    behavior in onRekaFocusOutside.
  • Static checks pass locally: oxlint (0 warnings/errors) and oxfmt formatting.

Follow-ups (tracked internally, agreed with reviewer)

  • Type the spec's in-memory secrets mocks with generated @comfyorg/ingest-types
    and return the API's real 201 create status, so the mock can't drift from
    the contract while the test stays green.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR introduces a server-driven BYOK (Bring Your Own Key) provider allowlist for secrets, adding Runway and Gemini providers with help text, refactoring useSecretForm/useSecrets to use string provider ids, updating the secret dialog UI, and adding e2e tests. It also adds a dismissOnFocusOutside opt-out for Reka dialogs to prevent unwanted dismissal from nested dialogs.

Changes

BYOK Secrets Provider Allowlist

Layer / File(s) Summary
Provider registry metadata and helpers
src/platform/secrets/providers.ts, src/platform/secrets/providers.test.ts, src/platform/secrets/types.ts, src/locales/en/main.json
ProviderConfig gains string value and optional helpKey; SECRET_PROVIDERS adds runway/gemini; new DEFAULT_PROVIDER_IDS and getProviderHelpKey exports; SECRET_PROVIDERS is no longer exported; SecretCreateRequest.provider becomes a free-form string; locale strings and tests added.
useSecretForm and useSecrets provider-id logic
src/platform/secrets/composables/useSecretForm.ts, .../useSecretForm.test.ts, .../useSecrets.ts
Provider state becomes string | null; providerOptions computed from server allowlist with dedup and default fallback; a watcher clears invalid selections; new providerHelp computed added; useSecrets.existingProviders returns string[].
Secret form dialog UI wiring
src/platform/secrets/components/SecretFormDialog.vue, SecretFormDialog.test.ts, SecretFormDialog.zindex.test.ts
Provider options render logos alongside labels; existingProviders prop retyped to string[]; hook destructuring updated to expose providerHelp; test mocks updated accordingly.
Cloud secrets end-to-end tests
browser_tests/tests/cloudSecrets.spec.ts
New Playwright spec mocks /api/secrets to verify add/list/delete flows without plaintext leakage and confirms gated providers are hidden for non-entitled accounts.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Dialog Focus-Outside Dismissal Opt-out

Layer / File(s) Summary
onRekaFocusOutside opt-out and wiring
src/components/dialog/rekaPrimeVueBridge.ts, GlobalDialog.vue, GlobalDialog.test.ts, src/stores/dialogStore.ts, src/platform/settings/composables/useSettingsDialog.ts
onRekaFocusOutside accepts an options object and prevents dismissal when dismissOnFocusOutside is false; GlobalDialog forwards dialogComponentProps; DialogComponentProps gains the new optional field; the settings dialog sets it false.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SettingsDialog
  participant GlobalDialog
  participant onRekaFocusOutside

  SettingsDialog->>GlobalDialog: showLayoutDialog(dismissOnFocusOutside: false)
  GlobalDialog->>onRekaFocusOutside: focus-outside(event, dialogComponentProps)
  onRekaFocusOutside->>onRekaFocusOutside: dismissOnFocusOutside === false?
  onRekaFocusOutside->>GlobalDialog: event.preventDefault(), no dismissal
Loading

Possibly related PRs

  • Comfy-Org/ComfyUI_frontend#12182: Both PRs modify the Reka focus-outside dismissal plumbing, extending onRekaFocusOutside and its wiring in GlobalDialog.vue.
  • Comfy-Org/ComfyUI_frontend#13494: Both PRs modify the secrets provider dropdown flow, switching provider options to server-provided allowlists through useSecrets/useSecretForm.

Suggested labels: released:cloud

Suggested reviewers: christian-byrne

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR includes a browser_tests Playwright spec, and the description concretely explains why the E2E regression test exists; the fail conditions are not all met.
Adr Compliance For Entity/Litegraph Changes ✅ Passed No changed files touch litegraph, ECS, or graph entity code, so ADR 0003/0008 checks are not applicable.
Title check ✅ Passed Title is concise and accurately captures the two main changes: the dialog focus fix and the BYOK secrets E2E test.
Description check ✅ Passed Includes a clear summary, change details, tests, and review notes; it covers the template's required information even though the headings differ.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch matt/be-2593-f14-fe-add-list-delete-e2e

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1689 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1670 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/09/2026, 07:04:30 PM UTC

Links

📦 Bundle: 7.78 MB gzip 🔴 +68 B

Details

Summary

  • Raw size: 32.8 MB baseline 32.8 MB — 🔴 +171 B
  • Gzip: 7.78 MB baseline 7.78 MB — 🔴 +68 B
  • Brotli: 5.36 MB baseline 5.36 MB — 🔴 +50 B
  • Bundles: 303 current • 303 baseline • 136 added / 136 removed

Category Glance
App Entry Points 🔴 +138 B (48 kB) · Utilities & Hooks 🔴 +34 B (3.39 MB) · Panels & Settings 🟢 -1 B (550 kB) · Vendor & Third-Party ⚪ 0 B (15.3 MB) · Other ⚪ 0 B (11.7 MB) · Graph Workspace ⚪ 0 B (1.27 MB) · + 5 more

App Entry Points — 48 kB (baseline 47.8 kB) • 🔴 +138 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-D8bqpTy4.js (new) — 48 kB 🔴 +48 kB 🔴 +14.1 kB 🔴 +12.2 kB
assets/index-BU78fW4O.js (removed) 47.8 kB — 🟢 -47.8 kB 🟢 -14.1 kB 🟢 -12.2 kB

Status: 1 added / 1 removed

Graph Workspace — 1.27 MB (baseline 1.27 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-B2_o1hRQ.js (removed) 1.27 MB — 🟢 -1.27 MB 🟢 -271 kB 🟢 -203 kB
assets/GraphView-D0IS-sQM.js (new) — 1.27 MB 🔴 +1.27 MB 🔴 +271 kB 🔴 +203 kB

Status: 1 added / 1 removed

Views & Navigation — 110 kB (baseline 110 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-CfTRxe4Y.js (new) — 25 kB 🔴 +25 kB 🔴 +6.25 kB 🔴 +5.52 kB
assets/CloudSurveyView-DL0--stu.js (removed) 25 kB — 🟢 -25 kB 🟢 -6.25 kB 🟢 -5.52 kB
assets/CloudLoginView-BBwd9Uxd.js (removed) 11.4 kB — 🟢 -11.4 kB 🟢 -3.06 kB 🟢 -2.67 kB
assets/CloudLoginView-CYUUvwTg.js (new) — 11.4 kB 🔴 +11.4 kB 🔴 +3.06 kB 🔴 +2.68 kB
assets/CloudSignupView-CA5fbDxW.js (removed) 9.79 kB — 🟢 -9.79 kB 🟢 -2.74 kB 🟢 -2.41 kB
assets/CloudSignupView-De6aMHHW.js (new) — 9.79 kB 🔴 +9.79 kB 🔴 +2.74 kB 🔴 +2.4 kB
assets/CloudLayoutView-BznGWBZ0.js (new) — 9.59 kB 🔴 +9.59 kB 🔴 +2.37 kB 🔴 +2.05 kB
assets/CloudLayoutView-Ir6UewM7.js (removed) 9.59 kB — 🟢 -9.59 kB 🟢 -2.37 kB 🟢 -2.06 kB
assets/UserCheckView-AKa03n-r.js (new) — 8.8 kB 🔴 +8.8 kB 🔴 +2.22 kB 🔴 +1.93 kB
assets/UserCheckView-H7MhSMAV.js (removed) 8.8 kB — 🟢 -8.8 kB 🟢 -2.22 kB 🟢 -1.93 kB
assets/CloudSubscriptionRedirectView-BTdQ0SRV.js (removed) 6.98 kB — 🟢 -6.98 kB 🟢 -2.58 kB 🟢 -2.28 kB
assets/CloudSubscriptionRedirectView-DfwAcBaE.js (new) — 6.98 kB 🔴 +6.98 kB 🔴 +2.58 kB 🔴 +2.27 kB
assets/WidgetTextPreview-DaEDx67Q.js (new) — 6.13 kB 🔴 +6.13 kB 🔴 +2.15 kB 🔴 +1.91 kB
assets/WidgetTextPreview-rGgS8Lat.js (removed) 6.13 kB — 🟢 -6.13 kB 🟢 -2.15 kB 🟢 -1.91 kB
assets/UserSelectView-B6QwNL5l.js (removed) 6 kB — 🟢 -6 kB 🟢 -2.15 kB 🟢 -1.89 kB
assets/UserSelectView-CQwcJOvj.js (new) — 6 kB 🔴 +6 kB 🔴 +2.15 kB 🔴 +1.88 kB
assets/CloudForgotPasswordView-DuSoljjt.js (new) — 5.15 kB 🔴 +5.15 kB 🔴 +1.76 kB 🔴 +1.54 kB
assets/CloudForgotPasswordView-IV4eJpvm.js (removed) 5.15 kB — 🟢 -5.15 kB 🟢 -1.76 kB 🟢 -1.53 kB
assets/CloudAuthTimeoutView-DKBi6hs5.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.57 kB 🟢 -1.37 kB
assets/CloudAuthTimeoutView-xVRYWV5K.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.58 kB 🔴 +1.36 kB
assets/WidgetTextPreview-BVzPI78G.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -90 B
assets/WidgetTextPreview-D6VKufQD.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +87 B

Status: 11 added / 11 removed / 3 unchanged

Panels & Settings — 550 kB (baseline 550 kB) • 🟢 -1 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel--LQET51f.js (new) — 49.4 kB 🔴 +49.4 kB 🔴 +9.97 kB 🔴 +8.83 kB
assets/KeybindingPanel-C_6Ng4yD.js (removed) 49.4 kB — 🟢 -49.4 kB 🟢 -9.97 kB 🟢 -8.82 kB
assets/SecretsPanel-BTcVjSwr.js (removed) 27.3 kB — 🟢 -27.3 kB 🟢 -6.63 kB 🟢 -5.8 kB
assets/SecretsPanel-DegoQO1f.js (new) — 27.3 kB 🔴 +27.3 kB 🔴 +6.63 kB 🔴 +5.8 kB
assets/CreditsPanel-D6cPv5s9.js (removed) 15.9 kB — 🟢 -15.9 kB 🟢 -4.66 kB 🟢 -4.09 kB
assets/CreditsPanel-DWTTdN22.js (new) — 15.9 kB 🔴 +15.9 kB 🔴 +4.66 kB 🔴 +4.09 kB
assets/AboutPanel-CL65UOTl.js (new) — 12 kB 🔴 +12 kB 🔴 +3.29 kB 🔴 +2.94 kB
assets/AboutPanel-DK4P0UI8.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.29 kB 🟢 -2.94 kB
assets/SubscriptionPanel-9fX7RfEz.js (removed) 11.5 kB — 🟢 -11.5 kB 🟢 -3.66 kB 🟢 -3.2 kB
assets/SubscriptionPanel-ByNlaHhj.js (new) — 11.5 kB 🔴 +11.5 kB 🔴 +3.66 kB 🔴 +3.21 kB
assets/ExtensionPanel-CvPFnrC6.js (new) — 9.03 kB 🔴 +9.03 kB 🔴 +2.49 kB 🔴 +2.2 kB
assets/ExtensionPanel-D4D5WBf1.js (removed) 9.03 kB — 🟢 -9.03 kB 🟢 -2.5 kB 🟢 -2.2 kB
assets/ServerConfigPanel-BvSjm1vJ.js (removed) 6.15 kB — 🟢 -6.15 kB 🟢 -1.97 kB 🟢 -1.76 kB
assets/ServerConfigPanel-hJhKzWAs.js (new) — 6.15 kB 🔴 +6.15 kB 🔴 +1.97 kB 🔴 +1.76 kB
assets/UserPanel-Cqvl227I.js (removed) 5.78 kB — 🟢 -5.78 kB 🟢 -1.82 kB 🟢 -1.58 kB
assets/UserPanel-DB6xsup4.js (new) — 5.78 kB 🔴 +5.78 kB 🔴 +1.82 kB 🔴 +1.58 kB
assets/refreshRemoteConfig-CWryMpIQ.js (removed) 2.88 kB — 🟢 -2.88 kB 🟢 -1.26 kB 🟢 -1.11 kB
assets/refreshRemoteConfig-Djgl-h7v.js (new) — 2.88 kB 🔴 +2.88 kB 🔴 +1.26 kB 🔴 +1.11 kB
assets/cloudRemoteConfig-BhOb-8Iy.js (new) — 990 B 🔴 +990 B 🔴 +541 B 🔴 +475 B
assets/cloudRemoteConfig-Cm_4p7Ym.js (removed) 990 B — 🟢 -990 B 🟢 -542 B 🟢 -466 B
assets/refreshRemoteConfig-C90g18TE.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +90 B
assets/refreshRemoteConfig-Druo9RJC.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -85 B

Status: 11 added / 11 removed / 16 unchanged

User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-B5NFIJhB.js (new) — 12.3 kB 🔴 +12.3 kB 🔴 +4.19 kB 🔴 +3.66 kB
assets/SignUpForm-CLYHknsX.js (removed) 12.3 kB — 🟢 -12.3 kB 🟢 -4.19 kB 🟢 -3.65 kB
assets/auth-B5iXuGqp.js (removed) 3.69 kB — 🟢 -3.69 kB 🟢 -1.3 kB 🟢 -1.13 kB
assets/auth-ChLAzM80.js (new) — 3.69 kB 🔴 +3.69 kB 🔴 +1.3 kB 🔴 +1.13 kB
assets/usePostAuthRedirect-BH6lgRld.js (new) — 3.33 kB 🔴 +3.33 kB 🔴 +1.27 kB 🔴 +1.11 kB
assets/usePostAuthRedirect-CDMVmQeV.js (removed) 3.33 kB — 🟢 -3.33 kB 🟢 -1.27 kB 🟢 -1.11 kB
assets/UpdatePasswordContent-BAqcQkJ5.js (removed) 1.92 kB — 🟢 -1.92 kB 🟢 -877 B 🟢 -768 B
assets/UpdatePasswordContent-D2UTuJpp.js (new) — 1.92 kB 🔴 +1.92 kB 🔴 +877 B 🔴 +765 B
assets/authStore-C9kwZsQ0.js (new) — 130 B 🔴 +130 B 🔴 +109 B 🔴 +123 B
assets/authStore-CM6qy4yi.js (removed) 130 B — 🟢 -130 B 🟢 -109 B 🟢 -121 B
assets/workspaceAuthStore-ClV6HFSU.js (new) — 110 B 🔴 +110 B 🔴 +104 B 🔴 +114 B
assets/workspaceAuthStore-hh1K17ct.js (removed) 110 B — 🟢 -110 B 🟢 -104 B 🟢 -114 B
assets/auth-_wMmeaVG.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +74 B
assets/auth-DeShHLbT.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -82 B

Status: 7 added / 7 removed / 3 unchanged

Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-BifyKCq5.js (removed) 90.5 kB — 🟢 -90.5 kB 🟢 -19.3 kB 🟢 -16.6 kB
assets/ComfyHubPublishDialog-CZAw1snx.js (new) — 90.5 kB 🔴 +90.5 kB 🔴 +19.3 kB 🔴 +16.5 kB
assets/useShareDialog-aowQTMQ4.js (new) — 23.7 kB 🔴 +23.7 kB 🔴 +5.58 kB 🔴 +4.97 kB
assets/useShareDialog-Dzu6UG8A.js (removed) 23.7 kB — 🟢 -23.7 kB 🟢 -5.58 kB 🟢 -4.98 kB
assets/ComfyHubPublishDialog-BO4Maivv.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +89 B
assets/ComfyHubPublishDialog-BTIu-XvQ.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -89 B
assets/useSubscriptionDialog-BZvAEuJD.js (removed) 110 B — 🟢 -110 B 🟢 -102 B 🟢 -91 B
assets/useSubscriptionDialog-Dcp7Bg5i.js (new) — 110 B 🔴 +110 B 🔴 +102 B 🔴 +96 B

Status: 4 added / 4 removed / 1 unchanged

UI Components — 57.5 kB (baseline 57.5 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-CGoK0zpQ.js (removed) 13.6 kB — 🟢 -13.6 kB 🟢 -3.82 kB 🟢 -3.41 kB
assets/ComfyQueueButton-SobxLsQn.js (new) — 13.6 kB 🔴 +13.6 kB 🔴 +3.82 kB 🔴 +3.41 kB
assets/useTerminalTabs-DCtny_zB.js (removed) 12.1 kB — 🟢 -12.1 kB 🟢 -3.83 kB 🟢 -3.38 kB
assets/useTerminalTabs-POByY9Bf.js (new) — 12.1 kB 🔴 +12.1 kB 🔴 +3.83 kB 🔴 +3.38 kB
assets/SubscribeButton-C9-ummbf.js (new) — 2.38 kB 🔴 +2.38 kB 🔴 +1.05 kB 🔴 +951 B
assets/SubscribeButton-rW6SI-QX.js (removed) 2.38 kB — 🟢 -2.38 kB 🟢 -1.05 kB 🟢 -915 B
assets/cloudFeedbackTopbarButton-D9g3FYTm.js (removed) 829 B — 🟢 -829 B 🟢 -497 B 🟢 -417 B
assets/cloudFeedbackTopbarButton-DgLOJCL3.js (new) — 829 B 🔴 +829 B 🔴 +497 B 🔴 +453 B
assets/ComfyQueueButton--BZctnOt.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +91 B
assets/ComfyQueueButton-B7y9WRNf.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -97 B

Status: 5 added / 5 removed / 8 unchanged

Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/load3dService-B9fcfnCX.js (new) — 127 kB 🔴 +127 kB 🔴 +27.8 kB 🔴 +23.5 kB
assets/load3dService-BfLYAD5T.js (removed) 127 kB — 🟢 -127 kB 🟢 -27.8 kB 🟢 -23.5 kB
assets/api-Aa8lUQMJ.js (removed) 91.9 kB — 🟢 -91.9 kB 🟢 -25.4 kB 🟢 -21.6 kB
assets/api-CrBoVmeJ.js (new) — 91.9 kB 🔴 +91.9 kB 🔴 +25.4 kB 🔴 +21.6 kB
assets/workflowShareService-B9_41e3N.js (new) — 17 kB 🔴 +17 kB 🔴 +5.01 kB 🔴 +4.44 kB
assets/workflowShareService-C0T_YrbI.js (removed) 17 kB — 🟢 -17 kB 🟢 -5.01 kB 🟢 -4.44 kB
assets/releaseStore-CUejKoRz.js (removed) 8.29 kB — 🟢 -8.29 kB 🟢 -2.34 kB 🟢 -2.04 kB
assets/releaseStore-vdQY4wQO.js (new) — 8.29 kB 🔴 +8.29 kB 🔴 +2.34 kB 🔴 +2.05 kB
assets/keybindingService-D4lnxqrs.js (removed) 7.46 kB — 🟢 -7.46 kB 🟢 -1.92 kB 🟢 -1.64 kB
assets/keybindingService-DSM3-R86.js (new) — 7.46 kB 🔴 +7.46 kB 🔴 +1.92 kB 🔴 +1.65 kB
assets/extensionStore-C3p8tKkZ.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.57 kB
assets/extensionStore-CipeOHHM.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.57 kB
assets/userStore-BABm8Djs.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +931 B 🔴 +822 B
assets/userStore-D6OSpeaZ.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -932 B 🟢 -823 B
assets/audioService-D56BaKaR.js (removed) 1.76 kB — 🟢 -1.76 kB 🟢 -861 B 🟢 -753 B
assets/audioService-p2Hr9OC6.js (new) — 1.76 kB 🔴 +1.76 kB 🔴 +860 B 🔴 +748 B
assets/dialogService-B5T8A2zK.js (new) — 100 B 🔴 +100 B 🔴 +99 B 🔴 +99 B
assets/dialogService-CUre_yZz.js (removed) 100 B — 🟢 -100 B 🟢 -99 B 🟢 -94 B
assets/settingStore-Cwu17lEY.js (removed) 98 B — 🟢 -98 B 🟢 -98 B 🟢 -93 B
assets/settingStore-DL-1NUXK.js (new) — 98 B 🔴 +98 B 🔴 +98 B 🔴 +97 B
assets/assetsStore-BQGK01v5.js (new) — 96 B 🔴 +96 B 🔴 +97 B 🔴 +100 B
assets/assetsStore-Cp_juyiI.js (removed) 96 B — 🟢 -96 B 🟢 -97 B 🟢 -100 B
assets/releaseStore-B6pzfdhu.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -86 B
assets/releaseStore-CbuPK98Z.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +79 B
assets/api-BOQr6HIm.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B
assets/api-f0H5SPWF.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B

Status: 13 added / 13 removed / 3 unchanged

Utilities & Hooks — 3.39 MB (baseline 3.39 MB) • 🔴 +34 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/promotionUtils-e_5OSoqd.js (new) — 3.03 MB 🔴 +3.03 MB 🔴 +699 kB 🔴 +527 kB
assets/promotionUtils-BNlo-xfs.js (removed) 3.03 MB — 🟢 -3.03 MB 🟢 -699 kB 🟢 -527 kB
assets/useConflictDetection-BF7oo2jK.js (new) — 234 kB 🔴 +234 kB 🔴 +52.3 kB 🔴 +42.6 kB
assets/useConflictDetection-CnLLewXK.js (removed) 234 kB — 🟢 -234 kB 🟢 -52.3 kB 🟢 -42.6 kB
assets/useLoad3d-79kgFS5a.js (new) — 25.5 kB 🔴 +25.5 kB 🔴 +5.75 kB 🔴 +5.09 kB
assets/useLoad3d-CjzdMTlh.js (removed) 25.5 kB — 🟢 -25.5 kB 🟢 -5.75 kB 🟢 -5.09 kB
assets/useLoad3dViewer-jPob4FxD.js (removed) 21.1 kB — 🟢 -21.1 kB 🟢 -4.98 kB 🟢 -4.36 kB
assets/useLoad3dViewer-kF2URFVx.js (new) — 21.1 kB 🔴 +21.1 kB 🔴 +4.98 kB 🔴 +4.35 kB
assets/useFeatureFlags-baQD5DFv.js (removed) 6.51 kB — 🟢 -6.51 kB 🟢 -2.02 kB 🟢 -1.71 kB
assets/useFeatureFlags-DWBZEo0G.js (new) — 6.51 kB 🔴 +6.51 kB 🔴 +2.02 kB 🔴 +1.7 kB
assets/subscriptionCheckoutUtil-aCDG7E4G.js (new) — 3.85 kB 🔴 +3.85 kB 🔴 +1.54 kB 🔴 +1.35 kB
assets/subscriptionCheckoutUtil-Du_791os.js (removed) 3.85 kB — 🟢 -3.85 kB 🟢 -1.54 kB 🟢 -1.35 kB
assets/useSessionCookie-BgU1631a.js (new) — 3.61 kB 🔴 +3.61 kB 🔴 +1.21 kB 🔴 +1.03 kB
assets/useSessionCookie-BQKO3sUH.js (removed) 3.61 kB — 🟢 -3.61 kB 🟢 -1.21 kB 🟢 -1.04 kB
assets/useDowngradeToPersonal-Bgqhth0O.js (new) — 3 kB 🔴 +3 kB 🔴 +1.19 kB 🔴 +1.04 kB
assets/useDowngradeToPersonal-j7fn2VnF.js (removed) 3 kB — 🟢 -3 kB 🟢 -1.19 kB 🟢 -1.02 kB
assets/assetPreviewUtil-B7nWgyya.js (removed) 2.41 kB — 🟢 -2.41 kB 🟢 -1 kB 🟢 -874 B
assets/assetPreviewUtil-Bgb5_lrG.js (new) — 2.41 kB 🔴 +2.41 kB 🔴 +1 kB 🔴 +879 B
assets/useUpstreamValue-Bi5URd4G.js (removed) 2.04 kB — 🟢 -2.04 kB 🟢 -791 B 🟢 -705 B
assets/useUpstreamValue-sCubHW0n.js (new) — 2.04 kB 🔴 +2.04 kB 🔴 +791 B 🔴 +704 B
assets/useWorkspaceTierLabel-CG6ZKMGM.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +854 B 🔴 +736 B
assets/useWorkspaceTierLabel-D-Ql4Ada.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -852 B 🟢 -735 B
assets/useLoad3d-Dv2UcrZ2.js (new) — 311 B 🔴 +311 B 🔴 +164 B 🔴 +148 B
assets/useLoad3d-DW1VwHHf.js (removed) 311 B — 🟢 -311 B 🟢 -162 B 🟢 -146 B
assets/useSessionCookie-BrCifxkZ.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +82 B
assets/useSessionCookie-TURn6vkv.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -83 B
assets/useFeatureFlags-_X3fZ7wf.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +90 B
assets/useFeatureFlags-YJV5bwKO.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -87 B
assets/useLoad3dViewer-BKOShgfA.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +92 B
assets/useLoad3dViewer-DhenkhUn.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -85 B
assets/useCurrentUser-CKCTP47k.js (new) — 96 B 🔴 +96 B 🔴 +97 B 🔴 +87 B
assets/useCurrentUser-TaMylNeP.js (removed) 96 B — 🟢 -96 B 🟢 -97 B 🟢 -88 B

Status: 16 added / 16 removed / 19 unchanged

Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 11.7 MB (baseline 11.7 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-CK_-sJbi.js (new) — 121 kB 🔴 +121 kB 🔴 +31 kB 🔴 +26.2 kB
assets/core-DwSzzS3f.js (removed) 121 kB — 🟢 -121 kB 🟢 -31 kB 🟢 -26.2 kB
assets/WidgetSelect-DTp13u4y.js (new) — 89.3 kB 🔴 +89.3 kB 🔴 +20.1 kB 🔴 +17.2 kB
assets/WidgetSelect-rS8G5o6a.js (removed) 89.3 kB — 🟢 -89.3 kB 🟢 -20.1 kB 🟢 -17.2 kB
assets/Load3DControls-B6zNG1X7.js (new) — 46.8 kB 🔴 +46.8 kB 🔴 +7.56 kB 🔴 +6.62 kB
assets/Load3DControls-DbKPIZa1.js (removed) 46.8 kB — 🟢 -46.8 kB 🟢 -7.56 kB 🟢 -6.6 kB
assets/SubscriptionTransitionPreviewWorkspace-Bvd2_S0G.js (new) — 46.8 kB 🔴 +46.8 kB 🔴 +9.65 kB 🔴 +8.53 kB
assets/SubscriptionTransitionPreviewWorkspace-D3TgGo9P.js (removed) 46.8 kB — 🟢 -46.8 kB 🟢 -9.65 kB 🟢 -8.57 kB
assets/SubscriptionRequiredDialogContentUnified-C1_faz5D.js (removed) 41.2 kB — 🟢 -41.2 kB 🟢 -9.16 kB 🟢 -7.98 kB
assets/SubscriptionRequiredDialogContentUnified-X8MMbnEc.js (new) — 41.2 kB 🔴 +41.2 kB 🔴 +9.16 kB 🔴 +7.96 kB
assets/WorkspacePanelContent-ClPfLiDK.js (new) — 34.5 kB 🔴 +34.5 kB 🔴 +7.49 kB 🔴 +6.61 kB
assets/WorkspacePanelContent-Dk2mRyCK.js (removed) 34.5 kB — 🟢 -34.5 kB 🟢 -7.49 kB 🟢 -6.61 kB
assets/WidgetPainter-CcLx4D3l.js (new) — 32.7 kB 🔴 +32.7 kB 🔴 +7.9 kB 🔴 +7.01 kB
assets/WidgetPainter-CIqvu51W.js (removed) 32.7 kB — 🟢 -32.7 kB 🟢 -7.9 kB 🟢 -7.02 kB
assets/Load3dViewerContent-BMMnF0QO.js (new) — 30.9 kB 🔴 +30.9 kB 🔴 +6.3 kB 🔴 +5.46 kB
assets/Load3dViewerContent-DBUT0CYK.js (removed) 30.9 kB — 🟢 -30.9 kB 🟢 -6.3 kB 🟢 -5.47 kB
assets/WidgetBoundingBoxes-B6_e72jU.js (removed) 28.6 kB — 🟢 -28.6 kB 🟢 -7.89 kB 🟢 -7 kB
assets/WidgetBoundingBoxes-CRavclI7.js (new) — 28.6 kB 🔴 +28.6 kB 🔴 +7.89 kB 🔴 +7 kB
assets/SubscriptionRequiredDialogContent-Cy2wYHg6.js (removed) 27.4 kB — 🟢 -27.4 kB 🟢 -6.75 kB 🟢 -5.96 kB
assets/SubscriptionRequiredDialogContent-xsFEAgBc.js (new) — 27.4 kB 🔴 +27.4 kB 🔴 +6.75 kB 🔴 +5.96 kB
assets/SubscriptionPanelContentWorkspace-BeC6qQyR.js (new) — 25 kB 🔴 +25 kB 🔴 +5.84 kB 🔴 +5.12 kB
assets/SubscriptionPanelContentWorkspace-z2lEGMAE.js (removed) 25 kB — 🟢 -25 kB 🟢 -5.84 kB 🟢 -5.12 kB
assets/SubscriptionRequiredDialogContentWorkspace-BCi-UMLz.js (removed) 24.6 kB — 🟢 -24.6 kB 🟢 -5.65 kB 🟢 -4.97 kB
assets/SubscriptionRequiredDialogContentWorkspace-U2taGIUj.js (new) — 24.6 kB 🔴 +24.6 kB 🔴 +5.65 kB 🔴 +4.97 kB
assets/WidgetImageCrop-Bf44c_i5.js (removed) 23.3 kB — 🟢 -23.3 kB 🟢 -5.75 kB 🟢 -5.04 kB
assets/WidgetImageCrop-OGgb1o0q.js (new) — 23.3 kB 🔴 +23.3 kB 🔴 +5.75 kB 🔴 +5.04 kB
assets/load3d-B0Jn3aLG.js (removed) 21.3 kB — 🟢 -21.3 kB 🟢 -5.19 kB 🟢 -4.51 kB
assets/load3d-BeR4BwBn.js (new) — 21.3 kB 🔴 +21.3 kB 🔴 +5.19 kB 🔴 +4.5 kB
assets/CurrentUserPopoverWorkspace-BTnvfPVn.js (new) — 20.6 kB 🔴 +20.6 kB 🔴 +4.75 kB 🔴 +4.23 kB
assets/CurrentUserPopoverWorkspace-e6kbBX6D.js (removed) 20.6 kB — 🟢 -20.6 kB 🟢 -4.74 kB 🟢 -4.23 kB
assets/SignInContent-BQ771FCf.js (new) — 20.1 kB 🔴 +20.1 kB 🔴 +5.07 kB 🔴 +4.43 kB
assets/SignInContent-DQgkWrXk.js (removed) 20.1 kB — 🟢 -20.1 kB 🟢 -5.07 kB 🟢 -4.43 kB
assets/WidgetInputNumber-B2RGHrEW.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.82 kB 🟢 -4.28 kB
assets/WidgetInputNumber-zgQKQ_wV.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.82 kB 🔴 +4.28 kB
assets/Load3D-DuvdfhCS.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.52 kB 🟢 -3.93 kB
assets/Load3D-uxMbZpOp.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.52 kB 🔴 +3.93 kB
assets/CreditsTile-DPNzrmQZ.js (removed) 17.1 kB — 🟢 -17.1 kB 🟢 -4.54 kB 🟢 -4.01 kB
assets/CreditsTile-vKCu5F69.js (new) — 17.1 kB 🔴 +17.1 kB 🔴 +4.54 kB 🔴 +4.01 kB
assets/WidgetRecordAudio-B544eSTq.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.63 kB 🔴 +4.14 kB
assets/WidgetRecordAudio-DPvbxB7G.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.63 kB 🟢 -4.14 kB
assets/WidgetRange-CxgO7Elo.js (new) — 16.2 kB 🔴 +16.2 kB 🔴 +4.16 kB 🔴 +3.72 kB
assets/WidgetRange-DNb4a6Xe.js (removed) 16.2 kB — 🟢 -16.2 kB 🟢 -4.16 kB 🟢 -3.73 kB
assets/WaveAudioPlayer-CMIgWIfF.js (removed) 12.8 kB — 🟢 -12.8 kB 🟢 -3.48 kB 🟢 -3.06 kB
assets/WaveAudioPlayer-DPTFWZRH.js (new) — 12.8 kB 🔴 +12.8 kB 🔴 +3.48 kB 🔴 +3.06 kB
assets/WidgetCurve-Ba34QlAu.js (new) — 11.3 kB 🔴 +11.3 kB 🔴 +3.5 kB 🔴 +3.16 kB
assets/WidgetCurve-CSqeAZ1i.js (removed) 11.3 kB — 🟢 -11.3 kB 🟢 -3.5 kB 🟢 -3.16 kB
assets/TeamWorkspacesDialogContent-B2cWhtI0.js (new) — 10.3 kB 🔴 +10.3 kB 🔴 +3 kB 🔴 +2.66 kB
assets/TeamWorkspacesDialogContent-BDWHSHwm.js (removed) 10.3 kB — 🟢 -10.3 kB 🟢 -3 kB 🟢 -2.66 kB
assets/Load3DConfiguration-D7qmZWsf.js (new) — 9.02 kB 🔴 +9.02 kB 🔴 +2.66 kB 🔴 +2.35 kB
assets/Load3DConfiguration-eVHYmr7Z.js (removed) 9.02 kB — 🟢 -9.02 kB 🟢 -2.66 kB 🟢 -2.35 kB
assets/onboardingCloudRoutes-2Bshcyrv.js (removed) 8.5 kB — 🟢 -8.5 kB 🟢 -2.67 kB 🟢 -2.29 kB
assets/onboardingCloudRoutes-DXw5bA_6.js (new) — 8.5 kB 🔴 +8.5 kB 🔴 +2.67 kB 🔴 +2.3 kB
assets/nodeTemplates-CbgPKsk8.js (new) — 8.33 kB 🔴 +8.33 kB 🔴 +2.88 kB 🔴 +2.54 kB
assets/nodeTemplates-DjUruGXn.js (removed) 8.33 kB — 🟢 -8.33 kB 🟢 -2.88 kB 🟢 -2.54 kB
assets/NightlySurveyController-BVFF6j4l.js (new) — 7.95 kB 🔴 +7.95 kB 🔴 +2.7 kB 🔴 +2.37 kB
assets/NightlySurveyController-CBwbrdc_.js (removed) 7.95 kB — 🟢 -7.95 kB 🟢 -2.7 kB 🟢 -2.39 kB
assets/InviteMemberDialogContent-_b0uRyY7.js (removed) 6.76 kB — 🟢 -6.76 kB 🟢 -2.22 kB 🟢 -1.96 kB
assets/InviteMemberDialogContent-eTWKrsbj.js (new) — 6.76 kB 🔴 +6.76 kB 🔴 +2.22 kB 🔴 +1.96 kB
assets/WidgetWithControl-Ce9PAwcx.js (removed) 6.38 kB — 🟢 -6.38 kB 🟢 -2.59 kB 🟢 -2.27 kB
assets/WidgetWithControl-nHCA7x2q.js (new) — 6.38 kB 🔴 +6.38 kB 🔴 +2.59 kB 🔴 +2.28 kB
assets/tierBenefits-C9armMGr.js (removed) 6.02 kB — 🟢 -6.02 kB 🟢 -1.93 kB 🟢 -1.67 kB
assets/tierBenefits-CM2_CPPh.js (new) — 6.02 kB 🔴 +6.02 kB 🔴 +1.93 kB 🔴 +1.67 kB
assets/CancelSubscriptionDialogContent-Ctau_bPQ.js (removed) 5.76 kB — 🟢 -5.76 kB 🟢 -1.97 kB 🟢 -1.72 kB
assets/CancelSubscriptionDialogContent-ogkMHO34.js (new) — 5.76 kB 🔴 +5.76 kB 🔴 +1.97 kB 🔴 +1.73 kB
assets/load3dPreviewExtensions-CzT7cY1a.js (removed) 5.38 kB — 🟢 -5.38 kB 🟢 -1.75 kB 🟢 -1.55 kB
assets/load3dPreviewExtensions-D_GCL6k1.js (new) — 5.38 kB 🔴 +5.38 kB 🔴 +1.75 kB 🔴 +1.55 kB
assets/FreeTierDialogContent-BH9YR7AH.js (removed) 5.25 kB — 🟢 -5.25 kB 🟢 -1.76 kB 🟢 -1.55 kB
assets/FreeTierDialogContent-C79k54LW.js (new) — 5.25 kB 🔴 +5.25 kB 🔴 +1.76 kB 🔴 +1.55 kB
assets/CreateWorkspaceDialogContent-DQILuXKz.js (new) — 5.19 kB 🔴 +5.19 kB 🔴 +1.83 kB 🔴 +1.58 kB
assets/CreateWorkspaceDialogContent-pvvomZ6T.js (removed) 5.19 kB — 🟢 -5.19 kB 🟢 -1.82 kB 🟢 -1.58 kB
assets/missingModelDownload-Banc8gnl.js (new) — 5.07 kB 🔴 +5.07 kB 🔴 +1.97 kB 🔴 +1.73 kB
assets/missingModelDownload-BqETPvjG.js (removed) 5.07 kB — 🟢 -5.07 kB 🟢 -1.98 kB 🟢 -1.73 kB
assets/ChangeMemberRoleDialogContent-BXtWpuQZ.js (removed) 5.04 kB — 🟢 -5.04 kB 🟢 -1.66 kB 🟢 -1.46 kB
assets/ChangeMemberRoleDialogContent-D95ThHuJ.js (new) — 5.04 kB 🔴 +5.04 kB 🔴 +1.67 kB 🔴 +1.46 kB
assets/EditWorkspaceDialogContent-BOvzE9Ek.js (removed) 5 kB — 🟢 -5 kB 🟢 -1.79 kB 🟢 -1.56 kB
assets/EditWorkspaceDialogContent-CMGE4IWC.js (new) — 5 kB 🔴 +5 kB 🔴 +1.79 kB 🔴 +1.56 kB
assets/WidgetTextarea-C_ldOwDo.js (removed) 4.86 kB — 🟢 -4.86 kB 🟢 -1.89 kB 🟢 -1.66 kB
assets/WidgetTextarea-JqmIEsu4.js (new) — 4.86 kB 🔴 +4.86 kB 🔴 +1.89 kB 🔴 +1.66 kB
assets/saveMesh-B_2jG3us.js (removed) 4.81 kB — 🟢 -4.81 kB 🟢 -1.55 kB 🟢 -1.38 kB
assets/saveMesh-CKw0Bem_.js (new) — 4.81 kB 🔴 +4.81 kB 🔴 +1.55 kB 🔴 +1.37 kB
assets/Preview3d-8Ap-hr-H.js (removed) 4.59 kB — 🟢 -4.59 kB 🟢 -1.43 kB 🟢 -1.23 kB
assets/Preview3d-CWyqKwc-.js (new) — 4.59 kB 🔴 +4.59 kB 🔴 +1.43 kB 🔴 +1.23 kB
assets/ValueControlPopover-bsrcFUB2.js (removed) 4.55 kB — 🟢 -4.55 kB 🟢 -1.59 kB 🟢 -1.42 kB
assets/ValueControlPopover-C35Pm_zy.js (new) — 4.55 kB 🔴 +4.55 kB 🔴 +1.59 kB 🔴 +1.42 kB
assets/DeleteWorkspaceDialogContent-CboQprzE.js (new) — 3.91 kB 🔴 +3.91 kB 🔴 +1.47 kB 🔴 +1.27 kB
assets/DeleteWorkspaceDialogContent-DkAPj6qp.js (removed) 3.91 kB — 🟢 -3.91 kB 🟢 -1.47 kB 🟢 -1.27 kB
assets/LeaveWorkspaceDialogContent-BOKS72rt.js (new) — 3.73 kB 🔴 +3.73 kB 🔴 +1.41 kB 🔴 +1.22 kB
assets/LeaveWorkspaceDialogContent-D3hzbu8s.js (removed) 3.73 kB — 🟢 -3.73 kB 🟢 -1.41 kB 🟢 -1.22 kB
assets/RemoveMemberDialogContent-BSuHJ9lK.js (new) — 3.71 kB 🔴 +3.71 kB 🔴 +1.37 kB 🔴 +1.19 kB
assets/RemoveMemberDialogContent-Dg7pZ4ie.js (removed) 3.71 kB — 🟢 -3.71 kB 🟢 -1.37 kB 🟢 -1.18 kB
assets/RevokeInviteDialogContent-BL4uagqm.js (removed) 3.63 kB — 🟢 -3.63 kB 🟢 -1.38 kB 🟢 -1.2 kB
assets/RevokeInviteDialogContent-Bni9rvvH.js (new) — 3.63 kB 🔴 +3.63 kB 🔴 +1.38 kB 🔴 +1.21 kB
assets/InviteMemberUpsellDialogContent-BWw8pFoD.js (new) — 3.52 kB 🔴 +3.52 kB 🔴 +1.27 kB 🔴 +1.11 kB
assets/InviteMemberUpsellDialogContent-cbXBDyBl.js (removed) 3.52 kB — 🟢 -3.52 kB 🟢 -1.26 kB 🟢 -1.1 kB
assets/workspaceCheckoutTelemetry-D9-fVNol.js (removed) 3.47 kB — 🟢 -3.47 kB 🟢 -1.56 kB 🟢 -1.36 kB
assets/workspaceCheckoutTelemetry-DVZrYhNR.js (new) — 3.47 kB 🔴 +3.47 kB 🔴 +1.56 kB 🔴 +1.36 kB
assets/Media3DTop-BkCgZlpT.js (removed) 3.26 kB — 🟢 -3.26 kB 🟢 -1.3 kB 🟢 -1.13 kB
assets/Media3DTop-Ce8Ngdbl.js (new) — 3.26 kB 🔴 +3.26 kB 🔴 +1.3 kB 🔴 +1.13 kB
assets/GlobalToast-BrGwIoYA.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.08 kB
assets/GlobalToast-DQI3bfNO.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.08 kB
assets/load3dAdvanced-72siTIZw.js (removed) 2.87 kB — 🟢 -2.87 kB 🟢 -1.13 kB 🟢 -982 B
assets/load3dAdvanced-CPnfhgtk.js (new) — 2.87 kB 🔴 +2.87 kB 🔴 +1.13 kB 🔴 +992 B
assets/SubscribeToRun-BmICfVrM.js (new) — 2.56 kB 🔴 +2.56 kB 🔴 +1.11 kB 🔴 +976 B
assets/SubscribeToRun-DBrj54v5.js (removed) 2.56 kB — 🟢 -2.56 kB 🟢 -1.11 kB 🟢 -973 B
assets/graphHasMissingNodes-CjDvLYN9.js (removed) 1.93 kB — 🟢 -1.93 kB 🟢 -903 B 🟢 -796 B
assets/graphHasMissingNodes-DB3D159h.js (new) — 1.93 kB 🔴 +1.93 kB 🔴 +905 B 🔴 +795 B
assets/MediaAudioTop-C_9carJ1.js (removed) 1.67 kB — 🟢 -1.67 kB 🟢 -837 B 🟢 -700 B
assets/MediaAudioTop-CBavTQ02.js (new) — 1.67 kB 🔴 +1.67 kB 🔴 +838 B 🔴 +703 B
assets/CloudRunButtonWrapper-CrBznFUq.js (removed) 1.13 kB — 🟢 -1.13 kB 🟢 -549 B 🟢 -488 B
assets/CloudRunButtonWrapper-DJ3eenhg.js (new) — 1.13 kB 🔴 +1.13 kB 🔴 +547 B 🔴 +490 B
assets/cloudSessionCookie-BEojiTEn.js (new) — 991 B 🔴 +991 B 🔴 +466 B 🔴 +397 B
assets/cloudSessionCookie-DeS9dCOF.js (removed) 991 B — 🟢 -991 B 🟢 -466 B 🟢 -410 B
assets/cloudBadges-BpTsq8Iv.js (removed) 973 B — 🟢 -973 B 🟢 -551 B 🟢 -496 B
assets/cloudBadges-Dw-p8yI7.js (new) — 973 B 🔴 +973 B 🔴 +552 B 🔴 +468 B
assets/Load3DAdvanced-Dmk0gOGG.js (new) — 813 B 🔴 +813 B 🔴 +454 B 🔴 +407 B
assets/Load3DAdvanced-DYMkpcmE.js (removed) 813 B — 🟢 -813 B 🟢 -452 B 🟢 -407 B
assets/nightlyBadges-BHjlexKG.js (removed) 464 B — 🟢 -464 B 🟢 -304 B 🟢 -254 B
assets/nightlyBadges-Ddj8BeT1.js (new) — 464 B 🔴 +464 B 🔴 +305 B 🔴 +257 B
assets/missingModelDownload-CS8eESCl.js (new) — 228 B 🔴 +228 B 🔴 +147 B 🔴 +127 B
assets/missingModelDownload-DcZtQVst.js (removed) 228 B — 🟢 -228 B 🟢 -151 B 🟢 -129 B
assets/SubscriptionPanelContentWorkspace-1pet4lAP.js (new) — 179 B 🔴 +179 B 🔴 +117 B 🔴 +90 B
assets/SubscriptionPanelContentWorkspace-HlHnDxfr.js (removed) 179 B — 🟢 -179 B 🟢 -117 B 🟢 -103 B
assets/Load3dViewerContent-BaX7wX1l.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -92 B
assets/Load3dViewerContent-DjUTz4rZ.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +87 B
assets/Load3DAdvanced-DaIUH-vL.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +88 B
assets/Load3DAdvanced-DC8BGHB5.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -87 B
assets/WidgetLegacy-BbPQUqoA.js (new) — 119 B 🔴 +119 B 🔴 +108 B 🔴 +93 B
assets/WidgetLegacy-UbVy19-Y.js (removed) 119 B — 🟢 -119 B 🟢 -108 B 🟢 -98 B
assets/workflowDraftStoreV2-KGT9P5Im.js (new) — 113 B 🔴 +113 B 🔴 +105 B 🔴 +117 B
assets/workflowDraftStoreV2-tYy4oQzB.js (removed) 113 B — 🟢 -113 B 🟢 -105 B 🟢 -109 B
assets/Load3D-BKCpf-yJ.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -81 B
assets/Load3D-Dm-B9W8H.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +81 B
assets/changeTracker-B3Wm7SiM.js (removed) 93 B — 🟢 -93 B 🟢 -95 B 🟢 -85 B
assets/changeTracker-DtCdP0AJ.js (new) — 93 B 🔴 +93 B 🔴 +95 B 🔴 +84 B

Status: 67 added / 67 removed / 98 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 149ms TBT · 90.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
vue-large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 151.2 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 9ms TBT · 164.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.4 MB heap

⚠️ 1 regression detected

Show regressions
Metric Baseline PR (median) Δ Sig
subgraph-mouse-sweep: layout duration 3ms 8ms +132% ⚠️ z=8.8
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 7ms 10ms +35% z=-1.5
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 10 -5% z=-2.9
canvas-idle: task duration 368ms 385ms +5% z=-0.3
canvas-idle: script duration 13ms 17ms +30% z=-3.7
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 59.5 MB 49.9 MB -16% —
canvas-idle: DOM nodes -276 -135 -51% z=-123.6
canvas-idle: event listeners -197 -98 -51% z=-23.0
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.9
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 3ms 4ms +40% z=0.3
canvas-mouse-sweep: style recalc duration 30ms 38ms +30% z=-1.4
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 72 74 +3% z=-2.0
canvas-mouse-sweep: task duration 656ms 841ms +28% z=-0.4
canvas-mouse-sweep: script duration 89ms 123ms +39% z=-1.9
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 46.2 MB 61.5 MB +33% —
canvas-mouse-sweep: DOM nodes -269 -261 -3% z=-125.0
canvas-mouse-sweep: event listeners -197 -199 +1% z=-49.8
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +11% z=0.7
canvas-zoom-sweep: style recalc duration 13ms 18ms +33% z=-0.8
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 32 +2% z=0.5
canvas-zoom-sweep: task duration 302ms 343ms +13% z=0.7
canvas-zoom-sweep: script duration 14ms 18ms +22% z=-3.2
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 63.1 MB 59.9 MB -5% —
canvas-zoom-sweep: DOM nodes -222 -232 +4% z=-392.6
canvas-zoom-sweep: event listeners -182 -184 +1% z=-40.1
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +1% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 6ms 8ms +47% z=-1.8
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 12 13 +4% z=-1.2
dom-widget-clipping: task duration 314ms 359ms +14% z=-0.3
dom-widget-clipping: script duration 40ms 59ms +47% z=-2.7
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 57.8 MB 54.0 MB -7% —
dom-widget-clipping: DOM nodes -275 -127 -54% z=-104.8
dom-widget-clipping: event listeners -199 -102 -49% variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 7ms 8ms +23% z=-3.9
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 10 10 -5% z=-6.7
large-graph-idle: task duration 461ms 516ms +12% z=-0.5
large-graph-idle: script duration 62ms 90ms +47% z=-1.1
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 57.2 MB 57.7 MB +1% —
large-graph-idle: DOM nodes -262 -125 -52% z=-165.1
large-graph-idle: event listeners -199 -98 -51% z=-20.3
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 13ms 17ms +24% z=-0.8
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 70 68 -3% z=-2.4
large-graph-pan: task duration 814ms 1061ms +30% z=-0.5
large-graph-pan: script duration 273ms 399ms +46% z=-0.4
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 79.0 MB 77.4 MB -2% —
large-graph-pan: DOM nodes 22 -277 -1359% z=-179.4
large-graph-pan: event listeners 4 -197 -5025% z=-243.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 6ms 7ms +23% —
large-graph-zoom: style recalc duration 12ms 16ms +28% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 64 63 -2% —
large-graph-zoom: task duration 979ms 1285ms +31% —
large-graph-zoom: script duration 342ms 491ms +44% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 64.4 MB 64.7 MB +0% —
large-graph-zoom: DOM nodes 8 -282 -3625% —
large-graph-zoom: event listeners 8 -94 -1269% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 4ms 8ms +84% z=-1.9
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 7 8 +14% z=-2.3
minimap-idle: task duration 420ms 519ms +24% z=-0.2
minimap-idle: script duration 63ms 90ms +42% z=-0.8
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 58.1 MB 56.8 MB -2% —
minimap-idle: DOM nodes 14 -273 -2050% z=-213.6
minimap-idle: event listeners 4 -197 -5025% z=-305.3
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -1% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 8ms 13ms +61% z=0.3
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 47 -2% z=-1.6
subgraph-dom-widget-clipping: task duration 321ms 378ms +18% z=-0.0
subgraph-dom-widget-clipping: script duration 90ms 121ms +34% z=-1.2
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 58.7 MB 61.4 MB +5% —
subgraph-dom-widget-clipping: DOM nodes -271 -134 -51% z=-139.1
subgraph-dom-widget-clipping: event listeners -193 -96 -51% z=-19.2
subgraph-idle: avg frame time 17ms 17ms +0% z=-0.2
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 7ms 9ms +27% z=-1.6
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 11 10 -9% z=-1.4
subgraph-idle: task duration 369ms 399ms +8% z=0.9
subgraph-idle: script duration 13ms 13ms +2% z=-2.8
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 59.6 MB 59.1 MB -1% —
subgraph-idle: DOM nodes -274 -277 +1% z=-199.5
subgraph-idle: event listeners -195 -199 +2% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.1
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 3ms 8ms +132% ⚠️ z=8.8
subgraph-mouse-sweep: style recalc duration 29ms 44ms +51% z=0.6
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 78 +1% z=-1.4
subgraph-mouse-sweep: task duration 581ms 725ms +25% z=-0.6
subgraph-mouse-sweep: script duration 64ms 91ms +43% z=-1.5
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 67.9 MB 50.6 MB -25% —
subgraph-mouse-sweep: DOM nodes -250 -233 -7% z=-134.2
subgraph-mouse-sweep: event listeners -197 -199 +1% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -1% —
subgraph-transition-enter: layout duration 11ms 16ms +48% —
subgraph-transition-enter: style recalc duration 26ms 32ms +24% —
subgraph-transition-enter: layout count 16 15 -6% —
subgraph-transition-enter: style recalc count 20 19 -5% —
subgraph-transition-enter: task duration 626ms 736ms +18% —
subgraph-transition-enter: script duration 21ms 27ms +28% —
subgraph-transition-enter: TBT 133ms 149ms +12% —
subgraph-transition-enter: heap used 96.5 MB 90.3 MB -6% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2531 2533 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 36ms 57ms +55% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 251 +0% —
viewport-pan-sweep: task duration 3017ms 4126ms +37% —
viewport-pan-sweep: script duration 948ms 1388ms +46% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 68.0 MB 74.3 MB +9% —
viewport-pan-sweep: DOM nodes -262 -124 -53% —
viewport-pan-sweep: event listeners -183 -52 -72% —
vue-large-graph-idle: avg frame time 17ms 17ms +0% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 8194ms 12057ms +47% —
vue-large-graph-idle: script duration 386ms 508ms +32% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 163.3 MB 151.2 MB -7% —
vue-large-graph-idle: DOM nodes -3301 -3301 +0% —
vue-large-graph-idle: event listeners -16380 -16373 -0% —
vue-large-graph-pan: avg frame time 18ms 17ms -5% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 18ms +7% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 64 72 +13% —
vue-large-graph-pan: task duration 10691ms 15099ms +41% —
vue-large-graph-pan: script duration 657ms 794ms +21% —
vue-large-graph-pan: TBT 0ms 9ms — —
vue-large-graph-pan: heap used 166.8 MB 164.2 MB -2% —
vue-large-graph-pan: DOM nodes -3301 -3303 +0% —
vue-large-graph-pan: event listeners -16373 -16362 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms -1% —
workflow-execution: layout duration 0ms 0ms -2% z=-8.1
workflow-execution: style recalc duration 14ms 20ms +39% z=-2.1
workflow-execution: layout count 2 2 +0% z=-5.4
workflow-execution: style recalc count 14 13 -7% z=-2.3
workflow-execution: task duration 150ms 142ms -5% z=1.8
workflow-execution: script duration 8ms 10ms +33% z=-6.4
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 44.2 MB 51.4 MB +16% —
workflow-execution: DOM nodes -191 -37 -81% z=-27.8
workflow-execution: event listeners -132 -34 -75% z=-19.5
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-07-09T19:20:25.836Z",
  "gitSha": "ab3216406f2cbe0c6193b0342dc83a119f09ed80",
  "branch": "matt/be-2593-f14-fe-add-list-delete-e2e",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.940000000025,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.664000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.01000000000005,
      "heapDeltaBytes": -3293648,
      "heapUsedBytes": 48829560,
      "domNodes": -290,
      "jsHeapTotalBytes": 18214912,
      "scriptDurationMs": 19.864,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2008.0869999999322,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.370000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 342.162,
      "heapDeltaBytes": -1977536,
      "heapUsedBytes": 55772000,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 14.316000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1939.4419999999855,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 37.498999999999995,
      "layouts": 12,
      "layoutDurationMs": 3.7709999999999995,
      "taskDurationMs": 871.1059999999999,
      "heapDeltaBytes": 19959444,
      "heapUsedBytes": 72022700,
      "domNodes": -283,
      "jsHeapTotalBytes": 17166336,
      "scriptDurationMs": 126.81399999999998,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1798.4569999999849,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 39.132,
      "layouts": 12,
      "layoutDurationMs": 3.563,
      "taskDurationMs": 810.2819999999999,
      "heapDeltaBytes": -12805560,
      "heapUsedBytes": 56939608,
      "domNodes": -239,
      "jsHeapTotalBytes": 19021824,
      "scriptDurationMs": 119.42499999999998,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.859999999955,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.295,
      "layouts": 6,
      "layoutDurationMs": 0.563,
      "taskDurationMs": 330.984,
      "heapDeltaBytes": 6987600,
      "heapUsedBytes": 59317380,
      "domNodes": -238,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 16.661,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.6499999999696,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 19.499,
      "layouts": 6,
      "layoutDurationMs": 0.788,
      "taskDurationMs": 354.161,
      "heapDeltaBytes": -3479892,
      "heapUsedBytes": 66204208,
      "domNodes": -225,
      "jsHeapTotalBytes": 13254656,
      "scriptDurationMs": 18.643,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 582.6309999999921,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.866000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.321,
      "heapDeltaBytes": -22378968,
      "heapUsedBytes": 47303940,
      "domNodes": -275,
      "jsHeapTotalBytes": 6701056,
      "scriptDurationMs": 61.33500000000001,
      "eventListeners": -203,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 567.0240000000604,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.109000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.62899999999996,
      "heapDeltaBytes": 7126884,
      "heapUsedBytes": 66019020,
      "domNodes": 22,
      "jsHeapTotalBytes": 19398656,
      "scriptDurationMs": 57.041,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.9729999999608,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.202,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.6590000000001,
      "heapDeltaBytes": -8734700,
      "heapUsedBytes": 58972484,
      "domNodes": -269,
      "jsHeapTotalBytes": -1323008,
      "scriptDurationMs": 90.84100000000001,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 1994.5069999999987,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.985999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.65700000000004,
      "heapDeltaBytes": -9725260,
      "heapUsedBytes": 62053248,
      "domNodes": 20,
      "jsHeapTotalBytes": 11677696,
      "scriptDurationMs": 89.979,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2127.9510000000528,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.079,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1068.418,
      "heapDeltaBytes": -5377860,
      "heapUsedBytes": 80245876,
      "domNodes": -275,
      "jsHeapTotalBytes": 3424256,
      "scriptDurationMs": 400.919,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2093.3770000000322,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 16.157999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1054.449,
      "heapDeltaBytes": 20616184,
      "heapUsedBytes": 82129000,
      "domNodes": -279,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 397.84,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3126.6460000000507,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 15.083999999999996,
      "layouts": 60,
      "layoutDurationMs": 7.294999999999999,
      "taskDurationMs": 1292.204,
      "heapDeltaBytes": 14501908,
      "heapUsedBytes": 68714952,
      "domNodes": -283,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 508.8,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3078.6209999999983,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 16.820999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.373999999999999,
      "taskDurationMs": 1278.313,
      "heapDeltaBytes": 13075468,
      "heapUsedBytes": 66921112,
      "domNodes": -281,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 473.98999999999995,
      "eventListeners": -195,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.490000000038,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.405000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.57399999999996,
      "heapDeltaBytes": -3459504,
      "heapUsedBytes": 58845868,
      "domNodes": -275,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 86.624,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.509,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.608000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.426,
      "heapDeltaBytes": -15518456,
      "heapUsedBytes": 60272228,
      "domNodes": -271,
      "jsHeapTotalBytes": 4005888,
      "scriptDurationMs": 92.98100000000001,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 564.8619999999482,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 14.636,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 360.289,
      "heapDeltaBytes": 7846344,
      "heapUsedBytes": 66965324,
      "domNodes": 22,
      "jsHeapTotalBytes": 17825792,
      "scriptDurationMs": 121.777,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 575.2619999999524,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.269000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.81600000000003,
      "heapDeltaBytes": 9313860,
      "heapUsedBytes": 61723980,
      "domNodes": -289,
      "jsHeapTotalBytes": 8515584,
      "scriptDurationMs": 119.70500000000001,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2027.4839999999585,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.283999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.207,
      "heapDeltaBytes": -8059368,
      "heapUsedBytes": 61758128,
      "domNodes": -277,
      "jsHeapTotalBytes": 19546112,
      "scriptDurationMs": 12.824999999999998,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2029.7479999999268,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.038999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.73500000000007,
      "heapDeltaBytes": -7723464,
      "heapUsedBytes": 62142692,
      "domNodes": -276,
      "jsHeapTotalBytes": 19546112,
      "scriptDurationMs": 12.774,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1726.8980000000056,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 41.013,
      "layouts": 16,
      "layoutDurationMs": 7.018,
      "taskDurationMs": 693.8599999999999,
      "heapDeltaBytes": -16718928,
      "heapUsedBytes": 53099116,
      "domNodes": -233,
      "jsHeapTotalBytes": 19546112,
      "scriptDurationMs": 87.689,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1794.8659999999563,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 47.701,
      "layouts": 16,
      "layoutDurationMs": 8.031,
      "taskDurationMs": 755.4150000000001,
      "heapDeltaBytes": -16784924,
      "heapUsedBytes": 53029440,
      "domNodes": -233,
      "jsHeapTotalBytes": 19283968,
      "scriptDurationMs": 94.04700000000001,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 965.8399999999574,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.889,
      "layouts": 15,
      "layoutDurationMs": 16.014,
      "taskDurationMs": 736.1469999999999,
      "heapDeltaBytes": 3666964,
      "heapUsedBytes": 94684160,
      "domNodes": 13673,
      "jsHeapTotalBytes": 14155776,
      "scriptDurationMs": 26.550000000000004,
      "eventListeners": 2533,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8204.83999999999,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 56.049,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3987.551,
      "heapDeltaBytes": 25876128,
      "heapUsedBytes": 82618064,
      "domNodes": -266,
      "jsHeapTotalBytes": 13529088,
      "scriptDurationMs": 1349.1280000000002,
      "eventListeners": -124,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8203.901999999971,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 57.102999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4264.813999999999,
      "heapDeltaBytes": 1216780,
      "heapUsedBytes": 73260104,
      "domNodes": 18,
      "jsHeapTotalBytes": 17620992,
      "scriptDurationMs": 1426.179,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11793.585000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11767.275,
      "heapDeltaBytes": -48098808,
      "heapUsedBytes": 155404880,
      "domNodes": -3302,
      "jsHeapTotalBytes": 18845696,
      "scriptDurationMs": 500.46000000000004,
      "eventListeners": -16375,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12361.084000000119,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12346.178000000002,
      "heapDeltaBytes": -39101624,
      "heapUsedBytes": 161663624,
      "domNodes": -3300,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 516.353,
      "eventListeners": -16370,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14909.089999999993,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 16.558000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14888.551,
      "heapDeltaBytes": -14981248,
      "heapUsedBytes": 168060412,
      "domNodes": -3300,
      "jsHeapTotalBytes": 14942208,
      "scriptDurationMs": 754.3140000000001,
      "eventListeners": -16362,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15330.201999999872,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 18.899,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15309.276,
      "heapDeltaBytes": -13578368,
      "heapUsedBytes": 176280296,
      "domNodes": -3306,
      "jsHeapTotalBytes": 14331904,
      "scriptDurationMs": 834.234,
      "eventListeners": -16362,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 446.0679999999684,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 17.692,
      "layouts": 2,
      "layoutDurationMs": 0.346,
      "taskDurationMs": 100.52600000000001,
      "heapDeltaBytes": 4885456,
      "heapUsedBytes": 61364552,
      "domNodes": 130,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 10.193,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.83099999988553,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 21.364,
      "layouts": 2,
      "layoutDurationMs": 0.3879999999999999,
      "taskDurationMs": 183.89500000000004,
      "heapDeltaBytes": -22712528,
      "heapUsedBytes": 46396456,
      "domNodes": -203,
      "jsHeapTotalBytes": 5390336,
      "scriptDurationMs": 10.153,
      "eventListeners": -132,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@mattmillerai mattmillerai added the cursor-review Trigger multi-model Cursor agent review on this PR label Jul 8, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 2 finding(s).

Severity Count
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

@codecov

codecov Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/dialog/GlobalDialog.vue 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main   #13510      +/-   ##
==========================================
- Coverage   77.95%   77.67%   -0.28%     
==========================================
  Files        1656     1656              
  Lines       92923    93403     +480     
  Branches    32950    32998      +48     
==========================================
+ Hits        72434    72550     +116     
- Misses      19840    20175     +335     
- Partials      649      678      +29     
Flag Coverage Δ
unit 65.90% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/dialog/rekaPrimeVueBridge.ts 100.00% <100.00%> (+7.14%) ⬆️
...c/platform/secrets/components/SecretFormDialog.vue 73.33% <ø> (ø)
src/platform/secrets/composables/useSecretForm.ts 94.62% <100.00%> (+0.11%) ⬆️
...platform/settings/composables/useSettingsDialog.ts 100.00% <ø> (+9.52%) ⬆️
src/stores/dialogStore.ts 78.26% <ø> (+2.70%) ⬆️
src/components/dialog/GlobalDialog.vue 87.75% <0.00%> (-0.39%) ⬇️

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattmillerai
mattmillerai marked this pull request as ready for review July 8, 2026 20:05
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 8, 2026
@mattmillerai mattmillerai added agent-coded Opened by the agent-work code loop needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 8, 2026
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 8, 2026
mattmillerai and others added 2 commits July 8, 2026 16:33
…r data

The secrets provider dropdown and saved-keys list now render whichever
providers the server lists via GET /secrets/providers, mapping each id to
its display label, logo, and optional help text. Previously the dropdown
intersected the server list against a hardcoded provider array, so a
newly-listed provider (e.g. runway/gemini) could never appear.

- Drive create-mode options from the server list; unknown ids fall back to
  the raw id with no logo, so adding a provider server-side needs no FE change
- Add label/logo/help registry entries and placeholder logo assets for the
  BYOK providers
- Surface provider-specific help text under the picker, falling back to the
  generic hint
- Extend composable + add registry unit tests
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 8, 2026
- Drop unused SECRET_PROVIDERS export (knip) now that lookups go through
  findProvider internally
- Reconcile the selected provider once the server allowlist resolves so an
  unlisted fallback cannot be submitted
- Dedupe server-returned provider ids; replace unsafe as never cast with a
  type-safe membership check
- Guard existingProviders against null with != null
The workflow template selector (z-1700) auto-opens on boot when
Comfy.TutorialCompleted is falsy and intercepts pointer events on the
settings dialog, so clicking the Secrets nav timed out. Mock settings
with TutorialCompleted=true, matching the existing cloud boot pattern.

Also drop the unused `export` on SECRET_PROVIDERS (internal-only) so
knip passes.
- Anchor the non-entitled test on the opened listbox so the gated-provider
  absence checks can't pass vacuously against a dropdown that never opened.
- Also assert the secret is not smuggled into any input value or attribute,
  not just visible text nodes.
@mattmillerai
mattmillerai force-pushed the matt/be-2592-f13-fe-provider-surface-labelslogos branch from 9b59d7b to 275d8c0 Compare July 8, 2026 20:44
@mattmillerai
mattmillerai force-pushed the matt/be-2593-f14-fe-add-list-delete-e2e branch from fa2486f to 32759ca Compare July 8, 2026 20:44
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 8, 2026
@mattmillerai
mattmillerai marked this pull request as draft July 8, 2026 20:56
@mattmillerai

Copy link
Copy Markdown
Member Author

Converting to draft to stop the auto-resolver from re-attempting. Lint is fixed, but the cloudSecrets E2E is a fully-mocked test timing out on the Secrets-panel open (waitForResponse('/api/secrets/providers') + the nav click) — a mock-wiring / interaction issue, not the new-user modal (that's already suppressed via Comfy.TutorialCompleted). Needs a hands-on Playwright debug (run headed, inspect the network) rather than blind retries. Will un-draft once the E2E is sorted.

@mattmillerai
mattmillerai marked this pull request as ready for review July 8, 2026 21:08
…loss

Deleting a Secrets key closed the entire Settings dialog: confirming the
delete removes the focused list row, so focus falls to an ordinary app
element. As a non-modal Reka dialog, Settings read that programmatic focus
shift as an outside interaction and dismissed itself, failing the add/list/
delete e2e at the empty-state assertion.

Add a `dismissOnFocusOutside` dialog prop (default true) and set it false on
Settings so it no longer dismisses on focus-outside; escape, the close
button, and outside-pointer dismissal are unaffected.
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 8, 2026
@mattmillerai

Copy link
Copy Markdown
Member Author

The playwright-tests (cloud) failure was a real product bug this new e2e caught, not a flaky test.

Root cause: confirming a Secrets delete removes the focused list row, so browser focus falls to an ordinary app element. The Settings dialog is a non-modal Reka dialog (it must be, to host nested confirm/edit dialogs), and it read that programmatic focus shift as an outside interaction and dismissed itself — so the post-delete No secrets stored empty state was asserted against a dialog that had already closed. Reproduced locally against the cloud build (build:cloud + preview) and traced it to onRekaFocusOutside.

Fix (unblocks the delete flow, no behavior change elsewhere): added a dismissOnFocusOutside dialog prop (default true) and set it false on the Settings dialog. Escape, the close button, and outside-pointer dismissal are unaffected; only the spurious focus-loss dismissal is suppressed. Added a unit case for the new prop; both cloud e2e tests now pass locally.

Note: this touches shared dialog infra inherited from the base branch — flagging in case it fits better in be-2592.

@mattmillerai

Copy link
Copy Markdown
Member Author
Screenshot 2026-07-09 at 2 45 50 PM

@huang47 updated that and fixed the issue you were experiencing.

- Revert providerHint copy: provider is required by the form validation,
  so the 'Optional' wording contradicted the enforced behavior.
- Drop the inert input/attribute DOM scan in the secrets e2e; the form is
  unmounted by then so it can never fail. Keep the request-contract and
  list-text assertions that actually guard the write-only value.
- Assert the non-entitled provider dropdown has zero options so a
  fetch-failure fallback to the default providers can't pass vacuously.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mattmillerai
mattmillerai requested a review from dante01yoon July 9, 2026 19:01
@mattmillerai mattmillerai removed their assignment Jul 9, 2026
@mattmillerai
mattmillerai requested a review from huang47 July 9, 2026 19:01

@huang47 huang47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t want to block the PR due to the tests. We should address it soon, but I’ll leave it to you to do so in the same PR or a follow-up.

  1. browser_tests/tests/cloudSecrets.spec.ts:125 should use the generated ingest types and return the API’s 201 create status. Right now the test hand-rolls SecretRecord / CreateCapture and jsonRoute(created) returns 200, so this can pass while drifting from CreateSecretResponses
  2. Additionally, The PR title/body still frame this as only an E2E test which is not the case anymore. Mind be worth tweaking the harness to make sure the PR title / description are up-to-date

@huang47

huang47 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Visual evidence for the Settings / Secrets delete flow. Before: Settings dismisses after confirming delete. After: Settings stays open on the empty Secrets state.

pr-13510-settings-delete-before-after.png

pr-13510-settings-delete-before-after.mp4

@mattmillerai
mattmillerai added this pull request to the merge queue Jul 9, 2026
@mattmillerai mattmillerai changed the title test: E2E for BYOK secret add / list / delete flow fix(dialog): keep Settings open when nested dialogs shift focus + BYOK secrets E2E Jul 9, 2026
@mattmillerai

Copy link
Copy Markdown
Member Author

Thanks @huang47 — both points taken:

  1. Typed mocks + 201 — agreed; filed as a follow-up in our internal tracker (same lane as the providerOptions regression-test follow-up from feat: render BYOK provider surface (labels / logos / help) from server data #13509) so this approved PR doesn't need another review round. The follow-up types the spec's in-memory secrets mock with the generated @comfyorg/ingest-types and aligns the mocked statuses with the real API (201 on create), so contract drift fails the test instead of passing silently.

  2. Stale title/body — fixed now: the PR is reframed as the dialog fix + the E2E that caught it, rather than test-only. Also took your harness note to heart — the PR-authoring loop now re-checks that the title/description still describe the full diff whenever scope grows mid-PR (e.g. a test-only PR gaining a product fix).

Merged via the queue into main with commit 2ef341d Jul 9, 2026
51 checks passed
@mattmillerai
mattmillerai deleted the matt/be-2593-f14-fe-add-list-delete-e2e branch July 9, 2026 21:37
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Post-merge review notes (didn't land before merge). None blocking.

Test typing/structure — browser_tests/tests/cloudSecrets.spec.ts

  • SecretRecord/CreateCapture (L38) re-type SecretResponse/CreateSecretRequest from @comfyorg/ingest-types by hand; import them and type the backend as { createRequests: CreateSecretRequest[]; store: SecretResponse[] } (already on your follow-up list).
  • Mock bodies are untyped inline objects — add satisfies SecretProvidersResponse / SecretResponse / SecretListResponse, and return 201 not jsonRoute's default 200 on create (L125) to match the contract.
  • mockSecretsBackend (L68) is inline; the sibling cloud mocks live in fixtures/utils/ (workspaceMocks, cloudBillingMocks) — worth extracting to fixtures/utils/cloudSecretsMocks.ts (keep the path-anchoring / method-branching / 204-on-delete as-is).
  • openSecretsPanel (L143) uses page.evaluate('Comfy.ShowSettingsDialog') + a hand-rolled nav click; the SettingDialog fixture already has open()/category('Secrets'). Keep the Promise.all(waitForResponse) sync.

Coverage/correctness

  • No-echo assertion (L221) uses getByText, which only sees text nodes — it'd miss the value reflected into an input/masked field. Also assert no input carries the value.
  • The dismissOnFocusOutside wiring in GlobalDialog.vue isn't covered by a mounted test; the only guard is the @cloud spec, which playwright.config grepInverts out of the default project, so a regression in that binding stays green under pnpm test:unit. A mounted GlobalDialog.test.ts case would close that.

Dialog debt

  • The dismissOnFocusOutside opt-out is the latest of several patches to the non-modal Settings self-dismiss (the isInsideOverlay allowlist keeps growing for the same root cause). Longer term, modeling the nested PrimeVue dialogs as nested Reka DismissableLayers would retire most of rekaPrimeVueBridge.ts.

Heads-up: #13464 (toast) and #13487 (menu trigger) both modify onRekaFocusOutside and will now conflict with main; each should keep both its allowlist widening and this opt-out on rebase.

@mattmillerai mattmillerai added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.45 and removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.45 labels Jul 10, 2026
@comfy-pr-bot

Copy link
Copy Markdown
Member

@mattmillerai Successfully backported to #13621

@comfy-pr-bot

Copy link
Copy Markdown
Member

@mattmillerai Successfully backported to #13622

@github-actions github-actions Bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Jul 13, 2026
@comfy-pr-bot comfy-pr-bot added the released:cloud PR has been released to cloud label Jul 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR released:cloud PR has been released to cloud size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants