Repository navigation
fix(dialog): keep Settings open when nested dialogs shift focus + BYOK secrets E2E - #13510
Conversation
📝 WalkthroughWalkthroughThis PR introduces a server-driven BYOK (Bring Your Own Key) provider allowlist for secrets, adding Runway and Gemini providers with help text, refactoring ChangesBYOK Secrets Provider Allowlist
Estimated code review effort: 3 (Moderate) | ~25 minutes Dialog Focus-Outside Dismissal Opt-out
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant SettingsDialog
participant GlobalDialog
participant onRekaFocusOutside
SettingsDialog->>GlobalDialog: showLayoutDialog(dismissOnFocusOutside: false)
GlobalDialog->>onRekaFocusOutside: focus-outside(event, dialogComponentProps)
onRekaFocusOutside->>onRekaFocusOutside: dismissOnFocusOutside === false?
onRekaFocusOutside->>GlobalDialog: event.preventDefault(), no dismissal
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1689 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 7.78 MB gzip 🔴 +68 BDetailsSummary
Category Glance App Entry Points — 48 kB (baseline 47.8 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.27 MB (baseline 1.27 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 110 kB (baseline 110 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 11 added / 11 removed / 3 unchanged Panels & Settings — 550 kB (baseline 550 kB) • 🟢 -1 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.5 kB (baseline 57.5 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.39 MB (baseline 3.39 MB) • 🔴 +34 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 19 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.7 MB (baseline 11.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 67 added / 67 removed / 98 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-09T19:20:25.836Z",
"gitSha": "ab3216406f2cbe0c6193b0342dc83a119f09ed80",
"branch": "matt/be-2593-f14-fe-add-list-delete-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.940000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.664000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.01000000000005,
"heapDeltaBytes": -3293648,
"heapUsedBytes": 48829560,
"domNodes": -290,
"jsHeapTotalBytes": 18214912,
"scriptDurationMs": 19.864,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.0869999999322,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.370000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.162,
"heapDeltaBytes": -1977536,
"heapUsedBytes": 55772000,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 14.316000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1939.4419999999855,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.498999999999995,
"layouts": 12,
"layoutDurationMs": 3.7709999999999995,
"taskDurationMs": 871.1059999999999,
"heapDeltaBytes": 19959444,
"heapUsedBytes": 72022700,
"domNodes": -283,
"jsHeapTotalBytes": 17166336,
"scriptDurationMs": 126.81399999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1798.4569999999849,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.132,
"layouts": 12,
"layoutDurationMs": 3.563,
"taskDurationMs": 810.2819999999999,
"heapDeltaBytes": -12805560,
"heapUsedBytes": 56939608,
"domNodes": -239,
"jsHeapTotalBytes": 19021824,
"scriptDurationMs": 119.42499999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.859999999955,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.295,
"layouts": 6,
"layoutDurationMs": 0.563,
"taskDurationMs": 330.984,
"heapDeltaBytes": 6987600,
"heapUsedBytes": 59317380,
"domNodes": -238,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 16.661,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.6499999999696,
"styleRecalcs": 33,
"styleRecalcDurationMs": 19.499,
"layouts": 6,
"layoutDurationMs": 0.788,
"taskDurationMs": 354.161,
"heapDeltaBytes": -3479892,
"heapUsedBytes": 66204208,
"domNodes": -225,
"jsHeapTotalBytes": 13254656,
"scriptDurationMs": 18.643,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 582.6309999999921,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.866000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.321,
"heapDeltaBytes": -22378968,
"heapUsedBytes": 47303940,
"domNodes": -275,
"jsHeapTotalBytes": 6701056,
"scriptDurationMs": 61.33500000000001,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 567.0240000000604,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.109000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.62899999999996,
"heapDeltaBytes": 7126884,
"heapUsedBytes": 66019020,
"domNodes": 22,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 57.041,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.9729999999608,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.202,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.6590000000001,
"heapDeltaBytes": -8734700,
"heapUsedBytes": 58972484,
"domNodes": -269,
"jsHeapTotalBytes": -1323008,
"scriptDurationMs": 90.84100000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 1994.5069999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.985999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.65700000000004,
"heapDeltaBytes": -9725260,
"heapUsedBytes": 62053248,
"domNodes": 20,
"jsHeapTotalBytes": 11677696,
"scriptDurationMs": 89.979,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2127.9510000000528,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.079,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1068.418,
"heapDeltaBytes": -5377860,
"heapUsedBytes": 80245876,
"domNodes": -275,
"jsHeapTotalBytes": 3424256,
"scriptDurationMs": 400.919,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2093.3770000000322,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.157999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1054.449,
"heapDeltaBytes": 20616184,
"heapUsedBytes": 82129000,
"domNodes": -279,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 397.84,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3126.6460000000507,
"styleRecalcs": 62,
"styleRecalcDurationMs": 15.083999999999996,
"layouts": 60,
"layoutDurationMs": 7.294999999999999,
"taskDurationMs": 1292.204,
"heapDeltaBytes": 14501908,
"heapUsedBytes": 68714952,
"domNodes": -283,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 508.8,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3078.6209999999983,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.820999999999998,
"layouts": 60,
"layoutDurationMs": 7.373999999999999,
"taskDurationMs": 1278.313,
"heapDeltaBytes": 13075468,
"heapUsedBytes": 66921112,
"domNodes": -281,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 473.98999999999995,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2023.490000000038,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.405000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.57399999999996,
"heapDeltaBytes": -3459504,
"heapUsedBytes": 58845868,
"domNodes": -275,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 86.624,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2037.509,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.608000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.426,
"heapDeltaBytes": -15518456,
"heapUsedBytes": 60272228,
"domNodes": -271,
"jsHeapTotalBytes": 4005888,
"scriptDurationMs": 92.98100000000001,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.8619999999482,
"styleRecalcs": 48,
"styleRecalcDurationMs": 14.636,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.289,
"heapDeltaBytes": 7846344,
"heapUsedBytes": 66965324,
"domNodes": 22,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 121.777,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.2619999999524,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.269000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.81600000000003,
"heapDeltaBytes": 9313860,
"heapUsedBytes": 61723980,
"domNodes": -289,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 119.70500000000001,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2027.4839999999585,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.283999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.207,
"heapDeltaBytes": -8059368,
"heapUsedBytes": 61758128,
"domNodes": -277,
"jsHeapTotalBytes": 19546112,
"scriptDurationMs": 12.824999999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2029.7479999999268,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.038999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.73500000000007,
"heapDeltaBytes": -7723464,
"heapUsedBytes": 62142692,
"domNodes": -276,
"jsHeapTotalBytes": 19546112,
"scriptDurationMs": 12.774,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.8980000000056,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.013,
"layouts": 16,
"layoutDurationMs": 7.018,
"taskDurationMs": 693.8599999999999,
"heapDeltaBytes": -16718928,
"heapUsedBytes": 53099116,
"domNodes": -233,
"jsHeapTotalBytes": 19546112,
"scriptDurationMs": 87.689,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1794.8659999999563,
"styleRecalcs": 79,
"styleRecalcDurationMs": 47.701,
"layouts": 16,
"layoutDurationMs": 8.031,
"taskDurationMs": 755.4150000000001,
"heapDeltaBytes": -16784924,
"heapUsedBytes": 53029440,
"domNodes": -233,
"jsHeapTotalBytes": 19283968,
"scriptDurationMs": 94.04700000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 965.8399999999574,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.889,
"layouts": 15,
"layoutDurationMs": 16.014,
"taskDurationMs": 736.1469999999999,
"heapDeltaBytes": 3666964,
"heapUsedBytes": 94684160,
"domNodes": 13673,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 26.550000000000004,
"eventListeners": 2533,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8204.83999999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 56.049,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3987.551,
"heapDeltaBytes": 25876128,
"heapUsedBytes": 82618064,
"domNodes": -266,
"jsHeapTotalBytes": 13529088,
"scriptDurationMs": 1349.1280000000002,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8203.901999999971,
"styleRecalcs": 250,
"styleRecalcDurationMs": 57.102999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4264.813999999999,
"heapDeltaBytes": 1216780,
"heapUsedBytes": 73260104,
"domNodes": 18,
"jsHeapTotalBytes": 17620992,
"scriptDurationMs": 1426.179,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11793.585000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11767.275,
"heapDeltaBytes": -48098808,
"heapUsedBytes": 155404880,
"domNodes": -3302,
"jsHeapTotalBytes": 18845696,
"scriptDurationMs": 500.46000000000004,
"eventListeners": -16375,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12361.084000000119,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12346.178000000002,
"heapDeltaBytes": -39101624,
"heapUsedBytes": 161663624,
"domNodes": -3300,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 516.353,
"eventListeners": -16370,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14909.089999999993,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.558000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14888.551,
"heapDeltaBytes": -14981248,
"heapUsedBytes": 168060412,
"domNodes": -3300,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 754.3140000000001,
"eventListeners": -16362,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15330.201999999872,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15309.276,
"heapDeltaBytes": -13578368,
"heapUsedBytes": 176280296,
"domNodes": -3306,
"jsHeapTotalBytes": 14331904,
"scriptDurationMs": 834.234,
"eventListeners": -16362,
"totalBlockingTimeMs": 16,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 446.0679999999684,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.692,
"layouts": 2,
"layoutDurationMs": 0.346,
"taskDurationMs": 100.52600000000001,
"heapDeltaBytes": 4885456,
"heapUsedBytes": 61364552,
"domNodes": 130,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.193,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 469.83099999988553,
"styleRecalcs": 13,
"styleRecalcDurationMs": 21.364,
"layouts": 2,
"layoutDurationMs": 0.3879999999999999,
"taskDurationMs": 183.89500000000004,
"heapDeltaBytes": -22712528,
"heapUsedBytes": 46396456,
"domNodes": -203,
"jsHeapTotalBytes": 5390336,
"scriptDurationMs": 10.153,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #13510 +/- ##
==========================================
- Coverage 77.95% 77.67% -0.28%
==========================================
Files 1656 1656
Lines 92923 93403 +480
Branches 32950 32998 +48
==========================================
+ Hits 72434 72550 +116
- Misses 19840 20175 +335
- Partials 649 678 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 52 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…r data The secrets provider dropdown and saved-keys list now render whichever providers the server lists via GET /secrets/providers, mapping each id to its display label, logo, and optional help text. Previously the dropdown intersected the server list against a hardcoded provider array, so a newly-listed provider (e.g. runway/gemini) could never appear. - Drive create-mode options from the server list; unknown ids fall back to the raw id with no logo, so adding a provider server-side needs no FE change - Add label/logo/help registry entries and placeholder logo assets for the BYOK providers - Surface provider-specific help text under the picker, falling back to the generic hint - Extend composable + add registry unit tests
- Drop unused SECRET_PROVIDERS export (knip) now that lookups go through findProvider internally - Reconcile the selected provider once the server allowlist resolves so an unlisted fallback cannot be submitted - Dedupe server-returned provider ids; replace unsafe as never cast with a type-safe membership check - Guard existingProviders against null with != null
The workflow template selector (z-1700) auto-opens on boot when Comfy.TutorialCompleted is falsy and intercepts pointer events on the settings dialog, so clicking the Secrets nav timed out. Mock settings with TutorialCompleted=true, matching the existing cloud boot pattern. Also drop the unused `export` on SECRET_PROVIDERS (internal-only) so knip passes.
- Anchor the non-entitled test on the opened listbox so the gated-provider absence checks can't pass vacuously against a dropdown that never opened. - Also assert the secret is not smuggled into any input value or attribute, not just visible text nodes.
9b59d7b to
275d8c0
Compare
fa2486f to
32759ca
Compare
|
Converting to draft to stop the auto-resolver from re-attempting. Lint is fixed, but the |
…loss Deleting a Secrets key closed the entire Settings dialog: confirming the delete removes the focused list row, so focus falls to an ordinary app element. As a non-modal Reka dialog, Settings read that programmatic focus shift as an outside interaction and dismissed itself, failing the add/list/ delete e2e at the empty-state assertion. Add a `dismissOnFocusOutside` dialog prop (default true) and set it false on Settings so it no longer dismisses on focus-outside; escape, the close button, and outside-pointer dismissal are unaffected.
|
The Root cause: confirming a Secrets delete removes the focused list row, so browser focus falls to an ordinary app element. The Settings dialog is a non-modal Reka dialog (it must be, to host nested confirm/edit dialogs), and it read that programmatic focus shift as an outside interaction and dismissed itself — so the post-delete Fix (unblocks the delete flow, no behavior change elsewhere): added a Note: this touches shared dialog infra inherited from the base branch — flagging in case it fits better in be-2592. |
@huang47 updated that and fixed the issue you were experiencing. |
- Revert providerHint copy: provider is required by the form validation, so the 'Optional' wording contradicted the enforced behavior. - Drop the inert input/attribute DOM scan in the secrets e2e; the form is unmounted by then so it can never fail. Keep the request-contract and list-text assertions that actually guard the write-only value. - Assert the non-entitled provider dropdown has zero options so a fetch-failure fallback to the default providers can't pass vacuously. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
huang47
left a comment
There was a problem hiding this comment.
I don’t want to block the PR due to the tests. We should address it soon, but I’ll leave it to you to do so in the same PR or a follow-up.
browser_tests/tests/cloudSecrets.spec.ts:125should use the generated ingest types and return the API’s 201 create status. Right now the test hand-rolls SecretRecord / CreateCapture and jsonRoute(created) returns 200, so this can pass while drifting from CreateSecretResponses- Additionally, The PR title/body still frame this as only an E2E test which is not the case anymore. Mind be worth tweaking the harness to make sure the PR title / description are up-to-date
|
Thanks @huang47 — both points taken:
|
|
Post-merge review notes (didn't land before merge). None blocking. Test typing/structure —
Coverage/correctness
Dialog debt
Heads-up: #13464 (toast) and #13487 (menu trigger) both modify |
|
@mattmillerai Successfully backported to #13621 |
|
@mattmillerai Successfully backported to #13622 |


ELI-5
The settings screen now has a "Secrets" panel where you can save API keys for
model/AI providers. This PR does two things. First, it fixes a real bug the new
test caught: confirming a delete inside Settings made the whole Settings window
close itself — like a cashier abandoning the register because you put your
receipt in your pocket. Second, it adds an end-to-end test that plays out the
whole story like a real user: open the panel, add a key, watch it show up in
the list, then delete it — and checks the key you typed is never shown back
to you afterward.
What
Product fix: Settings no longer dismisses itself when a nested dialog closes
fix(dialog): the Settings dialog is non-modal (it must be, to host nestedconfirm/edit dialogs). When a nested dialog closed and the element it had
focused was removed from the DOM (e.g. confirming a Secrets delete removes the
focused list row), browser focus fell to an ordinary app element — and the
non-modal Reka dialog read that programmatic focus shift as an outside
interaction and dismissed itself.
rekaPrimeVueBridge.ts/GlobalDialog.vue:onRekaFocusOutsidenow acceptsa per-dialog
dismissOnFocusOutsideopt-out (escape and outside pointerclicks still dismiss).
useSettingsDialog.ts: Settings opts out of focus-outside dismissal.dialogStore.ts: plumbs the new dialog prop.useSecretForm.ts,SecretFormDialog.vue, locale string).E2E: BYOK secret add / list / delete flow
Adds
browser_tests/tests/cloudSecrets.spec.ts, a Playwright spec covering thesecrets (API keys) surface in the cloud app:
(pick provider, name, secret value, save) -> the key appears in the list ->
delete it via the confirm dialog -> back to empty state.
plaintext value, but the value is never echoed back into the DOM (the
list-response schema is metadata-only).
the gated providers anywhere in the add dialog.
Follows the existing cloud E2E conventions: drives a raw
pageand reuses themockCloudBoot/bootCloudhelpers so the app boots signed-in against fullymocked endpoints. A small stateful in-memory handler backs the secrets endpoints
(list / create / delete + the provider allowlist) so the flow is deterministic
and never touches a real backend.
Why
Verification capstone for the secrets settings surface — proves the add / list /
delete flow works against the documented API behavior and locks in the two
contracts that matter: the secret value is never returned after creation, and
the provider allowlist is the only thing that surfaces gated providers to the
user. The dialog fix ships in the same PR because the E2E discovered it: the
delete step of the CRUD round-trip could not pass while Settings dismissed
itself, so the test and the fix are verified together.
Tests
browser_tests/tests/cloudSecrets.spec.ts— new, tagged@cloud; the deletestep doubles as the regression test for the dialog fix.
GlobalDialog.test.ts— new unit case pinningdismissOnFocusOutside: falsebehavior in
onRekaFocusOutside.Follow-ups (tracked internally, agreed with reviewer)
@comfyorg/ingest-typesand return the API's real
201create status, so the mock can't drift fromthe contract while the test stays green.