Repository navigation
fix(assets): make model type read-only on core - #13302
Conversation
📝 WalkthroughWalkthroughModel type editing is now limited to mutable cloud assets. Read-only states expose accessible explanations, and model type tag persistence uses a centralized update resolver with new test coverage and locale strings. ChangesModel type editing
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant ModelInfoPanel
participant resolveModelTypeTagUpdate
participant buildModelTypeTagUpdate
User->>ModelInfoPanel: Select model type
ModelInfoPanel->>resolveModelTypeTagUpdate: Pass selection and editability
resolveModelTypeTagUpdate->>buildModelTypeTagUpdate: Build changed tag set
buildModelTypeTagUpdate-->>ModelInfoPanel: Return updated tags
Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1740 passed, 0 failed📊 Browser Reports
📦 Bundle: 8.13 MB gzip 🔴 +241 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.28 MB (baseline 1.28 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 1 unchanged UI Components — 64.6 kB (baseline 64.6 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.39 MB (baseline 3.39 MB) • 🔴 +607 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 366 kB (baseline 366 kB) • 🔴 +523 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 16 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.5 MB (baseline 12.5 MB) • 🔴 +193 BBundles that do not match a named category
Status: 78 added / 78 removed / 199 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-28T06:48:13.478Z",
"gitSha": "146e0588240b3cb8a8bfd013436ea3f1f34b6ab0",
"branch": "synap5e/disable-change-model-tag-on-core",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.0479999999907,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.163,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.192,
"heapDeltaBytes": 3520208,
"heapUsedBytes": 71243192,
"domNodes": 18,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 24.465999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2018.5010000000148,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.735000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.2489999999999,
"heapDeltaBytes": 3441080,
"heapUsedBytes": 71242184,
"domNodes": 18,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 20.933999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2116.4459999999963,
"styleRecalcs": 78,
"styleRecalcDurationMs": 48.671,
"layouts": 12,
"layoutDurationMs": 4.6499999999999995,
"taskDurationMs": 1086.3799999999999,
"heapDeltaBytes": -14581560,
"heapUsedBytes": 53275540,
"domNodes": -275,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 136.132,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.1460000000725,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.248000000000005,
"layouts": 12,
"layoutDurationMs": 3.439,
"taskDurationMs": 885.382,
"heapDeltaBytes": -14041968,
"heapUsedBytes": 53713420,
"domNodes": -274,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 115.66999999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.410999999985,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.220000000000002,
"layouts": 6,
"layoutDurationMs": 0.68,
"taskDurationMs": 390.989,
"heapDeltaBytes": 6961452,
"heapUsedBytes": 74819444,
"domNodes": 77,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 20.598,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.7140000000063,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.988,
"layouts": 6,
"layoutDurationMs": 0.5730000000000002,
"taskDurationMs": 373.459,
"heapDeltaBytes": 7106384,
"heapUsedBytes": 75115068,
"domNodes": 77,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 18.467000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 606.5469999999777,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.956999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.002,
"heapDeltaBytes": -12022932,
"heapUsedBytes": 55925780,
"domNodes": 18,
"jsHeapTotalBytes": 21368832,
"scriptDurationMs": 61.178999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 559.3289999999342,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.6979999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.2610000000001,
"heapDeltaBytes": -12061484,
"heapUsedBytes": 55751064,
"domNodes": 16,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 54.132,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.2220000000325,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.448999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.027,
"heapDeltaBytes": 5804128,
"heapUsedBytes": 64643740,
"domNodes": -274,
"jsHeapTotalBytes": 3739648,
"scriptDurationMs": 122.87700000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.5299999999233,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.252999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.7850000000001,
"heapDeltaBytes": 6897336,
"heapUsedBytes": 65588904,
"domNodes": -274,
"jsHeapTotalBytes": 4788224,
"scriptDurationMs": 98.44500000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2180.8229999999753,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.573999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1233.932,
"heapDeltaBytes": 5691356,
"heapUsedBytes": 65383020,
"domNodes": -277,
"jsHeapTotalBytes": 4730880,
"scriptDurationMs": 407.088,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2137.9409999999552,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.635000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1208.475,
"heapDeltaBytes": 5237708,
"heapUsedBytes": 65136824,
"domNodes": -278,
"jsHeapTotalBytes": 5255168,
"scriptDurationMs": 392.762,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3145.4370000000154,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.196999999999997,
"layouts": 60,
"layoutDurationMs": 8.157,
"taskDurationMs": 1511.447,
"heapDeltaBytes": -6430408,
"heapUsedBytes": 56637844,
"domNodes": -283,
"jsHeapTotalBytes": 8196096,
"scriptDurationMs": 537.3919999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3183.04999999998,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.606000000000002,
"layouts": 60,
"layoutDurationMs": 7.777,
"taskDurationMs": 1470.866,
"heapDeltaBytes": -3614468,
"heapUsedBytes": 57809320,
"domNodes": -280,
"jsHeapTotalBytes": 7671808,
"scriptDurationMs": 516.532,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2058.2480000000487,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.614999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.109,
"heapDeltaBytes": 7264216,
"heapUsedBytes": 67886052,
"domNodes": -277,
"jsHeapTotalBytes": 4001792,
"scriptDurationMs": 101.878,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.2310000000198,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.9659999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.6010000000001,
"heapDeltaBytes": 7130128,
"heapUsedBytes": 67563000,
"domNodes": -275,
"jsHeapTotalBytes": 4526080,
"scriptDurationMs": 96.351,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.8940000000443,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.748000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.053,
"heapDeltaBytes": -11724972,
"heapUsedBytes": 56076072,
"domNodes": 16,
"jsHeapTotalBytes": 22155264,
"scriptDurationMs": 122.16099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.2389999999077,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.30899999999997,
"heapDeltaBytes": -11945572,
"heapUsedBytes": 56220736,
"domNodes": 22,
"jsHeapTotalBytes": 21893120,
"scriptDurationMs": 125.75,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2033.7610000000268,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.28700000000003,
"heapDeltaBytes": -22347996,
"heapUsedBytes": 45853160,
"domNodes": 20,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 15.214000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.0089999999636,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.484,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.95300000000003,
"heapDeltaBytes": -21585684,
"heapUsedBytes": 46372892,
"domNodes": -275,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 13.288000000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.132000000015,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.305,
"layouts": 16,
"layoutDurationMs": 4.615,
"taskDurationMs": 802.145,
"heapDeltaBytes": -19498812,
"heapUsedBytes": 48412276,
"domNodes": -273,
"jsHeapTotalBytes": 21757952,
"scriptDurationMs": 90.003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.8979999999956,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.091,
"layouts": 16,
"layoutDurationMs": 4.043,
"taskDurationMs": 806.4559999999999,
"heapDeltaBytes": -20367676,
"heapUsedBytes": 47722576,
"domNodes": -271,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 90.487,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1366.8700000000058,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.867000000000004,
"layouts": 15,
"layoutDurationMs": 13.667,
"taskDurationMs": 911.2460000000002,
"heapDeltaBytes": 3585332,
"heapUsedBytes": 85247768,
"domNodes": 13673,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 31.642000000000003,
"eventListeners": 2371,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8271.953999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.741,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4314.995000000001,
"heapDeltaBytes": 10996844,
"heapUsedBytes": 69849668,
"domNodes": -276,
"jsHeapTotalBytes": 6565888,
"scriptDurationMs": 1317.816,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8201.524999999947,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.998000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4258.062000000001,
"heapDeltaBytes": 1186984,
"heapUsedBytes": 60512120,
"domNodes": -274,
"jsHeapTotalBytes": 7147520,
"scriptDurationMs": 1290.237,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17909.094000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17877.503999999997,
"heapDeltaBytes": -42490036,
"heapUsedBytes": 170403740,
"domNodes": -8312,
"jsHeapTotalBytes": -8589312,
"scriptDurationMs": 548.8729999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17878.50900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17853.119,
"heapDeltaBytes": -59605136,
"heapUsedBytes": 166903296,
"domNodes": -8312,
"jsHeapTotalBytes": -14090240,
"scriptDurationMs": 557.4559999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22164.109999999993,
"styleRecalcs": 158,
"styleRecalcDurationMs": 22.034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22121.735999999997,
"heapDeltaBytes": -41539232,
"heapUsedBytes": 178661156,
"domNodes": -8312,
"jsHeapTotalBytes": -14176256,
"scriptDurationMs": 896.3389999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 470,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22272.07299999998,
"styleRecalcs": 164,
"styleRecalcDurationMs": 24.17699999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22218.431000000004,
"heapDeltaBytes": -37310176,
"heapUsedBytes": 180482700,
"domNodes": -8312,
"jsHeapTotalBytes": -14704640,
"scriptDurationMs": 918.0600000000001,
"eventListeners": -16381,
"totalBlockingTimeMs": 658,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 468.1899999999928,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.333000000000002,
"layouts": 5,
"layoutDurationMs": 1.946,
"taskDurationMs": 138.465,
"heapDeltaBytes": -15657172,
"heapUsedBytes": 51400388,
"domNodes": 154,
"jsHeapTotalBytes": 7737344,
"scriptDurationMs": 13.136999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 474.91599999989376,
"styleRecalcs": 12,
"styleRecalcDurationMs": 21.951,
"layouts": 4,
"layoutDurationMs": 1.359,
"taskDurationMs": 125.31200000000001,
"heapDeltaBytes": -16392172,
"heapUsedBytes": 50620472,
"domNodes": 115,
"jsHeapTotalBytes": 7737344,
"scriptDurationMs": 11.32,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #13302 +/- ##
==========================================
+ Coverage 78.86% 79.43% +0.57%
==========================================
Files 1743 1743
Lines 99281 96848 -2433
Branches 32881 30068 -2813
==========================================
- Hits 78294 76929 -1365
+ Misses 20588 19549 -1039
+ Partials 399 370 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 67 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
|
code changes lgtm, could you share the before/after screenshot to showcase the difference |
|
This PR stack is the first time the Model Library works against local, so before/after is arguably not honest. The stack is: Here's what #12972 (this PR's base) looks like on local i.e. with the dropdown allowed Then on this PR this changes to And I validated this PR against cloud as a BE, and confirmed no change |
|
This is awesome! Thanks @synap5e for the detailed context. |
|
manually verify it which shows the readonly model type |
c40bc91 to
e53b7b4
Compare
2b21ba2 to
0497377
Compare
0497377 to
1872397
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Automated multi-agent review of this PR's delta against its parent branch. The read-only gate (isModelTypeEditable = !isImmutable && isCloud) is sound: cloud path unchanged, core falls through to the existing read-only label, and the save guard is consistent at its sole call site. No blocking issues; two optional test-strengthening notes.
The base branch was changed.
…e-model-tag-on-core # Conflicts: # src/platform/assets/components/modelInfo/ModelInfoPanel.vue # src/platform/assets/composables/useUploadModelWizard.test.ts # src/platform/assets/utils/assetMetadataUtils.test.ts # src/platform/assets/utils/assetMetadataUtils.ts
…rg#12972) ## Summary The FE writes `model_type:<folder_name>` (from `/api/experiment/models` discovery) on model import and on model-type edits, gated on the `supports_model_type_tags` backend capability. Default off = today's bare directory-path write, so this is a no-op until the backend declares the cutover. Note: Comfy-Org#13302 (stacked on top of this) disables model type editing on Core for now, so the edit-path write is cloud-only in practice. The import write path stays live on core once a core backend advertises the flag, which is safe: an import creates the file in the folder its tag names, so no move-on-retag divergence can arise. ## Changes - **What**: - `assetMetadataUtils.ts`: export `MODEL_TYPE_TAG_PREFIX`; add pure helpers `toModelTypeTag`, `getEditableModelType`, `buildModelTypeTagUpdate` (flag-param, mirroring FE-1076's `modelTypeMode`). - Import (`useUploadModelWizard.ts`) and edit-type (`ModelInfoPanel.vue`) write paths prefix the selected folder_name when the flag is on; the edit dropdown read is prefix-aware so it round-trips. `user_metadata.model_type` stays bare. - Gated on the same `supports_model_type_tags` signal FE-1076 grouping reads (`useFeatureFlags().flags.supportsModelTypeTags`). - **Breaking**: none. Flag default false preserves the legacy bare-tag write/read exactly. ## Review Focus - The FE writes only the single selected folder_name's `model_type:` form; the backend keeps the bare directory-path twin in sync and forward-expands shared paths (spec-drift §1), so the edit path manages just the `model_type:` tags and the resolver read path is untouched. - An uncovered asset (no `model_type:` tag) still routes by its bare tag on both read and write, mirroring FE-1076. - Stacked on FE-1076 (Comfy-Org#12948, `synap5e/fe-1076-...`), which is self-contained on `main`. Chain: `main` → Comfy-Org#12948 (FE-1076) → Comfy-Org#12972 (this PR); the diff carries FE-1076's commits until it merges, then GitHub auto-retargets this PR to `main` (or this PR is merged to Comfy-Org#12948) Part of the cross-BE `model_type:<folder_name>` tag migration. Flipping the cutover dynconfig is a separate coordinated action, not in this PR. Treats FE-1069 (migrate model-upload import-by-URL off hard-coded `['models', <type>]` tags): the import-by-URL write here emits `models` + `model_type:<folder_name>` (flag-gated) per FE-1069's AC, with `user_metadata.model_type` kept bare.
AustinMroz
left a comment
There was a problem hiding this comment.
Obligatory @AGENTS.md:313
…table gate The read-only tests only proved the combobox was absent, which cannot distinguish intended read-only display from a silently missing field. Resolve model-type options in the test so the read-only label's value is assertable, and cover the immutable-on-cloud dimension of the editability gate alongside the existing core path.
fa04ec7
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/assets/components/modelInfo/ModelInfoPanel.test.ts`:
- Around line 178-182: Extend the immutable-cloud test for the model type field
to assert that the field is disabled and exposes the localized read-only
explanation through its accessible description. Use role/name or accessible
text/description queries rather than checking implementation details, while
retaining the existing current-value assertion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 00bddc0f-f2f3-4164-9663-21a55a242db7
📒 Files selected for processing (1)
src/platform/assets/components/modelInfo/ModelInfoPanel.test.ts




Summary
Make the Model Info model-type dropdown read-only on core (non-cloud) builds, since core can't yet move a model file when its type tag changes.
Changes
SelectinModelInfoPanelbehindisCloud. On core the field falls through to the existing read-only label; cloud is unchanged. Base/additional tag editing is untouched.Review Focus
Retagging a model rewrites its asset tags, but core is filesystem-backed and does not move the underlying file to match the new type, so an edit would leave the tag and the on-disk location diverged. This is a hard
isCloudbuild-time branch, intended to be reverted once core implements move-on-retag (or the asset system no longer requires the file move). The write-path helpers stay valid for cloud; they're just unreachable from the UI on core.Stacked on #12972.