Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughChangesModel type handling now supports feature-flagged Model Type Tag Handling
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ModelInfoPanel
participant FeatureFlags
participant assetMetadataUtils
participant AssetAPI
ModelInfoPanel->>FeatureFlags: read supportsModelTypeTags
ModelInfoPanel->>assetMetadataUtils: getEditableModelType
ModelInfoPanel->>assetMetadataUtils: buildModelTypeTagUpdate
ModelInfoPanel->>AssetAPI: save updated asset tags
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ⏳ Running...📦 Bundle: 8.13 MB gzip 🔴 +257 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.28 MB (baseline 1.28 MB) • 🟢 -1.67 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 1 unchanged UI Components — 64.6 kB (baseline 64.6 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.39 MB (baseline 3.39 MB) • 🔴 +361 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 366 kB (baseline 363 kB) • 🔴 +3.01 kBHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 19 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.5 MB (baseline 12.5 MB) • 🟢 -180 BBundles that do not match a named category
Status: 71 added / 71 removed / 206 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-28T04:13:29.165Z",
"gitSha": "3325679876e4940ec14a7f35a9309043dc1970e9",
"branch": "synap5e/fe-1084-fe-write-model-type-from-discovery-flip-the-cutover-flag",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.445999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.917999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.901,
"heapDeltaBytes": -21232156,
"heapUsedBytes": 46520536,
"domNodes": -274,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 15.396999999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2103.876000000014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.410999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.427,
"heapDeltaBytes": -22858748,
"heapUsedBytes": 45052168,
"domNodes": -277,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 23.517999999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.0580000000127,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.864999999999995,
"layouts": 12,
"layoutDurationMs": 3.381,
"taskDurationMs": 868.25,
"heapDeltaBytes": -16328584,
"heapUsedBytes": 51582972,
"domNodes": -276,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 117.84599999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1878.7189999999327,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.122,
"layouts": 12,
"layoutDurationMs": 3.5650000000000004,
"taskDurationMs": 927.839,
"heapDeltaBytes": -16467844,
"heapUsedBytes": 51467316,
"domNodes": -275,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 128.925,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.487999999957,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.387,
"layouts": 6,
"layoutDurationMs": 0.609,
"taskDurationMs": 370.02799999999996,
"heapDeltaBytes": 7339144,
"heapUsedBytes": 75150876,
"domNodes": 77,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 17.932999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.6659999999056,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.529000000000003,
"layouts": 6,
"layoutDurationMs": 0.598,
"taskDurationMs": 392.736,
"heapDeltaBytes": 6971516,
"heapUsedBytes": 74878608,
"domNodes": 77,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 19.334000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 646.4859999999817,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.229,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.13300000000004,
"heapDeltaBytes": -12372892,
"heapUsedBytes": 55501616,
"domNodes": 20,
"jsHeapTotalBytes": 21106688,
"scriptDurationMs": 62.311,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 609.6770000000333,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.987000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.335,
"heapDeltaBytes": -11974348,
"heapUsedBytes": 55816732,
"domNodes": 18,
"jsHeapTotalBytes": 21630976,
"scriptDurationMs": 61.449999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.0329999999935,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.424999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.8850000000001,
"heapDeltaBytes": 6498868,
"heapUsedBytes": 66171348,
"domNodes": -277,
"jsHeapTotalBytes": 4263936,
"scriptDurationMs": 107.16599999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.126999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.218000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 727.4739999999999,
"heapDeltaBytes": 6921140,
"heapUsedBytes": 66239104,
"domNodes": -276,
"jsHeapTotalBytes": 5312512,
"scriptDurationMs": 118.66500000000002,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2154.3460000000323,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.266000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1173.6259999999997,
"heapDeltaBytes": 6427392,
"heapUsedBytes": 67207364,
"domNodes": -277,
"jsHeapTotalBytes": 3944448,
"scriptDurationMs": 438.96900000000005,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2208.0060000000685,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.714000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1361.5900000000001,
"heapDeltaBytes": 5351712,
"heapUsedBytes": 65490220,
"domNodes": -278,
"jsHeapTotalBytes": 5779456,
"scriptDurationMs": 459.1689999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3229.9409999999966,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.573,
"layouts": 60,
"layoutDurationMs": 7.592999999999999,
"taskDurationMs": 1587.644,
"heapDeltaBytes": 1368292,
"heapUsedBytes": 62734660,
"domNodes": -283,
"jsHeapTotalBytes": 7933952,
"scriptDurationMs": 553.591,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3361.3189999999804,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.687999999999999,
"layouts": 60,
"layoutDurationMs": 7.625,
"taskDurationMs": 1600.864,
"heapDeltaBytes": 22222872,
"heapUsedBytes": 86446464,
"domNodes": 8,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 572.3020000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2011.6279999999733,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.689,
"heapDeltaBytes": 6193312,
"heapUsedBytes": 68772952,
"domNodes": -276,
"jsHeapTotalBytes": 5574656,
"scriptDurationMs": 100.147,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.7019999999811,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.419000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.605,
"heapDeltaBytes": 5881036,
"heapUsedBytes": 66446404,
"domNodes": -276,
"jsHeapTotalBytes": 5050368,
"scriptDurationMs": 120.708,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.4650000000029,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.913,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.502,
"heapDeltaBytes": -11832280,
"heapUsedBytes": 56103952,
"domNodes": 20,
"jsHeapTotalBytes": 21368832,
"scriptDurationMs": 116.81400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 672.2270000000208,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.73,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.21999999999997,
"heapDeltaBytes": -11521736,
"heapUsedBytes": 56564676,
"domNodes": 20,
"jsHeapTotalBytes": 21368832,
"scriptDurationMs": 127.91999999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2047.0189999999775,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.191,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.19300000000004,
"heapDeltaBytes": 3457892,
"heapUsedBytes": 70962340,
"domNodes": 20,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 13.699,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.0239999999303,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.138,
"heapDeltaBytes": 3489208,
"heapUsedBytes": 71464152,
"domNodes": 20,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 14.989,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.6729999999998,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.65500000000001,
"layouts": 16,
"layoutDurationMs": 3.79,
"taskDurationMs": 777.6410000000001,
"heapDeltaBytes": -20634928,
"heapUsedBytes": 47311336,
"domNodes": -274,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 89.40100000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1736.4510000001019,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.718,
"layouts": 16,
"layoutDurationMs": 4.226,
"taskDurationMs": 836.077,
"heapDeltaBytes": -21960628,
"heapUsedBytes": 45893008,
"domNodes": 62,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 99.334,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.6849999999295,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.286999999999995,
"layouts": 13,
"layoutDurationMs": 12.766,
"taskDurationMs": 971.9259999999998,
"heapDeltaBytes": 31018928,
"heapUsedBytes": 99449588,
"domNodes": 13673,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 34.90199999999999,
"eventListeners": 2371,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8439.96599999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.64099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4741.003,
"heapDeltaBytes": 5849564,
"heapUsedBytes": 64659260,
"domNodes": -275,
"jsHeapTotalBytes": 10555392,
"scriptDurationMs": 1573.7290000000003,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8340.78199999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4659.904,
"heapDeltaBytes": 8158272,
"heapUsedBytes": 69625316,
"domNodes": -271,
"jsHeapTotalBytes": 7061504,
"scriptDurationMs": 1435.381,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17464.737000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17445.742,
"heapDeltaBytes": -51574212,
"heapUsedBytes": 170676092,
"domNodes": -8312,
"jsHeapTotalBytes": -8327168,
"scriptDurationMs": 573.785,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17680.15600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17657.587,
"heapDeltaBytes": -42103444,
"heapUsedBytes": 165641532,
"domNodes": -3314,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 609.32,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20271.040000000026,
"styleRecalcs": 137,
"styleRecalcDurationMs": 15.989000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20223.403,
"heapDeltaBytes": -41919404,
"heapUsedBytes": 166415612,
"domNodes": -8312,
"jsHeapTotalBytes": -12521472,
"scriptDurationMs": 862.9170000000001,
"eventListeners": -16381,
"totalBlockingTimeMs": 201,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21029.057999999965,
"styleRecalcs": 145,
"styleRecalcDurationMs": 17.47500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20978.496,
"heapDeltaBytes": -57929052,
"heapUsedBytes": 166569680,
"domNodes": -8312,
"jsHeapTotalBytes": -14876672,
"scriptDurationMs": 908.1659999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 246,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 457.5609999999415,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.983999999999995,
"layouts": 2,
"layoutDurationMs": 0.40600000000000014,
"taskDurationMs": 111.837,
"heapDeltaBytes": -16078572,
"heapUsedBytes": 51105828,
"domNodes": 130,
"jsHeapTotalBytes": 7737344,
"scriptDurationMs": 9.527,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 458.57200000000375,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.002000000000002,
"layouts": 2,
"layoutDurationMs": 0.322,
"taskDurationMs": 108.33800000000001,
"heapDeltaBytes": -16034312,
"heapUsedBytes": 50971304,
"domNodes": 119,
"jsHeapTotalBytes": 7737344,
"scriptDurationMs": 9.193,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
Deployment failed with the following error: Learn More: https://vercel.com/uy-tieu-s-projects?upgradeToPro=build-rate-limit |
b9bef2a to
921514f
Compare
4841af2 to
c000719
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c00071925b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
24ed6a7 to
4d20b2b
Compare
e84fee1 to
bd7d07a
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #12972 +/- ##
==========================================
+ Coverage 79.01% 79.40% +0.38%
==========================================
Files 1742 1742
Lines 98401 96824 -1577
Branches 31832 30065 -1767
==========================================
- Hits 77751 76879 -872
+ Misses 20265 19575 -690
+ Partials 385 370 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 60 files with indirect coverage changes 🚀 New features to boost your workflow:
|
eec9abb to
f7d672e
Compare
c40bc91 to
e53b7b4
Compare
|
Visual check for PR #12972. Setup: route-mocked real app with https://github.com/user-attachments/assets/7e0e2d4e-5a96-45a6-a407-51170ac27ae6 pr-12972-clear-before-after.mp4 |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving. Final pass against the current head: the one commit since my last review restores the getServerFeature mock via mockReset() in afterEach and drops the manual try/finally, which is exactly the mock-lifecycle cleanup I flagged. Clean reparent otherwise, no logic change. Green.
The base branch was changed.
…ite-model-type-from-discovery-flip-the-cutover-flag # Conflicts: # src/platform/assets/utils/assetMetadataUtils.test.ts # src/platform/assets/utils/assetMetadataUtils.ts
## Summary Make the Model Info model-type dropdown read-only on core (non-cloud) builds, since core can't yet move a model file when its type tag changes. ## Changes - **What**: Gate the model-type `Select` in `ModelInfoPanel` behind `isCloud`. On core the field falls through to the existing read-only label; cloud is unchanged. Base/additional tag editing is untouched. ## Review Focus Retagging a model rewrites its asset tags, but core is filesystem-backed and does not move the underlying file to match the new type, so an edit would leave the tag and the on-disk location diverged. This is a hard `isCloud` build-time branch, intended to be reverted once core implements move-on-retag (or the asset system no longer requires the file move). The write-path helpers stay valid for cloud; they're just unreachable from the UI on core. Stacked on Comfy-Org#12972.
Summary
The FE writes
model_type:<folder_name>(from/api/experiment/modelsdiscovery) on model import and on model-type edits, gated on thesupports_model_type_tagsbackend capability. Default off = today's bare directory-path write, so this is a no-op until the backend declares the cutover.Note: #13302 (stacked on top of this) disables model type editing on Core for now, so the edit-path write is cloud-only in practice. The import write path stays live on core once a core backend advertises the flag, which is safe: an import creates the file in the folder its tag names, so no move-on-retag divergence can arise.
Changes
assetMetadataUtils.ts: exportMODEL_TYPE_TAG_PREFIX; add pure helperstoModelTypeTag,getEditableModelType,buildModelTypeTagUpdate(flag-param, mirroring FE-1076'smodelTypeMode).useUploadModelWizard.ts) and edit-type (ModelInfoPanel.vue) write paths prefix the selected folder_name when the flag is on; the edit dropdown read is prefix-aware so it round-trips.user_metadata.model_typestays bare.supports_model_type_tagssignal FE-1076 grouping reads (useFeatureFlags().flags.supportsModelTypeTags).Review Focus
model_type:form; the backend keeps the bare directory-path twin in sync and forward-expands shared paths (spec-drift §1), so the edit path manages just themodel_type:tags and the resolver read path is untouched.model_type:tag) still routes by its bare tag on both read and write, mirroring FE-1076.synap5e/fe-1076-...), which is self-contained onmain. Chain:main→ feat(assets): group model library by model_type tags (FE-1076) #12948 (FE-1076) → feat(assets): write model_type: tag from discovery (FE-1084) #12972 (this PR); the diff carries FE-1076's commits until it merges, then GitHub auto-retargets this PR tomain(or this PR is merged to feat(assets): group model library by model_type tags (FE-1076) #12948)Part of the cross-BE
model_type:<folder_name>tag migration. Flipping the cutover dynconfig is a separate coordinated action, not in this PR.Treats FE-1069 (migrate model-upload import-by-URL off hard-coded
['models', <type>]tags): the import-by-URL write here emitsmodels+model_type:<folder_name>(flag-gated) per FE-1069's AC, withuser_metadata.model_typekept bare.