Skip to content

Support fast disco on subgraph IO - #12619

Merged
AustinMroz merged 5 commits into
mainfrom
austin/fast-subgraph-disco-fe-852
Jun 8, 2026
Merged

AustinMroz merged 5 commits into
mainfrom
austin/fast-subgraph-disco-fe-852

Conversation

@AustinMroz

Copy link
Copy Markdown
Collaborator

Because subgraph links don't follow the normal link logic, the fast disconnection circle would not function when dragging input links that originate from a subgraph IO node. There's some sad duplication of state, but I think the flow is marginally cleaner now by not requiring instanceof checks.

The test added by this PR also verifies behavior for the node-to-node case.

@AustinMroz
AustinMroz requested a review from a team June 3, 2026 03:27
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 3, 2026
@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: be863b39-c79b-46cb-aff0-2b849b6f8d0a

📥 Commits

Reviewing files that changed from the base of the PR and between 0f4bc5d and 3fb8022.

📒 Files selected for processing (1)
  • src/lib/litegraph/src/canvas/RenderLink.ts
💤 Files with no reviewable changes (1)
  • src/lib/litegraph/src/canvas/RenderLink.ts

📝 Walkthrough

Walkthrough

Adds optional disconnect-on-drop fields to render links, initializes disconnect origin in link construction, updates canvas rendering and drop logic to honor the new fields, renames a test fixture helper, and adds a Playwright test for fast vs normal disconnection.

Changes

Fast disconnection support

Layer / File(s) Summary
RenderLink interface contract
src/lib/litegraph/src/canvas/RenderLink.ts
RenderLink extended with optional disconnectOnDrop?: boolean and disconnectOrigin?: Point.
ToInputFromIoNodeLink implementation
src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts
ToInputFromIoNodeLink adds disconnectOnDrop and disconnectOrigin fields; constructor sets disconnectOnDrop = true and derives disconnectOrigin from an existing link's target input position when present.
Canvas rendering and drop handling
src/lib/litegraph/src/LGraphCanvas.ts, src/lib/litegraph/src/canvas/LinkConnector.ts, src/lib/litegraph/src/canvas/MovingInputLink.ts
LGraphCanvas.drawConnections now iterates all render links and draws a disconnect outline for links with disconnectOnDrop+disconnectOrigin, updating the flag based on pointer proximity; LinkConnector.dropOnNothing disconnects any render link with a truthy disconnectOnDrop. MovingInputLink removed its drawConnectionCircle method and made disconnectOrigin optional.
Tests and fixture rename
browser_tests/fixtures/ComfyMouse.ts, browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts, browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts, browser_tests/tests/vueNodes/widgets/legacy.spec.ts
ComfyMouse.resizeByDragging renamed to dragElementBy. New Playwright test "Fast disconnection support" added; two existing tests updated to use the renamed helper.

Sequence Diagram

sequenceDiagram
  participant LGraphCanvas
  participant RenderLink
  participant LinkConnector
  LGraphCanvas->>RenderLink: iterate renderLinks, read `disconnectOrigin`
  LGraphCanvas->>RenderLink: draw disconnect outline when pointer within radius
  LGraphCanvas->>RenderLink: set `disconnectOnDrop` based on proximity
  LinkConnector->>RenderLink: remove entries where `disconnectOnDrop` true and call `disconnect()`
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

core/1.45, cloud/1.45

Suggested reviewers

  • pythongosssss

Poem

🐰 I nudged a tiny circle where the wires might part,
A hop, a gentle drag, and links unbind with art,
Fast drops slip free before the menu wakes,
Subgraphs sigh softly as their tether breaks,
The rabbit twitches whiskers — neat, precise, and smart.

🚥 Pre-merge checks | ✅ 3 | ❌ 4

❌ Failed checks (3 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It lacks proper structure with the required sections (Summary, Changes, Review Focus) and misses key details like dependencies. Fill out the description template with clear sections: add a concise summary explaining the issue, detail what was changed (core functionality), note any breaking changes if applicable, and highlight critical design decisions for review.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Adr Compliance For Entity/Litegraph Changes ⚠️ Warning LGraphCanvas.drawConnections() mutates link.disconnectOnDrop based on cursor position, violating ADR 0003 command pattern (non-serializable imperative side-effects). Use separate render-state dictionary/event system instead of mutating RenderLink. See docs/adr/0003-command-pattern.md for command pattern guidance.
Title check ❓ Inconclusive The title 'Support fast disco on subgraph IO' is vague and uses non-descriptive abbreviations ('disco', 'IO') that don't clearly convey the main change. Expand the title to be more descriptive: 'Support fast disconnection on subgraph IO nodes' or 'Enable fast disconnect UI for subgraph IO node links'.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PR title and commit subjects lack explicit bug-fix language (fix/fixed/fixes/bugfix/hotfix), so the check does not apply. Browser tests were also added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch austin/fast-subgraph-disco-fe-852

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1659 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1638 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

github-actions Bot commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 06/04/2026, 08:06:33 PM UTC

Links

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (2)
src/lib/litegraph/src/canvas/LinkConnector.ts (1)

876-879: 💤 Low value

Consider type guard for disconnect() capability.

The code now uses a generic disconnectOnDrop check and casts to { disconnect(): void }. This assumes any RenderLink with disconnectOnDrop=true also has a disconnect() method—an implicit contract not enforced by types. Per learnings from PR 7459, prefer user-defined type guards over casts in LiteGraph code for better type safety and reusability.

♻️ Optional type guard approach
// Define a type guard for disconnectable links
function isDisconnectableLink(
  link: RenderLink
): link is RenderLink & { disconnect(): boolean } {
  return !!link.disconnectOnDrop && 'disconnect' in link
}

// Usage:
remove(this.renderLinks, isDisconnectableLink).forEach(link => link.disconnect())

This approach provides compile-time safety and avoids the cast.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/lib/litegraph/src/canvas/LinkConnector.ts` around lines 876 - 879,
Replace the unsafe cast by adding a user-defined type guard that narrows
RenderLink to a disconnect-capable type and use it with remove(this.renderLinks,
...). Specifically, implement an isDisconnectableLink(link: RenderLink): link is
RenderLink & { disconnect(): void } that checks link.disconnectOnDrop and that
'disconnect' exists on the object, then call remove(this.renderLinks,
isDisconnectableLink).forEach(link => link.disconnect()); update usages
referencing RenderLink, renderLinks, disconnectOnDrop and disconnect()
accordingly.
src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts (1)

173-190: 💤 Low value

Code duplication with MovingInputLink.drawConnectionCircle.

This implementation is nearly identical to MovingInputLink.drawConnectionCircle (per context snippet lines 141-158). The only difference is the additional !this.disconnectOrigin guard. Consider extracting the shared circle-drawing logic into a utility function to improve maintainability.

♻️ Example utility extraction
// In a shared utility file:
function drawDisconnectCircle(
  ctx: CanvasRenderingContext2D,
  origin: Point,
  to: Readonly<Point>,
  radius = 35
): boolean {
  const [originX, originY] = origin
  const distSquared = (originX - to[0]) ** 2 + (originY - to[1]) ** 2

  ctx.save()
  ctx.strokeStyle = LiteGraph.WIDGET_OUTLINE_COLOR
  ctx.lineWidth = 2
  ctx.beginPath()
  ctx.moveTo(originX + radius, originY)
  ctx.arc(originX, originY, radius, 0, Math.PI * 2)
  ctx.stroke()
  ctx.restore()

  return distSquared < radius ** 2
}

// Usage in drawConnectionCircle:
drawConnectionCircle(ctx: CanvasRenderingContext2D, to: Readonly<Point>) {
  if (!this.disconnectOnDrop || !this.disconnectOrigin) return
  this.disconnectOnDrop = drawDisconnectCircle(ctx, this.disconnectOrigin, to)
}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts` around lines 173 -
190, The drawConnectionCircle implementation in ToInputFromIoNodeLink duplicates
logic from MovingInputLink.drawConnectionCircle; extract the shared
circle-drawing and distance-check into a single utility (e.g.,
drawDisconnectCircle) that accepts (ctx, origin: Point, to: Readonly<Point>,
radius?) and returns the boolean hit-test, then replace both
ToInputFromIoNodeLink.drawConnectionCircle and
MovingInputLink.drawConnectionCircle to early-return on !this.disconnectOnDrop
or !this.disconnectOrigin and call the new utility to set this.disconnectOnDrop;
reference the existing methods ToInputFromIoNodeLink.drawConnectionCircle and
MovingInputLink.drawConnectionCircle when applying the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts`:
- Around line 1243-1249: The fast branch currently skips any positive
verification because it never waits for the context menu and the final
toBeHidden check is a no-op; after the fast drag (when isFast is true) add an
explicit assertion that the link was removed (e.g. assert the link element/state
is absent or the link count decreased) using the same page helpers you use
elsewhere in this spec rather than relying on the context menu; locate the fast
branch around isFast, comfyPage.contextMenu.litegraphContextMenu and
comfyMouse.click(100, 100) and insert a check (via the test helper that queries
links on comfyPage or the graph/link selector used in this file) to confirm the
target link no longer exists.
- Around line 1261-1270: The test calls comfyPage.vueNodes.enterSubgraph() but
doesn’t adjust the viewport, causing comfyMouse.resizeByDragging() to throw and
the disconnection assertions to be flaky; after calling
comfyPage.vueNodes.enterSubgraph() add fitToViewInstant(comfyPage) to ensure
nodes/slots are in view, then after
performDisconnect(ksampler.getSlot('negative'), true) and
performDisconnect(ksampler.getSlot('latent_image'), false) add assertions using
getInputLinkDetails(ksampler.getSlot(...)) to verify the slot link state changed
as expected (fast vs normal disconnect); keep references to enterSubgraph,
fitToViewInstant, performDisconnect, and getInputLinkDetails when making the
changes.
- Around line 1240-1259: The test currently only checks the context menu
visibility in performDisconnect and must also assert link counts: before calling
performDisconnect capture countBefore via ksampler.getNode() or the node
reference then compute index = node.inputs.findIndex(input => input.name ===
slotName) and access ksampler.getInput(index).getLinkCount(); for the fast-path
call (isFast true) assert that getLinkCount() becomes 0 after performDisconnect,
and for the normal/cancelled path (isFast false) assert the link count remains
equal to countBefore; update performDisconnect usage for 'model' and 'positive'
slots to compute the correct input indices as shown and add these assertions
around the calls using NodeSlotReference.getLinkCount() /
NodeReference.getInput(i).

In `@src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts`:
- Around line 50-54: Set disconnectOnDrop only when there is an existing link:
instead of unconditionally assigning this.disconnectOnDrop = true in the
ToInputFromIoNodeLink constructor, check if existingLink is truthy and then set
this.disconnectOnDrop = true and compute this.disconnectOrigin via
network.getNodeById(existingLink.target_id).getInputPos(existingLink.target_slot);
otherwise set this.disconnectOnDrop = false (or leave undefined/false). This
ensures disconnectOnDrop and disconnectOrigin are consistently initialized based
on existingLink so dropOnNothing and disconnect() logic only run for real
existing links.

---

Nitpick comments:
In `@src/lib/litegraph/src/canvas/LinkConnector.ts`:
- Around line 876-879: Replace the unsafe cast by adding a user-defined type
guard that narrows RenderLink to a disconnect-capable type and use it with
remove(this.renderLinks, ...). Specifically, implement an
isDisconnectableLink(link: RenderLink): link is RenderLink & { disconnect():
void } that checks link.disconnectOnDrop and that 'disconnect' exists on the
object, then call remove(this.renderLinks, isDisconnectableLink).forEach(link =>
link.disconnect()); update usages referencing RenderLink, renderLinks,
disconnectOnDrop and disconnect() accordingly.

In `@src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts`:
- Around line 173-190: The drawConnectionCircle implementation in
ToInputFromIoNodeLink duplicates logic from
MovingInputLink.drawConnectionCircle; extract the shared circle-drawing and
distance-check into a single utility (e.g., drawDisconnectCircle) that accepts
(ctx, origin: Point, to: Readonly<Point>, radius?) and returns the boolean
hit-test, then replace both ToInputFromIoNodeLink.drawConnectionCircle and
MovingInputLink.drawConnectionCircle to early-return on !this.disconnectOnDrop
or !this.disconnectOrigin and call the new utility to set this.disconnectOnDrop;
reference the existing methods ToInputFromIoNodeLink.drawConnectionCircle and
MovingInputLink.drawConnectionCircle when applying the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8819418e-30ae-4f98-9b73-1d786a745447

📥 Commits

Reviewing files that changed from the base of the PR and between b1ecf3b and c55c978.

📒 Files selected for processing (5)
  • browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts
  • src/lib/litegraph/src/LGraphCanvas.ts
  • src/lib/litegraph/src/canvas/LinkConnector.ts
  • src/lib/litegraph/src/canvas/RenderLink.ts
  • src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts

@codecov

codecov Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff             @@
##             main   #12619       +/-   ##
===========================================
- Coverage   75.17%   60.81%   -14.36%     
===========================================
  Files        1557     1446      -111     
  Lines       91065    74490    -16575     
  Branches    24044    20996     -3048     
===========================================
- Hits        68455    45304    -23151     
- Misses      21883    28826     +6943     
+ Partials      727      360      -367     
Flag Coverage Δ
e2e ?
unit 60.81% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1126 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 3, 2026
{ tag: '@vue-nodes' },
async ({ comfyMouse, comfyPage }) => {
async function performDisconnect(slot: Locator, isFast: boolean) {
await comfyMouse.resizeByDragging(slot, { x: isFast ? -25 : -80 })

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resizeByDragging probably needs a rename... dragElementBy?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think worth doing as this reads very weirdly in this context

drawConnectionCircle(ctx: CanvasRenderingContext2D, to: Readonly<Point>) {
if (!this.disconnectOnDrop || !this.disconnectOrigin) return

const [originX, originY] = this.disconnectOrigin

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract a shared function from MovingInputLink drawConnectionCircle and use that in both places

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opted to inline the function instead. It solves the need of finding a place to put the code and lets me move the _getHighlightPosition call inside so that it only runs when required.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts (1)

49-53: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Conditionally initialize disconnectOnDrop based on existingLink presence.

Setting disconnectOnDrop = true unconditionally is semantically incorrect when creating a new link (no existingLink). When no existing link is present, there is nothing to disconnect, so the flag should be false. The disconnect() method guards against this at line 158, so it won't crash, but it causes unnecessary overhead in drop handling and is confusing.

🔧 Proposed fix
-    this.disconnectOnDrop = true
-
-    if (!existingLink) return
+    this.disconnectOnDrop = !!existingLink
+    if (!existingLink) return
+
     const toNode = network.getNodeById(existingLink.target_id)
     this.disconnectOrigin = toNode?.getInputPos(existingLink.target_slot)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts` around lines 49 - 53,
The code currently sets disconnectOnDrop = true unconditionally even when
existingLink is null; change it to only enable disconnection when an
existingLink exists (e.g., set disconnectOnDrop = Boolean(existingLink) or move
the assignment inside the if (existingLink) block), and keep the existing logic
that sets disconnectOrigin via
network.getNodeById(existingLink.target_id)?.getInputPos(existingLink.target_slot)
so disconnect() can use it safely; this removes unnecessary drop-handling
overhead when creating a new link.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/lib/litegraph/src/LGraphCanvas.ts`:
- Around line 6158-6176: The loop early-returns when link.disconnectOnDrop is
false which prevents recomputing it later; change the guard in the render loop
over linkConnector.renderLinks so it only skips when disconnectOrigin is missing
(e.g., replace "if (!link.disconnectOnDrop || !link.disconnectOrigin) return"
with "if (!link.disconnectOrigin) return"), then keep the existing distance
check using this._getHighlightPosition() to set link.disconnectOnDrop =
distSquared < radius ** 2 so the flag can flip true again when the cursor
re-enters.

---

Duplicate comments:
In `@src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts`:
- Around line 49-53: The code currently sets disconnectOnDrop = true
unconditionally even when existingLink is null; change it to only enable
disconnection when an existingLink exists (e.g., set disconnectOnDrop =
Boolean(existingLink) or move the assignment inside the if (existingLink)
block), and keep the existing logic that sets disconnectOrigin via
network.getNodeById(existingLink.target_id)?.getInputPos(existingLink.target_slot)
so disconnect() can use it safely; this removes unnecessary drop-handling
overhead when creating a new link.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 27830792-456d-421d-b81f-270fe40b6d79

📥 Commits

Reviewing files that changed from the base of the PR and between 8e2af47 and 0f4bc5d.

📒 Files selected for processing (9)
  • browser_tests/fixtures/ComfyMouse.ts
  • browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts
  • browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts
  • browser_tests/tests/vueNodes/widgets/legacy.spec.ts
  • src/lib/litegraph/src/LGraphCanvas.ts
  • src/lib/litegraph/src/canvas/LinkConnector.ts
  • src/lib/litegraph/src/canvas/MovingInputLink.ts
  • src/lib/litegraph/src/canvas/RenderLink.ts
  • src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • src/lib/litegraph/src/canvas/RenderLink.ts
  • src/lib/litegraph/src/canvas/LinkConnector.ts
  • browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts

Comment thread src/lib/litegraph/src/LGraphCanvas.ts Resolved
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 4, 2026
@AustinMroz
AustinMroz added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit d7f0d75 Jun 8, 2026
49 checks passed
@AustinMroz
AustinMroz deleted the austin/fast-subgraph-disco-fe-852 branch June 8, 2026 16:24
@coderabbitai coderabbitai Bot mentioned this pull request Jun 17, 2026
DrJKL pushed a commit that referenced this pull request Jul 6, 2026
Because subgraph links don't follow the normal link logic, the fast
disconnection circle would not function when dragging input links that
originate from a subgraph IO node. There's some sad duplication of
state, but I think the flow is marginally cleaner now by not requiring
`instanceof` checks.

The test added by this PR also verifies behavior for the node-to-node
case.
dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
Because subgraph links don't follow the normal link logic, the fast
disconnection circle would not function when dragging input links that
originate from a subgraph IO node. There's some sad duplication of
state, but I think the flow is marginally cleaner now by not requiring
`instanceof` checks.

The test added by this PR also verifies behavior for the node-to-node
case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants