Repository navigation
Compact vue nodes - #12886
Compact vue nodes#12886
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR refreshes Vue node UI styling by adding a ChangesNode UI Visual Refresh and Settings Cleanup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-12886.vercel.app This commit: https://website-frontend-kbw917p63-comfyui.vercel.app Last updated: 2026-07-02T22:23:01Z for |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/renderer/extensions/vueNodes/components/NodeFooter.test.ts (1)
183-210:⚠️ Potential issue | 🟠 Major | ⚡ Quick winReplace utility-class assertions with behavioral assertions.
This block asserts Tailwind rounding class names (
rounded-br-xl,rounded-b-xl), which makes the tests implementation-style dependent rather than behavior dependent. That conflicts with the test guideline and creates brittle failures on cosmetic refactors.Suggested direction
-describe('shape-based radius classes (getBottomRadius)', () => { - it('BOX shape renders no rounded-b* class on the single-tab footer', () => { - renderFooter({ isSubgraph: true, shape: RenderShape.BOX }) - expect(allButtonClasses()).not.toMatch(/rounded-b/) - }) - - it('CARD shape emits rounded-br variant on the single-tab footer', () => { - renderFooter({ isSubgraph: true, shape: RenderShape.CARD }) - const classes = allButtonClasses() - expect(classes).toMatch(/rounded-br-xl/) - expect(classes).not.toMatch(/\srounded-b-\w/) - }) - - it('default shape emits rounded-b variant on the single-tab footer', () => { - renderFooter({ isSubgraph: true }) - expect(allButtonClasses()).toMatch(/rounded-b-xl/) - }) - - it('enter tab uses right-only rounding in dual-tab mode (Case 1)', () => { - renderFooter({ - isSubgraph: true, - hasAnyError: true, - showErrorsTabEnabled: true - }) - const enterBtn = screen.getByTestId('subgraph-enter-button') - expect(enterBtn.className).toMatch(/rounded-br-xl/) - }) -}) +// Keep behavior-focused coverage in existing rendering + emits suites.As per coding guidelines: “Do not write tests dependent on non-behavioral features like utility classes or styles” and “Be parsimonious in testing; do not write redundant tests.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/renderer/extensions/vueNodes/components/NodeFooter.test.ts` around lines 183 - 210, The tests in the 'shape-based radius classes (getBottomRadius)' describe block are asserting specific Tailwind utility class names (rounded-br-xl, rounded-b-xl) which are implementation details that make tests brittle to CSS refactoring. Replace the regex assertions that match specific Tailwind classes with behavioral assertions that verify the actual visual outcome—such as checking that computed styles have the correct border-radius values applied, or that the rendered layout behaves as expected based on the shape prop, rather than asserting the presence of specific CSS class names.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/locales/en/main.json`:
- Line 91: The i18n locale change in src/locales/en/main.json line 91 updates
the enterSubgraph translation from "Enter Subgraph" to "Enter subgraph" with
lowercase 's'. Update the corresponding i18n test stubs in two test files to
match this capitalization change: in
src/renderer/extensions/vueNodes/components/NodeFooter.test.ts line 24, update
the enterSubgraph stub value to 'Enter subgraph'; similarly, in
src/components/rightSidePanel/errors/ErrorNodeCard.test.ts line 80, update the
enterSubgraph stub value to 'Enter subgraph' to keep the test mocks consistent
with the actual locale strings.
In `@src/renderer/extensions/vueNodes/components/LGraphNode.vue`:
- Around line 333-336: The `isLightTheme` computed property uses the double
negation operator `!!` on
`colorPaletteStore.completedActivePalette.light_theme`, which coerces undefined
(when the optional field is absent) to false, forcing dark shadow rendering.
Replace the boolean coercion with logic that checks if `light_theme` is
explicitly defined and provides a meaningful fallback for when it is undefined,
preserving the current theme behavior instead of defaulting to false.
---
Outside diff comments:
In `@src/renderer/extensions/vueNodes/components/NodeFooter.test.ts`:
- Around line 183-210: The tests in the 'shape-based radius classes
(getBottomRadius)' describe block are asserting specific Tailwind utility class
names (rounded-br-xl, rounded-b-xl) which are implementation details that make
tests brittle to CSS refactoring. Replace the regex assertions that match
specific Tailwind classes with behavioral assertions that verify the actual
visual outcome—such as checking that computed styles have the correct
border-radius values applied, or that the rendered layout behaves as expected
based on the shape prop, rather than asserting the presence of specific CSS
class names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a587a0f5-e753-420c-a0cb-e8afdabc7baa
📒 Files selected for processing (19)
packages/design-system/src/css/style.csssrc/components/builder/AppModeWidgetList.vuesrc/components/common/ScrubableNumberInput.vuesrc/components/rightSidePanel/parameters/SectionWidgets.vuesrc/locales/en/main.jsonsrc/renderer/extensions/vueNodes/components/InputSlot.vuesrc/renderer/extensions/vueNodes/components/LGraphNode.vuesrc/renderer/extensions/vueNodes/components/NodeFooter.test.tssrc/renderer/extensions/vueNodes/components/NodeFooter.vuesrc/renderer/extensions/vueNodes/components/NodeHeader.vuesrc/renderer/extensions/vueNodes/components/OutputSlot.vuesrc/renderer/extensions/vueNodes/components/SlotConnectionDot.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetWithControl.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownInput.vuesrc/renderer/extensions/vueNodes/widgets/components/layout/WidgetLayoutField.vuesrc/renderer/extensions/vueNodes/widgets/components/layout/index.tssrc/types/widgetTypes.ts
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #12886 +/- ##
=======================================
Coverage 77.79% 77.80%
=======================================
Files 1641 1641
Lines 95950 95881 -69
Branches 32820 32764 -56
=======================================
- Hits 74648 74599 -49
+ Misses 20588 20575 -13
+ Partials 714 707 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- Drop body font from text-sm to text-xs; header chevron and pin to 16px - Header padding 8/12/8 → 4 all sides (height 40 → 24 px) - Header text color matches widget labels (text-node-component-slot-text) - Footer height 36 → 44 px (visible 16 → 24 px); single 12 px corner radius - Footer subgraph/advanced text uses grey token; error stays white - Widget row 28 → 24 px; stepper buttons 32 → 24 px square - Slot dot 12 → 8 px; socket row 24 → 20 px; slot row padding 24 → 8 px - Label column 80 px, label↔input gap 8 px - Select trigger p-0 + pl-7 to align values with number widget x-position - Drop-shadow on the node root for combined body+footer silhouette - Softer header surface tokens for default themes - Drop unused body-border overlay element
The previous pl-7 (28 px) was designed to align dropdown values with number input values across a widget row — number values start at x = 28 px from the widget left (24 px stepper button + 4 px padding), so dropdowns padded to the same x position read as a vertical column in mixed-widget nodes like KSampler. For nodes that have no number widgets (e.g. Video Stitch, with only a dropdown and a toggle), the 28 px padding looked like wasted space: no values to align with, just a visible empty column on the left of every dropdown. The proper fix would be context-aware padding: the parent node detects whether any sibling widget is a stepper-input, and propagates that down. Tracked separately. For now, revert to the visually consistent 8 px (gap-2 rhythm used elsewhere on the node — header content gap, widget label↔input gap, etc.). This trades the cross-row column alignment in mixed-widget nodes for a cleaner standalone appearance.
This cleans up some ugly app mode hacks, and allows for a third intermediary height
697f1c7 to
3b3e93c
Compare
|
Updating Playwright Expectations |
This is quite a bit uglier than I would like, but alas
🎭 Playwright: ✅ 1689 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 7.77 MB gzip 🟢 -5 BDetailsSummary
Category Glance App Entry Points — 47.4 kB (baseline 47.4 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • 🟢 -887 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 98 kB (baseline 98 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 10 added / 10 removed / 2 unchanged Panels & Settings — 546 kB (baseline 547 kB) • 🟢 -331 BConfiguration panels, inspectors, and settings screens
Status: 13 added / 13 removed / 14 unchanged User & Accounts — 26.9 kB (baseline 26.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.5 kB (baseline 57.2 kB) • 🔴 +241 BReusable component library chunks
Status: 6 added / 6 removed / 7 unchanged Data & Services — 270 kB (baseline 270 kB) • 🟢 -50 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.37 MB (baseline 3.37 MB) • 🟢 -4 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 14 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.7 MB (baseline 11.7 MB) • 🔴 +583 BBundles that do not match a named category
Status: 83 added / 83 removed / 82 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-02T22:33:06.688Z",
"gitSha": "01947e9e23848ccdea9ab57ccba83222c4fc1bf0",
"branch": "austin/vue-size-fe-961",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2072.0030000000233,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.92799999999994,
"heapDeltaBytes": -7752364,
"heapUsedBytes": 45195796,
"domNodes": -292,
"jsHeapTotalBytes": 16379904,
"scriptDurationMs": 23.448999999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2006.623999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.607000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.471,
"heapDeltaBytes": -1902552,
"heapUsedBytes": 62264712,
"domNodes": 16,
"jsHeapTotalBytes": 23625728,
"scriptDurationMs": 17.417999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.4899999999843,
"styleRecalcs": 75,
"styleRecalcDurationMs": 44.522999999999996,
"layouts": 12,
"layoutDurationMs": 3.5449999999999995,
"taskDurationMs": 852.478,
"heapDeltaBytes": -12692120,
"heapUsedBytes": 56919172,
"domNodes": -242,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 129.89800000000002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.512000000031,
"styleRecalcs": 73,
"styleRecalcDurationMs": 38.014,
"layouts": 12,
"layoutDurationMs": 3.5540000000000003,
"taskDurationMs": 778.748,
"heapDeltaBytes": -7743704,
"heapUsedBytes": 53779880,
"domNodes": 56,
"jsHeapTotalBytes": 24936448,
"scriptDurationMs": 126.18700000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2209999999864,
"styleRecalcs": 33,
"styleRecalcDurationMs": 20.268,
"layouts": 6,
"layoutDurationMs": 0.6979999999999998,
"taskDurationMs": 358.632,
"heapDeltaBytes": -3821420,
"heapUsedBytes": 65463684,
"domNodes": -228,
"jsHeapTotalBytes": 13004800,
"scriptDurationMs": 19.279,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.0090000000155,
"styleRecalcs": 30,
"styleRecalcDurationMs": 24.349999999999998,
"layouts": 6,
"layoutDurationMs": 0.5739999999999998,
"taskDurationMs": 376.059,
"heapDeltaBytes": -3706480,
"heapUsedBytes": 65733884,
"domNodes": -226,
"jsHeapTotalBytes": 12742656,
"scriptDurationMs": 19.518,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 682.3650000000043,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.446,
"heapDeltaBytes": 4424868,
"heapUsedBytes": 56382724,
"domNodes": -290,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 64.36999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 622.951999999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.45899999999995,
"heapDeltaBytes": 2794852,
"heapUsedBytes": 72121312,
"domNodes": -283,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 61.46099999999999,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.8609999999971,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.168999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.844,
"heapDeltaBytes": -1143076,
"heapUsedBytes": 58500232,
"domNodes": -277,
"jsHeapTotalBytes": -557056,
"scriptDurationMs": 111.735,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.0800000000086,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.365999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.0269999999999,
"heapDeltaBytes": -25463312,
"heapUsedBytes": 58580812,
"domNodes": -269,
"jsHeapTotalBytes": 2445312,
"scriptDurationMs": 92.294,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2128.6799999999744,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.648999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1036.866,
"heapDeltaBytes": 10531636,
"heapUsedBytes": 84289324,
"domNodes": 16,
"jsHeapTotalBytes": 10543104,
"scriptDurationMs": 392.87,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2231.200999999942,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.176000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1200.6729999999998,
"heapDeltaBytes": 55115820,
"heapUsedBytes": 112653380,
"domNodes": 16,
"jsHeapTotalBytes": 57409536,
"scriptDurationMs": 441.48900000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3099.8749999999973,
"styleRecalcs": 62,
"styleRecalcDurationMs": 14.728000000000002,
"layouts": 60,
"layoutDurationMs": 7.2589999999999995,
"taskDurationMs": 1246.5049999999999,
"heapDeltaBytes": 11644476,
"heapUsedBytes": 66689856,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 480.069,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3152.261000000067,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.458000000000002,
"layouts": 60,
"layoutDurationMs": 7.442000000000001,
"taskDurationMs": 1306.121,
"heapDeltaBytes": 13452192,
"heapUsedBytes": 76130636,
"domNodes": -267,
"jsHeapTotalBytes": 5529600,
"scriptDurationMs": 477.21899999999994,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.586999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.486,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.4499999999999,
"heapDeltaBytes": -2585588,
"heapUsedBytes": 58858600,
"domNodes": -273,
"jsHeapTotalBytes": -1605632,
"scriptDurationMs": 89.364,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2021.708999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.166,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.68899999999996,
"heapDeltaBytes": -9212304,
"heapUsedBytes": 64633588,
"domNodes": 22,
"jsHeapTotalBytes": 8269824,
"scriptDurationMs": 90.345,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.4300000000358,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.698,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.72700000000003,
"heapDeltaBytes": -1990872,
"heapUsedBytes": 50974596,
"domNodes": -273,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 119.26299999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.8989999999358,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.648,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.58799999999997,
"heapDeltaBytes": 8968120,
"heapUsedBytes": 70034792,
"domNodes": 18,
"jsHeapTotalBytes": 21757952,
"scriptDurationMs": 120.536,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.227000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.957999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.481,
"heapDeltaBytes": 1780736,
"heapUsedBytes": 66503440,
"domNodes": 18,
"jsHeapTotalBytes": 22315008,
"scriptDurationMs": 20.169,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.8229999999971,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.546999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.512,
"heapDeltaBytes": -2197044,
"heapUsedBytes": 56887152,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 13.470999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.7320000000173,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.713,
"layouts": 16,
"layoutDurationMs": 4.573,
"taskDurationMs": 776.272,
"heapDeltaBytes": -16763188,
"heapUsedBytes": 52749176,
"domNodes": -232,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 98.611,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1754.5309999999859,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.114,
"layouts": 16,
"layoutDurationMs": 3.772,
"taskDurationMs": 725.7379999999999,
"heapDeltaBytes": 2955896,
"heapUsedBytes": 55008740,
"domNodes": -226,
"jsHeapTotalBytes": 17690624,
"scriptDurationMs": 92.862,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1015.5730000000176,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.821000000000005,
"layouts": 15,
"layoutDurationMs": 15.879999999999999,
"taskDurationMs": 780.9499999999998,
"heapDeltaBytes": 2497412,
"heapUsedBytes": 79234392,
"domNodes": 13673,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 30.360000000000014,
"eventListeners": 2533,
"totalBlockingTimeMs": 164,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8148.537999999973,
"styleRecalcs": 250,
"styleRecalcDurationMs": 53.96800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3665.975,
"heapDeltaBytes": -978708,
"heapUsedBytes": 71092024,
"domNodes": 18,
"jsHeapTotalBytes": 17358848,
"scriptDurationMs": 1232.803,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8131.900999999971,
"styleRecalcs": 251,
"styleRecalcDurationMs": 54.208000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3693.7209999999995,
"heapDeltaBytes": -719556,
"heapUsedBytes": 66116704,
"domNodes": -269,
"jsHeapTotalBytes": 991232,
"scriptDurationMs": 1240.2569999999998,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12341.154000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12322.449000000002,
"heapDeltaBytes": -33273992,
"heapUsedBytes": 169041812,
"domNodes": -3302,
"jsHeapTotalBytes": 19107840,
"scriptDurationMs": 536.556,
"eventListeners": -16374,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12331.764999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12319.702000000001,
"heapDeltaBytes": -23755880,
"heapUsedBytes": 166842792,
"domNodes": -3300,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 536.168,
"eventListeners": -16370,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14952.705999999978,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.727999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14933.127,
"heapDeltaBytes": -55181204,
"heapUsedBytes": 157500628,
"domNodes": -3300,
"jsHeapTotalBytes": 3117056,
"scriptDurationMs": 889.111,
"eventListeners": -16376,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15246.226999999977,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.58399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15221.330000000002,
"heapDeltaBytes": -33707880,
"heapUsedBytes": 166295840,
"domNodes": -3300,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 819.109,
"eventListeners": -16370,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 478.8249999999721,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.142000000000003,
"layouts": 6,
"layoutDurationMs": 1.745,
"taskDurationMs": 230.94799999999998,
"heapDeltaBytes": -21851908,
"heapUsedBytes": 48722864,
"domNodes": -164,
"jsHeapTotalBytes": 5402624,
"scriptDurationMs": 22.391000000000002,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 479.46200000001227,
"styleRecalcs": 14,
"styleRecalcDurationMs": 23.786999999999995,
"layouts": 5,
"layoutDurationMs": 1.2840000000000003,
"taskDurationMs": 154.571,
"heapDeltaBytes": -2521160,
"heapUsedBytes": 50970640,
"domNodes": -144,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 17.175000000000004,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🎨 Storybook: 🚧 Building... |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/vueNodes/interactions/node/move.spec.ts`:
- Around line 400-405: The select-all drag test in move.spec.ts only verifies
reroute and group positions, so it can miss a regression where multi-selected
nodes do not move. Update the test around the ksampler drag flow to also capture
and assert the position of the second selected node changes after
comfyMouse.dragElementBy, using the existing node-position helpers used
elsewhere in this spec. Keep the current reroute/group checks, but add a
movement assertion for the second selected node so the drag behavior is
validated end-to-end.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0bce13af-0949-4e12-846a-2671e27fa215
⛔ Files ignored due to path filters (24)
browser_tests/tests/mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/saveImageAndWebp.spec.ts-snapshots/save-image-and-webm-preview-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/subgraph/subgraphSlots.spec.ts-snapshots/vue-io-highlight-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-fit-to-contents-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-dragging-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-ctrl-alt-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-reuses-origin-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-input-drag-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-output-shift-drag-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-shift-output-multi-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-slot-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/error.spec.ts-snapshots/vue-node-required-input-missing-slot-error-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/rerouteNodeSize.spec.ts-snapshots/vue-reroute-node-compact-chromium-linux.pngis excluded by!**/*.png
📒 Files selected for processing (6)
browser_tests/tests/maskEditor.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tspackages/design-system/src/css/style.csssrc/components/builder/AppModeWidgetList.vuesrc/components/rightSidePanel/parameters/SectionWidgets.vue
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/vueNodes/interactions/node/move.spec.ts`:
- Around line 400-405: The select-all drag test in move.spec.ts only verifies
reroute and group positions, so it can miss a regression where multi-selected
nodes do not move. Update the test around the ksampler drag flow to also capture
and assert the position of the second selected node changes after
comfyMouse.dragElementBy, using the existing node-position helpers used
elsewhere in this spec. Keep the current reroute/group checks, but add a
movement assertion for the second selected node so the drag behavior is
validated end-to-end.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0bce13af-0949-4e12-846a-2671e27fa215
⛔ Files ignored due to path filters (24)
browser_tests/tests/mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/saveImageAndWebp.spec.ts-snapshots/save-image-and-webm-preview-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/subgraph/subgraphSlots.spec.ts-snapshots/vue-io-highlight-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-fit-to-contents-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-dragging-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-ctrl-alt-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-reuses-origin-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-input-drag-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-output-shift-drag-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-shift-output-multi-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-slot-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/error.spec.ts-snapshots/vue-node-required-input-missing-slot-error-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/rerouteNodeSize.spec.ts-snapshots/vue-reroute-node-compact-chromium-linux.pngis excluded by!**/*.png
📒 Files selected for processing (6)
browser_tests/tests/maskEditor.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tspackages/design-system/src/css/style.csssrc/components/builder/AppModeWidgetList.vuesrc/components/rightSidePanel/parameters/SectionWidgets.vue
🛑 Comments failed to post (1)
browser_tests/tests/vueNodes/interactions/node/move.spec.ts (1)
400-405: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Assert the second selected node moved, too.
This regression only checks the reroute and group after the select-all drag. If multi-select node movement regresses while auxiliary items still move, the test still passes.
Suggested fix
const getReroutePos = () => comfyPage.page.evaluate(() => [...graph!.reroutes.values()][0]) const getGroupPos = () => comfyPage.page.evaluate(() => graph!.groups[0].pos) + const initialLoaderLeft = await loader.pollLeftEdge() + const initialLoaderTop = await loader.pollTopEdge() const initialReroutePos = await getReroutePos() const initialGroupPos = await getGroupPos() await comfyMouse.dragElementBy(ksampler.title, { x: 100 }) + await expect.poll(loader.pollLeftEdge).not.toBe(initialLoaderLeft) + await expect.poll(loader.pollTopEdge).not.toBe(initialLoaderTop) await expect.poll(getReroutePos).not.toEqual(initialReroutePos) await expect.poll(getGroupPos).not.toEqual(initialGroupPos)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.const getReroutePos = () => comfyPage.page.evaluate(() => [...graph!.reroutes.values()][0]) const getGroupPos = () => comfyPage.page.evaluate(() => graph!.groups[0].pos) const initialLoaderLeft = await loader.pollLeftEdge() const initialLoaderTop = await loader.pollTopEdge() const initialReroutePos = await getReroutePos() const initialGroupPos = await getGroupPos() await comfyMouse.dragElementBy(ksampler.title, { x: 100 }) await expect.poll(loader.pollLeftEdge).not.toBe(initialLoaderLeft) await expect.poll(loader.pollTopEdge).not.toBe(initialLoaderTop) await expect.poll(getReroutePos).not.toEqual(initialReroutePos) await expect.poll(getGroupPos).not.toEqual(initialGroupPos)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@browser_tests/tests/vueNodes/interactions/node/move.spec.ts` around lines 400 - 405, The select-all drag test in move.spec.ts only verifies reroute and group positions, so it can miss a regression where multi-selected nodes do not move. Update the test around the ksampler drag flow to also capture and assert the position of the second selected node changes after comfyMouse.dragElementBy, using the existing node-position helpers used elsewhere in this spec. Keep the current reroute/group checks, but add a movement assertion for the second selected node so the drag behavior is validated end-to-end.
Bot has failed to post suggestions in a way that can be dismissed. The suggestion that the fixed test be extended is brazenly out of scope. The intent of this PR is not to cleanup tests.
| return 'rounded-none' | ||
| case RenderShape.CARD: | ||
| return 'rounded-tl-2xl rounded-br-2xl rounded-tr-none rounded-bl-none' | ||
| return 'rounded-tl-xl rounded-br-2xl rounded-tr-none rounded-bl-none' |
There was a problem hiding this comment.
Severity: Minor
What: This collapsed-CARD branch still returns rounded-br-2xl, while the rest of the sweep moved CARD corners to xl (the node body is rounded-br-xl).
Why this is an issue: Looks like a missed find/replace. It's a visual no-op today since the collapsed header doesn't paint that corner, but it'll render a mismatched bottom-right vs the body the moment it does.
Proposed Fix: Change rounded-br-2xl to rounded-br-xl.
There was a problem hiding this comment.
From testing, this is visible when nodes are collapsed. Thanks.
| </button> | ||
| </ComboboxTrigger> | ||
| <slot /> | ||
| <ComboboxTrigger as-child> |
There was a problem hiding this comment.
Severity: Minor (a11y)
What: There are two ComboboxTriggers here. reka registers the last-mounted one as triggerElement (each overwrites it in onMounted) and calls triggerElement.focus() when a filterable select closes, so focus returns to this aria-hidden chevron instead of the labeled control.
Why this is an issue: Returning focus to an aria-hidden / tabindex="-1" element is a focus-management bug. After closing the dropdown the user lands on an element that's hidden from assistive tech.
Proposed Fix: Make the chevron a plain <button @click> that toggles the dropdown open, rather than a second ComboboxTrigger, so the labeled control stays the focus target.
| 'Comfy.VueNodes.Enabled': z.boolean(), | ||
| 'Comfy.AppBuilder.VueNodeSwitchDismissed': z.boolean(), | ||
| 'Comfy.VueNodes.AutoScaleLayout': z.boolean(), | ||
| 'Comfy.Assets.UseAssetAPI': z.boolean(), |
There was a problem hiding this comment.
Severity: Minor
What: This removes the setting from the schema, but browser_tests/fixtures/ComfyPage.ts:540 still seeds 'Comfy.VueNodes.AutoScaleLayout': false.
Why this is an issue: Dead reference to a setting that no longer exists. It doesn't break (the fixture arg is Record<string, unknown>, so no type error), but it's misleading leftover state.
Proposed Fix: Delete the seed line in ComfyPage.ts:540. The non-EN locales/*/settings.json copies can be left as-is; i18n sync prunes them.
CodeJuggernaut
left a comment
There was a problem hiding this comment.
All changes look good, marking approved
Updates vue nodes to be compact.
This PR does modify the sizing of the asset dropdown (as used on nodes like "Load Image"). There are outstanding concerns about the visibility of the upload button and ongoing work to address this.
Subsumes #12678