Skip to content

[backport core/1.45] Fix ghost links on IO remove slot - #12522

Merged
AustinMroz merged 1 commit into
core/1.45from
backport-12473-to-core-1.45
May 29, 2026
Merged

AustinMroz merged 1 commit into
core/1.45from
backport-12473-to-core-1.45

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #12473 to core/1.45

Automatically created by backport workflow.

Context menu operations on subgraph IO slots only set the foreground
canvas as dirty, so links would visually persist until a different
operation caused a background draw.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label May 29, 2026
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 29, 2026
@github-actions

github-actions Bot commented May 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1638 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1619 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@github-actions

github-actions Bot commented May 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 05/29/2026, 05:17:16 PM UTC

Links

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##           core/1.45   #12522   +/-   ##
==========================================
  Coverage      60.17%   60.17%           
==========================================
  Files           1416     1416           
  Lines          72544    72544           
  Branches       20188    20188           
==========================================
  Hits           43650    43650           
  Misses         28420    28420           
  Partials         474      474           
Flag Coverage Δ
unit 60.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinMroz
AustinMroz merged commit 962e70d into core/1.45 May 29, 2026
62 checks passed
@AustinMroz
AustinMroz deleted the backport-12473-to-core-1.45 branch May 29, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants