Repository navigation
Fix ghost links on IO remove slot - #12473
Conversation
📝 WalkthroughWalkthroughUpdates one call in SubgraphIONodeBase to pass a second boolean to setDirtyCanvas. Separately, Playwright subgraph slot/link interaction tests are modified to precompute/reuse a clipped screenshot region and to add a disconnect/remove-slot verification that compares clipped screenshots. ChangesSubgraph canvas and tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1654 passed, 0 failed · 2 flaky📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12473 +/- ##
===========================================
- Coverage 74.69% 60.37% -14.32%
===========================================
Files 1528 1426 -102
Lines 92012 73911 -18101
Branches 26339 20460 -5879
===========================================
- Hits 68725 44623 -24102
- Misses 22413 28788 +6375
+ Partials 874 500 -374
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/subgraph/subgraphSlots.spec.ts`:
- Around line 711-715: The byte-exact screenshot assertion is flaky because
setDirtyCanvas(true, true) repaints the background asynchronously; replace the
one-shot expect(postScreenshot).toStrictEqual(twoLinkScreenshot) with a
retrying/polled comparison that repeatedly captures comfyPage.page.screenshot({
clip }) (after comfyPage.canvas.hover({ position: await seedIOSlot.getPosition()
})) until the captured buffer equals twoLinkScreenshot or a timeout elapses.
Locate the check around comfyPage.canvas.hover and seedIOSlot.getPosition and
implement the retry using Playwright-friendly polling (e.g., expect.poll or a
short-loop with a reasonable timeout) so the test waits for the async canvas
redraw instead of doing a single byte-exact match.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5f95dc95-6fb4-40ed-9cbb-96cc403de3cb
📒 Files selected for processing (1)
browser_tests/tests/subgraph/subgraphSlots.spec.ts
|
@AustinMroz Successfully backported to #12522 |
|
@AustinMroz Successfully backported to #12523 |
Backport of #12473 to `cloud/1.45` Automatically created by backport workflow. Co-authored-by: AustinMroz <austin@comfy.org>
Backport of #12473 to `core/1.45` Automatically created by backport workflow. Co-authored-by: AustinMroz <austin@comfy.org>
Context menu operations on subgraph IO slots only set the foreground canvas as dirty, so links would visually persist until a different operation caused a background draw.
Context menu operations on subgraph IO slots only set the foreground canvas as dirty, so links would visually persist until a different operation caused a background draw.
Context menu operations on subgraph IO slots only set the foreground canvas as dirty, so links would visually persist until a different operation caused a background draw.