Repository navigation
refactor(litegraph): deprecate LiteGraph.ON_EVENT (release N) - #12231
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 39 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDeprecation of ChangesON_EVENT Deprecation for v2 ABI Compatibility
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Title checkExplanation The title 'refactor(litegraph): deprecate LiteGraph.ON_EVENT (release N)' clearly summarizes the primary change: deprecating LiteGraph.ON_EVENT in the N release cycle as part of a deprecate-then-delete plan. Full details: Linked Issues checkExplanation The PR successfully implements all release-N action items from issue Full details: Out of Scope Changes checkExplanation All changes are within scope of the release-N deprecation cycle defined in Full details: Description checkExplanation The pull request description is complete and relevant. It explains the release-N deprecation scope, implementation changes, numeric slot 1 compatibility, testing evidence, sequencing, and known repository limitations. It does not use every template heading verbatim, but the required information is covered by equivalent sections. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 5.35 MB gzip 🔴 +235 BDetailsSummary
Category Glance App Entry Points — 31.8 kB (baseline 31.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.6 kB (baseline 82.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 526 kB (baseline 526 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 14 unchanged User & Accounts — 17.7 kB (baseline 17.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 57.9 kB (baseline 57.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.16 MB (baseline 3.16 MB) • 🔴 +360 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 369 kB (baseline 369 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 19 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 9.13 MB (baseline 9.13 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 85 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-13T23:33:59.143Z",
"gitSha": "194dab444c63b15460f27ae71cf2087363dc8216",
"branch": "litegraph/deprecate-on-event",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2079.51700000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.657999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.782,
"heapDeltaBytes": 236984,
"heapUsedBytes": 68959752,
"domNodes": -259,
"jsHeapTotalBytes": 20926464,
"scriptDurationMs": 26.268,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2002.4660000000267,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.625,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.254,
"heapDeltaBytes": 24759444,
"heapUsedBytes": 78347116,
"domNodes": 18,
"jsHeapTotalBytes": 50331648,
"scriptDurationMs": 17.419999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1869.3450000000098,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.414,
"layouts": 12,
"layoutDurationMs": 3.486,
"taskDurationMs": 787.161,
"heapDeltaBytes": -2116820,
"heapUsedBytes": 46514564,
"domNodes": -264,
"jsHeapTotalBytes": 14282752,
"scriptDurationMs": 127.963,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1870.9820000000263,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.936,
"layouts": 12,
"layoutDurationMs": 3.6419999999999995,
"taskDurationMs": 825.725,
"heapDeltaBytes": 16967416,
"heapUsedBytes": 66153904,
"domNodes": -265,
"jsHeapTotalBytes": 18477056,
"scriptDurationMs": 131.043,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.713000000023,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.97,
"layouts": 6,
"layoutDurationMs": 0.637,
"taskDurationMs": 311.937,
"heapDeltaBytes": 23117704,
"heapUsedBytes": 73242904,
"domNodes": 73,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 18.382,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1762.8490000000738,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.583000000000002,
"layouts": 6,
"layoutDurationMs": 0.565,
"taskDurationMs": 420.17499999999995,
"heapDeltaBytes": -3614296,
"heapUsedBytes": 45623952,
"domNodes": -215,
"jsHeapTotalBytes": 19525632,
"scriptDurationMs": 27.55400000000001,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 539.5290000000159,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.875,
"heapDeltaBytes": 8841760,
"heapUsedBytes": 58672512,
"domNodes": 18,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 58.736000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 540.2440000000297,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.129000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.75,
"heapDeltaBytes": 14916420,
"heapUsedBytes": 64146544,
"domNodes": 18,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 58.397000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2036.1659999999802,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.193,
"heapDeltaBytes": 4402312,
"heapUsedBytes": 61768252,
"domNodes": -262,
"jsHeapTotalBytes": 5529600,
"scriptDurationMs": 115.359,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.33900000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.423,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.1750000000001,
"heapDeltaBytes": 2186192,
"heapUsedBytes": 60863632,
"domNodes": -266,
"jsHeapTotalBytes": 5005312,
"scriptDurationMs": 112.49599999999998,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2231.5280000000257,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.751999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1216.0220000000002,
"heapDeltaBytes": 41141908,
"heapUsedBytes": 101352868,
"domNodes": -267,
"jsHeapTotalBytes": 41181184,
"scriptDurationMs": 402.586,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2155.1729999999907,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.792,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1167.513,
"heapDeltaBytes": -476444,
"heapUsedBytes": 59474416,
"domNodes": -268,
"jsHeapTotalBytes": 1540096,
"scriptDurationMs": 406.314,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3106.630999999993,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.893000000000004,
"layouts": 60,
"layoutDurationMs": 7.3020000000000005,
"taskDurationMs": 1275.791,
"heapDeltaBytes": 13882648,
"heapUsedBytes": 66335728,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 494.184,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3132.353999999964,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.038000000000004,
"layouts": 60,
"layoutDurationMs": 7.911,
"taskDurationMs": 1385.19,
"heapDeltaBytes": -7944252,
"heapUsedBytes": 59338660,
"domNodes": 12,
"jsHeapTotalBytes": 14561280,
"scriptDurationMs": 519.749,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.5269999999728,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.885000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.034,
"heapDeltaBytes": 6079408,
"heapUsedBytes": 67168644,
"domNodes": -266,
"jsHeapTotalBytes": 548864,
"scriptDurationMs": 90.104,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2072.1110000000635,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.017999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 711.657,
"heapDeltaBytes": 37604088,
"heapUsedBytes": 99348268,
"domNodes": -264,
"jsHeapTotalBytes": 33054720,
"scriptDurationMs": 113.58399999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.2310000000348,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.947,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.481,
"heapDeltaBytes": 15150340,
"heapUsedBytes": 64426752,
"domNodes": 18,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 118.94000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.5199999999786,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.721,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.274,
"heapDeltaBytes": 15603080,
"heapUsedBytes": 64659608,
"domNodes": 20,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 124.26199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2031.8260000000237,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.750000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.28099999999995,
"heapDeltaBytes": -6583768,
"heapUsedBytes": 62299496,
"domNodes": -235,
"jsHeapTotalBytes": 14897152,
"scriptDurationMs": 19.109,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.9539999999406,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.964000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.88100000000003,
"heapDeltaBytes": 38573508,
"heapUsedBytes": 91747084,
"domNodes": 16,
"jsHeapTotalBytes": 45613056,
"scriptDurationMs": 14.627999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1783.2800000000475,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.805,
"layouts": 16,
"layoutDurationMs": 4.4670000000000005,
"taskDurationMs": 828.941,
"heapDeltaBytes": 10020836,
"heapUsedBytes": 60537448,
"domNodes": -263,
"jsHeapTotalBytes": 21975040,
"scriptDurationMs": 103.67000000000002,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.1510000000053,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.281,
"layouts": 16,
"layoutDurationMs": 4.374999999999999,
"taskDurationMs": 716.9760000000001,
"heapDeltaBytes": -3776628,
"heapUsedBytes": 45510256,
"domNodes": -261,
"jsHeapTotalBytes": 15593472,
"scriptDurationMs": 96.76799999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1050.2880000000232,
"styleRecalcs": 16,
"styleRecalcDurationMs": 26.173000000000002,
"layouts": 4,
"layoutDurationMs": 11.792,
"taskDurationMs": 820.2650000000002,
"heapDeltaBytes": 81832008,
"heapUsedBytes": 222630708,
"domNodes": 13513,
"jsHeapTotalBytes": 80740352,
"scriptDurationMs": 28.919,
"eventListeners": 2529,
"totalBlockingTimeMs": 158,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8466.357000000016,
"styleRecalcs": 250,
"styleRecalcDurationMs": 51.861999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4057.456,
"heapDeltaBytes": 20819616,
"heapUsedBytes": 90312316,
"domNodes": -257,
"jsHeapTotalBytes": 43393024,
"scriptDurationMs": 1258.6580000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8523.265999999921,
"styleRecalcs": 252,
"styleRecalcDurationMs": 55,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4468.09,
"heapDeltaBytes": 126613252,
"heapUsedBytes": 190325280,
"domNodes": -69,
"jsHeapTotalBytes": 129384448,
"scriptDurationMs": 1369.9099999999999,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15020.244000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14990.961,
"heapDeltaBytes": 19469560,
"heapUsedBytes": 283065852,
"domNodes": -8329,
"jsHeapTotalBytes": 20897792,
"scriptDurationMs": 614.277,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12479.449000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12464.925000000001,
"heapDeltaBytes": -23447948,
"heapUsedBytes": 168766652,
"domNodes": -8331,
"jsHeapTotalBytes": 20246528,
"scriptDurationMs": 607.7819999999999,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16990.925000000003,
"styleRecalcs": 100,
"styleRecalcDurationMs": 17.961000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16967.247,
"heapDeltaBytes": -6168980,
"heapUsedBytes": 270032992,
"domNodes": -8335,
"jsHeapTotalBytes": 1286144,
"scriptDurationMs": 990.0240000000001,
"eventListeners": -16490,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14894.530999999915,
"styleRecalcs": 72,
"styleRecalcDurationMs": 20.840999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14871.192999999997,
"heapDeltaBytes": -40381808,
"heapUsedBytes": 165765908,
"domNodes": -8331,
"jsHeapTotalBytes": -4284416,
"scriptDurationMs": 863.2009999999999,
"eventListeners": -16460,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 498.2150000000729,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.072000000000003,
"layouts": 6,
"layoutDurationMs": 1.641,
"taskDurationMs": 174.58200000000002,
"heapDeltaBytes": -1284548,
"heapUsedBytes": 49043936,
"domNodes": -102,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 26.527,
"eventListeners": -64,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 468.18499999994856,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.917999999999996,
"layouts": 5,
"layoutDurationMs": 1.3840000000000001,
"taskDurationMs": 130.406,
"heapDeltaBytes": 5194536,
"heapUsedBytes": 59101396,
"domNodes": 157,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.66,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🎭 Playwright: ✅ 1899 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip 🔴 +127 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🔴 +334 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 223 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T10:33:27.119Z",
"gitSha": "7d62f18919e8f4df12dc56ab05685ba3f16d4721",
"branch": "litegraph/deprecate-on-event",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2064.0739999999482,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.518,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.511,
"heapDeltaBytes": -7116992,
"heapUsedBytes": 62590400,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.900999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2070.934999999963,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.174000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.159,
"heapDeltaBytes": 9500344,
"heapUsedBytes": 79771800,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.071000000000002,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.9570000000044,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.173,
"layouts": 14,
"layoutDurationMs": 4.627,
"taskDurationMs": 876.0790000000001,
"heapDeltaBytes": 6284824,
"heapUsedBytes": 77084856,
"domNodes": -279,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 140.84199999999998,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1782.1330000000444,
"styleRecalcs": 74,
"styleRecalcDurationMs": 32.303,
"layouts": 14,
"layoutDurationMs": 4.202000000000001,
"taskDurationMs": 852.108,
"heapDeltaBytes": 4966956,
"heapUsedBytes": 75797136,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 136.83599999999998,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.152999999977,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.545999999999998,
"layouts": 6,
"layoutDurationMs": 1.0180000000000002,
"taskDurationMs": 352.99299999999994,
"heapDeltaBytes": 4988568,
"heapUsedBytes": 75813036,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.276000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.7169999999496,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.025,
"layouts": 6,
"layoutDurationMs": 1.226,
"taskDurationMs": 368.37699999999995,
"heapDeltaBytes": 5124008,
"heapUsedBytes": 75707220,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.127999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 733.822000000032,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.162,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.31200000000007,
"heapDeltaBytes": -7833580,
"heapUsedBytes": 62905280,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 157.53300000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 636.4389999999958,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.18,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.59999999999997,
"heapDeltaBytes": 17865792,
"heapUsedBytes": 87673784,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 154.812,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2053.6460000000147,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.347000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.5719999999999,
"heapDeltaBytes": 11213960,
"heapUsedBytes": 86894064,
"domNodes": -271,
"jsHeapTotalBytes": -2187264,
"scriptDurationMs": 35.19800000000001,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2021.710999999982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.664999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.6510000000002,
"heapDeltaBytes": -14608040,
"heapUsedBytes": 86530852,
"domNodes": -269,
"jsHeapTotalBytes": -1626112,
"scriptDurationMs": 40.083999999999996,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2189.9040000000127,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.403999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1570.5549999999996,
"heapDeltaBytes": 21697568,
"heapUsedBytes": 87584416,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 762.189,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2203.4699999999248,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.118,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1583.3439999999998,
"heapDeltaBytes": 21608956,
"heapUsedBytes": 87111720,
"domNodes": -279,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 763.859,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3527.821000000017,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.380999999999998,
"layouts": 60,
"layoutDurationMs": 12.115,
"taskDurationMs": 1637.8830000000003,
"heapDeltaBytes": 8172668,
"heapUsedBytes": 75469132,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 725.457,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3558.452999999986,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.789,
"layouts": 60,
"layoutDurationMs": 12.020000000000001,
"taskDurationMs": 1649.781,
"heapDeltaBytes": 8462616,
"heapUsedBytes": 75716484,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 729.552,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3099.585999999988,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.758000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1892.7809999999997,
"heapDeltaBytes": 20015380,
"heapUsedBytes": 87009108,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 915.18,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3076.0759999999436,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.767999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1908.676,
"heapDeltaBytes": 20398068,
"heapUsedBytes": 87346216,
"domNodes": -275,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 929.6859999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.4490000000233,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.196999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.423,
"heapDeltaBytes": -15317636,
"heapUsedBytes": 87188104,
"domNodes": -269,
"jsHeapTotalBytes": -315392,
"scriptDurationMs": 32.52100000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.157000000041,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.602000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.1179999999999,
"heapDeltaBytes": -15686292,
"heapUsedBytes": 87210944,
"domNodes": -267,
"jsHeapTotalBytes": -577536,
"scriptDurationMs": 34.93599999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.8720000000189,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.192,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.81200000000007,
"heapDeltaBytes": 15141228,
"heapUsedBytes": 88181508,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 135.42000000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.4260000000413,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.762000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.806,
"heapDeltaBytes": 14873588,
"heapUsedBytes": 87668096,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 136.37,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.3609999999794,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.358999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.67999999999995,
"heapDeltaBytes": -6777964,
"heapUsedBytes": 65977644,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.266000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.1810000000078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.797000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.74799999999993,
"heapDeltaBytes": -6208960,
"heapUsedBytes": 66512840,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.869,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1749.3989999999826,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.394,
"layouts": 18,
"layoutDurationMs": 4.918,
"taskDurationMs": 873.5589999999999,
"heapDeltaBytes": -16129060,
"heapUsedBytes": 56771692,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 97.747,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.9230000000753,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.782,
"layouts": 18,
"layoutDurationMs": 4.989,
"taskDurationMs": 838.512,
"heapDeltaBytes": -12806688,
"heapUsedBytes": 59680356,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 95.93700000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.219000000091,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.672000000000004,
"layouts": 14,
"layoutDurationMs": 13.653000000000002,
"taskDurationMs": 874.3790000000002,
"heapDeltaBytes": 21187496,
"heapUsedBytes": 109340160,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.112,
"eventListeners": 2383,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8250.087000000007,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.532,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5627.906,
"heapDeltaBytes": 13058792,
"heapUsedBytes": 88534232,
"domNodes": -271,
"jsHeapTotalBytes": -913408,
"scriptDurationMs": 2488.278,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8285.175999999978,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.547999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5661.6359999999995,
"heapDeltaBytes": -7648632,
"heapUsedBytes": 93062608,
"domNodes": -270,
"jsHeapTotalBytes": -876544,
"scriptDurationMs": 2528.439,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15894.448000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15115.719,
"heapDeltaBytes": -33787788,
"heapUsedBytes": 175517484,
"domNodes": -6548,
"jsHeapTotalBytes": 4182016,
"scriptDurationMs": 271.09399999999994,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15794.490999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14965.064999999999,
"heapDeltaBytes": -32560768,
"heapUsedBytes": 176677476,
"domNodes": -6549,
"jsHeapTotalBytes": -647168,
"scriptDurationMs": 243.924,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18435.534000000076,
"styleRecalcs": 144,
"styleRecalcDurationMs": 17.038999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18170.493000000002,
"heapDeltaBytes": -8965560,
"heapUsedBytes": 193304520,
"domNodes": -6548,
"jsHeapTotalBytes": 2273280,
"scriptDurationMs": 864.6930000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18305.294,
"styleRecalcs": 137,
"styleRecalcDurationMs": 16.101000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18012.049000000003,
"heapDeltaBytes": -24355156,
"heapUsedBytes": 179964816,
"domNodes": -6548,
"jsHeapTotalBytes": 2826240,
"scriptDurationMs": 875.764,
"eventListeners": -7471,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5581.618000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.434,
"layouts": 20,
"layoutDurationMs": 24.615,
"taskDurationMs": 5507.508,
"heapDeltaBytes": -32473428,
"heapUsedBytes": 180926436,
"domNodes": -6548,
"jsHeapTotalBytes": 8097792,
"scriptDurationMs": 100.063,
"eventListeners": -7471,
"totalBlockingTimeMs": 285,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5669.412999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.77300000000004,
"layouts": 20,
"layoutDurationMs": 24.906,
"taskDurationMs": 5566.870000000001,
"heapDeltaBytes": -27918704,
"heapUsedBytes": 174724660,
"domNodes": -6548,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 115.86900000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 316,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 464.4469999999501,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.104,
"layouts": 3,
"layoutDurationMs": 1.3319999999999999,
"taskDurationMs": 121.24300000000001,
"heapDeltaBytes": 5047368,
"heapUsedBytes": 73867864,
"domNodes": 149,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.014,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 460.6449999999995,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.778,
"layouts": 3,
"layoutDurationMs": 1.4359999999999997,
"taskDurationMs": 99.94500000000001,
"heapDeltaBytes": 4910528,
"heapUsedBytes": 73849608,
"domNodes": 140,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.311000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/lib/litegraph/src/LiteGraphGlobal.ts (1)
377-385: ⚡ Quick winThrottle
ON_EVENTdeprecation warnings to avoid log spam.The getter warns on every read, which can flood console output for extensions that repeatedly access constants. Warn once by default (respecting
alwaysRepeatWarnings) and return the enum slot constant instead of a magic number.♻️ Proposed refactor
constructor() { Object.defineProperty(this, 'Classes', { writable: false }) + let hasWarnedOnEvent = false Object.defineProperty(this, 'ON_EVENT', { get() { - console.warn( - 'LiteGraph.ON_EVENT is deprecated; numeric slot 1 is preserved for v2 ABI but the symbol will be removed in release N+1. ON_EVENT is a no-op mode — use NEVER to mute a node.' - ) - return 1 + if (this.alwaysRepeatWarnings || !hasWarnedOnEvent) { + console.warn( + 'LiteGraph.ON_EVENT is deprecated; numeric slot 1 is preserved for v2 ABI but the symbol will be removed in release N+1. ON_EVENT is a no-op mode — use NEVER to mute a node.' + ) + hasWarnedOnEvent = true + } + return LGraphEventMode._UNUSED_1 }, configurable: true }) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/litegraph/src/LiteGraphGlobal.ts` around lines 377 - 385, The ON_EVENT getter currently logs on every access and returns a magic number; change it to log the deprecation only once (unless the global alwaysRepeatWarnings is true) by gating the console.warn with a persistent flag (e.g. this._warned_ON_EVENT) and return the appropriate enum slot constant instead of the literal 1 (use the existing NEVER/enum constant symbol) so callers get the canonical value; update the Object.defineProperty getter for 'ON_EVENT' to check this.alwaysRepeatWarnings || !this._warned_ON_EVENT before warning, set this._warned_ON_EVENT = true when warned, and return the enum constant (NEVER) rather than the magic number.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/lib/litegraph/src/LiteGraphGlobal.ts`:
- Around line 377-385: The ON_EVENT getter currently logs on every access and
returns a magic number; change it to log the deprecation only once (unless the
global alwaysRepeatWarnings is true) by gating the console.warn with a
persistent flag (e.g. this._warned_ON_EVENT) and return the appropriate enum
slot constant instead of the literal 1 (use the existing NEVER/enum constant
symbol) so callers get the canonical value; update the Object.defineProperty
getter for 'ON_EVENT' to check this.alwaysRepeatWarnings ||
!this._warned_ON_EVENT before warning, set this._warned_ON_EVENT = true when
warned, and return the enum constant (NEVER) rather than the magic number.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 230c14dd-a804-43cf-a409-fd3314b162fb
📒 Files selected for processing (3)
src/lib/litegraph/src/LGraphNode.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/lib/litegraph/src/types/globalEnums.ts
Custom node ecosystem search — breaking change validationThis PR is a soft deprecation, not a deletion: it renames the enum member Runtime impact on custom nodes
Ecosystem cross-checkSearched for ConclusionNot a runtime breaking change. Behavior is preserved via the deprecation getter + numeric default-accept in |
✅ This PR follows the correct deprecation patternUnlike the other PRs in this stack, this one properly:
The warning message is clear:
No additional action needed — this is the model the other PRs should follow for symbols with external consumers. |
ON_EVENT is a no-op mode — use NEVER to mute a node. The numeric slot (1) is preserved for v2 ABI; the symbol will be removed in release N+1. - Rename LGraphEventMode.ON_EVENT → _UNUSED_1 (value=1) in globalEnums.ts. - Replace window.LiteGraph.ON_EVENT static assignment with a deprecation getter that console.warn's then returns 1. - Delete the no-op 'case ON_EVENT: break' arm in LGraphNode.changeMode(). Widen the switch to a numeric default-accept so setMode(1) keeps working. - Update comfyui-frontend-types .d.ts: replace typeof LiteGraph.ON_EVENT with literal 1 in the mode?: union. Bump types patch version. Christian sign-off received on warning copy. Closes #12225 (release N half — release N+1 PR will drop _UNUSED_1 and the deprecation getter).
fd5a94e to
f6c47c6
Compare
|
Rebased onto current Full context for agent readersThe branch now points to Verification:
CI has restarted on the rebased head. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #12231 +/- ##
==========================================
+ Coverage 80.73% 82.34% +1.60%
==========================================
Files 2438 2029 -409
Lines 124324 117081 -7243
Branches 32894 31162 -1732
==========================================
- Hits 100378 96411 -3967
+ Misses 23444 20492 -2952
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 416 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Verified: current head |
Release-N half of the
LiteGraph.ON_EVENTdeprecate-then-delete cycle.Why
ON_EVENTis a no-op mode in the in-browser LiteGraph —changeMode()had acase ON_EVENT: breakarm that did nothing. UseNEVERto mute a node. The numeric slot1is preserved for v2 ABI; the symbol will be removed in release N+1.Changes
globalEnums.ts— renameLGraphEventMode.ON_EVENT→_UNUSED_1(value stays1).LiteGraphGlobal.ts— replacewindow.LiteGraph.ON_EVENTstatic assignment with anObject.definePropertygetter that fires the deprecationconsole.warnthen returns1. Registered in theLiteGraphGlobalconstructor so it lands at the same point in module evaluation as the previous class-field assignment (instance constructed atlitegraph.ts:17).LGraphNode.ts— delete the no-opcase ON_EVENT: breakarm inchangeMode(); widen the switchdefaultfromreturn falsetobreaksosetMode(1)(and any other numeric mode) falls through to the existingthis.mode = modeToassignment +return true.Compatibility surprises
packages/comfyui-frontend-types/does not exist in this repo. Step 4 of the brief targeted a.d.tswithtypeof LiteGraph.ON_EVENTin themode?:union —rgconfirmed notypeof LiteGraph.ON_EVENTanywhere in the worktree. The published types package is referenced indocs/adr/0002-monorepo-conversion.mdas a future package; the patch bump must be made in whichever sibling repo actually publishes it. The internalmode?:typings (src/lib/litegraph/src/{LGraph,interfaces}.ts) useLGraphEventModedirectly and continue to work —_UNUSED_1is still assignable tomode?: LGraphEventModeat the type level.src/lib/litegraph/src/__snapshots__/litegraph.test.ts.snapstill records"ON_EVENT": 1,from the old class-field shape. Withenumerabledefaulting tofalseon the newdefineProperty, the key drops out ofObject.keys()enumeration; first vitest run with-uwill regenerate. Left out of this PR to keep the diff minimal — flag for the next CI-green pass.Sign-off
Christian approved the warning copy:
Quality gates (Node 24)
pnpm lint,pnpm format:check,pnpm knipall clean (only preexisting@knipIgnoreUnusedButUsedByCustomNodeswarning onsrc/scripts/metadata/flac.ts).Sequencing
_UNUSED_1+ deprecation getter.Closes #12225 (release N half).
┆Issue is synchronized with this Notion page by Unito
Re-audit context (W2F-1, 2026-05-13)
Re-audit context: no listener-variant consumer impact found in W2F-1 sweep across 138 indexed extension repos. The W2F-1 sweep targeted the 21 EXTENSION-CONSUMER surfaces enumerated in
research/touch-points/database.yaml(S2.N*, S3.C1, S6.A1, S11.G3); the symbols deleted in this PR are LITEGRAPH-INTERNAL and not in that surfaced set. Seeresearch/meta/sourcegraph-mcp-coverage-investigation.md§Step E (AUDIT-LG.10 verdict-table impact: zero flips required).Evidence
Rebased onto
origin/mainat3277c2782d. Conflict resolution preserved numeric mode1compatibility and refreshed the affected LiteGraph snapshot.pnpm typecheck— passedpnpm exec vitest run src/lib/litegraph/src/litegraph.test.ts -u— 5 passed; 1 snapshot updatedgit diff --check origin/main...HEAD— passed