Repository navigation
perf: add viewport culling to reduce Vue node mount/unmount GC churn - #10481
christian-byrne wants to merge 8 commits into
Conversation
Adds a @Perf test that pans aggressively back and forth across a large graph (245 nodes), forcing many nodes to cross the viewport boundary. Measures style recalcs, forced layouts, task duration, heap delta, and DOM node churn. This is PR 1 of 2. The optimization (viewport culling) will follow in a separate PR once this baseline is established on main.
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a viewport-culling composable and integrates it into GraphCanvas so node components are mounted only when within an expanded viewport; culling respects transform-settling (throttles during transforms, immediate refresh after) and debounces unmounting. Changes
Sequence DiagramsequenceDiagram
participant Canvas as GraphCanvas
participant Culling as useViewportCulling
participant Viewport as getViewportSize
participant Transform as useTransformSettling
Canvas->>Culling: init(rawNodes, nodeLayouts, getViewportSize, isTransforming)
Culling->>Viewport: request viewport size
Viewport-->>Culling: width/height
Culling->>Culling: compute visible node IDs (with VIEWPORT_MARGIN, use isNodeInViewport)
Culling-->>Canvas: mountedNodeIds (visible IDs)
Canvas->>Transform: observe canvasElement
Transform-->>Canvas: isTransforming updates
Canvas->>Culling: provide isTransforming
alt isTransforming == true
Culling->>Culling: throttle recalculation of visibility
else transform ends
Culling->>Culling: immediate refresh of visibility
end
alt node leaves viewport
Culling->>Culling: debounce removal (HIDE_DELAY_MS)
Culling-->>Canvas: update mountedNodeIds after delay
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 5.08 MB gzip 🔴 +1.48 kBDetailsSummary
Category Glance App Entry Points — 23 kB (baseline 23 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.13 MB (baseline 1.13 MB) • 🔴 +3.44 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.7 kB (baseline 76.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 484 kB (baseline 484 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 12 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.9 kB (baseline 60.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 2.95 MB (baseline 2.95 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 334 kB (baseline 334 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 12 unchanged Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.41 MB (baseline 8.41 MB) • ⚪ 0 BBundles that do not match a named category
Status: 55 added / 55 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-03-25T18:54:01.851Z",
"gitSha": "50448d8fffffca165073283928168aad12f8f10e",
"branch": "perf/fix-viewport-gc-churn",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.2500000000373,
"styleRecalcs": 12,
"styleRecalcDurationMs": 13.181999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.115,
"heapDeltaBytes": 20941460,
"heapUsedBytes": 63673292,
"domNodes": 25,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 22.782999999999998,
"eventListeners": 30,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "canvas-idle",
"durationMs": 2032.1810000000369,
"styleRecalcs": 11,
"styleRecalcDurationMs": 13.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.889,
"heapDeltaBytes": 20163256,
"heapUsedBytes": 63095752,
"domNodes": 24,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 25.230000000000004,
"eventListeners": 22,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "canvas-idle",
"durationMs": 2018.0579999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.669,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.65299999999996,
"heapDeltaBytes": 19861588,
"heapUsedBytes": 63152404,
"domNodes": 18,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 16.635000000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2066.669999999931,
"styleRecalcs": 86,
"styleRecalcDurationMs": 53.55900000000001,
"layouts": 12,
"layoutDurationMs": 4.0089999999999995,
"taskDurationMs": 1047.414,
"heapDeltaBytes": 15897284,
"heapUsedBytes": 58438024,
"domNodes": 71,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 143.388,
"eventListeners": 30,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1994.1559999999754,
"styleRecalcs": 80,
"styleRecalcDurationMs": 44.722,
"layouts": 12,
"layoutDurationMs": 3.5090000000000003,
"taskDurationMs": 999.5039999999999,
"heapDeltaBytes": 16043048,
"heapUsedBytes": 60326140,
"domNodes": 64,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 141.477,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1999.6169999999438,
"styleRecalcs": 84,
"styleRecalcDurationMs": 41.95,
"layouts": 12,
"layoutDurationMs": 2.987,
"taskDurationMs": 969.7869999999999,
"heapDeltaBytes": 16642524,
"heapUsedBytes": 59775608,
"domNodes": 65,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 129.864,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.7710000001034,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.869999999999997,
"layouts": 6,
"layoutDurationMs": 0.608,
"taskDurationMs": 293.043,
"heapDeltaBytes": 24724060,
"heapUsedBytes": 67685992,
"domNodes": 79,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 25.891000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.9720000000652,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.902,
"layouts": 6,
"layoutDurationMs": 0.624,
"taskDurationMs": 322.18800000000005,
"heapDeltaBytes": 24537256,
"heapUsedBytes": 68976308,
"domNodes": 79,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 24.365000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.6370000000443,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.235,
"layouts": 6,
"layoutDurationMs": 0.626,
"taskDurationMs": 326.29600000000005,
"heapDeltaBytes": 15540004,
"heapUsedBytes": 66780488,
"domNodes": 82,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 27.414999999999996,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "dom-widget-clipping",
"durationMs": 586.9500000000016,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.71,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.35200000000003,
"heapDeltaBytes": 7289260,
"heapUsedBytes": 51642692,
"domNodes": 23,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 66.096,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027
},
{
"name": "dom-widget-clipping",
"durationMs": 596.3269999999739,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.374,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.449,
"heapDeltaBytes": 6498352,
"heapUsedBytes": 50308144,
"domNodes": 21,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 70.397,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "dom-widget-clipping",
"durationMs": 584.090999999944,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.569999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.725,
"heapDeltaBytes": 6369520,
"heapUsedBytes": 49427716,
"domNodes": 22,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 63.29899999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999
},
{
"name": "large-graph-idle",
"durationMs": 2045.6750000000739,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.221000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.047,
"heapDeltaBytes": 5081796,
"heapUsedBytes": 56077464,
"domNodes": -259,
"jsHeapTotalBytes": 15929344,
"scriptDurationMs": 96.87299999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2050.2420000000257,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.922000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.075,
"heapDeltaBytes": 4491972,
"heapUsedBytes": 54880300,
"domNodes": -265,
"jsHeapTotalBytes": 16715776,
"scriptDurationMs": 110.768,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "large-graph-idle",
"durationMs": 2074.6010000000297,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.601,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.375,
"heapDeltaBytes": 6610724,
"heapUsedBytes": 57698476,
"domNodes": -262,
"jsHeapTotalBytes": 15142912,
"scriptDurationMs": 104.648,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "large-graph-pan",
"durationMs": 2145.2150000000074,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1105.827,
"heapDeltaBytes": 19375004,
"heapUsedBytes": 71654496,
"domNodes": -266,
"jsHeapTotalBytes": 18231296,
"scriptDurationMs": 407.985,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "large-graph-pan",
"durationMs": 2122.1759999999676,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1143.134,
"heapDeltaBytes": -7557368,
"heapUsedBytes": 47539128,
"domNodes": -270,
"jsHeapTotalBytes": 21229568,
"scriptDurationMs": 423.30899999999997,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "large-graph-pan",
"durationMs": 2161.7669999999407,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.804000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1161.6599999999999,
"heapDeltaBytes": 19613144,
"heapUsedBytes": 73571220,
"domNodes": -268,
"jsHeapTotalBytes": 19017728,
"scriptDurationMs": 466.722,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "minimap-idle",
"durationMs": 2027.0600000000059,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.918,
"heapDeltaBytes": -8073816,
"heapUsedBytes": 47640436,
"domNodes": -271,
"jsHeapTotalBytes": 15986688,
"scriptDurationMs": 103.44999999999999,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65
},
{
"name": "minimap-idle",
"durationMs": 2055.0739999999905,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.885000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.141,
"heapDeltaBytes": 3248936,
"heapUsedBytes": 57705276,
"domNodes": -268,
"jsHeapTotalBytes": 16715776,
"scriptDurationMs": 105.732,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "minimap-idle",
"durationMs": 2011.0370000001012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.050999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.907,
"heapDeltaBytes": -6391664,
"heapUsedBytes": 50563452,
"domNodes": -237,
"jsHeapTotalBytes": 13422592,
"scriptDurationMs": 95.07400000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.2599999999575,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.133999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.287,
"heapDeltaBytes": 6076180,
"heapUsedBytes": 49378524,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 138.08499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.705999999992,
"styleRecalcs": 50,
"styleRecalcDurationMs": 15.508000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.729,
"heapDeltaBytes": -1290328,
"heapUsedBytes": 50976116,
"domNodes": 26,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 131.617,
"eventListeners": 30,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 537.5970000000052,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.37,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.611,
"heapDeltaBytes": 6179976,
"heapUsedBytes": 49369144,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 121.218,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-idle",
"durationMs": 2005.6849999999713,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.600999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.19500000000005,
"heapDeltaBytes": 19920556,
"heapUsedBytes": 62639436,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 20.256000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-idle",
"durationMs": 2012.4329999999873,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.465000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.42400000000004,
"heapDeltaBytes": 19874704,
"heapUsedBytes": 62926168,
"domNodes": 20,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 19.989,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-idle",
"durationMs": 2015.700000000038,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.856000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.464,
"heapDeltaBytes": 19949904,
"heapUsedBytes": 63631060,
"domNodes": 23,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 17.203999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.4950000000044,
"styleRecalcs": 85,
"styleRecalcDurationMs": 45.834,
"layouts": 16,
"layoutDurationMs": 4.2700000000000005,
"taskDurationMs": 899.1759999999998,
"heapDeltaBytes": 12099704,
"heapUsedBytes": 56864884,
"domNodes": 74,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 104.62599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1978.1850000000532,
"styleRecalcs": 83,
"styleRecalcDurationMs": 46.281000000000006,
"layouts": 16,
"layoutDurationMs": 4.702,
"taskDurationMs": 931.1279999999999,
"heapDeltaBytes": 11688976,
"heapUsedBytes": 54964220,
"domNodes": 72,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 106.61399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2023.3910000000606,
"styleRecalcs": 87,
"styleRecalcDurationMs": 46.846,
"layouts": 16,
"layoutDurationMs": 4.2,
"taskDurationMs": 973.2539999999999,
"heapDeltaBytes": 9094404,
"heapUsedBytes": 61908480,
"domNodes": -248,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 99.997,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "viewport-pan-sweep",
"durationMs": 8105.893000000037,
"styleRecalcs": 245,
"styleRecalcDurationMs": 40.33400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3878.3500000000004,
"heapDeltaBytes": 21182908,
"heapUsedBytes": 78448520,
"domNodes": -275,
"jsHeapTotalBytes": 24260608,
"scriptDurationMs": 1383.6320000000003,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999989
},
{
"name": "viewport-pan-sweep",
"durationMs": 8114.61799999995,
"styleRecalcs": 246,
"styleRecalcDurationMs": 40.917,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4046.563999999999,
"heapDeltaBytes": 15059368,
"heapUsedBytes": 72682240,
"domNodes": -275,
"jsHeapTotalBytes": 26095616,
"scriptDurationMs": 1465.8739999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "viewport-pan-sweep",
"durationMs": 8091.755000000035,
"styleRecalcs": 245,
"styleRecalcDurationMs": 39.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3575.422,
"heapDeltaBytes": 15125984,
"heapUsedBytes": 72689592,
"domNodes": -275,
"jsHeapTotalBytes": 19542016,
"scriptDurationMs": 1214.752,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 12197.529000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12179.877999999999,
"heapDeltaBytes": -32967452,
"heapUsedBytes": 165192720,
"domNodes": -8329,
"jsHeapTotalBytes": 26042368,
"scriptDurationMs": 601.4399999999999,
"eventListeners": -16477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 12215.72100000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12203.818000000001,
"heapDeltaBytes": -40408648,
"heapUsedBytes": 162290772,
"domNodes": -8329,
"jsHeapTotalBytes": 23945216,
"scriptDurationMs": 597.3839999999999,
"eventListeners": -16477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 12094.560000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12085.267000000002,
"heapDeltaBytes": -31111672,
"heapUsedBytes": 165371340,
"domNodes": -8329,
"jsHeapTotalBytes": 27090944,
"scriptDurationMs": 612.228,
"eventListeners": -16481,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.340000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 14388.515999999981,
"styleRecalcs": 124,
"styleRecalcDurationMs": 13.827000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14368.692000000003,
"heapDeltaBytes": -41077624,
"heapUsedBytes": 172020504,
"domNodes": -8329,
"jsHeapTotalBytes": -7073792,
"scriptDurationMs": 841.9760000000001,
"eventListeners": -16471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33000000000029
},
{
"name": "vue-large-graph-pan",
"durationMs": 14412.889999999948,
"styleRecalcs": 127,
"styleRecalcDurationMs": 14.434000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14369.348,
"heapDeltaBytes": -36428920,
"heapUsedBytes": 160152288,
"domNodes": -8331,
"jsHeapTotalBytes": -5238784,
"scriptDurationMs": 862.7090000000002,
"eventListeners": -16479,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 13976.930000000038,
"styleRecalcs": 123,
"styleRecalcDurationMs": 13.954999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13958.782,
"heapDeltaBytes": -21047180,
"heapUsedBytes": 172909480,
"domNodes": -8329,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 832.195,
"eventListeners": -16475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927
},
{
"name": "workflow-execution",
"durationMs": 454.4819999999845,
"styleRecalcs": 23,
"styleRecalcDurationMs": 27.22,
"layouts": 5,
"layoutDurationMs": 1.6740000000000002,
"taskDurationMs": 132.89000000000001,
"heapDeltaBytes": 4844948,
"heapUsedBytes": 50886052,
"domNodes": 192,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 28.774,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "workflow-execution",
"durationMs": 442.85899999999856,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.419999999999995,
"layouts": 5,
"layoutDurationMs": 1.397,
"taskDurationMs": 120.79999999999997,
"heapDeltaBytes": 4457520,
"heapUsedBytes": 48755800,
"domNodes": 157,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 25.478,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027
},
{
"name": "workflow-execution",
"durationMs": 457.7199999998811,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.416,
"layouts": 5,
"layoutDurationMs": 1.536,
"taskDurationMs": 127.04099999999998,
"heapDeltaBytes": 4481276,
"heapUsedBytes": 55087576,
"domNodes": 158,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 30.667,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
}
]
}🎨 Storybook: ❌ FailedDetails⏰ Completed at: 09/02/2026, 08:13:08 PM UTC Links
🎭 Playwright: ❌ 1875 passed, 12 failed · 2 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🔴 +1.68 kBDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.42 MB) • 🔴 +3.56 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 561 kB (baseline 560 kB) • 🔴 +1.47 kBHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 223 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T20:21:58.640Z",
"gitSha": "c882d6996650d95e2200ab72ec3c535e0cd71d24",
"branch": "perf/fix-viewport-gc-churn",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.2999999999688,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.392,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.7660000000001,
"heapDeltaBytes": 183648,
"heapUsedBytes": 70706352,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.426,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2046.4189999999576,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.580000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.9520000000001,
"heapDeltaBytes": -3424544,
"heapUsedBytes": 66585888,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.447000000000005,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1898.5400000000254,
"styleRecalcs": 79,
"styleRecalcDurationMs": 45.629999999999995,
"layouts": 14,
"layoutDurationMs": 4.752999999999999,
"taskDurationMs": 1002.8470000000001,
"heapDeltaBytes": -8644276,
"heapUsedBytes": 61837564,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 172.931,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1905.858999999964,
"styleRecalcs": 79,
"styleRecalcDurationMs": 46.233,
"layouts": 14,
"layoutDurationMs": 5.144,
"taskDurationMs": 911.456,
"heapDeltaBytes": 2911080,
"heapUsedBytes": 72246824,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 176.148,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6600000000149,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.16,
"layouts": 6,
"layoutDurationMs": 1.189,
"taskDurationMs": 408.40900000000005,
"heapDeltaBytes": 5041996,
"heapUsedBytes": 75671280,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.062999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.2799999999643,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.195999999999998,
"layouts": 6,
"layoutDurationMs": 1.08,
"taskDurationMs": 391.92999999999995,
"heapDeltaBytes": 4368892,
"heapUsedBytes": 74469844,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.659,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 800.0049999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.169000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.146,
"heapDeltaBytes": -7147812,
"heapUsedBytes": 63263100,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 180.007,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 759.1049999999768,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.742,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.03200000000004,
"heapDeltaBytes": 18563020,
"heapUsedBytes": 88078776,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.711,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2070.8329999999933,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 710.8610000000001,
"heapDeltaBytes": -14627912,
"heapUsedBytes": 87084284,
"domNodes": -265,
"jsHeapTotalBytes": -1896448,
"scriptDurationMs": 38.373000000000005,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.261999999999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.1000000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.934,
"heapDeltaBytes": -13834592,
"heapUsedBytes": 87779024,
"domNodes": -268,
"jsHeapTotalBytes": -1372160,
"scriptDurationMs": 39.80700000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2719.895000000008,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.226999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1753.2170000000003,
"heapDeltaBytes": 26153664,
"heapUsedBytes": 91716672,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 831.861,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2793.362000000002,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.692000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1806.9379999999999,
"heapDeltaBytes": 25963512,
"heapUsedBytes": 92421380,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 888.0369999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3686.807999999985,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.251999999999999,
"layouts": 60,
"layoutDurationMs": 12.521,
"taskDurationMs": 1777.1830000000002,
"heapDeltaBytes": 10088876,
"heapUsedBytes": 77074700,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.184,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3677.4219999999787,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.208000000000002,
"layouts": 60,
"layoutDurationMs": 12.574,
"taskDurationMs": 1767.923,
"heapDeltaBytes": 8028056,
"heapUsedBytes": 75246940,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.7650000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3213.872999999978,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.235000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2051.104,
"heapDeltaBytes": 26244956,
"heapUsedBytes": 93260336,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1018.5770000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3167.7140000000463,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.313999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2083.386,
"heapDeltaBytes": 25876116,
"heapUsedBytes": 92749160,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1042.128,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.8200000000297,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.346000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.462,
"heapDeltaBytes": 10931176,
"heapUsedBytes": 87667772,
"domNodes": -277,
"jsHeapTotalBytes": -2195456,
"scriptDurationMs": 40.092000000000006,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2036.8240000000242,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.172999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.3230000000001,
"heapDeltaBytes": -16523660,
"heapUsedBytes": 87326944,
"domNodes": -276,
"jsHeapTotalBytes": -1634304,
"scriptDurationMs": 37.94299999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 634.2349999999897,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.497999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.96700000000004,
"heapDeltaBytes": 15187704,
"heapUsedBytes": 88123404,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.00300000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 667.4919999999247,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.314000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.02400000000006,
"heapDeltaBytes": 14855388,
"heapUsedBytes": 87487004,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.10500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.5580000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.14,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.3040000000001,
"heapDeltaBytes": 3057692,
"heapUsedBytes": 75119184,
"domNodes": -293,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.199000000000003,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.0320000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.378000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.7840000000001,
"heapDeltaBytes": -10109968,
"heapUsedBytes": 61917596,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 11.973999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1805.9190000000171,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.714,
"layouts": 18,
"layoutDurationMs": 6.692,
"taskDurationMs": 935.385,
"heapDeltaBytes": -15052208,
"heapUsedBytes": 57856228,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 125.45499999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1792.414000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.24400000000001,
"layouts": 18,
"layoutDurationMs": 5.867999999999999,
"taskDurationMs": 941.2779999999999,
"heapDeltaBytes": -10638024,
"heapUsedBytes": 62332164,
"domNodes": -296,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 124.86099999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1501.905000000022,
"styleRecalcs": 28,
"styleRecalcDurationMs": 38.46999999999999,
"layouts": 16,
"layoutDurationMs": 15.718,
"taskDurationMs": 1092.415,
"heapDeltaBytes": -7464796,
"heapUsedBytes": 86449992,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 39.116,
"eventListeners": 2383,
"totalBlockingTimeMs": 92,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10053.607,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6507.673,
"heapDeltaBytes": 17143928,
"heapUsedBytes": 93296764,
"domNodes": -271,
"jsHeapTotalBytes": -430080,
"scriptDurationMs": 2909.583,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9317.86999999997,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.50900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6120.445,
"heapDeltaBytes": -8193688,
"heapUsedBytes": 93210516,
"domNodes": -268,
"jsHeapTotalBytes": -1179648,
"scriptDurationMs": 2750.803,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 6412.812999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5767.4929999999995,
"heapDeltaBytes": 804816,
"heapUsedBytes": 111941504,
"domNodes": -1614,
"jsHeapTotalBytes": 13987840,
"scriptDurationMs": 122.175,
"eventListeners": -2285,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 6301.103000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5760.967000000001,
"heapDeltaBytes": 16274080,
"heapUsedBytes": 125309420,
"domNodes": -1614,
"jsHeapTotalBytes": 12152832,
"scriptDurationMs": 127.75200000000004,
"eventListeners": -2285,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 8639.916000000028,
"styleRecalcs": 122,
"styleRecalcDurationMs": 13.684000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7722.996,
"heapDeltaBytes": -16941164,
"heapUsedBytes": 103422184,
"domNodes": -1614,
"jsHeapTotalBytes": 11104256,
"scriptDurationMs": 879.869,
"eventListeners": -2283,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 8458.637999999952,
"styleRecalcs": 122,
"styleRecalcDurationMs": 13.386999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7607.341999999999,
"heapDeltaBytes": 3218980,
"heapUsedBytes": 128426896,
"domNodes": -1614,
"jsHeapTotalBytes": 14180352,
"scriptDurationMs": 856.583,
"eventListeners": -2283,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5113.624000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4640.905000000001,
"heapDeltaBytes": -7933528,
"heapUsedBytes": 124937132,
"domNodes": -2598,
"jsHeapTotalBytes": 6905856,
"scriptDurationMs": 107.07,
"eventListeners": -2293,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5161.580000000072,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4488.173,
"heapDeltaBytes": -10734868,
"heapUsedBytes": 125789772,
"domNodes": -2598,
"jsHeapTotalBytes": 7692288,
"scriptDurationMs": 105.12899999999992,
"eventListeners": -2291,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 121.33800000003703,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.007,
"layouts": 3,
"layoutDurationMs": 0.8970000000000002,
"taskDurationMs": 92.44899999999998,
"heapDeltaBytes": 3127064,
"heapUsedBytes": 71110568,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.475999999999999,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 106.99099999999362,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.176000000000002,
"layouts": 2,
"layoutDurationMs": 0.7849999999999999,
"taskDurationMs": 73.52700000000002,
"heapDeltaBytes": 3021892,
"heapUsedBytes": 71447364,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.11,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/graph/GraphCanvas.vue`:
- Around line 307-322: The viewport culling relies only on window resize events
so canvas-only resizes leave mountedNodeIds stale; update useViewportCulling to
observe the actual canvas element (pass in the computed canvasElement from
GraphCanvas.vue) with a ResizeObserver that calls refreshMountedNodes() whenever
the canvas size changes, ensure the observer is created when the canvas element
becomes available, cleaned up/disconnected on unmount or when the element
changes, and keep the existing useEventListener(window, 'resize', ...) as a
fallback; reference functions/values useViewportCulling, getViewportSize,
refreshMountedNodes, mountedNodeIds and the canvasElement computed in
GraphCanvas.vue to locate the relevant code to modify.
In `@src/composables/graph/useViewportCulling.ts`:
- Around line 82-103: refreshMountedNodes currently always assigns a new Set to
mountedNodeIds.value which invalidates downstream shallowRefs; instead compute
visibleNow via computeVisibleNodeIds(), compare membership with
mountedNodeIds.value (check size first then iterate items to ensure equality),
and only replace mountedNodeIds.value with the new Set (and call
pruneMountedNodes()) when the membership actually changed; reference
functions/values: refreshMountedNodes, computeVisibleNodeIds,
mountedNodeIds.value, and pruneMountedNodes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b13e7b8d-2ee6-4fc9-8836-61d82b74e107
📒 Files selected for processing (3)
src/components/graph/GraphCanvas.vuesrc/composables/graph/useViewportCulling.test.tssrc/composables/graph/useViewportCulling.ts
Nodes outside the viewport are no longer rendered as Vue components. This reduces the number of mounted component instances and avoids the costly mount/unmount cycle that was generating excessive GC pressure (~1,273 GC events/sec) during panning. Key design decisions: - Generous viewport margin (0.75x) prevents visible pop-in - Immediate mount when nodes enter viewport - Debounced unmount (250ms) when nodes leave viewport, preventing churn when nodes oscillate at the viewport edge - Throttled visibility recomputation (96ms) during active pan/zoom to avoid making culling itself a per-frame hotspot - Nodes without layout data are always mounted (safe fallback) - Camera state is sampled imperatively via throttle, not bound as a reactive dependency on allNodes, preserving the existing TransformPane optimization that avoids full vdom diffs
Avoid publishing a new Set to mountedNodeIds when no nodes entered the viewport, preventing unnecessary downstream computed invalidation during pan/zoom ticks. #10481 (comment)
8961ac0 to
08b357a
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/composables/graph/useViewportCulling.test.ts (1)
80-103: Clarify the test expectation — initial culling is synchronous.The test comment on lines 98-100 explains that node 2 isn't "pruned" because it was never in the set. This is accurate but the test name "culls nodes outside the viewport after debounce" might be slightly misleading since the culling happens immediately on initial mount (not after debounce). The debounce only applies to removing nodes that were previously mounted.
Consider renaming to something like "excludes off-viewport nodes on initial mount" for clarity.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/composables/graph/useViewportCulling.test.ts` around lines 80 - 103, Rename the test description to reflect that initial culling is synchronous: change the it(...) string in the test that calls useViewportCulling (the test referencing mountedNodeIds and mockIsNodeInViewport) from "culls nodes outside the viewport after debounce" to "excludes off-viewport nodes on initial mount"; also update the inline comment around the mountedNodeIds assertions to clarify that computeVisibleNodeIds runs immediately on mount and that the debounce only applies when removing nodes that were previously mounted (leaving the rest of the test logic, mocks, and useViewportCulling usage unchanged).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/composables/graph/useViewportCulling.test.ts`:
- Around line 80-103: Rename the test description to reflect that initial
culling is synchronous: change the it(...) string in the test that calls
useViewportCulling (the test referencing mountedNodeIds and
mockIsNodeInViewport) from "culls nodes outside the viewport after debounce" to
"excludes off-viewport nodes on initial mount"; also update the inline comment
around the mountedNodeIds assertions to clarify that computeVisibleNodeIds runs
immediately on mount and that the debounce only applies when removing nodes that
were previously mounted (leaving the rest of the test logic, mocks, and
useViewportCulling usage unchanged).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: abff070f-d7b6-49da-a4b4-d9b95e26d8e5
📒 Files selected for processing (4)
browser_tests/tests/performance.spec.tssrc/components/graph/GraphCanvas.vuesrc/composables/graph/useViewportCulling.test.tssrc/composables/graph/useViewportCulling.ts
christian-byrne
left a comment
There was a problem hiding this comment.
The idea here is just to add back the viewport culling that was previously removed from the codebase -- we should use git history to ensure we are adding the nuances of that version -- and then use our new performance testing suite to validate all conclusions/lessons from that round of experimentation and more definitively decide whether viewporting culling is worth the tradeoffs or not.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/composables/graph/useViewportCulling.ts (1)
49-50: Consolidate duplicateuseTransformState()calls.
useTransformState()is invoked twice—once here (line 49) and again at line 125. This creates two separate composable instances. Consolidate into a single call to avoid redundant instantiation.♻️ Proposed fix
export function useViewportCulling({ rawNodes, nodeLayouts, getViewportSize, isTransforming, canvasElement }: UseViewportCullingOptions) { - const { isNodeInViewport } = useTransformState() + const { isNodeInViewport, camera } = useTransformState() const mountedNodeIds = shallowRef(new Set<string>())Then remove the duplicate call at line 125:
const refreshThrottled = useThrottleFn(refreshMountedNodes, CULL_THROTTLE_MS) watch([rawNodes, nodeLayouts], refreshMountedNodes, { immediate: true }) - const { camera } = useTransformState() watch( () => [camera.x, camera.y, camera.z] as const,🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/composables/graph/useViewportCulling.ts` around lines 49 - 50, The code calls useTransformState() more than once, creating duplicate composable instances; remove the second call and reuse the single instance returned earlier. Keep the existing const { isNodeInViewport } = useTransformState() and ensure any later references (previously using the second call) instead reference that same isNodeInViewport (and the same composable instance) so there’s only one useTransformState() invocation in this module; update usages around the code that referenced the duplicate call to use the initial reference.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/composables/graph/useViewportCulling.ts`:
- Around line 49-50: The code calls useTransformState() more than once, creating
duplicate composable instances; remove the second call and reuse the single
instance returned earlier. Keep the existing const { isNodeInViewport } =
useTransformState() and ensure any later references (previously using the second
call) instead reference that same isNodeInViewport (and the same composable
instance) so there’s only one useTransformState() invocation in this module;
update usages around the code that referenced the duplicate call to use the
initial reference.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3771b1f3-b287-446a-aa40-508b71b6f955
📒 Files selected for processing (2)
src/components/graph/GraphCanvas.vuesrc/composables/graph/useViewportCulling.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/graph/GraphCanvas.vue
|
@coderabbitai review |
|
Resolve conflicts against declared integration head 3517e14: - browser_tests/tests/performance.spec.ts: take main's version. Main already has the equivalent 'large graph viewport pan sweep' test (added in #10479, refactored to use canvasOps.panSweep() helper in #11411) plus 'large graph legacy node drag' and 'large graph zoom interaction' (#10478) that this branch's last commit (3517e14) had already reverted to defer to. - src/components/graph/GraphCanvas.vue: main replaced the useVueNodeLifecycle/VueNodeData node source with nodeDataStore/ NodeState (node-data-store migration, unrelated to this PR). Rebased viewport culling on top of the new source: - rawNodes now reads from nodeDataStore.getGraphNodesFor() instead of the removed vueNodeLifecycle.nodeManager. - useViewportCulling's type changed from VueNodeData[] to NodeState[] (both carry .id, otherwise unrelated shapes). - layoutStore.getAllNodes() (bulk map) no longer exists on main; every other consumer of layout data now uses the per-node layoutStore.getNodeLayout(rootGraphId, nodeId) lookup, so useViewportCulling was rewired to do the same, keyed off a new rootGraphId prop, and to react to layoutStore.nodeGeometryVersion instead of watching a bulk layout map. - useTransformState().isNodeInViewport did not exist on main (the composable's own doc comment calls out viewport culling as a design goal, so this is its natural home) - added it: converts a node's canvas-space position/size to screen space via the existing camera transform and tests for overlap with the margined viewport rect, matching the mapping already used by transformStyle. - Updated useViewportCulling.test.ts to mock layoutStore.getNodeLayout and layoutStore.nodeGeometryVersion instead of passing a raw layouts map, and to build NodeState fixtures instead of VueNodeData. Also dropped two vi.clearAllMocks()/vi.useRealTimers() calls now redundant per the project's vitest setup (comfy/no-redundant-vitest-cleanup).
|
Resolved merge conflicts against Two conflicting files:
Verified: |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #10481 +/- ##
==========================================
+ Coverage 80.85% 82.42% +1.57%
==========================================
Files 2445 2033 -412
Lines 124794 117580 -7214
Branches 33021 31329 -1692
==========================================
- Hits 100898 96913 -3985
+ Misses 23393 20489 -2904
+ Partials 503 178 -325
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 424 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Add viewport-based culling so only nodes within (or near) the viewport are mounted as Vue components, reducing GC churn from mount/unmount cycles during panning.
Changes
useViewportCullingcomposable filters which nodes are rendered as Vue components based on viewport visibility. Nodes entering the viewport mount immediately; nodes leaving unmount after a 250ms debounce to prevent edge oscillation churn. Visibility checks are throttled (96ms) during active pan/zoom to avoid becoming a per-frame hotspot.Review Focus
This is PR 2 of 2 (perf-fix-with-proof pattern). PR 1 (#10479) adds the
@perftest establishing a baseline. Once that merges, CI will run the sameviewport-pan-sweeptest on this PR and post a delta proving the improvement.useSlotElementTrackingare removed. The large margin and debounced unmount should prevent link rendering artifacts.Depends on #10479
┆Issue is synchronized with this Notion page by Unito