Repository navigation
refactor: keep DynamicGroup internal while stabilizing - #16811
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (9)
🧰 Additional context used📚 Code guidelines (1)📓 Path-based instructions (2)IMPORTANT: Only comment on issues directly introduced by this PR's code changes.⚙️ CodeRabbit configuration file Files:
Source excerpt: Keep changes small and direct.📄 CodeRabbit inference engine (AGENTS.md) Files:
📝 WalkthroughWalkthroughThe dynamic-group class is renamed to Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The public export is intentionally removed, and in-repository runtime code uses the internal implementation; no concrete merge-blocking regression is identified. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change removes a public API symbol without a compatibility alias, so external integrations using that symbol may require updates. The registered input format, validation limits, and execution dispatch are preserved. Making the class internal is an API-support boundary, not an access-control mechanism. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
ELI5
Keep DynamicGroup out of the public node-authoring API while it is being stabilized. Built-in nodes and contract tests can still use the internal implementation, and registered nodes keep the same input and execution format.
Summary
_DynamicGroupand remove its public export.io.DynamicGroup/IO.DynamicGroupare no longer available throughlatestor its versioned adapter; no public compatibility alias is retained.COMFY_DYNAMICGROUP_V3, schema expansion, validation, row reconstruction and execution behavior. This does not hide registered nodes from/object_infoor block prompt submission by CLI, MCP or other clients.Companion changes
73867fdf33c428f7a4bd7d632c22ca28373d8836). Four real-backend browser scenarios passed locally: empty execution, sparse API restoration, over-limit rejection/recovery, and editing/save/reopen/execution. Full-suite CI is pending; the pre-existing Redo regression remains enabled in that draft.Provenance
python -m pytest tests-unit/comfy_api_test/io_dynamic_group_test.py tests-unit/execution_test/dynamic_group_test.py tests-unit/execution_test/dynamic_inputs_test.py -q: 120 passed with Python 3.12 on CPU. Ruff passed for all three changed Python files.