Skip to content

Add node contract tests for the 1.55 frontend bump - #16839

Draft
christian-byrne wants to merge 6 commits into
masterfrom
glary/1.55-bump-release-contract-tests
Draft

christian-byrne wants to merge 6 commits into
masterfrom
glary/1.55-bump-release-contract-tests

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Tests only — no production code changes.

Why

#16736 moves the bundled frontend from 1.53.10 to 1.55.14. The 1.55 QA pass ran against cloud/1.55 on testcloud; core/1.55 forked from that same cut and then took 130 commits of its own, so the branch core actually ships was never the branch QA executed against. These lock the backend-side contracts in that window that nothing else covered.

One of the nodes involved shipped with no tests at all (CreateCameraInfo), and two of the contracts below span repositories, so a change on one side alone passes CI on both.

What is covered

tests-unit/nodes_test/test_bundled_node_contracts.py

The sweep runs over both halves of a default startup — comfy_extras and comfy_api_nodes (970 nodes, not 670) — and fails loudly if any bundled module fails to import, so it cannot quietly shrink what it examines. A canary node asserts the detector still fires.

tests-unit/comfy_extras_test/camera_info_contract_test.py

  • CameraAngle and CreateCameraInfo emit the same LOAD3D_CAMERA output, so they are interchangeable into 3D consumers.
  • CameraAngle's camera_info carries no quaternion, so _camera_basis takes its look-at path; the view direction it recovers is asserted to be the angle the node was given.
  • The elevation wording and the rendered view agree in sign across the bucket boundaries.
  • useCustomUp is set exactly when world up would be wrong, which is what the viewer gates camera roll on.
  • The inputs the frontend picker binds to: the CAMERA_ANGLE_VIEW widget type, the three widget ids, and the limits, defaults, steps and scene constants that src/extensions/core/cameraAngle/types.ts hand-duplicates and uses to place the preview camera. Nothing negotiates these at runtime.

Verification

  • tests-unit: 2818 passed, 88 skipped. ruff check . clean repo-wide.
  • Every test was mutation-checked: each was confirmed to fail when the thing it guards is broken, including a DynamicGroup input added to an API node, a dropped node registration, a flipped elevation sign, and each pinned frontend constant drifting. A harmless additive change was confirmed not to fail.
  • Checked end to end against a running backend rather than only in-process: /object_info serves 971 nodes with Compose Camera Angle Prompt, camera_info typed LOAD3D_CAMERA, view carrying widgetType: CAMERA_ANGLE_VIEW, and zero occurrences of COMFY_DYNAMICGROUP_V3 anywhere in the served schema. Executing both nodes returned right side view high-angle shot close-up and a camera_info with useCustomUp correctly absent at roll=0.

The screenshot is the two nodes on the current 1.53.10 pin, where view renders as a plain socket because that build has no cameraAngle extension at all. That is the gap 1.55.14 closes, and why the widget-type assertion is worth having.

Sequencing

These describe a frontend this repo does not ship yet, so they should land with or after #16736. They pass either way — 1.53.10 also predates the DynamicGroup renderer.

Generated with Glary

Screenshots

Compose Camera Angle Prompt and Create Camera Info nodes on the ComfyUI canvas, served by the backend under test on the current 1.53.10 frontend pin

Glary added 6 commits October 7, 2026 05:25
Lock the three bundled-node contracts the 1.55 bump depends on and that no
existing test covers: the camera node ids saved workflows reference, the
camera_info shape its 3D consumers read, and the absence of DynamicGroup
widgets from bundled nodes while the frontend has no renderer for them.
Review follow-ups: the node sweep only loaded comfy_extras, missing the 300
comfy_api_nodes that a default startup also registers; a failed module import
silently shrank what it examined; and the elevation check tied forward Y to one
wording bucket, which is false for the elevated range.
Review follow-ups: restore the mappings even when the import assert fires, name
1.57.0 as the condition for retiring the DynamicGroup guard, and add a canary
node so the sweep cannot quietly stop detecting anything.
The picker is selected by widgetType and mirrors the node's widget ids, limits
and scene constants, so either side can drift alone. Also anchor both halves of
the node sweep, and roll the quaternion so the useCustomUp case matches its
name.
SUBJECT_DISTANCE and the lens zoom range are hand-duplicated in the frontend's
cameraAngle/types.ts and place the preview camera, so a backend-only edit to any
of them moves the preview away from the emitted camera_info.
An extra widget is inert for the bridge and the preview camera, so only require
the inputs the frontend actually binds to.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant