Repository navigation
Add node contract tests for the 1.55 frontend bump - #16839
Draft
christian-byrne wants to merge 6 commits into
Draft
christian-byrne wants to merge 6 commits into
christian-byrne wants to merge 6 commits into
Conversation
added 6 commits
October 7, 2026 05:25
Lock the three bundled-node contracts the 1.55 bump depends on and that no existing test covers: the camera node ids saved workflows reference, the camera_info shape its 3D consumers read, and the absence of DynamicGroup widgets from bundled nodes while the frontend has no renderer for them.
Review follow-ups: the node sweep only loaded comfy_extras, missing the 300 comfy_api_nodes that a default startup also registers; a failed module import silently shrank what it examined; and the elevation check tied forward Y to one wording bucket, which is false for the elevated range.
Review follow-ups: restore the mappings even when the import assert fires, name 1.57.0 as the condition for retiring the DynamicGroup guard, and add a canary node so the sweep cannot quietly stop detecting anything.
The picker is selected by widgetType and mirrors the node's widget ids, limits and scene constants, so either side can drift alone. Also anchor both halves of the node sweep, and roll the quaternion so the useCustomUp case matches its name.
SUBJECT_DISTANCE and the lens zoom range are hand-duplicated in the frontend's cameraAngle/types.ts and place the preview camera, so a backend-only edit to any of them moves the preview away from the emitted camera_info.
An extra widget is inert for the bridge and the preview camera, so only require the inputs the frontend actually binds to.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Created by the Glary-Bot Agent
Tests only — no production code changes.
Why
#16736 moves the bundled frontend from 1.53.10 to 1.55.14. The 1.55 QA pass ran against
cloud/1.55on testcloud;core/1.55forked from that same cut and then took 130 commits of its own, so the branch core actually ships was never the branch QA executed against. These lock the backend-side contracts in that window that nothing else covered.One of the nodes involved shipped with no tests at all (
CreateCameraInfo), and two of the contracts below span repositories, so a change on one side alone passes CI on both.What is covered
tests-unit/nodes_test/test_bundled_node_contracts.pyCreateCameraInfostill registers under its own id after feat(camera-info): CreateCameraInfo node + CameraInfoState widget input #14964 moved it out ofnodes_gaussian_splat.pyintonodes_camera.py. It has shipped since v0.23.0, so saved workflows already carry that id and a dropped registration would break them silently.CameraAnglekeeps the display name agreed in feat: add CameraAngle node with camera_info and shot prompt outputs #16251 (Compose Camera Angle Prompt).COMFY_DYNAMICGROUP_V3widget. The DynamicGroup backend landed in core (feat: add DynamicGroup widget input #16260, fix: preserve dynamic input validation and lazy execution #16377) but its frontend support was deliberately held out of 1.55 and does not appear until 1.57.0, so a bundled node offering one would render an unusable widget. refactor: keep DynamicGroup internal while stabilizing #16811 made the input internal for this reason; this checks the property that actually matters at runtime.The sweep runs over both halves of a default startup —
comfy_extrasandcomfy_api_nodes(970 nodes, not 670) — and fails loudly if any bundled module fails to import, so it cannot quietly shrink what it examines. A canary node asserts the detector still fires.tests-unit/comfy_extras_test/camera_info_contract_test.pyCameraAngleandCreateCameraInfoemit the sameLOAD3D_CAMERAoutput, so they are interchangeable into 3D consumers.CameraAngle'scamera_infocarries no quaternion, so_camera_basistakes its look-at path; the view direction it recovers is asserted to be the angle the node was given.useCustomUpis set exactly when world up would be wrong, which is what the viewer gates camera roll on.CAMERA_ANGLE_VIEWwidget type, the three widget ids, and the limits, defaults, steps and scene constants thatsrc/extensions/core/cameraAngle/types.tshand-duplicates and uses to place the preview camera. Nothing negotiates these at runtime.Verification
tests-unit: 2818 passed, 88 skipped.ruff check .clean repo-wide.DynamicGroupinput added to an API node, a dropped node registration, a flipped elevation sign, and each pinned frontend constant drifting. A harmless additive change was confirmed not to fail./object_infoserves 971 nodes withCompose Camera Angle Prompt,camera_infotypedLOAD3D_CAMERA,viewcarryingwidgetType: CAMERA_ANGLE_VIEW, and zero occurrences ofCOMFY_DYNAMICGROUP_V3anywhere in the served schema. Executing both nodes returnedright side view high-angle shot close-upand acamera_infowithuseCustomUpcorrectly absent atroll=0.The screenshot is the two nodes on the current 1.53.10 pin, where
viewrenders as a plain socket because that build has nocameraAngleextension at all. That is the gap 1.55.14 closes, and why the widget-type assertion is worth having.Sequencing
These describe a frontend this repo does not ship yet, so they should land with or after #16736. They pass either way — 1.53.10 also predates the DynamicGroup renderer.
Generated with Glary
Screenshots