Repository navigation
bump manager version to 4.3 - #16613
lorenzozanee wants to merge 1 commit into
Conversation
|
🎉 Thank you for your contribution, we really appreciate it! 🎉 Like many open source projects, we require contributors to sign our Contributor License Agreement (CLA). A CLA makes the ownership of contributions explicit, so contributors and the project share a clear understanding of how the code can be used. By signing, you:
CLAs are standard practice across major open source projects including those under the Apache Software Foundation and the Linux Foundation. Ours is based on the Apache Software Foundation's CLA. Most importantly, it would enable us to relicense the project under a more permissive license in the future, giving the project and its community greater flexibility. ✍ To sign, please post a new comment on this PR with exactly the following text: ✍ I have read and agree to the Contributor License Agreement You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details
|
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely describes the main change: updating the pinned Manager version to 4.3. |
| Description check | ✅ Passed | The description directly explains the version change, the security-gate behavior, validation results, and linked issue. |
| Linked Issues check | ✅ Passed | The PR changes manager_requirements.txt from comfyui_manager==4.2.2 to comfyui_manager==4.3. The PR objective ties version 4.3 to the middle gate for stable CNR installs while retaining strict… |
| Out of Scope Changes check | ✅ Passed | The only PR change is the comfyui_manager dependency pin. This change directly supports issue #14380 by selecting the manager version that contains the stated security-gate correction. No unrelated … |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
Comment @coderabbitai help to get the list of available commands.
|
@lorenzozanee need you to accept the CLA in order to merge this PR please. |
a3608e2 to
7e357a7
Compare
|
duplicate: #16410 |
The pinned Manager 4.2.2 applies the stricter
middle+gate before resolving the requested CNR version, which can reject stable installs at normal security. Pin Manager 4.3 so stable CNR installs usemiddle; nightly and unknown versions retainmiddle+, and flagged packages remain blocked by default.Validation:
pytest -q tests-unit/app_test/custom_node_manager_test.py -k 'not get_workflow_templates'(4 passed, 1 deselected). Manager integration tests could not run because optional dependencies are missing; the UI flow was not reproduced.Fixes #14380