Skip to content

bump manager version to 4.3 - #16613

Closed
lorenzozanee wants to merge 1 commit into
Comfy-Org:masterfrom
lorenzozanee:fix/manager-normal-security-downloads
Closed

lorenzozanee wants to merge 1 commit into
Comfy-Org:masterfrom
lorenzozanee:fix/manager-normal-security-downloads

Conversation

@lorenzozanee

Copy link
Copy Markdown

The pinned Manager 4.2.2 applies the stricter middle+ gate before resolving the requested CNR version, which can reject stable installs at normal security. Pin Manager 4.3 so stable CNR installs use middle; nightly and unknown versions retain middle+, and flagged packages remain blocked by default.

Validation: pytest -q tests-unit/app_test/custom_node_manager_test.py -k 'not get_workflow_templates' (4 passed, 1 deselected). Manager integration tests could not run because optional dependencies are missing; the UI flow was not reproduced.

Fixes #14380

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Thank you for your contribution, we really appreciate it! 🎉

Like many open source projects, we require contributors to sign our Contributor License Agreement (CLA). A CLA makes the ownership of contributions explicit, so contributors and the project share a clear understanding of how the code can be used. By signing, you:

  • Confirm that you own your contribution.
  • Keep the right to reuse your own code.
  • Grant us a copyright license to include and share it within our projects.

CLAs are standard practice across major open source projects including those under the Apache Software Foundation and the Linux Foundation. Ours is based on the Apache Software Foundation's CLA. Most importantly, it would enable us to relicense the project under a more permissive license in the future, giving the project and its community greater flexibility.

✍ To sign, please post a new comment on this PR with exactly the following text: ✍


I have read and agree to the Contributor License Agreement


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@socket-security

socket-security Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedpypi/​comfyui-manager@​4.2.2 ⏵ 4.374 +110010010070

View full report

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f83f4502-1f83-418a-8a4a-d42839d2e9b5

📥 Commits

Reviewing files that changed from the base of the PR and between a3608e2 and 7e357a7.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6816acc9-d279-484a-9ef3-d76e768dcd80

📥 Commits

Reviewing files that changed from the base of the PR and between 47e63a2 and a3608e2.

📒 Files selected for processing (1)
  • manager_requirements.txt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⚠️ CI failures not shown inline (2)

GitHub Actions: CLA Assistant / 0_cla-assistant.txt: bump manager version to 4.3

Conclusion: failure

View job details

##[group]Run contributor-assistant/github-action@ca4a40a7d1004f18d9960b404b97e5f30a505a08
 with:
   lock-pullrequest-aftermerge: false
   path-to-document: https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md
   remote-organization-name: comfy-org
   remote-repository-name: comfy-cla
   path-to-signatures: signatures/cla.json
   branch: main
   allowlist: action@github.com,actions-user,ampagent,claude,comfy-pr-bot,GitHub Action,github-actions,github-actions[bot],Glary Bot,Glary-Bot,*[bot]
   custom-notsigned-prcomment: 🎉 Thank you for your contribution, we really appreciate it! 🎉
Like many open source projects, we require contributors to sign our [Contributor License Agreement (CLA)](https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md). A CLA makes the ownership of contributions explicit, so contributors and the project share a clear understanding of how the code can be used. By signing, you:
- Confirm that you own your contribution.
- Keep the right to reuse your own code.
- Grant us a copyright license to include and share it within our projects.
CLAs are standard practice across major open source projects including those under the Apache Software Foundation and the Linux Foundation. Ours is based on the Apache Software Foundation's CLA. Most importantly, it would enable us to relicense the project under a more permissive license in the future, giving the project and its community greater flexibility.
✍ **To sign, please post a new comment on this PR with exactly the following text:** ✍
   custom-pr-sign-comment: I have read and agree to the Contributor License Agreement
   custom-allsigned-prcomment: ✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
   use-dco-flag: false
   suggest-recheck: true
 env:
   GITHUB_***REDACTED_SECRET_ASSIGNMENT***
   PERSONAL_ACCESS_***REDACTED_SECRET_ASSIGNMENT***
 ##[endgroup]
 CLA Assistant GitHub Action bot has started the process
 (node:2228) [DEP0040] DeprecationWar...

GitHub Actions: CLA Assistant / cla-assistant: bump manager version to 4.3

Conclusion: failure

View job details

##[group]Run contributor-assistant/github-action@ca4a40a7d1004f18d9960b404b97e5f30a505a08
 with:
   lock-pullrequest-aftermerge: false
   path-to-document: https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md
   remote-organization-name: comfy-org
   remote-repository-name: comfy-cla
   path-to-signatures: signatures/cla.json
   branch: main
   allowlist: action@github.com,actions-user,ampagent,claude,comfy-pr-bot,GitHub Action,github-actions,github-actions[bot],Glary Bot,Glary-Bot,*[bot]
   custom-notsigned-prcomment: 🎉 Thank you for your contribution, we really appreciate it! 🎉
Like many open source projects, we require contributors to sign our [Contributor License Agreement (CLA)](https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md). A CLA makes the ownership of contributions explicit, so contributors and the project share a clear understanding of how the code can be used. By signing, you:
- Confirm that you own your contribution.
- Keep the right to reuse your own code.
- Grant us a copyright license to include and share it within our projects.
CLAs are standard practice across major open source projects including those under the Apache Software Foundation and the Linux Foundation. Ours is based on the Apache Software Foundation's CLA. Most importantly, it would enable us to relicense the project under a more permissive license in the future, giving the project and its community greater flexibility.
✍ **To sign, please post a new comment on this PR with exactly the following text:** ✍
   custom-pr-sign-comment: I have read and agree to the Contributor License Agreement
   custom-allsigned-prcomment: ✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
   use-dco-flag: false
   suggest-recheck: true
 env:
   GITHUB_***REDACTED_SECRET_ASSIGNMENT***
   PERSONAL_ACCESS_***REDACTED_SECRET_ASSIGNMENT***
 ##[endgroup]
 CLA Assistant GitHub Action bot has started the process
 (node:2228) [DEP0040] DeprecationWar...
🧰 Additional context used
📓 Path-based instructions (2)
IMPORTANT: Only comment on issues directly introduced by this PR's code changes.

⚙️ CodeRabbit configuration file

Files:

  • manager_requirements.txt
Source excerpt: Treat `execution.py` as one example of this rule: it should consume the prompt graph and execution-relevant state, produce execution results and errors, and not know about workflow ids, frontend ids, persistence ids, or API-...

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • manager_requirements.txt
🔇 Additional comments (1)
manager_requirements.txt (1)

1-1: LGTM!


📝 Walkthrough

Walkthrough

The required comfyui_manager version changes from 4.2.2 to 4.3 in manager_requirements.txt.

Priority: ➖ Normal

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to a3608

Version 4.3 addresses stable CNR installs at normal security while retaining the stricter checks for nightly and unknown versions. The live Download-All flow was not reproduced, but no specific merge blocker is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to a3608

The change affects 1 system.

Changed systems: manager_requirements.txt

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — manager_requirements.txt (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in manager_requirements.txt: The pinned comfyui_manager version changed from 4.2.2 to 4.3.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating the pinned Manager version to 4.3.
Description check ✅ Passed The description directly explains the version change, the security-gate behavior, validation results, and linked issue.
Linked Issues check ✅ Passed The PR changes manager_requirements.txt from comfyui_manager==4.2.2 to comfyui_manager==4.3. The PR objective ties version 4.3 to the middle gate for stable CNR installs while retaining strict…
Out of Scope Changes check ✅ Passed The only PR change is the comfyui_manager dependency pin. This change directly supports issue #14380 by selecting the manager version that contains the stated security-gate correction. No unrelated …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@alexisrolland

Copy link
Copy Markdown
Member

@lorenzozanee need you to accept the CLA in order to merge this PR please.

@ltdrdata
ltdrdata force-pushed the fix/manager-normal-security-downloads branch from a3608e2 to 7e357a7 Compare September 30, 2026 13:02
@ltdrdata ltdrdata closed this Sep 30, 2026
@ltdrdata

Copy link
Copy Markdown
Member

duplicate: #16410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "Download-All" button does not download anything. Nodes don't download.

3 participants