Skip to content

[v4] fix: replace PrimeVue styling with Manager-owned theme CSS (#3392) - #3457

Closed
loner233 wants to merge 1 commit into
Comfy-Org:manager-v4from
loner233:backport-3392-v4
Closed

loner233 wants to merge 1 commit into
Comfy-Org:manager-v4from
loner233:backport-3392-v4

Conversation

@loner233

@loner233 loner233 commented Nov 2, 2026

Copy link
Copy Markdown

Summary

Backport of #3392 to manager-v4, so the legacy UI of the pip package (--enable-manager-legacy-ui) gets the same fix.

Since ComfyUI_frontend 1.57.1, the frontend no longer injects PrimeVue's dialog styles; Comfy-Org/ComfyUI_frontend#16352 replaced the PrimeVue Dialog. The legacy Manager menu builds p-dialog markup by hand. So on ComfyUI v0.43.0 (frontend 1.57.4, comfyui_manager==4.2.2), the Manager dialog has no background and its buttons float over the canvas. 4.3 has the same problem.

Changes

Testing

Setup: ComfyUI core v0.31.0 with comfyui-frontend-package 1.57.4, started with --enable-manager --enable-manager-legacy-ui, viewed in Chromium.

  • 4.3 (before): #cm-manager-dialog has the classes p-dialog p-component global-dialog, and its background is rgba(0, 0, 0, 0).
  • 4.3 + this PR (after):
    • The dialog has the class cm-ui-dialog, background rgb(23, 23, 24) and a 1px border.
    • Buttons and selects are styled.
    • comfyui-gui-builder.css loads from the comfyui-manager-legacy extension directory.
    • The Custom Nodes Manager renders with styled buttons, including Install via Git URL.
  • node --check passes on the changed JS files.

Not checked: the light theme, and the Model Manager and Snapshot Manager windows.

🤖 Generated with Claude Code

Backport of #3392 to manager-v4. Paths move from js/ to
comfyui_manager/js/. The Node Usage Analyzer button and the preview
method and component policy combos are not on manager-v4, so their
hunks are dropped.

(cherry picked from commit b0b8bbe)
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7a750ca0-d3a0-4e2f-8d42-39da11b59a40

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T13:41:30.079505Z 962aa9f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 962aa9f33b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const header_actions = $el("div.flex.items-center");

const close_button = $el("button.p-button.p-component.p-button-icon-only.p-button-secondary.p-button-rounded.p-button-text.p-dialog-close-button", {
$el("button.cm-ui-button.cm-ui-close", {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Migrate the Playwright locators with the dialog classes

When the legacy Playwright suite runs, the DB-mode and Update-Policy persistence tests (tests/playwright/legacy-ui-manager-menu.spec.ts:75,122) still click .p-dialog-close-button, which no longer exists after this change, so both time out before completing their close/reopen assertions. The shared closeDialog helper and model-navigation test also reference the removed close-button or mask classes. Update these consumers to .cm-ui-close/.cm-ui-overlay or stable accessible selectors alongside the class rename.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants