Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 962aa9f33b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const header_actions = $el("div.flex.items-center"); | ||
|
|
||
| const close_button = $el("button.p-button.p-component.p-button-icon-only.p-button-secondary.p-button-rounded.p-button-text.p-dialog-close-button", { | ||
| $el("button.cm-ui-button.cm-ui-close", { |
There was a problem hiding this comment.
Migrate the Playwright locators with the dialog classes
When the legacy Playwright suite runs, the DB-mode and Update-Policy persistence tests (tests/playwright/legacy-ui-manager-menu.spec.ts:75,122) still click .p-dialog-close-button, which no longer exists after this change, so both time out before completing their close/reopen assertions. The shared closeDialog helper and model-navigation test also reference the removed close-button or mask classes. Update these consumers to .cm-ui-close/.cm-ui-overlay or stable accessible selectors alongside the class rename.
Useful? React with 👍 / 👎.
Summary
Backport of #3392 to
manager-v4, so the legacy UI of the pip package (--enable-manager-legacy-ui) gets the same fix.Since ComfyUI_frontend 1.57.1, the frontend no longer injects PrimeVue's dialog styles; Comfy-Org/ComfyUI_frontend#16352 replaced the PrimeVue Dialog. The legacy Manager menu builds
p-dialogmarkup by hand. So on ComfyUI v0.43.0 (frontend 1.57.4,comfyui_manager==4.2.2), the Manager dialog has no background and its buttons float over the canvas. 4.3 has the same problem.Changes
js/tocomfyui_manager/js/.main.Testing
Setup: ComfyUI core v0.31.0 with
comfyui-frontend-package1.57.4, started with--enable-manager --enable-manager-legacy-ui, viewed in Chromium.#cm-manager-dialoghas the classesp-dialog p-component global-dialog, and its background isrgba(0, 0, 0, 0).cm-ui-dialog, backgroundrgb(23, 23, 24)and a 1px border.comfyui-gui-builder.cssloads from thecomfyui-manager-legacyextension directory.node --checkpasses on the changed JS files.Not checked: the light theme, and the Model Manager and Snapshot Manager windows.
🤖 Generated with Claude Code