Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
005b42f
fix(home): keep a starting build's name and status readable, and drop…
mariana953 Nov 14, 2026
dd40691
Merge main into the Home build tile fix
mariana953 Nov 14, 2026
8424924
Merge remote-tracking branch 'origin/main' into mar/home-build-tile-t…
mariana953 Nov 15, 2026
eb43ac3
feat(home): stack build tiles when narrow, one build menu for Home an…
mariana953 Nov 15, 2026
33baffd
feat(home): icons on every build menu row, no right-click menu on sid…
mariana953 Nov 15, 2026
f732c7b
fix(home): more room between the build name and the ⋯ button
mariana953 Nov 15, 2026
6c02fd8
fix(home): build menu keeps uninstall safe, returns focus, hides new …
mariana953 Nov 15, 2026
b4ad1f6
Merge remote-tracking branch 'origin/main' into mar/home-build-tile-t…
mariana953 Nov 15, 2026
afa1c29
feat(home): set Auto start from the build menu, show it on the card
mariana953 Nov 15, 2026
4011352
test(tooltip): wait for the bubble to close after Escape
mariana953 Nov 15, 2026
1cd61ac
feat(home): call it Auto start in the build menu and on the card
mariana953 Nov 15, 2026
605fe3c
fix(home): build menu Launch starts a crashed build; sidebar menu ret…
mariana953 Nov 15, 2026
cfc5f8d
Merge remote-tracking branch 'origin/main' into mar/auto-start-in-bui…
mariana953 Nov 16, 2026
39eb70a
Merge origin/main into the Home build tile fix
mariana953 Nov 16, 2026
b2ba213
Merge branch 'mar/home-build-tile-text' of https://github.com/mariana…
mariana953 Nov 16, 2026
4622ca3
feat(auto-start): turn it on for a first build, drop the Settings dro…
benceruleanlu Nov 16, 2026
822a491
Merge remote-tracking branch 'origin/main' into mar/auto-start-in-bui…
benceruleanlu Nov 16, 2026
d0de405
fix(home): drop Open in new window from the build menu
benceruleanlu Nov 16, 2026
2031980
feat(auto-start): a new build's first start decides whether Auto star…
benceruleanlu Nov 16, 2026
a9a1081
fix(auto-start): leave the setting alone when the snapshot restore fa…
mariana953 Nov 16, 2026
b087157
fix(auto-start): close the gaps around a first build's Auto start
benceruleanlu Nov 16, 2026
a8cbfe4
Merge remote-tracking branch 'mariana953/mar/auto-start-in-build-menu…
benceruleanlu Nov 16, 2026
56c3565
fix(auto-start): offer Auto start only on installed local builds
benceruleanlu Nov 16, 2026
a885904
Merge remote-tracking branch 'origin/main' into bl/review-pr-2128-41c3e4
benceruleanlu Nov 16, 2026
4e22923
feat(builds): the whole build card starts the build on Home and Builds
mariana953 Nov 16, 2026
5f4acae
Merge remote-tracking branch 'refs/remotes/pr/2128' into mar/build-ca…
mariana953 Nov 16, 2026
8488d1e
test(e2e): start the build from its menu after a failed start, since …
mariana953 Nov 16, 2026
262063b
Merge remote-tracking branch 'origin/main' into mar/build-cards-click…
mariana953 Nov 16, 2026
5ae0432
test(auto-start): give each Auto start test file its own settings on …
mariana953 Nov 16, 2026
8b92266
Merge origin/main into mar/build-cards-click-to-start
mariana953 Nov 17, 2026
27b17ef
feat(builds): Update available is a quiet link beside the version
mariana953 Nov 17, 2026
3c58d40
feat(builds): shorten the update link to Update and show the bare ver…
mariana953 Nov 17, 2026
b76a8af
fix(builds): one hint at a time on build cards
mariana953 Nov 17, 2026
21e933a
fix(builds): no buttons on the build card, Update available is plain …
mariana953 Nov 17, 2026
c4989aa
Merge origin/main into mar/build-cards-click-to-start
mariana953 Nov 17, 2026
2658cb2
test(builds): pin that a build card has no button but ⋯
mariana953 Nov 17, 2026
57da0da
fix(home): short Update note beside the version on build cards
mariana953 Nov 17, 2026
7cee394
feat(builds): one-line toolbar with no tab counts, search folds into …
mariana953 Nov 17, 2026
c7642c5
test(builds): let the toolbar layout page fill its host
mariana953 Nov 17, 2026
6c14ece
fix(builds): second ⋯ press closes the tile menu; a typed search stay…
mariana953 Nov 17, 2026
70ff1d3
test(builds): hover the tile name and icon with force, since they pas…
mariana953 Nov 17, 2026
9264aee
fix(builds): give the search the sort's text size
mariana953 Nov 17, 2026
7f74ca7
Merge remote-tracking branch 'origin/main' into mar/build-cards-click…
mariana953 Nov 17, 2026
38a7588
fix(builds): Escape on the folded search returns focus to the search …
mariana953 Nov 17, 2026
ac91e9f
fix(builds): name a clipped build in its click hint; remote builds sa…
mariana953 Nov 17, 2026
9d80281
Merge main into build card parity
benceruleanlu Nov 17, 2026
7d1b20f
fix(builds): preserve tile actions and keep update notices visible
benceruleanlu Nov 17, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/assets-startup-failure.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { mkdtemp, rm, writeFile } from 'node:fs/promises'
import { test, expect } from '@playwright/test'
import en from '../locales/en.json'
import { launchApp, type AppContext } from './launchApp'
import { clickInstallTile, expectChooserVisible } from './support/chooserHelpers'
import { expectChooserVisible, pickFromBuildsTileMenu } from './support/chooserHelpers'
import { hasActiveLaunch } from './support/devHooks'
import { reserveFreePort, writeFakeComfyInstall } from './support/fakeComfyInstall'

Expand Down Expand Up @@ -34,7 +34,7 @@ async function launchAndReadError(stderr: string): Promise<string | null> {
document.querySelector('.chooser-tile-error-badge')?.setAttribute('data-earlier-failure', '')
return true
})()`)
await clickInstallTile(ctx!.panel, INSTALL_NAME)
await pickFromBuildsTileMenu(ctx!.panel, INSTALL_ID, 'launch')
await expect.poll(() => hasActiveLaunch(ctx!.app, INSTALL_ID), { timeout: 60_000 }).toBe(false)
await ctx!.panel.waitForVisible(NEW_ERROR_BADGE, { timeout: 30_000 })
expect(await ctx!.panel.click(NEW_ERROR_BADGE)).toBe(true)
Expand Down
17 changes: 15 additions & 2 deletions e2e/comfybuilder-launch.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ import { chmod, mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises'
import { test, expect } from '@playwright/test'
import en from '../locales/en.json'
import { launchApp, type AppContext, type SeedInstallation } from './launchApp'
import { clickInstallTile, expectChooserVisible } from './support/chooserHelpers'
import {
clickInstallTile,
expectChooserVisible,
pickFromBuildsTileMenu
} from './support/chooserHelpers'
import { getIpcInvocations, hasActiveLaunch, resetIpcInvocations } from './support/devHooks'
import { byTestId, TID } from './support/testIds'

Expand Down Expand Up @@ -124,9 +128,18 @@ test('clicking an installed ComfyBuilder tile launches it instead of opening the
await expectChooserVisible(ctx.panel)
})

test('clicking a not-ready ComfyBuilder tile explains itself instead of opening the new-install wizard @windows @macos', async () => {
test('clicking a not-ready ComfyBuilder tile opens its build page instead of the new-install wizard @windows @macos', async () => {
await clickInstallTile(ctx.panel, FAILED.name)

await ctx.panel.waitForVisible('[data-testid="build-details"]', { timeout: 10_000 })
expect(await ctx.panel.exists(NEW_INSTALL_WIZARD)).toBe(false)
expect(await ctx.panel.click('.build-details-back')).toBe(true)
await expectChooserVisible(ctx.panel)
})

test('launching a not-ready ComfyBuilder build from its menu explains itself instead of opening the new-install wizard @windows @macos', async () => {
await pickFromBuildsTileMenu(ctx.panel, FAILED.id, 'launch')

await ctx.panel.waitForVisible(byTestId(TID.baseAlertAction), { timeout: 10_000 })
expect(await ctx.panel.textOf('.base-alert-message-text')).toContain(en.errors.installNotReady)
expect(await ctx.panel.exists(NEW_INSTALL_WIZARD)).toBe(false)
Expand Down
25 changes: 14 additions & 11 deletions e2e/dashboard-delete-flow.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import path from 'node:path'
import { access, mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises'
import { test, expect } from '@playwright/test'
import { launchApp, type AppContext } from './launchApp'
import { expectChooserVisible } from './support/chooserHelpers'
import {
buildMenuItem,
expectChooserVisible,
pickFromBuildsTileMenu
} from './support/chooserHelpers'
import { byTestId, TID } from './support/testIds'
import { getIpcInvocations, resetIpcInvocations } from './support/devHooks'

Expand Down Expand Up @@ -58,25 +62,24 @@ test('chooser shows the seeded tile @windows @macos @linux', async () => {
).toBe(INSTALL_NAME)
})

test('Delete from kebab opens confirm without invoking get-detail-sections @windows @macos @linux', async () => {
test('Uninstall from the ⋯ menu asks inside the menu without invoking get-detail-sections @windows @macos @linux', async () => {
await resetIpcInvocations(ctx.app, 'get-detail-sections')

const kebabClicked = await ctx.panel.click(byTestId(TID.dashboardTileKebab(INSTALL_ID)))
expect(kebabClicked, 'kebab button click dispatched').toBe(true)
await pickFromBuildsTileMenu(ctx.panel, INSTALL_ID, 'delete')

await ctx.panel.waitForVisible(byTestId(TID.contextMenuItem('delete')), { timeout: 5_000 })
const deleteClicked = await ctx.panel.click(byTestId(TID.contextMenuItem('delete')))
expect(deleteClicked, 'delete menu item click dispatched').toBe(true)

await ctx.panel.waitForVisible(byTestId(TID.baseAlertAction), { timeout: 5_000 })
await ctx.panel.waitForVisible(buildMenuItem('confirm-uninstall'), { timeout: 5_000 })
expect(await ctx.panel.textOf('[data-testid="build-menu-uninstall-question"]')).toContain(
INSTALL_NAME
)

const invocations = await getIpcInvocations(ctx.app, 'get-detail-sections')
expect(invocations, 'Delete dispatch must not call get-detail-sections').toEqual([])
})

test('Confirm removes the install directory and tile @windows @macos @linux', async () => {
const confirmClicked = await ctx.panel.click(byTestId(TID.baseAlertAction))
expect(confirmClicked, 'confirm button click dispatched').toBe(true)
const confirmClicked = await ctx.panel.click(buildMenuItem('confirm-uninstall'))
expect(confirmClicked, 'confirm menu item click dispatched').toBe(true)
expect(await ctx.panel.exists(byTestId(TID.baseAlertAction)), 'no second dialog').toBe(false)

await ctx.panel.waitFor(
async () => !(await ctx.panel.exists(byTestId(TID.dashboardTile(INSTALL_ID)))),
Expand Down
16 changes: 2 additions & 14 deletions e2e/delete-untrack.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from 'node:path'
import { access, mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises'
import { test, expect } from '@playwright/test'
import { launchApp, type AppContext } from './launchApp'
import { expectChooserVisible } from './support/chooserHelpers'
import { expectChooserVisible, uninstallFromBuildsTileMenu } from './support/chooserHelpers'
import { closeTitlePopupIfOpen, titlePopupPage, waitForWebContents } from './support/cdpPages'
import { byTestId, TID } from './support/testIds'

Expand Down Expand Up @@ -40,14 +40,6 @@ async function errorShownOnDeletedBuild(): Promise<string | null> {
return ctx.panel.textOf('.base-alert-message-text')
}

async function openKebabAndClick(installationId: string, menuItemId: string): Promise<void> {
const kebabClicked = await ctx.panel.click(byTestId(TID.dashboardTileKebab(installationId)))
expect(kebabClicked, `kebab click on ${installationId}`).toBe(true)
await ctx.panel.waitForVisible(byTestId(TID.contextMenuItem(menuItemId)), { timeout: 5_000 })
const itemClicked = await ctx.panel.click(byTestId(TID.contextMenuItem(menuItemId)))
expect(itemClicked, `menu item click ${menuItemId}`).toBe(true)
}

test.describe.configure({ mode: 'serial' })

test.beforeAll(async () => {
Expand Down Expand Up @@ -126,11 +118,7 @@ test('Manage drawer Untrack drops the record but preserves the install directory
})

test('kebab Delete drops the record AND removes the install directory @real-comfy', async () => {
await openKebabAndClick(DELETE_ID, 'delete')

await ctx.panel.waitForVisible(byTestId(TID.baseAlertAction), { timeout: 5_000 })
const confirmed = await ctx.panel.click(byTestId(TID.baseAlertAction))
expect(confirmed, 'delete confirm click dispatched').toBe(true)
await uninstallFromBuildsTileMenu(ctx.panel, DELETE_ID)

await ctx.panel.waitFor(
async () => !(await tileExists(DELETE_ID)) || (await ctx.panel.isVisible(DELETE_ERROR_BADGE)),
Expand Down
9 changes: 2 additions & 7 deletions e2e/migrate-legacy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { resolve } from 'node:path'
import { test, expect } from '@playwright/test'
import { launchApp, type AppContext } from './launchApp'
import { closeTitlePopupIfOpen, titlePopupPage, waitForWebContents } from './support/cdpPages'
import { expectChooserVisible } from './support/chooserHelpers'
import { expectChooserVisible, pickFromBuildsTileMenu } from './support/chooserHelpers'
import { getIpcInvocations, resetIpcInvocations } from './support/devHooks'
import { byTestId, TID } from './support/testIds'

Expand Down Expand Up @@ -97,12 +97,7 @@ test('chooser kebab Migrate opens the real adoption confirm; Cancel backs out cl
expect(legacyInstallId, 'legacyInstallId not captured by the prior test').toBeTruthy()
await resetIpcInvocations(ctx.app, 'run-action')

expect(
await ctx.panel.click(byTestId(TID.dashboardTileKebab(legacyInstallId))),
'kebab click on legacy desktop tile'
).toBe(true)
await ctx.panel.waitForVisible(byTestId(TID.contextMenuItem('migrate')), { timeout: 5_000 })
expect(await ctx.panel.click(byTestId(TID.contextMenuItem('migrate')))).toBe(true)
await pickFromBuildsTileMenu(ctx.panel, legacyInstallId, 'migrate')

await waitForWebContents(ctx.app, 'comfyTitlePopup.html')
const popup = titlePopupPage(ctx.app)
Expand Down
5 changes: 3 additions & 2 deletions e2e/process-ownership.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,9 @@ test('cancelling from the busy check stops nothing and starts nothing @linux', a
await crashDesktop(ctx!)
const app = await start()
await clickInstallTile(app.panel, INSTALL_NAME)
await app.panel.waitForVisible('[data-testid^="chooser-tile-view-logs-"]', { timeout: 15_000 })
expect(await app.panel.click('[data-testid^="chooser-tile-view-logs-"]')).toBe(true)
const startingTile = '.chooser-tile:has([data-testid^="chooser-tile-progress-"])'
await app.panel.waitForVisible(startingTile, { timeout: 15_000 })
expect(await app.panel.click(startingTile), 'the starting tile opens its logs').toBe(true)
await app.panel.waitFor(
async () =>
(await app.panel.allText('[data-testid="build-progress-steps"]'))
Expand Down
28 changes: 7 additions & 21 deletions e2e/real-comfy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import { test, expect } from '@playwright/test'
import { keepOnlyComfyHostWindow } from './support/comfyHostWindow'
import { launchApp, type AppContext } from './launchApp'
import {
pickFromBuildsTileMenu,
uninstallFromBuildsTileMenu,
clickInstallTile,
clickNewInstallTile,
expectChooserVisible,
Expand Down Expand Up @@ -2300,14 +2302,7 @@ test('cleans up the copy install before the original delete test runs @sec-copy
expect(_copyInstallId, 'no copy install id captured to clean up').toBeTruthy()

await expectChooserVisible(ctx.panel)
await ctx.panel.waitForVisible(byTestId(TID.dashboardTileKebab(_copyInstallId)), {
timeout: 15_000
})
expect(await ctx.panel.click(byTestId(TID.dashboardTileKebab(_copyInstallId)))).toBe(true)
await ctx.panel.waitForVisible(byTestId(TID.contextMenuItem('delete')), { timeout: 5_000 })
expect(await ctx.panel.click(byTestId(TID.contextMenuItem('delete')))).toBe(true)
await ctx.panel.waitForVisible(byTestId(TID.baseAlertAction), { timeout: 15_000 })
expect(await ctx.panel.click(byTestId(TID.baseAlertAction))).toBe(true)
await uninstallFromBuildsTileMenu(ctx.panel, _copyInstallId)

await expect
.poll(() => existsSync(_copyInstallPath), { timeout: 240_000, intervals: [1_000, 2_000] })
Expand Down Expand Up @@ -2337,15 +2332,13 @@ test('dashboard kebab "Copy Installation" creates a real ~500MB copy @sec-copy @
test.setTimeout(600_000)

await expectChooserVisible(ctx.panel)
await ctx.panel.waitForVisible(byTestId(TID.dashboardTileKebab(_updateInstallId)), {
await ctx.panel.waitForVisible(byTestId(TID.dashboardTile(_updateInstallId)), {
timeout: 10_000
})

await resetIpcInvocations(ctx.app, 'run-action')

expect(await ctx.panel.click(byTestId(TID.dashboardTileKebab(_updateInstallId)))).toBe(true)
await ctx.panel.waitForVisible(byTestId(TID.contextMenuItem('copy-install')), { timeout: 5_000 })
expect(await ctx.panel.click(byTestId(TID.contextMenuItem('copy-install')))).toBe(true)
await pickFromBuildsTileMenu(ctx.panel, _updateInstallId, 'copy-install')

await waitForWebContents(ctx.app, 'comfyTitlePopup.html')
const popup = titlePopupPage(ctx.app)
Expand Down Expand Up @@ -2398,7 +2391,7 @@ test('Manage drawer "Untrack" removes the install from the registry without touc

await waitForWebContents(ctx.app, 'panel.html')
await expectChooserVisible(ctx.panel)
await ctx.panel.waitForVisible(byTestId(TID.dashboardTileKebab(_kebabCopyInstallId)), {
await ctx.panel.waitForVisible(byTestId(TID.dashboardTile(_kebabCopyInstallId)), {
timeout: 10_000
})

Expand Down Expand Up @@ -2893,14 +2886,7 @@ test('real delete wipes the fully-installed ~500MB tree off disk @sec-delete @re
test.setTimeout(300_000)
expect(_deleteInstallPath, 'install path not captured').toBeTruthy()

await ctx.panel.waitForVisible(byTestId(TID.dashboardTileKebab(_deleteInstallId)), {
timeout: 10_000
})
expect(await ctx.panel.click(byTestId(TID.dashboardTileKebab(_deleteInstallId)))).toBe(true)
await ctx.panel.waitForVisible(byTestId(TID.contextMenuItem('delete')), { timeout: 5_000 })
expect(await ctx.panel.click(byTestId(TID.contextMenuItem('delete')))).toBe(true)
await ctx.panel.waitForVisible(byTestId(TID.baseAlertAction), { timeout: 15_000 })
expect(await ctx.panel.click(byTestId(TID.baseAlertAction))).toBe(true)
await uninstallFromBuildsTileMenu(ctx.panel, _deleteInstallId)

await expect
.poll(() => existsSync(_deleteInstallPath), { timeout: 240_000, intervals: [1_000, 2_000] })
Expand Down
6 changes: 2 additions & 4 deletions e2e/snapshot-share.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from 'node:path'
import { mkdir, mkdtemp, readdir, readFile, rm } from 'node:fs/promises'
import { test, expect } from '@playwright/test'
import { launchApp, type AppContext } from './launchApp'
import { expectChooserVisible } from './support/chooserHelpers'
import { expectChooserVisible, pickFromBuildsTileMenu } from './support/chooserHelpers'
import { titlePopupPage, waitForWebContents } from './support/cdpPages'
import { evalWithRetry } from './support/evalRetry'
import { byTestId, TID } from './support/testIds'
Expand Down Expand Up @@ -129,9 +129,7 @@ test('dashboard kebab → Share exports the latest snapshot @windows @macos @lin
await clearExportDir()
await ctx.panel.waitForSelector(byTestId(TID.dashboardTile(INSTALL_ID)), { timeout: 10_000 })

expect(await ctx.panel.click(byTestId(TID.dashboardTileKebab(INSTALL_ID)))).toBe(true)
await ctx.panel.waitForVisible(byTestId(TID.contextMenuItem('share')), { timeout: 5_000 })
expect(await ctx.panel.click(byTestId(TID.contextMenuItem('share')))).toBe(true)
await pickFromBuildsTileMenu(ctx.panel, INSTALL_ID, 'share')

expectLatestEnvelope(await readSharedEnvelope())
})
Expand Down
45 changes: 42 additions & 3 deletions e2e/support/chooserHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,53 @@ export async function clickInstallTile(
const tile = [...document.querySelectorAll('.chooser-tile')].find((candidate) =>
candidate.querySelector('.chooser-tile-name')?.textContent?.toLowerCase().includes(needle),
)
const launch = tile?.querySelector('.chooser-tile-launch')
if (!launch) return false
launch.click()
if (!tile) return false
tile.click()
return true
})()`)
expect(launched, `Install tile matching "${nameSubstring}" launched`).toBe(true)
}

export function buildMenuItem(item: string): string {
return byTestId(`build-menu-${item}`)
}

export async function openBuildsTileMenu(
panel: WebContentsPage,
installationId: string
): Promise<void> {
await panel.waitForVisible(byTestId(TID.dashboardTile(installationId)), { timeout: 15_000 })
expect(
await panel.click(byTestId(TID.dashboardTileKebab(installationId))),
`build menu ⋯ clicked on ${installationId}`
).toBe(true)
await panel.waitForVisible(`[data-testid="build-menu"][data-build-id="${installationId}"]`, {
timeout: 5_000
})
}

export async function pickFromBuildsTileMenu(
panel: WebContentsPage,
installationId: string,
item: string
): Promise<void> {
await openBuildsTileMenu(panel, installationId)
await panel.waitForVisible(buildMenuItem(item), { timeout: 5_000 })
expect(await panel.click(buildMenuItem(item)), `build menu ${item} picked`).toBe(true)
}

export async function uninstallFromBuildsTileMenu(
panel: WebContentsPage,
installationId: string
): Promise<void> {
await pickFromBuildsTileMenu(panel, installationId, 'delete')
await panel.waitForVisible(buildMenuItem('confirm-uninstall'), { timeout: 5_000 })
expect(
await panel.click(buildMenuItem('confirm-uninstall')),
'uninstall confirmed in the build menu'
).toBe(true)
}

export async function openTitleMenu(titleBar: WebContentsPage): Promise<void> {
await titleBar.waitForVisible('.title-menu-button--icon[aria-haspopup="menu"]')
const ok = await titleBar.click('.title-menu-button--icon[aria-haspopup="menu"]')
Expand Down
5 changes: 4 additions & 1 deletion locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,10 @@
"nextApp": "Next app",
"retry": "Try again",
"buildInstalling": "Installing ComfyUI",
"buildStartingComfyUI": "Starting ComfyUI"
"buildStartingComfyUI": "Starting ComfyUI",
"buildClickToStart": "Click to start",
"buildClickToOpen": "Click to open",
"buildClickToViewLogs": "Click to view logs"
},
"installType": {
"standalone": "Standalone",
Expand Down
3 changes: 3 additions & 0 deletions locales/zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,9 @@
"buildDidntStart": "未能启动",
"buildInstalling": "正在安装 ComfyUI",
"buildStartingComfyUI": "正在启动 ComfyUI",
"buildClickToStart": "点击启动",
"buildClickToOpen": "点击打开",
"buildClickToViewLogs": "点击查看日志",
"cloudHardware": "RTX 6000 Pro · 96 GB",
"exampleWorkflows": "示例工作流",
"seeAllApps": "查看全部应用",
Expand Down
12 changes: 6 additions & 6 deletions src/renderer/src/composables/useInstallContextMenu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ export interface ManageOpenOptions {
autoAction?: string | null
}

const promotingInstallationIds = ref<ReadonlySet<string>>(new Set())

export function isPromotingToWorkspace(inst: Installation): boolean {
return promotingInstallationIds.value.has(inst.id)
}

export function useInstallContextMenu(
opts: {
onManage?: (inst: Installation, options?: ManageOpenOptions) => void
Expand All @@ -68,19 +74,13 @@ export function useInstallContextMenu(
y: 0,
inst: null as Installation | null
})
const promotingInstallationIds = ref<ReadonlySet<string>>(new Set())

function setPromotingToWorkspace(installationId: string, promoting: boolean): void {
const next = new Set(promotingInstallationIds.value)
if (promoting) next.add(installationId)
else next.delete(installationId)
promotingInstallationIds.value = next
}

function isPromotingToWorkspace(inst: Installation): boolean {
return promotingInstallationIds.value.has(inst.id)
}

function isLocalLikeInstall(inst: Installation): boolean {
return inst.sourceCategory !== 'cloud'
}
Expand Down
Loading
Loading