Repository navigation
feat(builds): the whole build card starts the build on Home and Builds - #2163
Draft
mariana953 wants to merge 29 commits into
Draft
mariana953 wants to merge 29 commits into
mariana953 wants to merge 29 commits into
Conversation
… the folder from Home tiles While a build starts or installs, its Home card put View logs and Cancel beside the text, which squeezed the name and status to nothing at every width. The actions now sit on their own row under the name, and the device picture steps aside when the builds grid is narrow, so the card keeps its size and the text has room. The tile subtitle no longer shows the install folder, which was always cut off; it shows the ComfyUI version (or the source when there is none).
Keep main's uninstall card: no View logs while uninstalling, and its "Removing files" progress line now sits beside Cancel in the action row.
…d the sidebar Home's build tiles go to one per row when two no longer fit their name and status, and keep three in a row on wide windows. A starting or installing tile looks like every other tile: status with percent, name, ComfyUI version and the progress bar. Clicking it opens the logs. Every Home tile shows a More button on hover, and a right-click on a tile or on a build in the sidebar opens the same menu: what the build can do now (Launch; View logs and Cancel; View logs, Restart and Stop), Open in new window, the existing build menu items, then Uninstall, which asks inside the menu. A right-click on Home in the sidebar offers Open in new window.
…ebar pages Each build menu row shows its icon left of the label, like the other Desktop menus: the existing items keep theirs, and Launch, View logs, Cancel, Restart, Stop and Open in new window get one. A right-click on Home, Apps or Assets in the sidebar opens nothing, so the page menu and its new-window bridge are gone.
…window while busy
…ext-rework # Conflicts: # src/renderer/src/panel/home/HomeBuildCard.vue
Drop the Auto start checkbox under every Home build card and Builds page tile. The shared build menu (Home tile, right-click, sidebar row) gets a Start with Desktop / Don't start with Desktop line right after Open in new window, shown in every state. The Builds page tile menu gets the same line as its first group. A ready card or tile whose build starts with Desktop says Starts with Desktop with a power icon instead of Ready. The panel shares one copy of the auto start setting, so a change from any menu shows on every card at once.
…urns focus to its row
…ld-menu # Conflicts: # src/renderer/src/components/ui/Tooltip.test.ts
Keep the build menu on the starting card: View logs and Cancel stay in the ⋯ menu, so the inline busy actions from main are dropped. Keep main's sidebar Desktop Settings button above the account, beside the sidebar build menu.
…953/Comfy-Desktop into mar/auto-start-in-build-menu
…pdown The build menu now sets Auto start, so Settings > General no longer has "Auto-launch on startup". The setting itself is unchanged: startup still reads `autoLaunchOnStartup`, and a saved "last" keeps working, though only the build menu can change it now. When an install finishes and it is the only local build (Comfy Cloud does not count) and nothing is set to start with Desktop yet, that build is set to start with Desktop. A failed install, a second build, or a build the user already picked leaves the setting alone. ComfyUI updates and copies do not go through this path. The shared-controls e2e drove the removed dropdown; it now drives the Language select the same way.
…ld-menu # Conflicts: # src/renderer/src/panel/HomeView.test.ts
main (Comfy-Org#2147) removed openInstallInNewWindow and its string, since every build now opens in its own window. The build menu from the base PR still called it, which broke the typecheck after the merge. Auto start keeps its own group in the menu.
…t stays on The Notion item for Auto launch on startup asks that a new install try to start its build, keep Auto start on if it starts, and turn it off if it does not. Install already turned it on; now the first start settles it. When install turns Auto start on for the first build it also records `autoStartAwaitingFirstStart`. The next launch of that build ends the wait: if ComfyUI answered, Auto start stays on; if the start failed, it goes back to None. Cancelled starts don't count. Picking Auto start by hand ends the wait too, so a later failure never undoes a choice the user made. The renderer preview scenarios waited for the old installing tile's detail line and View logs button, which the one-menu tile replaced; they now wait for the progress bar and open the logs by clicking the tile.
…ils or the user picks a build mid-install
From a review of the PR: - A build left over in the setting after its uninstall no longer counts as a choice, so the next first build still gets Auto start. - "Last used build" had no control left once the Settings dropdown went. At startup it is now pinned to the build it would have started (or None when no build has started), so that build's tile shows Auto start and its menu can turn it off. That startup still opens the same build. - A first start that throws, not only one that returns a failure, turns Auto start back off. - Failing to save the Auto start setting (a full disk) is logged and no longer turns a finished install or a start into an error.
…' into mar/auto-start-in-build-menu # Conflicts: # src/main/lib/firstBuildAutoStart.ts
- The Auto start line was offered on Comfy Cloud and on builds whose install failed or is unfinished. Cloud's tile never shows Auto start, so a Cloud pick opened Cloud at every launch with nothing on screen saying why, and a failed build could become the startup build. - At startup a saved Cloud pick (from the old Settings dropdown, or a Last used build that was Cloud) becomes None, since nothing can show or turn it off any more. - A failure while checking whether a new install is the first build is logged instead of turning the finished install into an error.
A click on a Builds tile does what a Home card click does, with a hover hint (Click to start / open / view logs). The Start and Update buttons are gone; the shared build menu opens from the ⋯ button or a right-click. The status stays on top, so a running build with an update still shows Running, and the version and a short Update available note sit on the bottom line. The Builds grid drops to one column when the page is narrow.
…rds-click-to-start
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
…a click on a failed tile opens its logs
…-to-start # Conflicts: # e2e/assets-startup-failure.test.ts
…Linux GitHub's Linux runners set XDG_CONFIG_HOME, so these two files shared one settings.json and overwrote each other's Auto start value when they ran at the same time. Clear the XDG dirs for the file, as launch.test.ts does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
A build card is now one big button. Click it and the build starts (or opens, if it is already running). There are no Start or Update buttons on the card anymore; everything else lives in the ⋯ menu. The card always tells you first what the build is doing, and the version and any update sit on the line below.
Summary
Builds on #2128 (Auto start in the build menu). Once #2128 merges, this diff shrinks to the card changes only.
Before / After
Tests