Skip to content

feat(apps): read the app list from the production catalog whatever Cloud Desktop runs against - #2059

Closed
vqt123 wants to merge 1 commit into
claude/assets-folder-cards-92eb1afrom
vinh/apps-production-catalog
Closed

vqt123 wants to merge 1 commit into
claude/assets-folder-cards-92eb1afrom
vinh/apps-production-catalog

Conversation

@vqt123

@vqt123 vqt123 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

TL;DR: Desktop reads the Apps tab's list from the production catalog (https://cloud.comfy.org) even when it runs against staging Cloud.

Why The list came from the Cloud Desktop is pointed at. Staging's catalog has no Desktop apps, so a Desktop started against staging showed an empty Apps tab. Catalog changes are safe to make in production (drafts stay hidden until published, and a publish can be rolled back), so staging does not need a catalog of its own.

Before / After

  • Before: COMFY_CLOUD_ISSUER=https://stagingcloud.comfy.org gives an empty Apps tab.
  • After: the same Desktop lists the production catalog's Desktop apps; runs still go to staging Cloud. Thumbnails already came from comfy.org.

Seen in production by: curl 'https://stagingcloud.comfy.org/api/v1/catalog/items?type=app&surface=desktop_starters' returns no items (measured 2026-11-12).

Not run: the new catalog.test.ts case was written, not run locally (CI runs it). Lint and format pass on both files.

Rule bent: none.

Ref BE-26339

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The catalog URL now uses https://cloud.comfy.org instead of the configured issuer. A test verifies that a staging issuer does not change the catalog origin.

Changes: Catalog origin

Layer / File(s) Summary
Catalog URL and regression test
src/main/apps/catalog.ts, src/main/apps/catalog.test.ts
catalogUrl resolves its endpoint against the fixed production origin. A test checks that the URL retains this origin when COMFY_CLOUD_ISSUER is set to a staging URL.

Possibly related PRs

Suggested reviewers: pablowiedemann, benceruleanlu

Merge Risk: Minimal · up to 6364f

Desktop pointed at staging Cloud will list apps from the production catalog instead of showing an empty Apps tab. No concrete merge-blocking defect was found. Whether every production app opens and runs against staging is not verifiable from this repository.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 320f057e-bb58-4c8f-8500-51e581a9c205
Commits

Reviewing files that changed from the base of the PR and between efcafa7 and 6364f5c.

Files selected for processing: 2

  • src/main/apps/catalog.test.ts
  • src/main/apps/catalog.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants