Skip to content

feat(explore): Apps becomes Explore with Apps and Workflows; Home gets Apps | Workflows tabs - #2063

Draft
mariana953 wants to merge 8 commits into
Comfy-Org:vinh/apps-production-catalogfrom
mariana953:mar/m3-explore-home-tabs
Draft

mariana953 wants to merge 8 commits into
Comfy-Org:vinh/apps-production-catalogfrom
mariana953:mar/m3-explore-home-tabs

Conversation

@mariana953

@mariana953 mariana953 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

Desktop's Apps page becomes Explore, with two tabs: Apps and Workflows (the Hub's workflows). On Home, the carousel gets the same kind of tabs, Apps | Workflows, so people can browse either one without leaving Home. Home's arc cards show just their title and, on the front card, an arrow to open it. Cards show what they make (Image, Video, 3D or Audio), both Explore tabs share one toolbar (search, filters, sort, card size), and switching Home's tabs fades smoothly instead of jumping.

Draft for later (milestone 3). Stacked on the Apps chain: base is vinh/apps-production-catalog (#2059). That chain is behind main, so Home's carousel here is the older one; it picks up #2041 and #2060 once the chain catches up with main. The same goes for the dropdowns: the Filters and view menus are built on the design system's Menu, so they take the shared dropdown look from #2067 (popover background, 4px padding, 28px rows, 12px text, picked row filled) once that lands; the captures below show the look before it.

Summary

  • Explore: the sidebar's Apps row reads Explore (compass icon) and always shows. The page has Apps | Workflows tabs (the existing SegmentedControl). Apps is the current gallery and app host, unchanged. Workflows is a grid of the catalog's workflows; a card opens it on the Hub. With the remote apps switch off, Explore shows Workflows only.
  • Home tabs: with the apps switch on, Apps | Workflows tabs sit centred over the carousel, Apps first. The Apps tab lists the catalog's apps; the front app opens in Explore. Switch off: Home is as today, workflows only.
  • See all: "See all apps" opens Explore on Apps, "See all workflows" opens Explore on Workflows (instead of the Hub in the browser).
  • Arc cards: each card shows only its title, two lines at most. Hovering or focusing the front card fades in a white arrow at its top right, on a translucent grey square (9px radius); nothing moves or gets cut. Same arrow as style(home): corner arrow on the front workflow card #2060.
  • Category badge: Home's front card and every Explore card show Image, Video, 3D or Audio on glass (rgb(14 14 16 / 0.28), blur 14px, saturate 1.5); Image uses the design system's image glyph (ImageGlyph). It reads read from the catalog (an item's output kind, else its generation type). One shared CategoryBadge. No badge when the catalog doesn't say: today that is every app, since the production catalog's apps carry neither field.
  • Explore toolbar: both tabs share one toolbar at the right of the tabs, in the same place on either tab, built like the one-comfy proto: a Filters button with a count, a search field ("Search apps" / "Search workflows") with a ⌘/ hint and shortcut, a clear button and Esc to clear, and a view menu with a Size stepper (− bar +: 5, 4 or 3 across; the bar's segments are split by space, with no lines) and a Sort by row that opens Recommended / Name A to Z, the picked one filled. Each tab keeps its own search, filters and sort; the card size is shared. Search reads the title, description, use case and models.
  • Filters: groups come from the catalog and show only when the tab's cards split into two or more values: Type (Image / Video / 3D / Audio), Use case (the Hub's category label, localized), Model (the Hub's model list) and Runs on (This computer with the builds' computer icon, Comfy Cloud with the cloud icon). As in the proto, each group is an uppercase row showing "All" or what is picked, and opens its own submenu, one at a time; the Model submenu has a search on top. Each option counts what picking it would show given the other picks, and options that would show nothing are left out. "Clear filters" (⌘⌫) appears once anything is picked, under a divider that runs edge to edge of the menu. Recommended follows the Hub's recommendedRank. What the catalog lacks today: apps carry no category, use case or model, so the Apps tab has search, sort and size but no Filters; every workflow is CLOUD, so Runs on is left out until some run locally; there is no date, so there is no Newest sort.
  • Smooth tab switch: the carousel fades out, waits until the new tab's first pictures are ready, then fades back in. Opacity and a small move only; instant with reduced motion.
  • Nothing lost: dragging, arrow keys, side cards, opening apps and their outputs, and the apps switch all work as before. The switch logic moved from the sidebar into useAppsEnabled, unchanged.

Before / After

Before After
before, Home after, Home on Apps, front card hovered
Home shows workflows only after, Home on Workflows, front card hovered
before, Apps page after, Explore on Apps
No Workflows page after, Explore on Workflows with category badges
No toolbar after, Workflows toolbar: Filters, search with the ⌘/ hint, view menu
No filters after, Filters: Type, Use case and Model rows
No filters after, Model submenu with its search, typed wan
No filters after, a use case picked, Clear filters row under an edge to edge divider
No sort or size after, view menu: Size stepper (segments split by space, no lines) and Sort by row
No sort or size after, Sort by submenu, Recommended filled

Change breakdown

Category Files Added Deleted Share of 2588 changed lines
Product code 21: src/main/apps/catalog.ts, src/main/catalog/category.ts, src/main/catalog/workflows.ts, src/renderer/src/components/ImageGlyph.vue, src/renderer/src/composables/useAppsEnabled.ts, src/renderer/src/panel/AppSidebar.vue, src/renderer/src/panel/AppsGallery.vue, src/renderer/src/panel/AppsView.vue, src/renderer/src/panel/CategoryBadge.vue, src/renderer/src/panel/ExploreFilter.vue, src/renderer/src/panel/ExploreSearchField.vue, src/renderer/src/panel/ExploreViewOptions.vue, src/renderer/src/panel/HomeView.vue, src/renderer/src/panel/PanelApp.vue, src/renderer/src/panel/TemplatesGallery.vue, src/renderer/src/panel/exploreCards.ts, src/renderer/src/panel/exploreTab.ts, src/renderer/src/panel/home/HomeWorkflowCarousel.vue, src/renderer/src/panel/home/carouselCard.ts, src/renderer/src/types/ipc.ts, src/types/ipc.ts 1296 114 54.5%
Test code 8: src/main/apps/catalog.test.ts, src/main/catalog/category.test.ts, src/main/catalog/workflows.test.ts, src/renderer/src/panel/AppSidebar.test.ts, src/renderer/src/panel/AppsView.test.ts, src/renderer/src/panel/HomeView.test.ts, src/renderer/src/panel/PanelApp.test.ts, src/renderer/src/panel/exploreCards.test.ts 988 78 41.2%
Translations 2: locales/en.json, locales/zh.json 110 2 4.3%

Testing

  • Full unit suite (353 files, 8269 tests) passed 3 runs in a row. Explore tests cover badges, the filter groups and their counts, combined picks, Runs on appearing only when workflows run in more than one place (with the computer and cloud icons), one filter submenu open at a time, the Model search, Clear filters from the menu and with ⌘⌫, the search clear button and Esc, the Size stepper limits, search over titles, descriptions, use cases and models, Recommended and A to Z sort, card size, per-tab search and filters, and the empty result; Home tests cover the front-only arrow, the title-only cards and the glass Image badge. exploreCards.test.ts covers rank order, when a group is offered, and model order.
  • npm run typecheck:web, npm run typecheck:node, eslint and prettier pass on touched files.
  • Checked in the built app on macOS, dark theme: Home on both tabs with the front card hovered (arrow at full opacity, badge glass measured as rgba(14,14,16,0.28) with blur(14px) saturate(1.5)), See all, Explore on both tabs, badges, the toolbar in the same spot on both tabs (search box measured at the same position), the Filters menu with live data, the Model submenu search, picking a use case, the view menu and the Sort by submenu. Not checked: light theme, Windows, Linux, the apps switch off in the built app.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mariana953 mariana953 changed the title feat(explore): Apps becomes Explore with Apps and Templates; Home gets Apps | Workflows tabs feat(explore): Apps becomes Explore with Apps and Workflows; Home gets Apps | Workflows tabs Nov 13, 2026
Filters opens one submenu per group with an uppercase row and its value, a
search on top of the Model list, and Clear filters with Cmd+Backspace. Runs on
uses the builds' computer and cloud icons. The view menu is a Size stepper
and a Sort by row. The search field has the Cmd+/ hint and a clear button.
benceruleanlu added a commit that referenced this pull request Nov 14, 2026
…wording when apps fail to load

Checked against Mar's open draft #2063, which shows where Home is going
(Apps | Workflows tabs over this carousel). Two things the first commit
added pull the other way, so they are removed:

- The "App" label on each tile. #2063 puts a category badge in that
  corner and has no such label.
- The right-pointing hover arrow on app tiles. #2063 keeps the same
  arrow for apps and workflows.

The tiles now look exactly as they did before this branch. Only what
they list and what a click does has changed.

When the apps cannot be loaded, Home now says "Apps couldn't be loaded.
Check your connection and try again." in the same one-line block the
workflows use. home.appsUnavailable, home.openApp and home.showApp have
the keys and the English and Chinese text #2063 adds, so that draft has
nothing to reconcile here later.
benceruleanlu added a commit that referenced this pull request Nov 14, 2026
… in Desktop (DESK-285) (#2098)

* fix(home): list the published apps in the Home carousel and open them in Desktop (DESK-285)

Home's carousel listed twelve Comfy Hub workflows from the Cloud catalog
and opened each one on comfy.org in the browser. The Apps page lists
something else: the apps in the website's apps.json. So the carousel did
not show what is published, and a tile took the person out of Desktop.

The carousel now asks for the same list the Apps page asks for
(apps:list). The website decides which apps show and in what order, and
Home keeps no list of its own. The tile in front opens that app on the
Apps page, through the host its cards already use, so the sidebar folds
and "All apps" leads back to the cards the same way.

What Home shows in each case:

- Apps on, list loading: the three placeholder cards it already had.
- Apps on, list loaded: the apps, each marked "App" as in the Home frame.
- Apps on, list empty: "No apps yet", the Apps page's own words.
- Apps on, list failed: "Apps didn't load" with Try again. Desktop keeps
  the last list it loaded, so this shows only when none has loaded since
  Desktop started.
- Apps off, or Desktop cannot tell: the example workflows that open on
  Comfy Hub, as before Apps. With the switch off there is no Apps page
  to open an app on.

HomeWorkflowCarousel becomes HomeCarousel and takes either kind of card.
Its test ids go from home-workflow-* to home-carousel-*.

The "See all" link is left alone. #2084 renames it and points it at the
Apps page, and this change stays clear of the lines that one edits so
the two merge either way round.

* refactor(home): look up the Apps switch once for the carousel and See all apps

With #2084 merged, Home asked whether Apps is on twice: once for the
"See all apps" link and once for the carousel. Both now read the one
answer the carousel already had.

The first commit put a check inside loadWorkflows so that it would not
touch the lines #2084 edits. That is no longer needed. Home now loads
the example workflows when the Apps switch turns out to be off, and
loadWorkflows only loads.

* fix(home): keep the carousel tiles as they were, and use the planned wording when apps fail to load

Checked against Mar's open draft #2063, which shows where Home is going
(Apps | Workflows tabs over this carousel). Two things the first commit
added pull the other way, so they are removed:

- The "App" label on each tile. #2063 puts a category badge in that
  corner and has no such label.
- The right-pointing hover arrow on app tiles. #2063 keeps the same
  arrow for apps and workflows.

The tiles now look exactly as they did before this branch. Only what
they list and what a click does has changed.

When the apps cannot be loaded, Home now says "Apps couldn't be loaded.
Check your connection and try again." in the same one-line block the
workflows use. home.appsUnavailable, home.openApp and home.showApp have
the keys and the English and Chinese text #2063 adds, so that draft has
nothing to reconcile here later.

* fix(home): use an app picked on Home once, so it cannot reopen later

After opening an app from a Home tile, the panel kept that pick until
the person left the Apps page. Going to Benchmarks or Performance test
changes the panel but not the page, so the pick survived. Clicking Apps
in the sidebar then mounted the Apps page again and it opened the same
app, even one the person had already closed with "All apps".

The Apps page now takes the pick when it opens and hands the slot back
empty straight away (startWith is a v-model). Nothing can replay it,
whichever way the person leaves and comes back. The watcher in PanelApp
that emptied the slot on a page change is removed, because the slot is
already empty by then.

Two journeys in PanelApp.test.ts cover it and both failed before the
fix: open from Home, close, visit Benchmarks, open Apps; and the same
with the app left open.

Found by Benjamin and by CodeRabbit on #2098.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant