Repository navigation
feat(explore): Apps becomes Explore with Apps and Workflows; Home gets Apps | Workflows tabs - #2063
Draft
mariana953 wants to merge 8 commits into
Draft
mariana953 wants to merge 8 commits into
mariana953 wants to merge 8 commits into
Conversation
…nd give Home's carousel Apps and Workflows tabs
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
…nt card, and the image glyph on a glass badge
… use case and model, sort and card size
Filters opens one submenu per group with an uppercase row and its value, a search on top of the Model list, and Clear filters with Cmd+Backspace. Runs on uses the builds' computer and cloud icons. The view menu is a Size stepper and a Sort by row. The search field has the Cmd+/ hint and a clear button.
benceruleanlu
added a commit
that referenced
this pull request
Nov 14, 2026
…wording when apps fail to load Checked against Mar's open draft #2063, which shows where Home is going (Apps | Workflows tabs over this carousel). Two things the first commit added pull the other way, so they are removed: - The "App" label on each tile. #2063 puts a category badge in that corner and has no such label. - The right-pointing hover arrow on app tiles. #2063 keeps the same arrow for apps and workflows. The tiles now look exactly as they did before this branch. Only what they list and what a click does has changed. When the apps cannot be loaded, Home now says "Apps couldn't be loaded. Check your connection and try again." in the same one-line block the workflows use. home.appsUnavailable, home.openApp and home.showApp have the keys and the English and Chinese text #2063 adds, so that draft has nothing to reconcile here later.
benceruleanlu
added a commit
that referenced
this pull request
Nov 14, 2026
… in Desktop (DESK-285) (#2098) * fix(home): list the published apps in the Home carousel and open them in Desktop (DESK-285) Home's carousel listed twelve Comfy Hub workflows from the Cloud catalog and opened each one on comfy.org in the browser. The Apps page lists something else: the apps in the website's apps.json. So the carousel did not show what is published, and a tile took the person out of Desktop. The carousel now asks for the same list the Apps page asks for (apps:list). The website decides which apps show and in what order, and Home keeps no list of its own. The tile in front opens that app on the Apps page, through the host its cards already use, so the sidebar folds and "All apps" leads back to the cards the same way. What Home shows in each case: - Apps on, list loading: the three placeholder cards it already had. - Apps on, list loaded: the apps, each marked "App" as in the Home frame. - Apps on, list empty: "No apps yet", the Apps page's own words. - Apps on, list failed: "Apps didn't load" with Try again. Desktop keeps the last list it loaded, so this shows only when none has loaded since Desktop started. - Apps off, or Desktop cannot tell: the example workflows that open on Comfy Hub, as before Apps. With the switch off there is no Apps page to open an app on. HomeWorkflowCarousel becomes HomeCarousel and takes either kind of card. Its test ids go from home-workflow-* to home-carousel-*. The "See all" link is left alone. #2084 renames it and points it at the Apps page, and this change stays clear of the lines that one edits so the two merge either way round. * refactor(home): look up the Apps switch once for the carousel and See all apps With #2084 merged, Home asked whether Apps is on twice: once for the "See all apps" link and once for the carousel. Both now read the one answer the carousel already had. The first commit put a check inside loadWorkflows so that it would not touch the lines #2084 edits. That is no longer needed. Home now loads the example workflows when the Apps switch turns out to be off, and loadWorkflows only loads. * fix(home): keep the carousel tiles as they were, and use the planned wording when apps fail to load Checked against Mar's open draft #2063, which shows where Home is going (Apps | Workflows tabs over this carousel). Two things the first commit added pull the other way, so they are removed: - The "App" label on each tile. #2063 puts a category badge in that corner and has no such label. - The right-pointing hover arrow on app tiles. #2063 keeps the same arrow for apps and workflows. The tiles now look exactly as they did before this branch. Only what they list and what a click does has changed. When the apps cannot be loaded, Home now says "Apps couldn't be loaded. Check your connection and try again." in the same one-line block the workflows use. home.appsUnavailable, home.openApp and home.showApp have the keys and the English and Chinese text #2063 adds, so that draft has nothing to reconcile here later. * fix(home): use an app picked on Home once, so it cannot reopen later After opening an app from a Home tile, the panel kept that pick until the person left the Apps page. Going to Benchmarks or Performance test changes the panel but not the page, so the pick survived. Clicking Apps in the sidebar then mounted the Apps page again and it opened the same app, even one the person had already closed with "All apps". The Apps page now takes the pick when it opens and hands the slot back empty straight away (startWith is a v-model). Nothing can replay it, whichever way the person leaves and comes back. The watcher in PanelApp that emptied the slot on a page change is removed, because the slot is already empty by then. Two journeys in PanelApp.test.ts cover it and both failed before the fix: open from Home, close, visit Benchmarks, open Apps; and the same with the app left open. Found by Benjamin and by CodeRabbit on #2098.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Desktop's Apps page becomes Explore, with two tabs: Apps and Workflows (the Hub's workflows). On Home, the carousel gets the same kind of tabs, Apps | Workflows, so people can browse either one without leaving Home. Home's arc cards show just their title and, on the front card, an arrow to open it. Cards show what they make (Image, Video, 3D or Audio), both Explore tabs share one toolbar (search, filters, sort, card size), and switching Home's tabs fades smoothly instead of jumping.
Summary
SegmentedControl). Apps is the current gallery and app host, unchanged. Workflows is a grid of the catalog's workflows; a card opens it on the Hub. With the remote apps switch off, Explore shows Workflows only.rgb(14 14 16 / 0.28), blur 14px, saturate 1.5); Image uses the design system's image glyph (ImageGlyph). It reads read from the catalog (an item's output kind, else its generation type). One sharedCategoryBadge. No badge when the catalog doesn't say: today that is every app, since the production catalog's apps carry neither field.recommendedRank. What the catalog lacks today: apps carry no category, use case or model, so the Apps tab has search, sort and size but no Filters; every workflow isCLOUD, so Runs on is left out until some run locally; there is no date, so there is no Newest sort.useAppsEnabled, unchanged.Before / After
Change breakdown
src/main/apps/catalog.ts,src/main/catalog/category.ts,src/main/catalog/workflows.ts,src/renderer/src/components/ImageGlyph.vue,src/renderer/src/composables/useAppsEnabled.ts,src/renderer/src/panel/AppSidebar.vue,src/renderer/src/panel/AppsGallery.vue,src/renderer/src/panel/AppsView.vue,src/renderer/src/panel/CategoryBadge.vue,src/renderer/src/panel/ExploreFilter.vue,src/renderer/src/panel/ExploreSearchField.vue,src/renderer/src/panel/ExploreViewOptions.vue,src/renderer/src/panel/HomeView.vue,src/renderer/src/panel/PanelApp.vue,src/renderer/src/panel/TemplatesGallery.vue,src/renderer/src/panel/exploreCards.ts,src/renderer/src/panel/exploreTab.ts,src/renderer/src/panel/home/HomeWorkflowCarousel.vue,src/renderer/src/panel/home/carouselCard.ts,src/renderer/src/types/ipc.ts,src/types/ipc.tssrc/main/apps/catalog.test.ts,src/main/catalog/category.test.ts,src/main/catalog/workflows.test.ts,src/renderer/src/panel/AppSidebar.test.ts,src/renderer/src/panel/AppsView.test.ts,src/renderer/src/panel/HomeView.test.ts,src/renderer/src/panel/PanelApp.test.ts,src/renderer/src/panel/exploreCards.test.tslocales/en.json,locales/zh.jsonTesting
exploreCards.test.tscovers rank order, when a group is offered, and model order.npm run typecheck:web,npm run typecheck:node, eslint and prettier pass on touched files.rgba(14,14,16,0.28)withblur(14px) saturate(1.5)), See all, Explore on both tabs, badges, the toolbar in the same spot on both tabs (search box measured at the same position), the Filters menu with live data, the Model submenu search, picking a use case, the view menu and the Sort by submenu. Not checked: light theme, Windows, Linux, the apps switch off in the built app.