Skip to content

feat(home): prev/next arrows and an Open button on the workflow carousel - #2041

Merged
benceruleanlu merged 3 commits into
Comfy-Org:mainfrom
mariana953:mar/home-carousel-arrows-cta
Nov 13, 2026
Merged

benceruleanlu merged 3 commits into
Comfy-Org:mainfrom
mariana953:mar/home-carousel-arrows-cta

Conversation

@mariana953

@mariana953 mariana953 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

The Home page shows example workflows as a fan of cards you can spin. Until now you had to drag it, use the keyboard or click a side card to turn it, and nothing told you the front card opens. This adds two quiet arrows at the ends of the fan, and an Open button that appears on the front card when you point at it.

Summary

  • Prev / next arrows at the two ends of the arc, past the side cards, as on the prototype (Pablo's "Open designs for Desktop" asks):
    • Bare chevrons in a 36px hit area with a 20px icon, in muted-foreground.
    • Opacity is 50% at rest, 90% while the pointer is on the carousel, and 100% on hover or focus, with a soft square background (foreground 7%, 8px radius).
    • Hidden when there is only one workflow. On a short list that doesn't wrap, the arrow at the end you've reached hides.
    • The aria-labels "Previous workflow" / "Next workflow" are in en and zh.
  • Open button on the front card: a white pill with dark text at the bottom right, shown on hover or keyboard focus. It sits inside the card button and opens the same workflow as clicking the card (same open emit). It is aria-hidden because the card already says "Open {title} on Comfy Hub".
    • It says Open, not the prototype's Run, because the card opens the workflow on Comfy Hub and doesn't run it.
    • The button only takes space while it's shown, so at rest the front card's title and description show in full, as before.
  • Roomier link hover: "See all workflows" and "All builds" had a cramped hover (24px tall, 6px side padding). It's now 32px tall with 12px side padding and an 8px radius. The "All builds" hover lines up with the right edge of the build cards.
  • Nothing lost: drag, clicking a side card, ← → keys, wrap-around and the reduced-motion behaviour all work as before. Under reduced motion, the arrows and the button appear without a transition.

Before / After

Desktop's panel is dark-only on main (resolveTheme() always returns 'dark'), so there's no light state to capture.

Before After
At rest before after at rest
Pointer on the front card before after, Open shown
Pointer on an arrow (no arrows) after, arrow hover
Hover on See all workflows before after
Hover on All builds before after

Follow-up

  • Apps instead of workflows. The prototype's carousel shows apps that open on click. This keeps main's data source (catalog workflows). Switching it to apps is a separate decision and will be a separate PR.

Telemetry

No new events. The arrows only turn the carousel, and Open goes through the same openCatalogWorkflow call as clicking the card, so no existing event changes.

Test plan

  • pnpm format:check, pnpm lint, pnpm typecheck, pnpm test (8278 passed)
  • New tests: the arrows turn the carousel both ways and wrap without opening anything. On a short list they stop at the ends, and with one card they're left out. Open shows on the front card only and opens that workflow.
  • Checked in the built app: the arrows sit at 50% at rest, 90% with the pointer on the carousel and 100% with the background on hover. Open appears on hover, and the title shows in full at rest. The See all workflows and All builds hovers measure 32px tall.
  • Not behind a flag: it's a small UI change to an existing surface and changes no behaviour.

Bare chevrons at both ends of the arc, dimmed until the pointer is on the
carousel, and a white Open pill on the front card on hover or focus that
opens the same workflow as clicking the card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The home workflow carousel adds previous and next controls, non-wrapping endpoint states, and an Open action on the front card. English and Simplified Chinese labels and tests cover the controls and action. Home link styling also changes.

Changes: Home workflow carousel

Layer / File(s) Summary
Carousel navigation controls
src/renderer/src/panel/home/HomeWorkflowCarousel.vue, locales/en.json, locales/zh.json, src/renderer/src/panel/HomeView.test.ts
Adds previous and next buttons with translated labels. The buttons navigate between workflows and are disabled at the ends when wrapping is off. Focus moves to an available control or the current card after navigation. Tests cover navigation, focus, endpoint states, and omission of the controls for a single workflow.
Front-card Open action and presentation
src/renderer/src/panel/home/HomeWorkflowCarousel.vue, src/renderer/src/panel/HomeView.test.ts, src/renderer/src/panel/HomeView.vue
Places each card’s title and optional description beside the action area. The front card shows an Open action on hover or focus. Tests verify that the action opens the front workflow. Home link styling also changes.

Possibly related PRs

Merge Risk: Minimal · up to e9396

This change adds previous/next arrows and an Open button to the Home workflow carousel, and enlarges the hover area on two links. No concrete merge-blocking risk was found. Browser behavior was not independently executed.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Create a new PR
Simplify code

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c742d817-ee31-4afd-b9f6-daa45702937b
Commits

Reviewing files that changed from the base of the PR and between 6bfc772 and e93962f.

Files selected for processing: 3

  • src/renderer/src/panel/HomeView.test.ts
  • src/renderer/src/panel/HomeView.vue
  • src/renderer/src/panel/home/HomeWorkflowCarousel.vue

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@mariana953 mariana953 added the cursor-review Trigger multi-model Cursor code review label Nov 12, 2026
@mariana953
mariana953 marked this pull request as ready for review November 12, 2026 15:51
@mariana953
mariana953 requested review from a team as code owners November 12, 2026 15:51
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mariana953 added a commit to mariana953/Comfy-Desktop that referenced this pull request Nov 12, 2026
mariana953 added a commit to mariana953/Comfy-Desktop that referenced this pull request Nov 12, 2026
…y-Org#2041

All builds and See all apps get the roomier hover Comfy-Desktop#2041
ships: 32px tall, 12px side padding, 8px radius. The arc's arrows and
Open button already matched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- When an arrow turns a short list to its end and becomes disabled, focus
  moves to the other arrow instead of falling to the page body.
- Left/right keys now work from the arrow buttons too: the key handlers
  sit on the wrapper around the list and the arrows.
- Turning with the keys while a card has focus moves focus to the new
  front card, so Open shows on it and focus never stays on a card that
  slid offstage.
- The two arrows render from one list instead of two copied buttons.
- "See all workflows" gets the same -my-1 as "All builds", so the
  taller hover area no longer pushes the Builds section down.
@benceruleanlu
benceruleanlu added this pull request to the merge queue Nov 12, 2026
Merged via the queue into Comfy-Org:main with commit 8231fe5 Nov 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants