Skip to content

feat(builds): New build as the shared split button - #2040

Merged
benceruleanlu merged 1 commit into
Comfy-Org:mar/home-open-build-pickerfrom
mariana953:mar/builds-new-build-split
Nov 12, 2026
Merged

benceruleanlu merged 1 commit into
Comfy-Org:mar/home-open-build-pickerfrom
mariana953:mar/builds-new-build-split

Conversation

@mariana953

@mariana953 mariana953 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Merge order: #2030 first, then this PR. It's stacked on #2030, which adds SplitButton.vue; until that merges, the diff also shows its commits and only the last commit belongs here. After #2030 merges, retarget this PR to main.

ELI5

The New build button on Builds now has the same thin line between "New build" and its arrow as every other split button.

Summary

  • The New build button on Builds uses the shared components/ui/SplitButton.vue instead of its own two buttons, so it gets the full-height 1px divider, the 30px chevron half and the same hover and open states as Open ComfyUI on Home.
  • Same handler, same menu items (Add Existing Build, Load Snapshot), same test ids and class hooks (chooser-tile-new, build-actions-*).

Before / after

Before After After, menu open

No functionality added or removed

UI only. The main half still calls handleNewInstallClick; the menu items emit the same show-build-import events.

Telemetry

Unchanged.

Test plan

  • ChooserView.test.ts (65 passed)
  • typecheck, eslint, prettier
  • Checked in the built app: closed and menu open

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fa0b42da-f878-4c12-87ae-1ff47eb76419

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mariana953 mariana953 added the cursor-review Trigger multi-model Cursor code review label Nov 12, 2026
@mariana953
mariana953 marked this pull request as ready for review November 12, 2026 13:00
@mariana953
mariana953 requested review from a team as code owners November 12, 2026 13:00
@mariana953 mariana953 added cursor-review Trigger multi-model Cursor code review and removed cursor-review Trigger multi-model Cursor code review labels Nov 12, 2026
@mariana953
mariana953 changed the base branch from main to mar/home-open-build-picker November 12, 2026 13:55
mariana953 added a commit to mariana953/Comfy-Desktop that referenced this pull request Nov 12, 2026
…mfy-Org#2040

Its chevron holds Add Existing Build and Load Snapshot, as on Desktop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@benceruleanlu
benceruleanlu merged commit 3821abe into Comfy-Org:mar/home-open-build-picker Nov 12, 2026
32 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants