Repository navigation
feat(builds): New build as the shared split button - #2040
Merged
benceruleanlu merged 1 commit intoNov 12, 2026
Merged
benceruleanlu merged 1 commit into
benceruleanlu merged 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
mariana953
marked this pull request as ready for review
November 12, 2026 13:00
4 of 5 tasks
mariana953
added a commit
to mariana953/Comfy-Desktop
that referenced
this pull request
Nov 12, 2026
…mfy-Org#2040 Its chevron holds Add Existing Build and Load Snapshot, as on Desktop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
benceruleanlu
approved these changes
Nov 12, 2026
benceruleanlu
merged commit Nov 12, 2026
3821abe
into
Comfy-Org:mar/home-open-build-picker
32 of 39 checks passed
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
The New build button on Builds now has the same thin line between "New build" and its arrow as every other split button.
Summary
components/ui/SplitButton.vueinstead of its own two buttons, so it gets the full-height 1px divider, the 30px chevron half and the same hover and open states as Open ComfyUI on Home.chooser-tile-new,build-actions-*).Before / after
No functionality added or removed
UI only. The main half still calls
handleNewInstallClick; the menu items emit the sameshow-build-importevents.Telemetry
Unchanged.
Test plan
ChooserView.test.ts(65 passed)