Skip to content

style(builds): New build as the shared split button (re-apply #2040) - #2064

Merged
benceruleanlu merged 1 commit into
Comfy-Org:mainfrom
mariana953:mar/new-build-split-button-main
Nov 13, 2026
Merged

benceruleanlu merged 1 commit into
Comfy-Org:mainfrom
mariana953:mar/new-build-split-button-main

Conversation

@mariana953

Copy link
Copy Markdown
Contributor

ELI5

The New build button on Builds now has the same thin line between "New build" and its arrow as every other split button.

Summary

Before / after

Before After After, menu open

No functionality added or removed

UI only. The main half still calls handleNewInstallClick; the menu items emit the same show-build-import events. Telemetry unchanged.

Test plan

  • Unit tests: 8342 passed
  • typecheck, eslint, prettier

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

ChooserView.vue replaces the separate new-build button and Menu trigger with SplitButton. The component receives the existing state, labels, test ID, and new-build action. Existing menu items remain in its menu slot.

Changes: Chooser Split Button

Layer / File(s) Summary
Replace chooser controls
src/renderer/src/views/ChooserView.vue
ChooserView imports SplitButton and uses it for the new-build action and existing menu items. It removes the Menu and ChevronDown imports.

Suggested reviewers: benceruleanlu

Merge Risk: Minimal · up to 6adb8

The Builds page's New build control now uses the shared split button. The action and menu items are unchanged, and no merge-blocking risk was identified.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Create a new PR
Simplify code

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 46e13e65-b247-4d48-8946-981fb24688c7
Commits

Reviewing files that changed from the base of the PR and between 7709dc4 and 6adb823.

Files selected for processing: 1

  • src/renderer/src/views/ChooserView.vue

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@benceruleanlu
benceruleanlu added this pull request to the merge queue Nov 13, 2026
Merged via the queue into Comfy-Org:main with commit b0a1587 Nov 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants