Repository navigation
style(downloads): uppercase label and no divider lines in the downloads popup - #2017
Merged
benceruleanlu merged 1 commit intoNov 11, 2026
Merged
Conversation
…ds popup Same change as Comfy-Org#2012, now based on main instead of the closed Comfy-Org#1981. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 32 minutes for your next included review. View limit details
|
benceruleanlu
approved these changes
Nov 11, 2026
mariana953
added a commit
to mariana953/Comfy-Desktop
that referenced
this pull request
Nov 12, 2026
Uppercase Downloads label, no divider lines, rows on a card fill with the progress through them, and View All Downloads as a menu-style row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #2012, which was stacked on #1981 (now closed). Same change, now based on
main.ELI5
The downloads popup was the only popup still drawn the old way: a bold title with a line under it and a line over the footer. Now it reads like the rest of the new UI: a small uppercase label on top, no divider lines, and the footer link behaves like a menu row.
Summary
Context
Only
DownloadsView.vuechanges; the popup height is still measured from the header, list and footer, so it shrinks to fit.Before / after
Before is current
main.No functionality added or removed
Same markup hooks (
.downloads-head,.downloads-title,.downloads-foot,.downloads-link), same handlers, same strings.Test plan
comfyTitlePopuptests pass (107), eslint, prettier🤖 Generated with Claude Code