Skip to content

style(downloads): uppercase label and no divider lines in the downloads popup - #2017

Merged
benceruleanlu merged 1 commit into
Comfy-Org:mainfrom
mariana953:mar/downloads-popup-main
Nov 11, 2026
Merged

benceruleanlu merged 1 commit into
Comfy-Org:mainfrom
mariana953:mar/downloads-popup-main

Conversation

@mariana953

Copy link
Copy Markdown
Contributor

Replaces #2012, which was stacked on #1981 (now closed). Same change, now based on main.

ELI5

The downloads popup was the only popup still drawn the old way: a bold title with a line under it and a line over the footer. Now it reads like the rest of the new UI: a small uppercase label on top, no divider lines, and the footer link behaves like a menu row.

Summary

  • Title becomes an uppercase section label (11px, letter-spaced, muted), the same style as the other section titles.
  • No divider lines under the header or over the footer; space separates them, per the "no lines" rule.
  • "View All Downloads" is a menu-style row: 32px high, 13px, same hover fill and radius as the ☰ menu items.
  • Download rows, progress, retry, close and the empty state are unchanged.

Context

Only DownloadsView.vue changes; the popup height is still measured from the header, list and footer, so it shrinks to fit.

Before / after

Before is current main.

Before After
before after

No functionality added or removed

Same markup hooks (.downloads-head, .downloads-title, .downloads-foot, .downloads-link), same handlers, same strings.

Test plan

  • comfyTitlePopup tests pass (107), eslint, prettier
  • Captured in the built app
  • With active and finished downloads, rows and progress look as before
  • View All Downloads opens the full downloads view

🤖 Generated with Claude Code

…ds popup

Same change as Comfy-Org#2012, now based on main instead of the closed Comfy-Org#1981.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 32 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d56219c3-3edc-4cc7-a4b8-3cd3a5f3afd1
Commits

Reviewing files that changed from the base of the PR and between 5a1ed06 and 4257103.

Files selected for processing: 1

  • src/renderer/src/comfyTitlePopup/DownloadsView.vue
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mariana953
mariana953 marked this pull request as ready for review November 11, 2026 18:15
@mariana953
mariana953 requested review from a team as code owners November 11, 2026 18:15
@benceruleanlu
benceruleanlu added this pull request to the merge queue Nov 11, 2026
Merged via the queue into Comfy-Org:main with commit 2c6e820 Nov 11, 2026
16 checks passed
mariana953 added a commit to mariana953/Comfy-Desktop that referenced this pull request Nov 12, 2026
Uppercase Downloads label, no divider lines, rows on a card fill with the
progress through them, and View All Downloads as a menu-style row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants