[siyabendoezdemir]

The finish-tabs lane finishes tabs, Today, folders, Favorites, Spaces and profiles. Most of their gaps waited on chrome's sidebar, the Settings window and the Library, which are on main now.

It's built from lanes/finish-tabs.md. Since then it has merged feel (PR #25), finish-views (PR #26), pages (PR #27), the sign-off marks (PR #28) and sign-offs 2 to 4 (PR #29); main is 9a30d3d. Against main it changes 118 files (+8538/−1000). The lane stopped near D30's 9k lines, and the review's two fix rounds added about 680 more.

The builder's report is reviews/lane-finish-tabs-report.md in the project's context folder.

What it builds

• Orbit's own row menus (TB-14, P0). The tab, pinned, Favorite, folder, multi-selection and split row menus open in Orbit's overlay, in the Space's colours.

  • An item that does what a key does shows that key from the live keymap (KS-18). While a menu is open, it takes the keys first (KS-19).
  • A menu anchors on its row's slot, and the row stays drawn while its menu is open (FL-21).
  • Tests read the menus through a row-menu test hook. The page menu stays native.

• Spaces and toasts (P0):

  • SP-02: the toast shown while the sidebar is hidden gets Show.
  • SP-14: ⌘Z after the theme picker reverts the theme.
  • SP-16 and SB-13: toasts take the Space's tint, and show over the page while the sidebar is hidden.
  • SP-15: the neutral theme shows the window's material where the platform has one. This completes SB-24. Linux and older Windows have none in Electron, so the neutral theme is solid there.

• TD-03: the per-profile archive timing, checked and tested. Archive periods apply at once.

• Drops (TB-09, NV-08):

  • a row dropped on a page's edge or centre makes a split (SV-04);
  • over a field that takes links, a row drops its URL there instead;
  • a link dragged from a page onto the sidebar opens as a tab where it lands.

• Blank windows (TB-17, which completes NV-10): KS-05's ⌃⌘N on macOS, and the command bar elsewhere.

• The recent-tab switcher (TB-05, FL-26). With ⌃Tab, the list shows at the second Tab or after 150 ms, with MD-11's sound and recording indicators. It switches when ⌃ is let go.

• Tab sleep (TB-16):

  • a background tab using half a core for 30 s is frozen;
  • low memory and the battery saver put tabs to sleep sooner.

  A sleeping tab costs 1.0 MB, against the spec's target of under 5 MB.

• Also:

  • tabs: Open as Split for a multi-selection (TB-13), and notes on a Favorite that plays sound (TB-15);
  • folders: full-colour folder icons (FD-07), and "Open " in the command bar (FD-09);
  • Spaces: ⌘Z for a Space reorder (SP-11), and Select Next and Previous Space (SP-22);
  • profiles: a deleted profile's folder removed from disk (PR-08), and the profile rename (PR-09);
  • keys: sidebar undo and redo in the keymap (KS-05).

• SV-26's sidebar part: two rows merge into one split row in place, and split back out, with the reorder spring.

• AR-11 (sign-off 2's gap 3, D82): a folder that comes back with its tabs draws its row in the same frame as them.

• Hardening:

  • the Recently Closed list holds only what the calling window may reopen (chrome fix check B, F2);
  • main shows or places no tab that an unfinished import hasn't shown (D66 (1), N2). This comes with a test of the restore's undo and redo (N1), and IM-14's crash note (N3);
  • ⌘W on a busy page that may warn shows the next tab at once (D77 (4)). The page comes back only if it warns;
  • pages fix check 2's follow-ups 1–3: the wording, D77 (4)'s limit while DevTools are attached, and the dead code.

• Built:

  • yes: TB-05, TB-13, TB-14, TB-15, TB-16, TB-17, PN-05 (Peek already covered it, so tests only), TD-03, FD-07, FD-09, SV-26, SP-02, SP-14, SP-15, SP-16, PR-08, PR-09, NV-10, SB-13 and SB-24.
  • partial:
    • TB-09: there's no drop into another window's sidebar, or into SP-13's overview.
    • KS-05: only ⌘⇧D is left, which is the look lane's.
    • NV-08: only SV-08's link drag onto a page's edge is left.
    • SP-11 and SP-22: their Library parts wait for SP-13.
    • PR-10: there are no passwords or site settings pages to act on yet.

• Left (D30): SP-13, large-state saves (PERF.md's open item), and the P2s TB-19, TB-21, FV-09, TD-07, FD-11 and SP-25. TD-08 and SP-26 are out of scope (D41).

Decisions where the spec was unclear

• TB-17, the blank window:
  • It uses a blank Space that stays out of the Space order, in the source window's profile, with a neutral theme.
  • Closing it archives its tabs. It's kept when it is the last window.
  • A Today tab dragged out moves. A pinned tab, a Favorite or a split pane goes as a copy.
  • It has no Spaces, pins, Favorites or folders, and finds only its own tabs.
• TB-05: the switch happens when ⌃ is let go, which replaces feel's live-switch test.
  • W keeps the list open.
  • Esc, a click outside, another action or losing focus cancels.
  • An unfinished import's tabs are left out (D65).
• TB-16:
  • A tab using half a core for 30 s (10 s with the battery saver) is frozen through the engine's page lifecycle.
  • Low memory (under 10 %, or under 1 GB) puts tabs idle for 5 min to sleep, even with the timer set to Never.
  • The battery saver (under 20 %) cuts the timer to a quarter, but never below 5 min.
• ⌘W: only a close that the pages lane takes over selects the next tab early, and never in a split pane. Undo shows the tab again in the windows that showed it.
• SV-26: it animates only when two or more rows of one list merge or separate. With reduced motion there's no animation.
• D87, what a page's drag may open in the sidebar (review follow-up 1): an http(s) address only, as the split drop already rules. Other text makes a search on the tab list or in a folder, and nothing on the Favorites. Every other scheme opens nothing.
• D88, a blank window's new-window links (review follow-up 8): ⇧-click, Open Link in New Window and a page's own request open a new blank window of the same profile, so the page keeps its session.
• Smaller calls:
  • SP-11: any reorder of the Spaces can be undone.
  • TB-15: the notes show on any Favorite that is playing sound.
  • PR-08: the profile's folder is removed at once, and again at the next launch, and only inside Partitions.
  • F2: closed tabs are filtered by the calling window, with no fallback to the focused one.
  • A blank Space found at launch without its window has its tabs archived, as when a blank window closes.

Edits in other lanes' files

• Files feel-fix owns since D80 (small, so they may conflict when feel-fix merges):
  • peek/index.ts: the undo key;
  • miniwindow/index.ts: newBlank;
  • split/index.ts: the menu hook;
  • commandbar/: rank, search and sources;
  • SplitRow.tsx and SplitFavoriteTile.tsx: menuAt.
• The review's fix round:
  • the import lane's import/unplaced.ts, which now holds hiddenByImport, and renderer/import/sidebar.ts;
  • feel-fix's split/index.ts and miniwindow/index.ts: the D66 guard's calls only;
  • nav/new-window.ts (D88), persist.ts, and shared/link-drop.ts, Sidebar.tsx and drag.ts (D87).
• Fix round 2:
  • feel-fix's split/index.ts: split.focusPane's guard, and Change Icon… focusing the sidebar first;
  • the import lane's renderer/import/sidebar.ts and import-file.spec.ts: where a dropped file's fallback text lands (F4);
  • docs/FEEL.md: FL-22's line.
• Pages:
  • pages/gestures.ts: a comment only;
  • ARCHITECTURE.md: the wording, and the DevTools limit;
  • pages-gestures.spec.ts: a test for a pop-up window's own opens;
  • pages-support.ts: /opener takes as;
  • a test title in pages-gestures.test.ts;
  • the NV-24 and NV-09 notes.
• Shared files:
  • main: context, index, material (new), menu, nav, persist and windows, and the shell preload;
  • renderer: the overlay app, the Library app, the profiles section, the shell app, toasts, the split engine and useTabDrop, global.css, the theme and shortcuts;
  • shared: actions, blank, commands, private, rpc, state, theme and toast;
  • docs/FEEL.md.
• Other lanes' tests:
  • finish-views.spec.ts's three split-row menu tests read the overlay now (1cd4832);
  • feel-rows.spec.ts's budgets are judged on the best of three rounds (e4ff9d7, D46);
  • TB-05's test replaces feel's live-switch test.
• Other lanes' notes: IM-14, AR-11, SV-26, FL-09 and KS-19. CB-13's note is out of date (it says New Blank Window isn't built). It's feel-fix's row, so feel-fix updates it.

Merge gate (D42, local)

Gate r4 ran on this exact head, dce14c5, on the VPS (Linux, under Xvfb), from 21:47 to 22:32 UTC. The lead ran it with the gate script:

npm run build && npm run typecheck && npm run lint && ./node_modules/.bin/vitest run
xvfb-run -a -s "-screen 0 1440x900x24" ./node_modules/.bin/playwright test --workers 1 --retries 0 --reporter=line

• Build, typecheck and lint: exit 0.
• Unit: 112 files, 1085/1085 passed.
• E2E: 814 passed, 2 skipped, 0 failed. Exit 0, 44.7 min, load 5.0 → 6.5. The 2 skips are nav.spec's macOS-only key tests.
• Earlier gates:
  • r3, on 24fde53 (fix round 1's head): 812 passed, 2 skipped, 0 failed (45.1 min).
  • r2, on fb3297b (the head the review read): 805 passed, 2 skipped, 0 failed (44.4 min).
  • r1, on dbca55d: 803 passed, 2 failed, 2 skipped.
    • downloads.spec.ts:577 (DL-03) passed when rerun alone. As a new row arrives, the old row is still fading out, and the test's strict locator finds both. The finish-downloads lane fixes that test.
    • import-file.spec.ts:397 was real: the N2 guard refused the test's own step that places a hidden import tab. fb3297b turns the guard off for that step through its test hook, as import-unplaced.spec.ts already does.
• D18: each fix fails a named test without it. The lane report and both fix rounds' reports list each one. The fix check also cut all of round 1's fixes at once, and all 13 of the matching tests failed.
• Unverified (not run here):
  • the window's material on macOS and Windows (tested on Linux with a stand-in);
  • the macOS haptic tick;
  • a page really freezing: pages don't freeze under Playwright, so TB-16's freezing is tested through hooks;
  • nav.spec's two macOS-only key tests.

Review

• Review: REQUEST CHANGES, 5 must-fix (an independent reviewer, reviews/lane-finish-tabs.md), each reproduced:

  1. split.create, split.addTab, split.openUrl and mini.fromTab still showed a tab an unfinished import hadn't shown (D66 (1)).
  2. An open Peek's page could be frozen and put to sleep (TB-16). Main then threw on every Peek layout.
  3. A row menu closed by Enter, a click or a bound key gave the keyboard to the page, even when it was opened from the sidebar (KS-19).
  4. A page could read the address of a row dragged across it, with no drop (TB-09).
  5. No test failed without 3a's filter in the tabs.recentlyClosed command (D18).

• Fix round 1 (860426c, 24fde53; reviews/lane-finish-tabs-fix1-report.md) fixes all five. Each fix has a test that failed with it taken out. It also takes these follow-ups:

  • D87's sidebar drops and D88's blank-window links (above);
  • FL-26's test budget is now the spec's one frame, and FD-07's check takes the best of three (D46);
  • FEEL.md's FL-22 entry drops the two exceptions SB-13 and SP-16 ended;
  • a blank Space found without its window at launch has its tabs archived.

• Routed to other lanes:

  • the Peek layout's own guard for a page that has gone goes to feel-fix (its item 9, pushed), which rewrote that code;
  • the blank window's command bar goes to finish-downloads (item 12), with its private-window filter;
  • CB-13's note goes to feel-fix.

• A side effect of must-fix 2: an open Peek's page counts as on screen, so the media tray doesn't list it while the Peek shows.

• Fix check: APPROVE WITH FIXES, 1 must-fix (reviews/lane-finish-tabs-fixcheck.md). All five must-fixes held, and each round-1 test failed with its fix cut.

  • The must-fix [reproduced]: split.focusPane still showed a tab an unfinished import hadn't shown (D66 (1)). Every other command in its sweep of src/main refuses one.
  • Follow-ups:
    • F1: a split row's Change Icon…, chosen from a menu opened while the page had the keyboard, left the keyboard in the page.
    • F2: FEEL.md's FL-22 line left out one of its two exceptions.
    • F3: a playing Peek replaced by another overlay makes the media code ask for the floating player. It's harmless as the Peek's page is gone first. It goes to feel-fix, which owns src/main/media/.
    • F4: a dropped bookmarks file that can't be read fell back to its drag's text as if dropped on the tab list, wherever it landed.
    • F5, a nit: a page reads a row drag's effectAllowed as none. Left as is.

• Fix round 2 (dce14c5; reviews/lane-finish-tabs-fix2-report.md):

  • split.focusPane accepts only a pane of a split, and N2's test now sends it a hidden tab;
  • F1: Change Icon… on a split row gives the sidebar the keyboard first, as Rename… does;
  • F2: FEEL.md's FL-22 line names both exceptions, as FL-22's note does;
  • F4: a dropped file's fallback text is judged by where it lands, so on the Favorites, text that isn't an address opens nothing (D87 (3)).

  Each code fix's test failed with its fix taken out.

• Fix check 2: APPROVE, no must-fix (reviews/lane-finish-tabs-fixcheck2.md).

  • The must-fix, F1, F2 and F4 hold. split.focusPane refuses a hidden import tab, and any tab outside a split; every sender passes a pane, and Focus Pane and the pane drop still work.
  • Cutting the three code fixes at once failed all five matching tests. The four regression specs passed (109 tests).
  • Its one follow-up is wording: FL-22's note says only a toast with a button waits while hovered, which holds only at the sidebar's foot. It goes to the look lane's one toast system (AP-14).

🤖 Generated with Claude Code

---

Note

Medium Risk
Wide changes to tab lifecycle, persistence, command bar, and import visibility affect core browsing flows, though the lane reports extensive unit/e2e coverage rather than security-critical paths.

Overview
This PR marks a large batch of finish-tabs work: the generated FEATURES.md checklist moves many P0/P1 items from partial to built, with matching behavior notes across sidebar, tabs, Spaces, profiles, and import.

Tabs and chrome: Sidebar rows get Orbit-themed overlay context menus (with keymap hints and keyboard handling). Blank windows use a profile-scoped hidden Space (not in the switcher), ⌃⌘N / command-bar entry, cascade + command bar on open, and archive-on-close persistence rules. The ⌃Tab recent-tab switcher shows a themed overlay list and switches on ⌃ release. Tab sleep adds engine page freezing for busy background tabs, plus low-memory and battery-saver paths. Drag-and-drop extends to split creation, dropping URLs into link-capable fields, and opening http(s) links dragged onto the sidebar.

Spaces, profiles, and polish: Neutral theme can show macOS vibrancy / Windows Mica via new windowMaterial(). Theme picker edits support ⌘Z undo; toasts are Space-tinted and, when the sidebar is hidden, appear over the page card with optional Show actions (new tabs, new Spaces). Profile delete clears session data and removes partition folders (with a relaunch cleanup list). Space reorder is undoable; command bar gains “Open <folder>” matching and blank-window tab/Space filtering.

Guards and docs: Unfinished import tabs are hidden from activation paths via hiddenByImport. Small updates to page gesture rules (website-first shortcuts count as gestures; ⌘W busy-close behavior documented). docs/ARCHITECTURE.md and docs/FEEL.md reflect switcher and toast motion measurements.

^{Reviewed by Cursor Bugbot for commit dce14c5. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 9f34dd0d-419a-4543-b7e4-9231a1e7e2d4)

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 4d9d343e-485b-4439-beca-2c294252e670)

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 377bf970-3a3f-40a9-a562-fdbdca7f0bf4)