[siyabendoezdemir]

The tweaks lane builds Tweaks (D36): per-site changes to how a site looks and behaves. They're made in a small editor over the live page and applied before the page's first paint.

It's built from lanes/tweaks.md on main at 62f6fd6. Since then it has merged pages (PR #27, at 1ccdbad), the sign-off marks (PR #28, at 73eb3f9), PR #29 (at d2e22b1) and finish-tabs (PR #31, at 8d3201a); main is 21487aa. Against main it changes 62 files (+11765/−43). The builder stopped after item 4, near D30's 9k lines, so item 5's BO-19 and BO-20 are left.

The reports are in the project's context folder: reviews/lane-tweaks-report.md for the lane, and lane-tweaks-fix1-report.md, -fix2-report.md and -fix3-report.md for the three fix rounds.

What it builds

• A section registry for the site controls panel (D37). It's in a commit of its own (e1bd19d), so other features can add rows to the panel. The extensions lane uses it next.
• New Tweak and the editor (BO-01, BO-02):
  • New Tweak opens from the command bar (also "customize", "customization" and "site style"), the sidebar's + menu, the site controls panel, the address field's paintbrush and the tab menu. None is bound to a key (KS-18).
  • The editor is a small view of its own over the page's top-right corner. The page around it stays live, and every change shows at once and is saved.
• Before first paint (BO-18): the page preload asks main for the site's sheets, so no frame shows the page without its Tweak. Tweaks survive reloads, back and forward, a reopened tab, a woken tab and a restart.
• CSS and JavaScript (BO-11): CSS applies as it's typed, on a page that's still loading too.
  • JavaScript runs from main in the page's own world, once per load at document ready, and checks the page's host before it runs.
  • It runs only where the user allows it on this device, and editing it never allows it.
• On and off, scope and the command bar (BO-14, BO-17, BO-21):
  • each Tweak's switch in the site controls panel, and the address field's paintbrush;
  • the host, with an "Also apply to subdomains" box, and private windows;
  • the command bar's Tweak actions. A Mini Window's page takes no Tweak: its Tweak keys say why, in the window where View Tweaks opens the Library.
• The no-code controls (BO-03 to BO-10, BO-12, BO-13):
  • colour: the colour wheel with its accent handle, invert, the Contrast, Brightness and saturation sliders, and reset;
  • text and layout: eight font presets, page size and text case;
  • Hide-element mode. On a page that's still loading, it shows at once that it's starting, and goes in when the load ends unless Done, Esc (in the panel or the page) or another document ends it first (D89);
  • the name menu (Rename, Reset all edits) and Shuffle.
• The Library's Tweaks (BO-15), each with its switch and menu. The switch for all of them (BO-16) is in Settings → Advanced.
• Built:
  • yes: BO-01 to BO-06 and BO-08 to BO-17.
  • partial:
    • BO-07: the presets are font stacks of what the system has, so nothing is bundled. Rounded and Hand fall back on Linux.
    • BO-18: all but the Space colours, which come with BO-19.
    • BO-21: all but Export Tweak…, which comes with BO-20.
• Left: BO-19 (Space colours as variables in a Tweak's sheet) and BO-20 (export and import as a local file), both P2. BO-22 is out of scope.

The page preload (D40, D85)

Two channels, each with its D40 (4) entry in docs/ARCHITECTURE.md:

• orbit-page:tweak-sheets: a synchronous read before the page's first paint. The message carries nothing. Main answers from the sending frame's own URL, with the CSS of the Tweaks that are on for that host, and a number for this document's read. It answers only:
  • a main frame,
  • of a page in a profile's session,
  • on http: or https:.
• The preload inserts the sheets as injected author sheets (webFrame.insertCSS, src/preload/tweak-sheets.ts), and keeps their keys in its own world. So the page can't read or remove them, and the Tweak's layer comes first, so the page's !important rules don't outrank it. There's no global.
• orbit-page:tweak-retire (main → page): once main's own copies are in, it tells the preload to take its sheets out. It carries only the document's number, and main never waits for it, so a late one can't touch a newer document's sheets.
• No JavaScript. JavaScript Tweaks never go through the preload.

Decisions where the spec was unclear

• The editor: a Tweak it made and left empty goes when it closes. Internal and error pages take no Tweak.
• JavaScript and scope: JavaScript runs in the main frame only, once per load. The subdomain box is off by default, and isn't offered for an address by number.
• The panel:
  • Hide's choices are in the panel, and Hide elements and Code share a row.
  • Dragging the name moves the panel once the pointer has moved 4 px.
  • Shuffle keeps its menu open.
• The Library:
  • Its row menu is the Library's own HTML menu.
  • A Tweak keeps the origin it was made on, for Open Site. Older Tweaks get https://host, or http for localhost and IP hosts.
  • Edit and Open Site reuse a tab of the Space on that site. Edit waits for the page, and says why if its load fails.
• BO-16: it has its own tweaks.setGlobal command. While Tweaks are off, the row switches stay usable, dimmed.
• The lead's decisions on the review: D85 (the preload's sheets and the retire message), D86 (BO-10's restore markers stay in the panel) and D89 (Hide mode on a page that's still loading).

Edits in other lanes' files

Each one is small and additive:

• Shared and preload:
  • page.ts: the D40 block, with the new tweak-sheets.ts module;
  • state.ts: the Tweak fields;
  • defaults.ts, persist.ts, actions.ts, rpc.ts and site.ts.
• Chrome and tabs:
  • tabs/menus.ts and tabs/commands.ts: Tweak this Site… and its key hint, now in finish-tabs' overlay row menu;
  • Address.tsx: the paintbrush;
  • SpacePanels.tsx: the + menu;
  • miniwindow/index.ts: the Tweak actions reach their handlers from a Mini Window (KS-20);
  • main.tsx.
• Registries:
  • the site controls panel's new one;
  • advanced.settings.tsx: <TweaksSetting /> and its keywords.
• Merges: each conflict keeps both sides.
  • Pages' preload and shared files conflicted at 1ccdbad, and the Tweak channel is a block of its own.
  • Finish-tabs (8d3201a): the tab menu's imports and keys, rpc.ts, and ARCHITECTURE.md's page-scripts paragraph. The Tweak specs now use finish-tabs' overlay row menu, and F9's test checks that "Tweak this Site…" from a row menu leaves the keyboard in the editor.
• Dependencies: none added.

Merge gate (D42, local)

Gate r2 ran on this exact head, 86dcc5e, on the VPS (Linux, under Xvfb), from 23:51 to 00:39 (10-12) UTC. The lead ran it with the gate script:

npm run build && npm run typecheck && npm run lint && ./node_modules/.bin/vitest run
xvfb-run -a -s "-screen 0 1440x900x24" ./node_modules/.bin/playwright test --workers 1 --retries 0 --reporter=line

• Build, typecheck and lint: exit 0.
• Unit: 117 files, 1133/1133 passed.
• E2E: 853 passed, 2 skipped (the macOS-only tests below), 0 failed, in 47.7 min; e2e exit 0. Load average 14.2 at the start, 3.1 at the end.
• Earlier gate: r1, on 3f6bad0 (the head the review read): 786 passed, 1 failed, 2 skipped (44.0 min). The failure, import-file.spec.ts:151 [IM-13], passed when rerun alone: the import window closed while Playwright was still finishing its Cancel click.
• D18: each fix fails a named test without it. The three fix rounds' reports list each result, and both fix checks cut the fixes again.
• Unverified (macOS only, not run here):
  • the editor's view, keys and font presets on macOS;
  • nav.spec's two macOS-only key tests.

Review

• Review: APPROVE WITH FIXES, 2 must-fix (an independent reviewer, reviews/lane-tweaks.md), both reproduced, with the fix prototyped:
  1. The first-paint sheets sat in document.adoptedStyleSheets, so the page's own scripts could read the user's CSS, drop the sheets (2 of 3 first frames then lacked the Tweak), and outrank them with layered !important rules.
  2. On a page still loading, no change to its Tweaks showed until the load ended: about 5.6 s with one slow image, against 6 ms on a loaded page. Main's retire waited on a script in an isolated world, which Electron holds until the page stops loading.
• D85 takes the reviewer's design for both: the preload inserts the sheets with webFrame.insertCSS, and main retires them with one message that carries only a document number and is never awaited. D86 keeps BO-10's restore markers in the panel.
• Fix round 1 (46a87d9): both must-fixes by D85. A Tweak turned off on a loading page now shows in 6–17 ms, where 3f6bad0 took 7.9 s. Follow-ups F1–F9: Hide mode holds against the page, scripts check their host, the notes say only what's true, BO-03's drag test counts main's edits, FL-01's motion tokens, a Mini Window's Tweak keys, the Library's Edit on a failed load, and Hide all similar's count. Each code fix's test failed on 3f6bad0.
• Fix check: APPROVE WITH FIXES, 1 must-fix (reviews/lane-tweaks-fixcheck.md). Both D85 fixes behaved as the reviewer's prototype did, and each cut failed its test.
  • The must-fix, already there at 3f6bad0: an insertCSS that never answers (after a crash, or when another site's page replaces a busy one) left the tab's sync busy, so no later Tweak change showed in that tab. A late answer also sent a removal to the new page's renderer.
  • D89: Hide mode on a page that's still loading starts when the load ends, but shows at once that it will.
• Fix round 2 (db7354c): each document's wait also ends on a new document, a gone renderer or closed contents, and a late key goes back only to its own renderer. D89's start shows at once. Each fix's test fails without it.
• Fix check 2: APPROVE, no must-fix (reviews/lane-tweaks-fixcheck2.md). After a crash or a navigation the next change shows, a late key never reaches the new renderer, and no wait is left. Its follow-ups:
  1. a Mini Window's Tweak note could land in a private window, while View Tweaks opened the Library in the browser window;
  2. an Esc in the page didn't cancel Hide mode's start (D89 (5) now says it does);
  3. a late key's e2e test, kept from the fix check's probe.
• Fix round 3 (80748ac to 86dcc5e, after main was merged in at 8d3201a): all three follow-ups and F9's test, each failing without its fix (reviews/lane-tweaks-fix3-report.md).
• The lead's check of round 3 and the merge: APPROVE, nothing new (reviews/lane-tweaks-fix3-check.md). The lead built none of this lane.

🤖 Generated with Claude Code

---

Note

Medium Risk
Introduces early CSS injection and optional user JavaScript in web pages; safeguards exist (global toggle, JS allow/import gates, main-frame-only, private-window option) but the attack surface and persistence path are materially larger.

Overview
Adds Tweaks: per-site visual and behavioral customizations edited in a draggable panel over the live page, persisted in app state and reflected in the feature checklist/docs.

Application model: Before first paint, the page preload synchronously fetches Tweak CSS via orbit-page:tweak-sheets and injects author sheets; main later replaces them with insertCSS and retires preload copies via orbit-page:tweak-retire. Live edits sync sheets while loading; allowed JavaScript runs once per load from main in the page’s main world (not via preload). Hide-element mode uses an isolated-world picker (src/main/tweaks/hide.ts).

Product surfaces: Command bar, tab menu (“Tweak this Site…”), address paintbrush, sidebar + menu, site-controls registry sections, Settings → Advanced global toggle, and Library Tweaks list. Mini Windows forward Tweak actions to the browser window behind them (KS-20). State load uses normalizeTweaks / normalizeTweakSettings.

UI: New tweak renderer view (TweakEditorApp) with colour wheel, fonts, size/case, code editor, hide UI, etc. BO-19 (Space theme colours in CSS) and BO-20 (export/gallery) remain unbuilt; BO-07 fonts are partial (system stacks only).

^{Reviewed by Cursor Bugbot for commit 86dcc5e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 33551c62-d75d-409f-b4c1-4f4607da3e11)

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: cc366263-0c43-4f92-a95b-d7bfd8e614a1)

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 3f95c9a0-5ba4-4ded-b5a9-18f1e2514a58)

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: f5407e28-6acf-4bb7-a76a-12f1e6742d59)

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 66363c35-dec7-4a2e-be94-ef1e11350a21)