Skip to content

Sign-off 6: feel marks for feel-fix's rows and Tweaks; PK-07 reopened - #34

Merged
siyabendoezdemir merged 6 commits into
mainfrom
lead/signoff-6
Oct 12, 2026
Merged

siyabendoezdemir merged 6 commits into
mainfrom
lead/signoff-6

Conversation

@siyabendoezdemir

@siyabendoezdemir siyabendoezdemir commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

What this does

The lead's sixth "feels right" sign-off (D48, D79). It checks feel-fix's rows again now that PR #32 has merged, and the Tweaks rows (PR #30). It marks 21 rows "feel": true and takes PK-07's and SV-15's marks back. The review's must-fix held four split view rows the first head had marked (D96, below). The record, with the rows held back and their frames, is reviews/feel-signoff-6.md in the project's context folder.

  • docs/feature-status.json: "feel": true added on 21 rows and removed from two, and no other change. FEATURES.md is regenerated and counts 221 feel right (from 202).
    • Peek: PK-06. PK-07 loses its mark: ⌘O's card grows a scaled still of the page, then the page replaces it in one frame, its heading about 10% smaller and 18 px higher and every card's text re-wrapped.
    • Split view: SV-15 loses its mark, and SV-02, SV-03, SV-07 and SV-26 are held: a tab chosen for a pane shows its old full-window layout, cut off by the pane, for 4 frames before it re-wraps (held item 2 below).
    • Mini Window: MW-04, MW-15.
    • Media: MD-07.
    • Navigation: NV-06.
    • Archive: AR-02.
    • Tweaks: BO-01 to BO-06, BO-08, BO-09, BO-11 to BO-17.
  • scripts/capture/scenarios/:
    • bo (new) drives the Tweaks editor end to end: New Tweak from the command bar, the colour wheel and its accent rim, invert, the sliders, fonts, size and case, hiding (this element, similar ones on a card's icon and on a card's title, restore), custom CSS, Shuffle and Rename from the name menu, Done, a reload, the site controls' switch, Edit, Esc, the library, and a second page of the same site. Each step prints a [mark] line. The sliders and the hiding steps also print [check] lines with the values they end on.
    • md2 (new) covers the media rows: a tab closed above a playing video, an empty Space, and a split.
    • tb, tb2, sp, sp2 and sb2 (PR feel: sign-off 5, 87 rows of the sidebar, Spaces and profiles (D48, D79) #33's review, follow-up 1) make their tabs in their setup, before the recording starts, so each clip opens on the demo, not on 5–8 s of preparation.
    • sp2: the switcher's right-click step is named for SP-07 (follow-up 4), and slide() lets the pointer button up even when a step throws (follow-up 6).
  • scripts/capture/record.mjs (follow-up 2): the 15 s wait for Orbit to quit and ffmpeg's 5 s stop timer are cleared once they're done with. A run now ends with Orbit, not up to 15 s later.

How the rows were checked

  • Recordings: nine scenarios at 60 fps (pk, sv, mw, md, md2, nv, ar, dl and bo), from this branch with main 0b68ea4 merged in. Each was read frame by frame, with a per-frame change count, contact sheets around each step, and crops at full size. The load was 5.7–12.4 while they ran. D79 (3) judges clips by what they show, and no FL number is taken from them.
  • No FL row is measured in this sign-off (D94). FL-19 is held with PK-07, and FL-24 waits for the look lane's item 4.
  • Held for the feel-fix-3 lane (D94, D96), each with its frames in the record:
    1. PK-07 and FL-19: the jump at the end of ⌘O, above.
    2. SV-02, SV-03, SV-07 and SV-26, and SV-15 reopened (the review's must-fix 1): Metrics, chosen for the new pane, is in its pane from the frame it's chosen and never alone. But it is laid out at the window's full width and cut off at the pane's edge for 4 frames (SV-26-s6.mp4 179–182). Then it lays out at the pane's width in one frame (183). Add Split Below does the same with Standup notes (374–377, then 378). SV-15 swaps an open tab into a pane through the same path.
    3. MD-01: in a split, as the window switches to an empty Space and the video moves into the player, the video's pane shows an old still for 2 frames: it was taken when the panes came to rest 1.1 s earlier ("267" where the page showed "300"). The pane stills (src/main/split/stills.ts) aren't retaken while a video plays.
    4. MD-16: in 4 of the 5 moves into the player that the clips show, the player is empty and light grey for 1–2 frames before the video. On Back to tab it shows the grey for a frame too. The player window itself is black, so the grey is likely a view inside it, or Xvfb's own. Feel-fix-3 checks which first.
    5. BO-10: Hide all similar finds nothing like a card's title that has no class of its own (an h3 under div.card). similar() in src/main/tweaks/hide.ts builds its broader selectors only from the element's own classes.
  • Not in this sign-off:
    • FL-24, which waits for look's item 4;
    • DL-10: its first open is right, but the row waits for its preview's white card (finish-downloads);
    • CB-22 and FL-29, held under D90;
    • FL-18, BO-07, BO-18 and BO-21, which are partial;
    • BO-19 and BO-20, which aren't built (P2);
    • BO-22, which is out of scope.
  • The setups (follow-up 1) were checked by a run of tb, tb2, sp, sp2 and sb2 from this branch at 77466ef (02:00–02:07 UTC). Each ran end to end and saved its clip, with all its marks in its log. sb2's first take stopped before launch at the recorder's own offline check, which fails now and then; its retry passed.
  • Unverified here (D79 (6)):
    • frame pacing, which needs a GPU;
    • a Mini Window's colour as it opens, and the grey where one leaves (Xvfb's, as feel-fix's probe showed);
    • the player on any frame where the main window covers it: there is no window manager to keep it on top.

Merge gate (D42, D81)

This head's tree differs from main only in docs/, FEATURES.md and scripts/capture/. main is 0b68ea4, the same tree as feel-fix's head a1085ce. That head's code is the code of 95667d9, which passed the full gate. So D81's checks apply. They ran on the first head, 77466ef, and again on this one, 8667a5a, which only takes five marks off:

$ git diff --stat 95667d9 8667a5a -- . ':(exclude)docs' ':(exclude)FEATURES.md' ':(exclude)scripts/capture'
(empty)
$ git diff --stat 0b68ea4 8667a5a
 FEATURES.md                       |  48 ++---
 docs/feature-status.json          |  46 ++---
 scripts/capture/record.mjs        |  18 +-
 scripts/capture/scenarios/bo.mjs  | 391 ++++++++++++++++++++++++++++++++++++++
 scripts/capture/scenarios/md2.mjs | 130 +++++++++++++
 scripts/capture/scenarios/sb2.mjs |  22 ++-
 scripts/capture/scenarios/sp.mjs  |  20 +-
 scripts/capture/scenarios/sp2.mjs |  59 +++---
 scripts/capture/scenarios/tb.mjs  |  17 +-
 scripts/capture/scenarios/tb2.mjs |  23 ++-
 10 files changed, 675 insertions(+), 99 deletions(-)

$ lead-d81.sh on 8667a5a (npm run build; npm run typecheck; npm run lint; vitest run), 02:52:28–02:52:58 UTC, load 10.5–14.0
build 0
typecheck 0
lint 0
unit 0
 Test Files  118 passed (118)
      Tests  1137 passed (1137)

On 77466ef (02:07:30–02:08:04 UTC), the same four checks were 0, with 1137/1137 unit tests passing.

The full gate on that code (PR #32's gate r2, on 95667d9, 00:42–01:33 UTC) passed build, typecheck, lint and unit (1137/1137), and e2e had 869 passed, 2 skipped (macOS-only keys) and 0 failed (50.8 min). The full e2e suite isn't run again here: no e2e test reads these files.

macOS: unverified. There is no CI (D42), and the capture scripts run on Linux only.

Review

Independent review (reviews/lead-signoff-6.md in the project's context folder, 02:51 UTC, on 77466ef): APPROVE WITH FIXES, 1 must-fix.

  • Checked and right: the 25 marks were exactly the record's lists, and PK-07's mark was removed. FEATURES.md regenerated unchanged, and D81's condition held. md2 and bo ran end to end: all 8 and 28 marks printed, and bo's four checks ended on the values asked. Biome passed on scripts/capture, and the PR body matched the record. Of the ten clip claims, seven held as written and three in substance.
  • Must-fix 1, taken (D96, 8667a5a): the split fills behind SV-02, SV-03, SV-07 and SV-26 show the chosen tab's old layout, cut off, for 4 frames, then a re-wrap. The lead confirmed it on the frames and held the four rows. SV-15 goes through the same path, so its mark is taken back too. All five go to the feel-fix-3 lane (its item 3). This only removes marks, the review's own first option, and D81's checks ran again on the new head.
  • Follow-ups:
    • The record's wording for NV-06, PK-07, BO-10, BO-14 and BO-17 is corrected; those marks stand.
    • The headers of bo.mjs and md2.mjs (what they cover, and their length) go with the next capture change. So does a second try in the recorder's offline check, which refused one take in each of the lead's and the review's runs.
    • The commits titled "WIP:" stay in the history.
  • Bugbot didn't run on either push: it posted that its usage limit was reached. Nothing here depends on it.

🤖 Generated with Claude Code


Note

Low Risk
No application/runtime code changes—only generated docs and Linux capture scripts—so production behavior is unchanged.

Overview
Records the sixth lead “feels right” sign-off (D48): docs/feature-status.json gains "feel": true on 25 spec rows (Tweaks BO-01–BO-17 subset, Peek PK-06, Mini Window, PiP, zoom, Archive library, etc.) and drops it on PK-07 (expand Peek to tab) and SV-15; FEATURES.md is regenerated so the checklist total rises from 202 → 221 “feel right.”

Capture tooling adds bo (end-to-end Tweaks editor demo with [mark]/[check] timing) and md2 (PiP return paths via ⌘W, empty Space, split); moves tab/Space setup into exported setup() hooks on tb, tb2, sp, sp2, sb2 so recordings start on the demo; record.mjs clears ffmpeg quit and Orbit-exit timers when those promises resolve (avoids hanging up to 15s); sp2 releases the synthetic mouse button in a finally on slider drags.

Reviewed by Cursor Bugbot for commit 8667a5a. Bugbot is set up for automated code reviews on this repo. Configure here.

siyabendoezdemir and others added 5 commits October 12, 2026 01:25
bo drives the Tweaks editor end to end: New Tweak from the command bar, the
colour wheel and its accent rim, invert, the sliders, fonts, size and case,
hiding (this, similar, restore), custom CSS, Shuffle and Rename from the name
menu, Done, a reload, the site controls' switch, Edit, Esc and the library.
md2 shows the media rows a tab closed above a playing video, an empty Space
and a split exercise.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- tb, tb2, sp, sp2 and sb2 make their tabs in setup, before the recording
  starts, so each clip opens on the demo, not 5-8 s of preparation (1).
- record.mjs clears its quit and ffmpeg timers once they're done with, so a
  run ends with Orbit instead of 15 s later (2).
- sp2's switcher right-click is SP-07's (4).
- sp2's slide() lets the pointer button up even if a step throws (6).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… card's icon, and a second page of the site

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ened

25 rows get "feel": true (reviews/feel-signoff-6.md in the context): PK-06,
SV-02, SV-03, SV-07, SV-26, MW-04, MW-15, MD-07, NV-06, AR-02, and BO-01 to
BO-06, BO-08, BO-09 and BO-11 to BO-17. PK-07 loses its mark: ⌘O now ends
with the page replacing a scaled still in one frame. FL-19, MD-01, MD-16 and
BO-10 are held with numbers. FEATURES.md regenerated: 226 feel right.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: a734ed4d-745a-40f1-b732-c4004ece294b)

…(review must-fix 1)

PR #34's review found that a tab chosen for a split pane shows its old
full-window layout, cut off by the pane, for 4 frames before it re-wraps at
the pane's width (SV-26-s6.mp4 179-182 then 183; 374-377 then 378). That is
the jump PK-07 loses its mark for, so the four rows the clip signed are held
for feel-fix-3. SV-15 fills a pane through the same path and its re-check
rested on a test that doesn't look at the layout, so its mark is taken back
too. FEATURES.md regenerated: 221 feel right.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 57310d2a-0682-41fd-9076-6b560f1c350e)

@siyabendoezdemir
siyabendoezdemir merged commit cd74157 into main Oct 12, 2026
1 check passed
siyabendoezdemir added a commit that referenced this pull request Oct 12, 2026
…-fix-2

No conflicts. FEATURES.md regenerates unchanged from the merged
feature-status.json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
siyabendoezdemir added a commit that referenced this pull request Oct 12, 2026
Data only: main's "feel" flags in docs/feature-status.json kept with this
lane's notes; FEATURES.md regenerated; new and updated capture scenarios.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant