Skip to content

Upgrade project files to SDK-style format compatible with dotnet - #355

Merged
peterjamesnugent merged 5 commits into
developfrom
SAP2000_Toolkit-#354-UpgradeProjectFilestoDotNetSDK
Aug 21, 2026
Merged

Upgrade project files to SDK-style format compatible with dotnet#355
peterjamesnugent merged 5 commits into
developfrom
SAP2000_Toolkit-#354-UpgradeProjectFilestoDotNetSDK

Conversation

@peterjamesnugent

Copy link
Copy Markdown
Member

Issues addressed by this PR

Closes #354

  • The project files were still using the legacy .NET Framework project files and needed to be upgraded to SDK-style format compatible with dotnet.
  • I have not upgraded the framework to netstandard2.0 as I was not confident this would be compatible for this repo and its dependencies.

Test files

  • Make sure the solution build with dotnet build
  • Run your end of milestone testing procedure

Changelog

Additional comments

@peterjamesnugent
peterjamesnugent requested a review from GCRA101 July 29, 2026 14:48
@peterjamesnugent peterjamesnugent self-assigned this Jul 29, 2026
@peterjamesnugent peterjamesnugent added the type:compliance Non-conforming to code guidelines label Jul 29, 2026
LukeBastianBH
LukeBastianBH previously approved these changes Aug 20, 2026

@LukeBastianBH LukeBastianBH left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built using dotnet build in VS Code. Successfully tested pushing and pulling of Bars, panels, and uniform loads in Rhino 8.

@peterjamesnugent

Copy link
Copy Markdown
Member Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 9 requests in the queue ahead of you.

@peterjamesnugent

Copy link
Copy Markdown
Member Author

@BHoMBot check core

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check core

@peterjamesnugent

Copy link
Copy Markdown
Member Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent

Copy link
Copy Markdown
Member Author

@BHoMBot check compliance

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 12 requests in the queue ahead of you.

@peterjamesnugent

Copy link
Copy Markdown
Member Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@LukeBastianBH LukeBastianBH left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built with dotnet in VS Code and tested some basic push/pull functionality in Rhino 8

@peterjamesnugent

Copy link
Copy Markdown
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci

bhombot-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent
peterjamesnugent merged commit 1721c52 into develop Aug 21, 2026
12 checks passed
@peterjamesnugent
peterjamesnugent deleted the SAP2000_Toolkit-#354-UpgradeProjectFilestoDotNetSDK branch August 21, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:compliance Non-conforming to code guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade project files to SDK-style format compatible with dotnet

2 participants