Allow Pull of FE Mesh Objects - #353
Conversation
peterjamesnugent
left a comment
There was a problem hiding this comment.
A few changes making use of existing methods.
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
|
@BHoMBot check required |
|
@GCRA101 to confirm, the following actions are now queued:
There are 404 requests in the queue ahead of you. |
peterjamesnugent
left a comment
There was a problem hiding this comment.
Everything else looks good, just one change to use Localisation_Toolkit for unit conversion.
LukeBastianBH
left a comment
There was a problem hiding this comment.
Successfully pulled panels and meshes using the provided GH script in Rhino 6 and the associated installer. Also pulled bars as independent check.
fyi, @peterjamesnugent |
|
@GCRA101 fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
|
@BHoMBot fix project file ref. 91474559693 |
|
@GCRA101 I have queued up your request to fix the |
|
@GCRA101 I am now going to fix the project compliance in accordance with the annotations previously made. |
|
@GCRA101 to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
|
@BHoMBot check required |
|
@GCRA101 to confirm, the following actions are now queued:
|
|
@BHoMBot check required |
|
@GCRA101 to confirm, the following actions are now queued:
|
|
@BHoMBot check core |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
|
@BHoMBot check required |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
|
The check |
|
@peterjamesnugent to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
peterjamesnugent
left a comment
There was a problem hiding this comment.
My changes have been addressed and based on @LukeBastianBH 's functionality review - happy to merge.
|
@BHoMBot check ready-to-merge |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
Issues addressed by this PR
Fixes #352
SAP2000 Toolkit now allows to pull FEMesh objects from models.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23353-AllowPullOfMeshObjects/Test%20Script.gh?csf=1&web=1&e=ysz7ev
SAP2000 File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23353-AllowPullOfMeshObjects/Test%20SAP2000%20Model.sdb?csf=1&web=1&e=b3fCb6
Changelog