Skip to content

Allow Pull of FE Mesh Objects - #353

Merged
peterjamesnugent merged 14 commits into
developfrom
SAP2000_Toolkit-#352-AllowPullOfMeshObjects
Aug 4, 2026
Merged

Allow Pull of FE Mesh Objects#353
peterjamesnugent merged 14 commits into
developfrom
SAP2000_Toolkit-#352-AllowPullOfMeshObjects

Conversation

@GCRA101

@GCRA101 GCRA101 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@GCRA101 GCRA101 self-assigned this Jul 29, 2026
@GCRA101 GCRA101 added the type:feature New capability or enhancement label Jul 29, 2026

@peterjamesnugent peterjamesnugent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes making use of existing methods.

Comment thread SAP2000_Adapter/Convert/ToBHoM/Panel.cs Outdated
Comment thread SAP2000_Adapter/Convert/ToBHoM/Panel.cs Outdated
Comment thread SAP2000_Adapter/SAP2000_Adapter.csproj
Comment thread SAP2000_Adapter/CRUD/Read/Mesh.cs Outdated
Comment thread SAP2000_Adapter/CRUD/Read/Mesh.cs Outdated
Comment thread SAP2000_Adapter/CRUD/Read/Mesh.cs Outdated
Comment thread SAP2000_Adapter/CRUD/Read/Mesh.cs
@GCRA101
GCRA101 requested a review from peterjamesnugent July 30, 2026 13:32
@GCRA101

GCRA101 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

@GCRA101 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 404 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good, just one change to use Localisation_Toolkit for unit conversion.

Comment thread SAP2000_Adapter/Convert/ToBHoM/Panel.cs Outdated
LukeBastianBH
LukeBastianBH previously approved these changes Jul 31, 2026

@LukeBastianBH LukeBastianBH left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully pulled panels and meshes using the provided GH script in Rhino 6 and the associated installer. Also pulled bars as independent check.

@GCRA101

GCRA101 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Successfully pulled panels and meshes using the provided GH script in Rhino 6 and the associated installer. Also pulled bars as independent check.

fyi, @peterjamesnugent

@GCRA101
GCRA101 requested a review from peterjamesnugent July 31, 2026 17:36
@bhombot-ci

bhombot-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

@GCRA101 fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 91474559693

@GCRA101

GCRA101 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot fix project file ref. 91474559693

@bhombot-ci

bhombot-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

@GCRA101 I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci

bhombot-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

@GCRA101 I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci

bhombot-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

@GCRA101 to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@GCRA101

GCRA101 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

@GCRA101 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@GCRA101

GCRA101 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

@GCRA101 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent

Copy link
Copy Markdown
Member

@BHoMBot check core

@bhombot-ci

bhombot-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check core

@peterjamesnugent

Copy link
Copy Markdown
Member

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci

bhombot-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent

Copy link
Copy Markdown
Member

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci

bhombot-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

There are 2 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes have been addressed and based on @LukeBastianBH 's functionality review - happy to merge.

@peterjamesnugent

Copy link
Copy Markdown
Member

@BHoMBot check ready-to-merge

@bhombot-ci

bhombot-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent
peterjamesnugent merged commit 60c04dd into develop Aug 4, 2026
11 checks passed
@peterjamesnugent
peterjamesnugent deleted the SAP2000_Toolkit-#352-AllowPullOfMeshObjects branch August 4, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Pull of Mesh Objects

4 participants