Repository navigation
fix: handle unset maximumWaitTime and walk time on guaranteed interchanges - #68
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the update that treats negative transfer wait limits as unlimited.
No open issues 🎉
What changed in this PR
Updates transfer-risk handling so negative maximumWaitTime values mean no wait limit, preventing false warnings for guaranteed transfers.
Changes:
- Treats negative wait limits, including Entur’s
-1sentinel, like absent limits. - Documents the behavior and adds a regression test for a guaranteed transfer with
maximumWaitTime: -1.
| File | Description |
|---|---|
src/transfer-risk/transfer-risk.ts |
Handles negative wait limits as unlimited and documents the sentinel. |
src/transfer-risk/__tests__/transfer-risk.test.ts |
Verifies that a negative wait limit suppresses the transfer-risk warning. |
Review effort: Balanced
reidzeibel
changed the title
gorandalum
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/AtB-AS/kundevendt/issues/24807
Relevant discussion with Entur here: https://mittatb.slack.com/archives/CHLDG8C30/p1794561475969269