Repository navigation
fix: handle unset maximumWaitTime and walk time on guaranteed interchanges - #496
Merged
Merged
Conversation
reidzeibel
requested
a balanced review from Copilot
and removed request for
marius-at-atb and
rosvik
November 13, 2026 12:39
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the guaranteed-interchange handling fixes and shared utilities dependency update.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Corrects guaranteed-interchange handling in the trip service for older app versions and updates the shared utilities dependency.
Changes:
- Treats negative
maximumWaitTimevalues as an unlimited wait. - Uses the previous transit service’s arrival time, excluding intervening walking time, when checking guarantees.
- Adds regression tests and upgrades
@atb-as/utilsto8.0.2.
| File | Description |
|---|---|
src/service/impl/trips/utils.ts |
Corrects wait-limit and arrival-time handling for guaranteed connections. |
src/service/impl/trips/__tests__/utils.test.ts |
Covers walking transfers, exceeded wait limits, and the negative sentinel value. |
pnpm-lock.yaml |
Locks utilities to 8.0.2 and consolidates dependency snapshots. |
package.json |
Updates @atb-as/utils to ^8.0.2. |
Review effort: Balanced
gorandalum
approved these changes
Nov 13, 2026
rosvik
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of https://github.com/AtB-AS/kundevendt/issues/24807
Updates the utils as per AtB-AS/utils#68, and handle the same issue in older version of the app.