Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lcu/core/lcu_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def put(self, path: str, json_data, timeout: float, headers: Optional[dict] = No
try:
t0 = time.perf_counter()
resp = self.connection.session.put(
url,
(self.connection.base or "") + path,
json=json_data,
timeout=timeout,
headers=headers,
Expand Down
39 changes: 39 additions & 0 deletions lcu/tests/test_lcu_api_reconnect.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import unittest
from types import SimpleNamespace
from unittest.mock import Mock

import requests

from lcu.core.lcu_api import LCUAPI


class PutReconnectTests(unittest.TestCase):
def test_retry_uses_refreshed_base_and_session_and_preserves_arguments(self):
old, new = Mock(), Mock()
old.put.side_effect = requests.ConnectionError('client restarted')
response = new.put.return_value
connection = SimpleNamespace(ok=True, base='https://127.0.0.1:1000', session=old)

def refresh(force=False):
self.assertTrue(force)
connection.base = 'https://127.0.0.1:2000'
connection.session = new

connection.refresh_if_needed = Mock(side_effect=refresh)
api = LCUAPI(connection)
api._cache_put('/resource', {'old': True}, 60)
payload, headers = [{'skinId': 1}], {'X-Test': 'value'}
self.assertIs(api.put('/resource', payload, 2.5, headers), response)
old.put.assert_called_once_with('https://127.0.0.1:1000/resource', json=payload,
timeout=2.5, headers=headers)
new.put.assert_called_once_with('https://127.0.0.1:2000/resource', json=payload,
timeout=2.5, headers=headers)
self.assertEqual(api._cache, {})

def test_failed_retry_returns_none(self):
session = Mock()
session.put.side_effect = requests.ConnectionError('closed')
connection = SimpleNamespace(ok=True, base='https://127.0.0.1:1000',
session=session, refresh_if_needed=Mock())
self.assertIsNone(LCUAPI(connection).put('/resource', {}, 1))
self.assertEqual(session.put.call_count, 2)
Loading