Repository navigation
fix(lcu): retry PUT on the refreshed client endpoint - #375
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the League client restarts on a different local port during a PUT, Rose refreshes its connection but retries the old URL. Rebuild the retry URL from the refreshed connection base, preserving session replacement, request arguments, retry behavior, and cache invalidation.
Validation:
python -B -m unittest lcu.tests.test_lcu_api_reconnect -v(2 passing); isolated LCU discovery (5 passing); all 323 Python tests passed in the combined audit worktree; CI error-only Ruff 0.16.8 andgit diff --checkpassed. The reconnect regression fails against unpatched HEAD: expected port 2000, actual port 1000. Tests use mocked sessions and make no LCU requests.