fix: show alternate streamed error text safely - #196
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some streamed failure frames carry a user-facing
errorstring instead ofmsgormessage. The 0.4 client discarded that string and showed only its generic failure text. Normalize the first nonblank string amongmsg,message, anderror, while continuing to omit the rawreasonfield.The existing 0.4 turn lifecycle already treats an empty error frame as a failed turn with exit code 1. This change preserves that behavior and makes the server's available error text visible.
Verification
npm run buildnode --test --test-isolation=none dist/test/stream.test.js dist/test/turn_lifecycle.test.js(38 passed)git diff --checkSynthetic regressions cover canonical field precedence, a blank
msgwith anerrorfallback, non-stringerror, hiddenreason, sanitized terminal controls, a trailingdoneframe, and nonzero one-shot exit.No package tag or publication is included.