fix: allow only public legacy stream errors - #197
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The alternate SSE
errorfield is not a general public-message contract: some historical media paths placed provider exception text there. Restrict the 0.4 client fallback introduced in #196 to two audited, fixed legacy public media messages. Continue to accept canonicalmsgandmessagestrings. All othererrorvalues use the existing generic failed-turn message;reasonremains omitted.The client still exits nonzero on every error frame and ignores any trailing
doneframe.Verification
npm run buildnode --test --test-isolation=none dist/test/stream.test.js dist/test/turn_lifecycle.test.js(39 passed)git diff --checkSynthetic regressions cover both fixed legacy messages, canonical precedence, strict allowlist matching, a secret-looking arbitrary
errorwith terminal controls, hiddenreason, a trailingdoneframe, and one-shot exit code 1.No package tag or publication is included.