Repository navigation
D-DRAM-P3-5: k-of-n on the shipped carry words — kill condition fired - #1954
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AdaWorldAPI
marked this pull request as ready for review
November 4, 2026 00:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a lab bench plus a board record. It changes no production code, adds no new opcode and no public type. Please don't merge automatically. The IDEAS status line for this result is on #1952, because the IDEAS section was added there.
What was measured
crates/crepe-plan-probe/examples/kofn_carry_words.rsasks, per lane: are at least k of the n masks set? It compares:full_add_maskadds two masks into column 0,half_add_maskripples the carry upward, and a constant-k comparator runs over the planes.U8x64::saturating_add(mask_blend(m, 0, 1))per mask, thencmpgt_mask(k-1).trailing_zeros.Result
The carry arm is 1.7–4.0× slower than the facade byte counters in every cell: dense, random and one-lane masks; n = 3, 8, 32; k = 1, ⌈n/2⌉, n. On dense masks with n = 32 it takes 61–65 ns per 64-lane word, against 24–25 ns for the byte counters.
The kill condition stated before the run ("slower than native on dense masks") fired. The likely cause is width: one
u64(64 lanes) per carry-word call versus one vector add per 64 lanes. That cause is HYPOTHESIS; no wide carry-word arm was built.Correctness:
Disable runs (commit first, then patch, then checkout):
gtterm: 21 FAIL lines;Clippy
-D warningspasses on the example.Coverage of the A-gates proposed in #1949 (a proposal by a GPT session, adopted after review):
Open
U64x8would be a new ndarray word, which needs ndarray's owner. It is not built here.Record:
.claude/board/entries/2026-11-03-d-dram-p3-5-kofn.md. STATUS_BOARD and the plan checklist are updated.Generated by Claude Code