Repository navigation
D-DRAM-P3: integrate #1949 with P2 open ends; ReadPolicy range rule; D-DRAM-1 census - #1951
Merged
Merged
Conversation
Credits what D-GLOBAL-WHERE P2 (#1950) already measured against the gates pre-registered in #1949: - measured in the lab: L9, L10, C2, C4; - partly measured: L1/L2, L6, A3, A4. Orders eleven owned items by signal per effort. Three of them need no outside decision: ReadPolicy weighing the range count, non-vacuous projection cases, and the D-DRAM-1 census. Production and gated items keep their owners (mask-risc, ndarray, Quack, EXO-46/89/151, D4/S-INGRESS). #1949's stop conditions stay in force. Adds the D-DRAM-P3 rows to STATUS_BOARD, an INTEGRATION_PLANS entry, and the regenerated supersession index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
plan_read decided on covered rows alone. In D-GLOBAL-WHERE P2 it therefore sent one contiguous 10% range to a full scan, 3.8x (1M) and 4.6x (10M) slower than the range read. A full read now also needs `ranges x page_rows >= n_rows`: the ranges must be spread widely enough to touch about every page. ReadPolicy::DEFAULT uses page_rows = 4,096, a POLICY PIN taken from the #1788 A.3 chunk size; page_rows = 0 restores the old rule. Measured with where_lance_arm at 1M (all oracle and refusal checks pass): - clustered 10% and 50% now read ranges, 1.2-7.8x faster than the old full read (10%, k=16: 103,492 -> 13,292 us); - scattered 10% still reads in full; - scattered 50% coalesces into one range covering nearly the table, at the old full-read time (56,820 vs 54,430 us). Tests (4 new): - a long run keeps the range read; - scattered ranges still read in full; - the page condition fires at the boundary and not one range below; - page_rows = 0 restores the coverage-only rule. Disable runs: with the old coverage-only rule, two tests fail; with `spread = false`, six fail. Full crate: fmt, clippy -D warnings and cargo test (63 tests) all pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Read-only census, verified in code:
- ndarray ships only `half_add_mask` / `full_add_mask` (and
`sum8_u8_add_masked`) for counting.
- The "5x24" kernels are the `U24x5` microtile packing, in examples/ only
("Lab fixture only: no public type"); Abacus is examples/ only.
- dt64 `dr.rs` owns the DR map. Every focus/lease candidate outside it
(drf-focus-probe FocusKey, lance-graph-nsl FocusLease) is in an excluded
lab crate, so a locator receipt has no production host. D-DRAM-2 stays
gated on EXO-46/EXO-151.
Also: the STATUS_BOARD and plan checklist mark P3-1 and P3-3 done, the
two Haiku harvest runs are logged with their misses, and the indexes are
regenerated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 3, 2026 23:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lab and docs only. Please don't merge automatically. Every gate in #1949 stays with its owner (EXO-46, EXO-89, EXO-151, D4, S-INGRESS).
Plan:
.claude/plans/d-dram-p3-integrated-v1.mdThe plan merges the open ends of D-GLOBAL-WHERE P2 (#1950) into the D-DRAM-0 falsifier map (#1949). This session owns all eleven resulting items.
It first credits what P2 already measured against #1949's pre-registered gates:
It then orders the items by signal per unit of effort. STATUS_BOARD gains rows D-DRAM-P3-1 to D-DRAM-P3-8.
D-DRAM-P3-1:
ReadPolicyalso requires spread ranges (crepe-plan-probe, lab)plan_readused to decide on covered rows alone. P2 measured the cost of that: one contiguous 10% range went to a full scan that was 3.8× (1M) and 4.6× (10M) slower than reading the range. A full read now also needsranges × page_rows ≥ n_rows, so the ranges must be spread widely enough to touch about every page.DEFAULTusespage_rows = 4096. This is a policy pin taken from the docs(D-DQM): DR64 ↔ DuckDB ↔ Lance 13 capability crosswalk (follow-up to #1787) #1788 A.3 chunk size, not a measured crossover.page_rows = 0restores the old rule.where_lance_armat 1M passes all oracle and refusal checks:DEFAULTDEFAULTTests:
ranges × page_rows = n_rows, andpage_rows = 0restores coverage-only.spread = falseturns 6 red.fmt --check,clippy --all-targets -D warningsandcargo test(63 tests) pass locally.D-DRAM-P3-3: D-DRAM-1 census (read-only),
.claude/board/entries/2026-11-03-d-dram-1-census.mdEvery item below was read at its cited line.
ndarray
b3d7919half_add_maskandfull_add_maskare shipped as public counting words (plussum8_u8_add_maskedfor masked byte sums).U24x5microtile packing. It lives inexamples/only, and its source says "Lab fixture only: no public type, no production caller."Abacusis alsoexamples/only.U24x5orAbacuswould hit docs(D-DRAM-0): DR locator memoization and adaptive Abakus mask lens (architecture gates) #1949's stop condition.lance-graph
lance-graph-dt64dr.rsowns the DR map (MapTable,LocalMap,Frame,Guards). ItsFocusis a tile revision, not a lease.drf-focus-probeFocusKey/check_sealandlance-graph-nslFocusLease.Not in this PR
These are owned and queued in the plan:
Generated by Claude Code