Skip to content

docs(D-DT64-6): implementation plan for the OGIT predicate expansion - #1832

Merged
AdaWorldAPI merged 6 commits into
mainfrom
ccr-39105428-bcm2m2
Oct 28, 2026
Merged

AdaWorldAPI merged 6 commits into
mainfrom
ccr-39105428-bcm2m2

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

#1831 (D-DT64-6, squash-merged as 42b4b83) describes the OGIT predicate stages D-DT64-6-1 to 6-4 in one line each. This PR adds an implementation plan for those stages, .claude/plans/d-dt64-6-ogit-predicates-impl-v1.md, with a board entry and board rows. It is documentation only: no code, tests or ABI, and it authorizes no work. Each stage still needs its own owner approval.

The plan rests on measurements against OGIT master b5731a8:

  • Most verbs never reach lance-graph's OGIT reader. ttl_parse accepts a verb only when it is declared as a class with rdfs:subClassOf ogit:Verb. 511 of OGIT's 523 verb files declare owl:ObjectProperty instead, so only the 12 NTO/WorkOrder verbs come through. OgitUri::parse also requires an ogit.<Domain>: prefix, so names in the root ogit: namespace are skipped (183 SGO verbs and the SGO core entities).
  • OGAR's reader is the complement, and has limits of its own (plan §7):
    • It rejects 102 files: the 12 rdfs:Class verbs, plus 90 files whose type line has column-aligned whitespace after a.
    • Accepting the first form brings rejections from 102 to 90; accepting both brings them to 0. Measured, then reverted.
    • extract_allowed_block loses 116 cells in 5 files. In 4 of them a ) inside a comment ends the list early; in the fifth a description contains the text ogit:allowed.
    • No file has two cells on one line or a cell spanning lines.
  • ogit:allowed lives in entity files. 960 files contain it, and none of them are under verbs/. The plan keeps the file counts apart (960 / 953 / 952 / 939 / 931), and keeps allowed rows apart from from-to rows; OgitTables::Allowed reads only the former.

Stages

D-id Repo Work
D-DT64-6-1a (new) lance-graph classify accepts owl:ObjectProperty verbs; root ogit: subjects are kept; anything unclassified is reported
D-DT64-6-1b (proposed, §7.1) OGAR parse_verb and detect_kind accept the rdfs:Class verb form and column-aligned type lines
D-DT64-6-1 OGAR Partition test in tests/ontology_cache.rs: both readers, one OGIT checkout, one run
D-DT64-6-2 owner decides (§6) Classid-free (src, verb, dst) table, checked pair for pair. Applies only under option B (see below)
D-DT64-6-3 DT64 lab One OGIT verb catalogue per ClassView frame
D-DT64-6-4 OGAR and a consumer Read access through HotPlug activation, with no copy in the consumer

Reconciliation with merged #1831 and #1833

Board changes

  • Entry entries/2026-10-28-d-dt64-6-ogit-predicates-impl.md, updated with the measurements.
  • Rows in STATUS_BOARD.md and INTEGRATION_PLANS.md.
  • entries/README.md regenerated; the supersession index is regenerated too and comes out unchanged.

Validation

  • append_only_gate.py origin/main passes: 11 files checked, none shrank.
  • entries_index.py --check passes (491 rows).
  • Every count in the plan comes with its source. The OGAR counts came from a throwaway example that called OgitTables::load; it was not committed. The full-parse counts come from OGIT#11's tools/import_check.py.
  • Not run: code and tests, because this PR adds none.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4

Details #1831's D-DT64-6-1..4 and adds D-DT64-6-1a. ttl_parse classifies
only the 12 rdfs:Class verbs (511 of 523 OGIT verbs are owl:ObjectProperty)
and skips root ogit: names; ogit:allowed sits on entity files as blank-node
cells that walk_rdf_list does not read. Stages give files, tests that fail
on main, silence twins, disable runs and acceptance counts. Docs only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4ef1818d-2d92-43b3-8457-3fa48b0f09f8
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Takes #1831's STATUS_BOARD section as merged and adds a dated note on
AdaWorldAPI/OGIT#11 to the plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4
@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 28, 2026 03:16
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T03:17:52.790715Z f793a2a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f793a2a26c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/plans/d-dt64-6-ogit-predicates-impl-v1.md
Comment thread .claude/plans/d-dt64-6-ogit-predicates-impl-v1.md Outdated
…iption vs ON/WHEN/DO

Adds plan sections 6-9, measured on OGIT b5731a8 against OGAR main's
reader code and OGIT#11's full Turtle parse:

- OGAR rejects 102 files (12 rdfs:Class verbs, 90 column-aligned
  type lines); accepting both forms measured 102 -> 90 -> 0.
- extract_allowed_block loses 116 cells in 5 files (a ')' in a
  comment inside the list; ogit:allowed in a description). No file
  has two cells on a line or a cell spanning lines.
- File universes 960/953/952/939/931 and allowed vs from-to rows
  kept apart.
- Table ownership recorded as OPEN: OGAR, lance-graph-ontology, or
  a generated TSV snapshot both read (no dependency edge between
  them).
- Corrections to merged #1831 section 2 and #1833 section 2 (the
  "successor" attribution); description is not a fourth axis;
  crai-rs CR-H2 waits on the D-SAG-6-1 audit.

Housekeeping: parent link to main, the per-verb LinkSpec replacement
is #1831's decision, OGIT#11 counts re-measured on its head, Calendar
example shows the file's real layout. Merges main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4
#1831's entry already owns D-DT64-6; entries_index --check rejects
the duplicate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4
… §10 corrections

- D-DT64-6-2 now states its precondition: it is a second ogit:allowed
  parser, which merged #1831 rules out unless the owner picks §6 option B
  and amends that guard. The stage is scoped to option B.
- Item 5 resolves references across the whole checkout in a second pass,
  not per file.
- §10 records corrections to the merged parent plan from the D-CFA, EAW
  and #1819 research docs, each citing the section it corrects.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4
@AdaWorldAPI
AdaWorldAPI merged commit ea709af into main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants