Repository navigation
docs(onnx) S1–S2: semantic intake and minimal RelAlg polyfill plan - #1746
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Architecture correction approved by the operator on 2026-10-23. Adds one marked supersession block under the title and inline markers on the sentences that state a root assumption (A1-A7). Canonical text and the representation seams are in #1753 (d-native-first-dependency-correction-v1.md, d-native-repr-contract-v1.md). No other text in this plan changes; the #1744/#1745/#1750 S0 dispute is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…1754) Marked supersession: 'R2IL polyfill' reads as the R2IL router (D-MPF-4), and [7] is the lance-graph-onnx leaf facade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
S1–S2: ONNX semantic intake and typed dispatch onto existing methods
Status: draft planning only; blocked on canonical S0 ownership (#1744/#1745/#1750) and existing OP-ONNX-1 numerical routing decision.
Corrected scope
Keep
ModelProto/GraphProtoas the ONNX graph, and retainlance-graph-relalg::Relas a narrow Boolean/selection planning subset under D-RA-2. Do not createRel::MatMul,Rel::Tanh, a second graph AST or a numerical interpreter. ONNX value semantics dispatch, when admitted, directly to existing numerical methods.Source-backed assets:
AdaWorldAPI/ndarray/src/hpc/vml.rs::vstanhalready implements f32 SIMD tanh, reachable from Burnfloat_tanh.crates/burn/src/ops/matmul.rsalready implements ordinary numeric MatMul fallback alongside CompiledAttention/CompiledLinear.crates/bgz-tensor,crates/helixandcrates/bgz17already provide palette/calibration and 256² table math. The missing step is semantic/intake binding, NOT redevelopment of these kernels.Two modes, not a second proprietary runtime
P0 identity and numerical admission
Import must preserve exact model/graph/operator/layer, weight/initializer digest, codebook/calibration generation, dtype/shape, state/effects and binding provenance. Shape or d_head alone does not establish safe substitution. The current Burn compiled palette paths are model-specific approximations, not automatically equivalent to ONNX MatMul. Admit them only with separate opt-in error/quality contracts.
Gates: official pinned ONNX schema/IR/opsets and typed refuses, secure external tensor data, differential Tanh and numeric MatMul oracle, same-shape model collision negatives, no new Rel value AST; quality/CI restrictions from EXO-137 and EXO-139. Source inventory in #1749.
Related: #1744, #1750, #1747, EXO-50. No implementation/merge authorized.
New offline-model preparation dependency: #1751
Optimum-ONNX already supplies
main_export, model-specific configs, export validation and ORT calibration-data workflow. #1751 documents a separate out-of-tree offline BGZ sidecar frontend; S1 retains semantic import and typed native dispatch. An Optimum exporter success does NOT admit its output as a native or compiled numerical operator. Model, initializer, node/layer and codebook lineage must survive from Optimum export to #1749's identity-safe method binding. First candidate: operator-approved pinned compact BERT MatMul/Gemm layer. No Optimum Python dependency in Rust runtime; #1744/#1745/#1750 S0 conflict remains open.⊘ Supersession — D-NFC (2026-10-23, operator-approved architecture correction)
Canonical dependency diagram and root assumptions: #1753 (
d-native-first-dependency-correction-v1.md); shipped / lab / missing seams:d-native-repr-contract-v1.mdthere.P0 invariants. (1) ONNX is an external mathematical compatibility specification; the existing R2IL polyfill is the native starting point; no ONNX graph, Tract runtime or Optimum dependency in the internal execution path. (2) Quack binding + DR64³ + Palette256³ is the intended native representation; existing R2IL, mask-risc, BGZ, Helix and ndarray primitives are reused; implemented components and unimplemented integration contracts are kept apart.
For this PR:
GraphProtoand the operator schemas do not own the internal computational graph or numerical meaning; native typed operations and compiled R2IL procedures do (A1).Where this description or the plan says otherwise, it is superseded at the marked ⊘ points (plan commit
d27d816a2). Nothing is merged, no ABI or execution contract changes, and the #1744 / #1745 / #1750 S0 dispute is unchanged.