Repository navigation
docs(onnx) S3d: Tensor × DR × Hybrid crossover + compiled Palette quality arm - #1748
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Architecture correction approved by the operator on 2026-10-23. Adds one marked supersession block under the title and inline markers on the sentences that state a root assumption (A1-A7). Canonical text and the representation seams are in #1753 (d-native-first-dependency-correction-v1.md, d-native-repr-contract-v1.md). No other text in this plan changes; the #1744/#1745/#1750 S0 dispute is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…1754) Marked supersession: 'R2IL polyfill' reads as the R2IL router (D-MPF-4), and [7] is the lance-graph-onnx leaf facade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
S3d: Tensor × DR × Hybrid, with existing compiled Palette as a separately admitted candidate
Status: draft differential benchmark specification. No new kernel, optimizer, JIT or speedup claimed.
Existing hardware-aware execution is real, but not generic ONNX equivalence
float_tanhand ndarray NEON/parity infrastructure already exist.Eligibility and fourth evaluation candidate
The original T/D/H (Tensor, DR typed fold, Hybrid per-tile) comparison retains one exact ONNX mathematical contract and an independent oracle. Add an explicit P: existing compiled Palette/BGZ/Helix lane as a separate model-specific approximate quality frontier, unless a restricted exact parity domain is established.
Current Burn compiled caches key on d_head or matrix shapes and do not verify weight/model/layer/codebook identity. Compiled attention ignores runtime lhs/rhs and returns scaled distance; centroid linear omits full zero-point bias correction. P is not an eligible transparent ONNX MatMul arm by default. Reuse requires admitted identity and explicit error contract (see #1749).
Falsifiable benchmark matrix
Per-tile sparse/dense crossover; prepacked Tensor baseline; H switching overhead; cold/warm/repeated N and incremental updates; model/layer/codebook cache validation, stale rebinding and output materialization; x86 AVX/AMX and already-existing ARM NEON measured only on actual hardware. Track calibration+packing+transfer+cache invalidation costs independently. Quality metrics (max/tail error and held-out task quality) separate from exact semantic oracle. Include collision, zero-point, NaN/Inf, codebook saturation and multi-hop failures (#1726/#1731).
Gate: T/D/H independent numeric parity for an actual admitted ONNX operator, plus optional P-frontier only with quality/identity admission and honest cost. A fast wrong result is refused.
Dependencies #1744 / #1745 / #1750 S0 owner ruling; #1746 semantic intake; #1747 focus; #1749 compiled numerical identity; EXO-50. No executable work authorized.
Benchmark input and approximation gate: #1751
#1751 will research offline Optimum export, reference validation and a non-destructive BGZ/Palette sidecar. Reuse its eventual pinned BERT-layer numerical fixtures rather than writing another model-exporter. T/D/H remain comparable exact-or-declared-tolerance arms. Existing compiled Palette is a separate quality-bound candidate P, not exact ONNX MatMul by default. Include model/layer/weight/codebook witness, calibration/packing/amortization, and held-out quality as distinct from exact parity. No unguarded Burn d_head/shape cache, no new tensor executor.
⊘ Supersession — D-NFC (2026-10-23, operator-approved architecture correction)
Canonical dependency diagram and root assumptions: #1753 (
d-native-first-dependency-correction-v1.md); shipped / lab / missing seams:d-native-repr-contract-v1.mdthere.P0 invariants. (1) ONNX is an external mathematical compatibility specification; the existing R2IL polyfill is the native starting point; no ONNX graph, Tract runtime or Optimum dependency in the internal execution path. (2) Quack binding + DR64³ + Palette256³ is the intended native representation; existing R2IL, mask-risc, BGZ, Helix and ndarray primitives are reused; implemented components and unimplemented integration contracts are kept apart.
For this PR:
Where this description or the plan says otherwise, it is superseded at the marked ⊘ points (plan commit
841f38b7e). Nothing is merged, no ABI or execution contract changes, and the #1744 / #1745 / #1750 S0 dispute is unchanged.