Repository navigation
gkat-probe: D-GKAT-0 PROBE, bounded GKAT checking of structured Rubicon flows - #1676
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review Two things to check in particular:
Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3d3968b08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review on #1676, two P2 findings, each reproduced by a test that failed before the fix: - the oracle's fixed silent-step budget classified a terminating run of 2^14 skips as divergent; divergence is now a repeated loop-head stack; - the determinacy check ignored acceptance, so skip ∪ p passed; a prefix that both accepts and continues is now nondeterministic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
|
@codex review Head is now 55c64a4, which addresses both P2 findings. Generated by Claude Code |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Lab crate, zero dependencies, excluded from the workspace. Guarded Thompson automata, normalization and union-find bisimulation decide equivalence over a declared atom set of at most 8 tests; a separate check requires WHERE(rev) and WHERE(mul) immediately before every RequestCommit. Unguarded choice, GoTo, GoBack, undeclared projections and more than 8 tests are refused. Every verdict is cross-checked against an independent bounded interpreter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
The first disable run of normalization stayed green: no test compared an action into a dead state with a rejection. p·0 ≡ 0 now does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
Codex review on #1676, two P2 findings, each reproduced by a test that failed before the fix: - the oracle's fixed silent-step budget classified a terminating run of 2^14 skips as divergent; divergence is now a repeated loop-head stack; - the determinacy check ignored acceptance, so skip ∪ p passed; a prefix that both accepts and continues is now nondeterministic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
55c64a4 to
bccff82
Compare
|
@codex review I rebased onto main Generated by Claude Code |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
D-GKAT-0. This is a PROBE, a research fixture, not a production verifier.
The new lab crate
crates/gkat-probehas zero dependencies and is excluded from the workspace. It runs under its own CI workflow. Claimed on EXO-50 (session_01VncKoyG6JkpsoqhqTGTv3f/026, ACKed in/036). The source is the #1670 excerpt of Smolka et al., Guarded Kleene Algebra with Tests, POPL 2020 (arXiv:1907.05920, §§2–5). The plan is the D-LFA amendment in #1673.Admitted fragment
0,1, assertb, actionp,e·f,if b then e else f,while b do e.AtomBound. A DR64-shaped signature is refused: 64 lanes are not 64 GKAT tests.Where={T},Check={T,U}.Refusal, never translated: unguarded choice,GoTo,GoBack, undeclared projections or tests, and mismatched signatures.WaitForInputlowers towhile ¬ready do Suspend, withreadyobserved at resume.Checks
RequestCommitmust come immediately after an atom with WHERE(rev) ∧ WHERE(mul);Results (26 tests)
p·0 ≡ 0.GoToandGoBackare refused. The union "porqwhatever the atom" fails determinacy.2^katoms fork ≤ 8tests, and3^nfor K3 observables;k = 9is refused. Counts only, no timings.RequestCommitbefore its guard → not equivalent, and unsafe;U;Proof boundary
nactions proves nothing.RequestCommitis an intent; the write is done by the supervisor /cycle_driver, which this PR does not touch.Files
crates/gkat-probe/**Cargo.tomlexcludelist.github/workflows/gkat-probe.ymlentries/2026-10-21-d-gkat-0-probe.md, the STATUS_BOARD D-GKAT-0 row, and the regenerated entries and supersession indexesNot touched: relalg, Quack, kanban,
cycle_driver, the D-RFT-2 rule catalogue, the D-LFA-1/2 runtime, and #1673.Handoff to D-LFA-1 (proposal, not claimed)
flow::Signature/Stepas the declared-guard boundary.Generated by Claude Code