Repository navigation
D-CMR-2: lower the contract set algebra onto mask-risc (runs as extents, three levels); D-CMR-5 re-scoped - #1650
Conversation
…kpoint) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
…or 2026-10-21) Q1 = C: no seek of f with bounds from S or a previous fold. Q2 = B, conditionally: frozen-codebook translation of S into f's projection coordinates, membership plane only, attested and accounted. Preimage as a co-addressed transposed fold over a version-bound projection of f, reusable across queries. R1 (rmap rebind/discover) stays C. Many-to-one: valid distinct-source preimage, bag-sensitive aggregates refused. Still BLOCKED on a contract-level codebook witness; no operator built. Plan + STATUS row + entry 2026-10-21-d-cmr-5-rescope.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
lance_graph::fold::set_lower: SetPlan splits a normalized SetExpr into Runs (counted seeks on an attested sorted i32 lane) ∩ residual (one mask-risc program run per run via execute_extent). Geometry / optics / etch levels; SetPlan::unsplit is the geometry-off arm. Tests: random nested expressions equal the row oracle at every level; geometry runs against empty planes with 0 extents; Experiment C; non-basis silence twin; refusals. Disable runs: geometry off, split off, basis-lane check off, keep-no-clear each red. fmt + clippy -D warnings clean. Open: D-CMR-2b (scratch-free Pred fold in mask-risc). Board: STATUS D-CMR-2 In PR, LATEST_STATE, entry 2026-10-21-d-cmr-2-lowering.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Hygiene only (termination clause: generates no further arc entry). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
contract: D-CMR-6 guarded rule catalogue (set_rules) + #1650 closeout
This PR adds D-CMR-2: the contract's
set_algebra(D-CMR-1, #1644) is now lowered onto mask-risc, in core. It also records your D-CMR-5 ruling of 2026-10-21 (plan and board only).D-CMR-2:
lance_graph::fold::set_lowerSplit.
SetPlan::new(&SetExpr, n_rows, Option<&SortedBasis>)normalizes the expression and then splits it:Runs, at one binary-search seek per boundary. This applies to an expression made only of such comparisons, and to the basis conjuncts of a top-levelAnd.Orstays residual and costs no seeks.Three levels (plan §3.4):
Count = Σ(hi−lo); no plane, lane or extent is readCountterminal, per run (execute_extent)KeepintoOut::Mask; bits outside the runs are clearedCosts are reported separately, as ADMISSION B requires:
SortedBasis::attest_reads: one scan;SetPlan::seeks: binary searches;Measured::{extents, extent_rows}: the query side.Disable arm.
SetPlan::unsplitturns geometry off. It has to give the same answers, and it does.No new dependency. Core already depends on the contract and mask-risc unconditionally.
fold.rsgains onepub mod set_lower.Tests (
cargo test -p lance-graph --lib set_lower: 6 passed)i32lane, au32code lane and two planes, with N = 1000 (not a multiple of 64). Count and set equal the row oracle at every level, and so doesunsplit. The test also requires that both levels actually ran and that the runs narrowed the extents.Planeswith no lanes and no masks, reports 0 extents and uses at most 6 seeks.Keepbuffer.Disable runs (each restored afterwards)
geometry_reads_no_plane_lane_or_extentnew=unsplit)keepdoes not clear its destinationkeep)cargo clippy -p lance-graph --lib --tests -- -D warningsandcargo fmt --checkare clean.Not in this PR
D-CMR-2b. mask-risc's fused paths decline a
Pred(fused_ternlog,ir.rs:1012). A residual comparison therefore runs tiled, with per-tile scratch bounded byTILE_WORDS; it never writes a population-sized mask. The scratch-free predicate fold is a mask-risc change. mask-risc also has no counter for rows or words read, so the geometry claim is proven by running against empty planes instead.D-CMR-5 re-scope (your ruling, 2026-10-21)
The plan row and the STATUS row now read "BLOCKED: lawful design proposed". The design:
rebind/discover) stays option C.The gate includes valid distinct-source preimages, refusal of bag-sensitive Count/Sum, and refusal on a stale or missing witness. It stays blocked until there is a contract-level codebook witness; no operator is built. The decision is recorded in
entries/2026-10-21-d-cmr-5-rescope.md.Board:
STATUS_BOARD(D-CMR-2 In PR, D-CMR-5),LATEST_STATE, entries2026-10-21-d-cmr-2-lowering.mdand2026-10-21-d-cmr-5-rescope.md, entries index.mainis merged in (#1648); only the generated index conflicted.Generated by Claude Code