Repository navigation
contract: D-CMR-6 guarded rule catalogue (set_rules) + #1650 closeout - #1651
Conversation
Hygiene only (termination clause: generates no further arc entry). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
New zero-dependency module lance_graph_contract::set_rules: measures over one population (Count, Sum, CountRows, Add, Sub, Const, Opaque), explicit semantics (universe, exact/wrapping/checked/IEEE, two/three-valued, plain or _sym sums, distinct or bag), and six rules as data: set normalization, complement, relational difference, additive cancellation, range intersection, range count. The driver applies only strictly shrinking rewrites, to a fixpoint or a step budget; refused matches keep the original and are traced. Tests (17): differential against i128 / wrapping-i64 oracles over random tables and random rule subsets; experiments A, D, E; each guard removal turns its named test red. set_algebra.rs, set_program.rs, crepe, relalg and mask-risc unchanged; relalg suite passes unchanged. Board: STATUS D-CMR-6 In PR, plan gap ledger, LATEST_STATE inventory delta, entry 2026-10-21-d-cmr-6-rule-catalogue.md, entries index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e71382a67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…of _sym sums, IEEE range count Codex review of #1651 (four findings). Each new guard has a test; the bag and checked cases carry an oracle counterexample. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA
D-RA-2: relalg symbolic answers from contract::set_rules + #1651 closeout
Two commits, one per concern. Review them separately.
1.
dca11fd: #1650 closeout (board files only)STATUS_BOARD: D-CMR-2 marked Shipped (D-CMR-2: lower the contract set algebra onto mask-risc (runs as extents, three levels); D-CMR-5 re-scoped #1650,f031089).PR_ARC_INVENTORY: new entry for D-CMR-2: lower the contract set algebra onto mask-risc (runs as extents, three levels); D-CMR-5 re-scoped #1650.LATEST_STATE: new "main after D-CMR-2: lower the contract set algebra onto mask-risc (runs as extents, three levels); D-CMR-5 re-scoped #1650" section.2.
2e71382: D-CMR-6, the guarded rule catalogue and fixpoint driverNew zero-dependency module
lance_graph_contract::set_rules.Measures and semantics. A measure is
Count,Sum,CountRows,Add,Sub,ConstorOpaque. The semantics are explicit: the row count (universe), the arithmetic (exact, wrapping, checked, IEEE), two- or three-valued sets, plain or_symsums, and distinct rows or a bag.Rules. There are six, stored as data in
CATALOGUE:Count(¬A) → N − Count(A);Sum(A) − Sum(A∧B) → Sum(A∧¬B), and the same forCount;(a+b) − a → b;Guards. Each rule refuses when its conditions fail:
_symsums;A refused rewrite keeps the original expression and is recorded in the trace.
Driver. It applies only rewrites that strictly shrink the expression, and stops when no rule fires or the step budget runs out.
Tests (17).
i128and wrappingi64reference evaluators, with random subsets of the rules enabled. It also checks that most inputs are actually rewritten.i32accumulator is the counterexample: the original overflows, while the rewritten sum gives 5.Disable runs. I removed each guard in turn, and each removal fails exactly its named test.
Gates. All 1,539 contract tests pass. The 26 relalg tests pass unchanged. clippy
-D warningsand fmt are clean.Untouched:
set_algebra.rs,set_program.rs(U2), crepe (U3), relalg and mask-risc.Board, updated in the same commit: STATUS sets D-CMR-6 to In PR; new entry
entries/2026-10-21-d-cmr-6-rule-catalogue.md; the LATEST_STATE inventory delta; the plan's gap ledger.Coordination: claimed on EXO-50 as
session_013z2e1YXkm6o6HNrDn5BPWA/016; ownership confirmed ingpt-ada-01/004and/007.🤖 Generated with Claude Code
https://claude.ai/code/session_013z2e1YXkm6o6HNrDn5BPWA