Post-merge recovery for #1601–#1617 by AdaWorldAPI · Pull Request #1618 · AdaWorldAPI/lance-graph

AdaWorldAPI · 2026-10-19T19:59:56Z

PRs #1601–#1617 were merged with 17 review threads still unresolved and no board coverage. This PR fixes what was merged, branching from main (47697c77). The original PRs stay closed.

Commits

8c191498 act-r. Renames lance-graph-actr to lance-graph-act-r and the library to lance_graph_act_r, on edition 2024. The crate is standalone and excluded from the workspace, and builds in its own CI job, act-r.yml. Candidate gains an evaluated_at field. arbitrate now refuses the whole batch with Refusal::StaleCandidate if any candidate was evaluated against a different snapshot. 10 tests pass. With the guard disabled, 3 of them fail.
6791e4ac mask-risc. feat(mask-risc): expose scoped outgoing graph-hop fold #1616's OutgoingHop uses two MaskOp::Gather reads plus a scatter, so it reads positions taken from another lane's values. The 2026-10-16 ruling bans that shape. The hop now compiles only with the quarantined-gather-hop feature, which is off by default. A compile_fail doctest proves the hop is unreachable in a default build, and with the gate disabled that doctest fails. The six original tests run in CI with the feature on. The hop is neither deleted nor relabelled as a BIND. Tracked as ISS-GATHER-HOP-1616, until GATHER-DECISION.
f95c72fe docs and qualia.
- D-SRAM-4 is marked BLOCKED, and the optimizer gate is split in two.
- jirak is recorded as a gap: it is not a calibration API. Both row limits are stated.
- The causal-pickaxe prerequisite now names Lance 13 / LanceDB 0.40 and reuses the H14c-5 row-identity measurement.
- A Rejected candidate outcome is added. Fixture C-09 now uses DRed maintenance.
- The relative pronoun takes its case from inside the clause.
- Both qualia verifiers now use explicit checks instead of assert. The four musical fields are pinned to a SHA-256. Negative controls run under python -O, and a CI job is added (qualia-verify.yml).
429fcba6 d-rmap. The palette and the map now carry generations. §6a adds a table of falsifiers. Status stays PROPOSED.
b2c5453c board.
- Arc entries for all 17 PRs.
- New rows on STATUS_BOARD.
- Index entries for seven plans.
- New issue ISS-GATHER-HOP-1616.
- A new LATEST_STATE section.
- A reconciliation entry.
- The entries index is regenerated. The supersession index came out unchanged.

Review-thread reconciliation

PR	Threads	Disposition
#1603	1	Valid, fixed (commit 3)
#1604	2	Valid, fixed (commit 3)
#1605	1	Valid, fixed (commit 3)
#1607	2	Valid, fixed (commit 3)
#1608	1	Valid, fixed (commit 3)
#1612	2	Valid, fixed (commit 3)
#1613	2	Valid, fixed (commit 3)
#1614	2	Outdated: already fixed in the merged text (plan §148; SB-02a/b, SB-24b/c)
#1615	1	Valid, fixed (commit 1)
#1617	2	Valid, fixed (commit 4)
#1616	0	No review thread. The shape conflicts with the no-gather ruling and is quarantined (commit 2).

Verification

Check	Result
act-r tests	10/10 pass; fmt and clippy `-D warnings` clean
mask-risc, default build	200 tests and the compile_fail doctest pass
mask-risc, quarantine feature on	6/6 pass; clippy clean both ways
qualia verifiers	Pass under both normal Python and `-O`; 7 negative controls OK
`entries_index.py --check`	Passes
Supersession regeneration	No diff
Append-only board files	All grew

Open

GATHER-DECISION: deciding which gather-style reads are admitted. The quarantine does not decide this.
ACT-R Snapshot is still a local type; binding it to the canonical contract types is not done yet.
D-RMAP amortization is unmeasured.

Generated by Claude Code

…didate eligibility ACT-R is Adaptive Control of Thought, Rational; the old name read as actor/ractor. Package lance-graph-act-r, crate lance_graph_act_r, edition 2024 (standalone, zero dependencies, so no workspace-convention conflict). Correctness (#1615 review): Candidate carried no evaluation witness, so arbitrate() stamped any snapshot onto a decision whose eligibility was computed against another state, and witness_matches() then accepted it. Candidate now carries evaluated_at; arbitrate() refuses the whole batch with Refusal::StaleCandidate when any candidate (eligible or not) was evaluated at another snapshot. Tests: stale eligibility, fresh twin, mixed generations, recycled thought address, invalid scores, tie-break, stale decision. Registers the crate in the root exclude list and adds a CI job (.github/workflows/act-r.yml) so its tests run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyWZYKycy6MoYDxHRVnV5K

OutgoingHop's two MaskOp::Gather ops read frontier[sources[i]] and visible[targets[i]], and its terminal scatters by targets[i]: a read at a position taken from another lane's values, the shape the 2026-10-16 ruling marks as not to be built (D-HOLO H14c/H14d). Green CI does not override that. graph_hop now compiles only under the off-by-default `quarantined-gather-hop` feature, with a banner in its module doc. A compile_fail doctest pins that the default build cannot reach OutgoingHop; a CI step still runs the quarantined tests under the feature so the code does not rot. The other Gather consumers (quack Semijoin, dir-sim) predate the ruling and are unchanged: deciding their scope is the open GATHER-DECISION, not this commit. The petgraph lance-fold-hop experiment pins rev 66636da and is unaffected until it bumps; a bump must enable the feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyWZYKycy6MoYDxHRVnV5K

#1612 Souffle RAM plan: D-SRAM-4 marked OPEN/BLOCKED; its target, the d' driver of D-RA-4, is a banned gather shape and no lawful recursion driver exists yet. D-SRAM-2's gate split: disabling an optimizer rewrite must keep the answer and only remove the plan shape; negative controls disable a semantic guard instead. #1613 JC R API plan: jc::jirak exposes only prove(), so it is listed as a GAP, not a calibration provider. Both row limits stated: per-group exactness, and the total-input refusal (n_rows > 2^32) the grouped moment terminals apply before running. #1605 causal pickaxe plan: the Lance 7 / LanceDB 0.30 prerequisite was stale; the workspace is on lance 13.* / lancedb 0.40.*. Reuses H14c-5's row-identity measurement instead of repeating it. #1604 candidates RFC: adds a witnessed Rejected outcome; fixture C-09 asserts the derived result and admits DRed. #1603 language LEGO RFC: the relative pronoun agrees in gender and number only; its case comes from inside the relative clause. #1607/#1608 qualia verifiers: explicit checks instead of assert (they ran as no-ops under python -O); the four archival fields are checked against a pinned digest and the sidecar against the archive values. Negative controls in test_verify_qualia.py; CI job qualia-verify.yml runs both under -O. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyWZYKycy6MoYDxHRVnV5K

#1617 review (both findings verified): RelationTile was keyed by focus frame only, so it survived a map append, delete, compaction or reseal and could return obsolete adjacency; MapPalette had no generation of its own although the execution context requires MapPaletteId+Generation. RelationTile is now keyed by global MapId + map generation (or seal digest) + FocusBinding generation + access scope; MapPalette carries a palette generation that a slot reassignment bumps. Adds a falsifier table (map regeneration, palette-slot reassignment, focus-slot reuse, thought incarnation reuse, stale tile access, cross-tenant change). Architecture only; nothing implemented, CE64 untouched, RelAlg owns no tables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyWZYKycy6MoYDxHRVnV5K

The 17 PRs merged with no board rows. Prepends arc entries for each, STATUS_BOARD rows (ACT-R crate, graph_hop quarantine, D-RMAP, D-SRAM with D-SRAM-4 BLOCKED, D-JCR, D-JCSBI, CPG, VSC), plan index entries for the seven plans, ISS-GATHER-HOP-1616, a LATEST_STATE section, and an entry with the review-thread reconciliation table. Entries index regenerated; the supersession index is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyWZYKycy6MoYDxHRVnV5K

coderabbitai · 2026-10-19T20:00:04Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: fce698a9-4286-473b-a46b-f1f6d60acd7a

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-10-19T20:06:55Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-19T20:10:06.448087Z	`b2c5453`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2c5453cd8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

coderabbitai · 2026-10-19T20:10:20Z

Add Carrot credits or activate Agent usage billing to use Autofix

PR_ARC_INVENTORY entries for #1618 (post-merge recovery for #1601-#1617, merged dbe0696) and #1619 (D-RMAP binding palette generation and the §7 versioning crosswalk, merged 8e004a2), and a LATEST_STATE section for main after #1619. Contract inventory delta: none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyWZYKycy6MoYDxHRVnV5K

Two Codex findings on #1621, both checked against the plan text: - #1619: map generation is the sealed RelationshipMap/RelationFacts DurableRef only; ThoughtCommitId applies to palette generation alone (D-RMAP-1A §7.3). - #1618: at dbe0696 the thought-palette binding still keyed only MapPaletteId; #1618 added the map generation to the tile key and a palette generation to MapPalette. The binding change is #1619's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyWZYKycy6MoYDxHRVnV5K

D-RMAP focus probe and native join over a relationship table; board rows for #1618–#1620

#1601-#1617 carry no Claude Code footer in their PR bodies. #1618 gave them arc rows and one shared recovery entry, but most of their docs and data named no plan or board file, and no plan named them. - 19 artifacts (13 .arxiv notes, 2 language-LEGO docs, the 34-recipes doc, 2 qualia readmes, the act-r README) gain a "Plan and board" line under their title, pointing at an existing owning plan. - 11 existing plans gain a "Connected sources from #1601-#1617" section listing what they own (3 docs that already linked their plan are listed plan-side only). - graph_hop.rs names .claude/board/ISSUES.md instead of a bare ISSUES.md. - Board: entry 2026-10-20-chatgpt-prs-1601-1617-plan-links.md, a STATUS_BOARD section, an INTEGRATION_PLANS entry, regenerated index. No content, plan or D-id is invented. Qualia verifiers still pass (the pinned digest covers the JSON data, not the readmes). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f

claude added 5 commits October 19, 2026 19:48

AdaWorldAPI marked this pull request as ready for review October 19, 2026 20:06

chatgpt-codex-connector Bot reviewed Oct 19, 2026

View reviewed changes

Comment thread .claude/plans/d-rmap-separate-tables-thought-palettes-v1.md

Comment thread .github/workflows/act-r.yml

AdaWorldAPI merged commit dbe0696 into main Oct 19, 2026
21 checks passed

This was referenced Oct 19, 2026

d-rmap: palette generation in the binding, and versioning derived from Thought Git and #1605 #1619

Merged

MORK / PathMap Schnellverschluss: source switch, typed backend switch, differential probe (D-MPS-0..7) #1620

Merged

AdaWorldAPI mentioned this pull request Oct 19, 2026

D-RMAP focus probe and native join over a relationship table; board rows for #1618–#1620 #1621

Merged

AdaWorldAPI added a commit that referenced this pull request Oct 20, 2026

Merge pull request #1621 from AdaWorldAPI/ccr-08f48cec-lbv9l4

fcd1f60

D-RMAP focus probe and native join over a relationship table; board rows for #1618–#1620

AdaWorldAPI mentioned this pull request Oct 20, 2026

Consolidate into #1622: D-RPR-1 sub-cases, plan links for #1601–#1617, and the handoff lab probe #1624

Merged

Navigation Menu

Repository navigation

Post-merge recovery for #1601–#1617 - #1618

Post-merge recovery for #1601–#1617#1618
AdaWorldAPI merged 5 commits into
mainfrom
ccr-08f48cec-lbv9l4

AdaWorldAPI commented Oct 19, 2026

Uh oh!

coderabbitai Bot commented Oct 19, 2026 •

edited by AdaWorldAPI

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AdaWorldAPI commented Oct 19, 2026

Commits

Review-thread reconciliation

Verification

Open

Uh oh!

coderabbitai Bot commented Oct 19, 2026 • edited by AdaWorldAPI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Oct 19, 2026 •

edited by AdaWorldAPI

Loading

chatgpt-codex-connector Bot commented Oct 19, 2026 •

edited

Loading