Repository navigation
Consolidate into #1622: D-RPR-1 sub-cases, plan links for #1601–#1617, and the handoff lab probe - #1624
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
50641e6 to
af2ea13
Compare
#1622 is canonical for D-RST and D-RPR. #1624's duplicate plan file, same-named entry and status rows D-RPR-0..6 are withdrawn (dropped in the rebase); what #1622 lacked is now plan section 11 under the existing ids: - D-RPR-1 sub-cases 1a-1f (kill condition + disable run each) - anti-vacuity rules, incl. the measured first-focus failure - independent oracles; green -> red -> green protocol - refusals by axis: version, focus, scope, ordering, thought identity, narrow frame, capacity - measured preparation/reuse costs (break-even 76/11/1.8, CSR vs tile, escape reporting, bytes, zero-copy tension) - two-variable and multiplicity limits Corrections: WORLD/ANGLE/THOUGHT are metaphors (pointer notes in sections 1 and 3); thought identity is #1605's ThoughtCommitId and DurableRef; the "D-RST resolves to no plan" claim is withdrawn; D-MTP-1's Semijoin path is gather-shaped; the two ThoughtMask meanings are OPEN. The draft chain probe is banked as a patch in .claude/harvest/d-rpr-1-chain-probe-draft/: it applies to main 4dbd085, 5 of 6 tests pass there, and it is not merged because D-RPR-1 is not authorized. Board: the D-RPR-1 evidence column, entry 2026-10-20-d-rpr-consolidation-1624.md, regenerated index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
them arc rows and one shared recovery entry, but most of their docs and data named no plan or board file, and no plan named them. - 19 artifacts (13 .arxiv notes, 2 language-LEGO docs, the 34-recipes doc, 2 qualia readmes, the act-r README) gain a "Plan and board" line under their title, pointing at an existing owning plan. - 11 existing plans gain a "Connected sources from #1601-#1617" section listing what they own (3 docs that already linked their plan are listed plan-side only). - graph_hop.rs names .claude/board/ISSUES.md instead of a bare ISSUES.md. - Board: entry 2026-10-20-chatgpt-prs-1601-1617-plan-links.md, a STATUS_BOARD section, an INTEGRATION_PLANS entry, regenerated index. No content, plan or D-id is invented. Qualia verifiers still pass (the pinned digest covers the JSON data, not the readmes). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
same-named entry and status rows D-RPR-0..6 are withdrawn (dropped in the rebase); what #1622 lacked is now plan section 11 under the existing ids: - D-RPR-1 sub-cases 1a-1f (kill condition + disable run each) - anti-vacuity rules, incl. the measured first-focus failure - independent oracles; green -> red -> green protocol - refusals by axis: version, focus, scope, ordering, thought identity, narrow frame, capacity - measured preparation/reuse costs (break-even 76/11/1.8, CSR vs tile, escape reporting, bytes, zero-copy tension) - two-variable and multiplicity limits Corrections: WORLD/ANGLE/THOUGHT are metaphors (pointer notes in sections 1 and 3); thought identity is #1605's ThoughtCommitId and DurableRef; the "D-RST resolves to no plan" claim is withdrawn; D-MTP-1's Semijoin path is gather-shaped; the two ThoughtMask meanings are OPEN. The draft chain probe is banked as a patch in .claude/harvest/d-rpr-1-chain-probe-draft/: it applies to main 4dbd085, 5 of 6 tests pass there, and it is not merged because D-RPR-1 is not authorized. Board: the D-RPR-1 evidence column, entry 2026-10-20-d-rpr-consolidation-1624.md, regenerated index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
…fter #1623 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
af2ea13 to
af3cb0f
Compare
One fold's escapes drive the next counted preparation lookup (rebind's neighbours seeks); the mask-risc fold stays co-addressed (no Gather, no scatter). Eight tests against a full-scan oracle; chain_cost example times each transition against direct and full-rebuild arms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
Plan §11.10 names the operation chain (fold escapes -> rebind seeks -> slot_of translation), the disable runs and the measured costs; the banked patch is marked superseded; board row and a dated entry carry the result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
The entry describes what the PRs lacked (plan and board links), not who wrote them. Renamed the entry file and updated every link to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b702f0acd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let focus = self.focus.replace(&changes); | ||
| let w = at(current, &focus); | ||
| let full_seeks = focus.len() * self.preds.len(); | ||
| let (csr, tile, seeks) = match how { | ||
| Rebuild::Incremental => { | ||
| let (csr, tile) = rebind(run, &self.focus, &focus, &self.csr, w); |
There was a problem hiding this comment.
Validate the old witness before restamping admission
When ask begins with seeds outside the focus, or a later fold produces escapes, this path rebuilds the old run/CSR while copying the caller's new facts, seal, and scope values into w without first checking the existing frame. A stale frame can therefore be “refreshed” after a facts, index, or authorization-scope change, and the subsequent reach witness check passes even though the prepared data still came from the old world; the current stale-world test misses this because its seed is already focused, so admit returns before restamping. Check the frame against the non-focus witness components before performing either rebuild.
Useful? React with 👍 / 👎.
Rebased onto
mainafter #1622 and #1623 merged. #1622 is the canonical owner of D-RST and D-RPR. This PR carries only what it lacked.1. Plan links for #1601–#1617
#1601–#1617 merged docs and data that named no plan, and no plan named them. #1618 gave them arc rows only.
graph_hop.rsnames.claude/board/ISSUES.md.2026-10-20-prs-1601-1617-plan-links.md, plus a status section and a plan-index entry.2. D-RPR consolidation (
79133f7,af3cb0f)My earlier duplicate plan file, its same-named entry and status rows D-RPR-0..6 are dropped. What #1622's plan lacked is now its §11, under the existing ids:
It also corrects:
Semijoin;ThoughtMaskcollision, which stays OPEN.3. The handoff as a lab demonstration (
2aaf6e7,b702f0a)This is the gather-shaped transition, kept outside the fold. The 2026-10-16 no-gather ruling stands, and no admission is claimed.
The code is in
crates/mork-pathmap-probe:src/chain.rs,tests/chain.rsandexamples/chain_cost.rs. The only change to existing code makesTileExec::programpub. The full write-up is plan §11.10.TileExec::reachruns a mask-risc program over tile planes in one(target, source)space. A test reads the program itself and finds noGatherand no scatter terminal. Its twin checks that a program with a Gather is detected.rebindmakes oneSortedRun::neighboursseek per changed slot and predicate, and every seek is counted.Focus::slot_ofmaps global to local inside preparation.rebind's CSR copy, not seeks.keepin eviction:asklivelocks, so the test hangs instead of failing and only a timeout catches it.Still open:
rebindcopy floor;Gates
cargo fmt --check,clippy -D warningsandcargo testinmork-pathmap-probe, each with and without--features leapfrog: green.entries_index.py --check: current (381 rows).append_only_gate.py: no protected file shrank.supersession_index.py: regenerates unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01VncKoyG6JkpsoqhqTGTv3f