Repository navigation
Mirror the OGAR CRM domain and app prefixes 0x0008–0x000B - #1438
Merged
Merged
Conversation
Adds ConceptDomain::Crm (high byte 0x05) and the 15 CRM codebook rows
crm_contact 0x0501 through crm_custom_record 0x050F, matching OGAR's
ogar-vocab. Also adds AppPrefix::{Osm, WeatherNext, Spear, HubSpo}
(0x0008-0x000B): OGAR had allocated them but the contract could not
name them without depending on ogar-vocab.
0x0500 is now Crm instead of Unassigned; 0x0006 stays unallocated.
lance-graph-ogar parity passes against the OGAR branch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 07:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract mirror for AdaWorldAPI/OGAR#330.
What
ogar_codebook::ConceptDomain::Crmat high byte0x05, plus the 15CODEBOOKrowscrm_contact 0x0501…crm_custom_record 0x050F, identical to OGAR'sogar-vocab.AppPrefix::{Osm 0x0008, WeatherNext 0x0009, Spear 0x000A, HubSpo 0x000B}. OGAR had already allocated these prefixes, but zero-dep consumers could not name them without depending onogar-vocab.0x0006stays unallocated.0x0500re-pinned fromUnassignedtoCrm,0x0600pinned asUnassigned; added round-trip checks for the new prefixes andrender_classid_for_concept(HubSpo, "crm_deal") == 0x0503_000B.LATEST_STATE.mdgets an entry.Landing order
OGAR #330 first, this straight after. The
lance-graph-ogarparity check runs against OGARmain, so this branch is red until #330 merges, andmainis red from that merge until this lands (the same red window asosm_street_node, #268).Verification
lance-graph-contractlib tests: 1458 passed. Clippy-D warningsis clean on the lib. I ran these in a standalone copy of the crate because the workspace needs anndarraysibling this container lacks. In that copy themanifest_codegenintegration test does not compile; it needs the workspacemodules/directory, which a standalone copy does not have, so this change is not the cause.lance-graph-ogarwith OGAR patched to the docs: add Cursor Cloud specific instructions to AGENTS.md #330 branch (lockfile confirms a path source): 84 + 5 + 6 + 6 + 4 passed, 1 ignored. That includesmirror_is_a_faithful_copy_of_ogar_codebookin both directions.🤖 Generated with Claude Code
https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Generated by Claude Code