Skip to content

Mirror the OGAR CRM domain and app prefixes 0x0008–0x000B - #1438

Merged
AdaWorldAPI merged 1 commit into
mainfrom
ccr-1d749cc5-q8s5qs
Oct 10, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
ccr-1d749cc5-q8s5qs

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Contract mirror for AdaWorldAPI/OGAR#330.

What

  • ogar_codebook::ConceptDomain::Crm at high byte 0x05, plus the 15 CODEBOOK rows crm_contact 0x0501 … crm_custom_record 0x050F, identical to OGAR's ogar-vocab.
  • AppPrefix::{Osm 0x0008, WeatherNext 0x0009, Spear 0x000A, HubSpo 0x000B}. OGAR had already allocated these prefixes, but zero-dep consumers could not name them without depending on ogar-vocab. 0x0006 stays unallocated.
  • Tests: 0x0500 re-pinned from Unassigned to Crm, 0x0600 pinned as Unassigned; added round-trip checks for the new prefixes and render_classid_for_concept(HubSpo, "crm_deal") == 0x0503_000B.
  • LATEST_STATE.md gets an entry.

Landing order

OGAR #330 first, this straight after. The lance-graph-ogar parity check runs against OGAR main, so this branch is red until #330 merges, and main is red from that merge until this lands (the same red window as osm_street_node, #268).

Verification

  • lance-graph-contract lib tests: 1458 passed. Clippy -D warnings is clean on the lib. I ran these in a standalone copy of the crate because the workspace needs an ndarray sibling this container lacks. In that copy the manifest_codegen integration test does not compile; it needs the workspace modules/ directory, which a standalone copy does not have, so this change is not the cause.
  • lance-graph-ogar with OGAR patched to the docs: add Cursor Cloud specific instructions to AGENTS.md #330 branch (lockfile confirms a path source): 84 + 5 + 6 + 6 + 4 passed, 1 ignored. That includes mirror_is_a_faithful_copy_of_ogar_codebook in both directions.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z


Generated by Claude Code

Adds ConceptDomain::Crm (high byte 0x05) and the 15 CRM codebook rows
crm_contact 0x0501 through crm_custom_record 0x050F, matching OGAR's
ogar-vocab. Also adds AppPrefix::{Osm, WeatherNext, Spear, HubSpo}
(0x0008-0x000B): OGAR had allocated them but the contract could not
name them without depending on ogar-vocab.

0x0500 is now Crm instead of Unassigned; 0x0006 stays unallocated.
lance-graph-ogar parity passes against the OGAR branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f2a89694-41d3-4736-87ff-b590dfe5d33f

📥 Commits

Reviewing files that changed from the base of the PR and between 4025314 and 2831063.


📒 Files selected for processing (2)
  • .claude/board/LATEST_STATE.md
  • crates/lance-graph-contract/src/ogar_codebook.rs

 _____________________________________________________________________________________________________________________________
< I have a dream, that one day, my four little PRs will not be judged by their indentation but by the content of their logic. >
 -----------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 10, 2026 07:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T07:51:17.794053Z 2831063 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 6e40f43 into main Oct 10, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants