Repository navigation
Bump Rust toolchain pin from 1.97.1 to 1.98.1 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: Lint | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| concurrency: | ||
| group: lint-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| format: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| # No `toolchain:` input — the action reads `rust-toolchain.toml`, so the | ||
| # pinned version lives in exactly ONE place. | ||
| components: rustfmt, clippy | ||
| - run: cargo fmt --all --check | ||
|
|
||
| clippy: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| # No `toolchain:` input — the action reads `rust-toolchain.toml`, so the | ||
| # pinned version lives in exactly ONE place. | ||
| components: rustfmt, clippy | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - run: cargo clippy --all-targets -- -D warnings | ||
|
|
||
| test: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| # No `toolchain:` input — the action reads `rust-toolchain.toml`, so the | ||
| # pinned version lives in exactly ONE place. | ||
| components: rustfmt, clippy | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - run: cargo test --workspace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| [toolchain] | ||
| channel = "1.98.1" | ||
| # The pinned version is the `channel` line ABOVE — deliberately not restated | ||
| # in this comment, so a future bump touches one line rather than editing | ||
| # prose that then drifts. (lance-graph's rust-toolchain.toml explains the | ||
| # same reasoning; every sibling repo in this stack — lance-graph, OGAR, | ||
| # tesseract-rs, stockfish-rs, ruff — follows this shape.) | ||
| # | ||
| # This file did not exist before this pin. Before it, a2ui-rs carried the | ||
| # toolchain only as PROSE — CLAUDE.md's `cargo +1.97.1 test/clippy/fmt`, | ||
| # docs/WASM-INTEGRATION.md, scripts/build-graph-wasm.sh's `RUST_TOOLCHAIN` | ||
| # default, and the two Dockerfiles' `ARG RUST_VERSION` — with no | ||
| # `.github/workflows/` at all in this repo to enforce any of it. That is | ||
| # exactly the drift shape this file exists to close: a bare `cargo` in this | ||
| # checkout now resolves to the reviewed toolchain without a human copying a | ||
| # version string across five files by hand. | ||
| # | ||
| # `rust-version = "1.95"` in Cargo.toml remains the crate's own declared | ||
| # MSRV floor and is untouched by this file — this channel is an alignment | ||
| # choice with the sibling repos, same as the Dockerfiles already document | ||
| # ("by ALIGNMENT, not by necessity"). Note the ndarray fork's OWN manifest | ||
| # now declares `rust-version = "1.98"` (verified in the sibling checkout), | ||
| # so 1.95 no longer reliably builds this workspace's `ndarray` git | ||
| # dependency regardless of this file's channel — a separate, pre-existing | ||
| # gap this bump does not attempt to close (see CLAUDE.md / this session's | ||
| # report for detail). | ||
| # | ||
| # Bump log (append one line per bump): | ||
| # (no file) → 1.98.1 added the file + bumped from the prose-only 1.97.1 | ||
| # pin in one step, joining the workspace-wide 1.98 sweep | ||
| # already landed in lance-graph / OGAR / stockfish-rs / | ||
| # ruff. Delta measured in THIS repo via | ||
| # `cargo clippy --all-targets -- -D warnings`: 2 findings, | ||
| # both `clippy::chunks_exact_to_as_chunks` (new in 1.98, | ||
| # default-on STYLE group) — `crates/a2ui-graph/src/ | ||
| # radial.rs` and `crates/a2ui-graph/src/gpu.rs`, both | ||
| # test-only `chunks_exact(N)` calls, fixed to | ||
| # `.as_chunks::<N>().0`. No `#![allow(...)]`/ | ||
| # `#![expect(...)]` list carried the removed | ||
| # `clippy::from_iter_instead_of_collect`. `cargo test` | ||
| # and `cargo fmt --check` were both clean before and | ||
| # after the fix. | ||
| # | ||
| # Never auto-track `stable` — bump explicitly when a future version is | ||
| # reviewed and the workspace's fmt/clippy/test gates pass clean. | ||
| # | ||
| # rustfmt + clippy ride the pin so a fresh `rustup show` in this workspace | ||
| # materializes the complete CI-equivalent toolchain in one step (same | ||
| # rationale lance-graph's file states in full). | ||
| components = ["rustfmt", "clippy"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
✅ Runtime observed
🏁 Script executed:
Repository: AdaWorldAPI/a2ui-rs
Length of output: 208
🏁 Script executed:
Repository: AdaWorldAPI/a2ui-rs
Length of output: 6181
🏁 Script executed:
Repository: AdaWorldAPI/a2ui-rs
Length of output: 2784
🏁 Script executed:
Repository: AdaWorldAPI/a2ui-rs
Length of output: 2749
Use an available toolchain in the override example.
The
1.99.0channel is unavailable, soRUST_TOOLCHAIN=1.99can fail in both the target check andcargo "+$TOOLCHAIN". UseRUST_TOOLCHAIN=betafor a preview build.Proposed documentation fix
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: MCP tools