Skip to content

ogar-dir-sim: mail is a business-card property; ExchangeGuid is the immutable mailbox identity (doc) - #338

Merged
AdaWorldAPI merged 3 commits into
mainfrom
ccr-0455e606-wmtsor
Oct 10, 2026
Merged

AdaWorldAPI merged 3 commits into
mainfrom
ccr-0455e606-wmtsor

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

What

Docs only:

  • AddressRole::Mail: mail is a property on the user's business card, like the telephone number. It follows the user, not the mailbox or the recipient. It is not identity, not received at, and not provisioned.
  • ExchangeIdentity:
    • A provisioned mailbox's immutable identity is its exchange_guid.
    • PrimarySmtpAddress (primary_smtp) identifies the recipient implicitly, as a string, and can change.
    • node is the on-premises object.
    • ExternalDirectoryObjectId links the mailbox to its Entra user.
    • This replaces the incorrect line "an address is a value of an identity, never the key".

lance-graph #1446 and Stalwart #9 carry the same wording.

Verified (Rust 1.99.0, debug 0)

  • fmt --check and cargo doc are clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg

…not the mailbox

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: c2198761-066f-4172-a57a-fb0f120478cf

📥 Commits

Reviewing files that changed from the base of the PR and between 1189b43 and e420569.


📒 Files selected for processing (2)
  • crates/ogar-dir-sim/src/exchange.rs
  • crates/ogar-dir-sim/src/violation.rs

 _____________________________________________________
< Merge conflicts fear my conflict-resolution skills. >
 -----------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

…tpAddress identifies the recipient

mail is a property on the user's business card, like the telephone number:
shown in the address book and used inside messages, it follows the user
rather than the mailbox, and is not identity. The recipient's identity is
its PrimarySmtpAddress; the provisioned mailbox is identified by its
ExchangeGuid; ExternalDirectoryObjectId links the mailbox to its Entra user.
Replaces the 'licence plate' wording.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@AdaWorldAPI AdaWorldAPI changed the title ogar-dir-sim: mail is the user's licence plate; it follows the user (doc) ogar-dir-sim: mail is a business-card property; PrimarySmtpAddress identifies the recipient (doc) Oct 10, 2026
…SmtpAddress identifies the recipient implicitly and can change

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@AdaWorldAPI AdaWorldAPI changed the title ogar-dir-sim: mail is a business-card property; PrimarySmtpAddress identifies the recipient (doc) ogar-dir-sim: mail is a business-card property; ExchangeGuid is the immutable mailbox identity (doc) Oct 10, 2026
@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 10, 2026 11:33
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@AdaWorldAPI
AdaWorldAPI merged commit b9d698c into main Oct 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants