Repository navigation
ogar-dir-sim: mail hydrates no identity; remove MailLabel - #337
Merged
Merged
Conversation
MailLabel (from #332) modelled mail as a trigger that resolves to the address holder's ExchangeIdentity. It does not: mail is a label any account may carry, it resolves to nothing, and identity is read by GUID only — the object, then the mailbox's ExchangeGuid once provisioned, and ExternalDirectoryObjectId across the hybrid join. ExchangeIdentity stays (read by GUID); MailLabel and its export are removed, and the AddressRole::Mail doc says so. No consumer used MailLabel (lance-graph #1444 drops its use in the same step). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
…messages; not identity, receiving or provisioning) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
…sses correctly
ExternalDirectoryObjectId is the Entra identity (formerly MsolUser) every
mail recipient has, not a hybrid-join key; that identity carries
{alias}@{tenant}.onmicrosoft.com (Microsoft-internal cloud address). The
routing address {alias}@{tenant}.mail.onmicrosoft.com is the external EOP
target. ExchangeGuid identifies the provisioned mailbox.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
…a user
"External" names the directory outside Exchange: the recipient's link
from mailbox to user. The user (Entra, formerly MsolUser) carries
{alias}@{tenant}.onmicrosoft.com; the mailbox is identified by its
ExchangeGuid; the routing address is the EOP target.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 11:21
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects #332.
mailis the licence plate. It is shown in the address book and used inside messages, and it matters, but it is a label:MailLabelmodelledmailas a trigger that resolved to the address holder'sExchangeIdentity. That was wrong, so it is removed along with its re-export. Nothing outside OGAR used it; lance-graph #1444 (merged) dropped its use.Identities are GUIDs, never addresses:
node: the on-premises object (objectGUID).exchange_guid: the provisioned mailbox.ExternalDirectoryObjectId: links every mail recipient's mailbox to its user. "External" refers to the directory outside Exchange: the user is the Entra object (formerly the MsolUser), which carries{alias}@{tenant}.onmicrosoft.com, Microsoft's internal cloud address.The routing address is not the Entra user's address.
{alias}@{tenant}.mail.onmicrosoft.com(ROUTING) is the external target Exchange Online Protection (EOP) delivers to. TheExchangeIdentity,ROUTING, module andAddressRole::Maildocs now say all of this, including that themailmodel holds as long as AD Connect does not usemailas the sync anchor.Verified (Rust 1.99.0, debug 0)
cargo test --workspace: 1050 passed, 0 failed.clippy --workspace --all-targets -D warnings: clean.fmt --all --check: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg