Skip to content

Mint the CRM domain (0x05XX) and HubSpoPort (0x000B) - #330

Merged
AdaWorldAPI merged 1 commit into
mainfrom
ccr-1d749cc5-q8s5qs
Oct 10, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
ccr-1d749cc5-q8s5qs

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

  • ConceptDomain::Crm at high byte 0x05, with 15 concepts 0x0501–0x050F: contact, company, deal, ticket, lead, pipeline, pipeline stage, call, meeting, task, note, list, campaign, sequence, custom record. Each has a class_ids constant, an identity-only builder and a row in all_canonical_classes.
  • ports::HubSpoPort, app prefix 0x000B, for the hubspo-rs consumer. It aliases the 15 CRM concepts and maps ten more objects onto existing core concepts instead of minting new ones:
    • email → email 0x0B05
    • product → product 0x0207
    • line item → commercial_line_item 0x0201
    • quote, invoice, order → commercial_document 0x0202
    • commerce payment → payment_record 0x0205
    • tax rate → tax_policy 0x0203
    • user, team → project_actor 0x0104
  • Docs: APP-CLASS-CODEBOOK-LAYOUT gets the 0x05 domain and the 0x000B row; DISCOVERY-MAP gets the new entry D-CRM-DOMAIN.

Decisions worth a look

  • The 0x05 byte. RecipeConceptId family bytes 0x05/0x06 (Scope/Concern) are a separate, typed address space and stay reserved mint-on-emit. The board's LATEST_STATE domain table mixed the two spaces and also still listed Weather (0x04) as unassigned; both are corrected.
  • Custom objects and custom properties stay tenant data. They share the one crm_custom_record concept and are never minted.
  • No crm_actions rows yet. As with geo_actions, capabilities are declared once the consumer implements them; declaring surface nobody implements would be fiction. resolve_hotplug will report NoCapabilitiesFor for the port until then.

Landing order

lance-graph's CI checks lance-graph-ogar parity against OGAR main, so after this merges its mirror (ogar_codebook.rs: ConceptDomain::Crm, the 15 rows, AppPrefix entries) is red until the mirror PR lands. That PR follows straight after this one.

Verification

  • cargo test on all 25 crates that depend on ogar-vocab: green.
  • cargo fmt --check and clippy -D warnings on ogar-vocab and ogar-class-view: clean.
  • Disable check: removing the 0x05 => Crm arm fails five tests (the three CRM mint tests, the email-domain test and the HubSpoPort coverage test). The arm was restored afterwards.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z


Generated by Claude Code

Adds ConceptDomain::Crm at high byte 0x05 with 15 concepts,
crm_contact 0x0501 through crm_custom_record 0x050F, each with a
class_ids constant, an identity-only builder, and a row in
all_canonical_classes. HubSpoPort (app prefix 0x000B) aliases the
15 CRM concepts and converges ten more HubSpot objects onto existing
core concepts (email, product, line item, commercial document,
payment record, tax policy, project actor) instead of minting.

Custom objects and custom properties stay tenant data: they share the
one crm_custom_record concept. No crm_actions rows yet; capabilities
are declared once the consumer implements them, as with geo_actions.

The recipe family bytes 0x05/0x06 (RecipeConceptId) are a separate
typed address space and stay reserved mint-on-emit; the board row that
mixed the two spaces is corrected, and Weather (0x04) is listed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 32cc8c56-642a-440c-95a3-9d988cdaab62

📥 Commits

Reviewing files that changed from the base of the PR and between 5ae0db4 and c6a7797.


📒 Files selected for processing (6)
  • .claude/board/LATEST_STATE.md
  • crates/ogar-class-view/src/lib.rs
  • crates/ogar-vocab/src/lib.rs
  • crates/ogar-vocab/src/ports.rs
  • docs/APP-CLASS-CODEBOOK-LAYOUT.md
  • docs/DISCOVERY-MAP.md

 ________________________________________________________________________
< This is like dependency injection, except the dependency is suffering. >
 ------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 10, 2026 07:50
@AdaWorldAPI
AdaWorldAPI merged commit f988514 into main Oct 10, 2026
4 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T07:51:18.151315Z c6a7797 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants