Repository navigation
Mint the CRM domain (0x05XX) and HubSpoPort (0x000B) - #330
Merged
Merged
Conversation
Adds ConceptDomain::Crm at high byte 0x05 with 15 concepts, crm_contact 0x0501 through crm_custom_record 0x050F, each with a class_ids constant, an identity-only builder, and a row in all_canonical_classes. HubSpoPort (app prefix 0x000B) aliases the 15 CRM concepts and converges ten more HubSpot objects onto existing core concepts (email, product, line item, commercial document, payment record, tax policy, project actor) instead of minting. Custom objects and custom properties stay tenant data: they share the one crm_custom_record concept. No crm_actions rows yet; capabilities are declared once the consumer implements them, as with geo_actions. The recipe family bytes 0x05/0x06 (RecipeConceptId) are a separate typed address space and stay reserved mint-on-emit; the board row that mixed the two spaces is corrected, and Weather (0x04) is listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ConceptDomain::Crmat high byte0x05, with 15 concepts0x0501–0x050F: contact, company, deal, ticket, lead, pipeline, pipeline stage, call, meeting, task, note, list, campaign, sequence, custom record. Each has aclass_idsconstant, an identity-only builder and a row inall_canonical_classes.ports::HubSpoPort, app prefix0x000B, for the hubspo-rs consumer. It aliases the 15 CRM concepts and maps ten more objects onto existing core concepts instead of minting new ones:email0x0B05product0x0207commercial_line_item0x0201commercial_document0x0202payment_record0x0205tax_policy0x0203project_actor0x0104APP-CLASS-CODEBOOK-LAYOUTgets the0x05domain and the0x000Brow;DISCOVERY-MAPgets the new entry D-CRM-DOMAIN.Decisions worth a look
0x05byte.RecipeConceptIdfamily bytes0x05/0x06(Scope/Concern) are a separate, typed address space and stay reserved mint-on-emit. The board'sLATEST_STATEdomain table mixed the two spaces and also still listed Weather (0x04) as unassigned; both are corrected.crm_custom_recordconcept and are never minted.crm_actionsrows yet. As withgeo_actions, capabilities are declared once the consumer implements them; declaring surface nobody implements would be fiction.resolve_hotplugwill reportNoCapabilitiesForfor the port until then.Landing order
lance-graph's CI checks
lance-graph-ogarparity against OGARmain, so after this merges its mirror (ogar_codebook.rs:ConceptDomain::Crm, the 15 rows,AppPrefixentries) is red until the mirror PR lands. That PR follows straight after this one.Verification
cargo teston all 25 crates that depend onogar-vocab: green.cargo fmt --checkandclippy -D warningsonogar-vocabandogar-class-view: clean.0x05 => Crmarm fails five tests (the three CRM mint tests, the email-domain test and the HubSpoPort coverage test). The arm was restored afterwards.🤖 Generated with Claude Code
https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Generated by Claude Code