Repository navigation
Query: saved views with edge sort over Quack; views through the IAM gate (D-QRY-3) - #45
Merged
Merged
Conversation
…ate (D-QRY-3) A SavedView is data: object, filter groups, one sort key, columns. page() returns one page in the view's order without ORDER BY: storage order with no key; for an I32 key the values at the page's first and last rank are found by Count-threshold bisection and only the band between them is sorted; for a code key one GroupReduce Count picks the codes overlapping the page. Ties go by ordinal, records without a value last. hubspo-compat::views::open_view refuses a view whose filter or sort reads a hidden property and drops hidden columns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c64f677a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… authorized concept Codex on #45: a zero-length I32 page underflowed r1 - 1, and open_view never checked that the view's object is the concept the access was compiled for, so an unfiltered view of another object passed. The store now answers which concept a table holds, and anything else is refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the saved-view half of D-QRY-3, claimed on EXO-50 in message 017. The board half shipped in #21.
hubspo-query::viewSavedViewis data only: the object, its filter groups, at most one sort key, and the columns. Sharing and column visibility are decided at the output edge.page(view, binder, offset, limit, runner)returns one page of ordinals in the view's order. Quack has noORDER BY, so the sort happens at the edge:Agg::Rows, in storage order.I32key: bisection withCountthresholds finds the values at the page's first and last rank, at most 33 programs per bound. Only the band between those two values is materialised and sorted, which is the page plus any ties at its ends.GroupReduce Countgives a count per code. Only the codes that overlap the page are materialised.Runneris the caller's executor. The test implements it on mask-risc.hubspo-compat::views::open_viewTests
tests/view_oracle.rscompares every page against a plain Rust sort over 3,000 records:I32keys (one nullable with a narrow, tie-heavy range; one covering the full range includingi32::MINandi32::MAX), and two code keys (one nullable, one with an empty code);hubspo-compathas twoopen_viewtests.-D warnings, and tests all pass.Disable runs: all eight went red.
beforecount ignored;Still open
ORDER BYwaits on it.The board is updated: LATEST_STATE and the D-QRY-3 row on STATUS_BOARD.
Generated by Claude Code