Repository navigation
Probe P-VIEW-1: saved-view page cost at 1M and 4M rows - #46
Merged
Merged
Conversation
25-record pages at 1M and 4M rows. An I32 key runs 67 Count programs and takes about twice as long as sorting every kept record at the edge; a code key costs about 1.7 scans. The rank-select / ORDER BY ask goes upstream (ISS-ORDER-BY-RANK-SELECT). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a406a5f7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…d apart Codex on #46: the nullable amount key's tail offset fell in its null tail, which runs 2 programs and no bisection, so '67 programs whatever the offset' did not hold for every printed row. Offsets now come from the key's valued count, the null-tail page gets its own labelled row, and the board quotes ranges over three runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a probe and board entries; no library code changes. It measures what one saved-view page costs without
ORDER BY(the D-QRY-3 follow-up from #45).cargo run --release -p hubspo-query --example probe_view_page [rows]measures 25-record pages throughview::page. Each run reports programs run, rows materialised and the median of 5 runs, alongside two references:Countover the key lane, the floor for any in-engineORDER BY.Offsets are taken from each key's valued count. A nullable key also gets one page entirely inside its null tail, reported on its own row. On ascending-order cases the probe also asserts that the page matches the full sort.
Ranges over three runs; timings on this shared container vary:
I32page (valued)I32key: 67 programs on every page with valued records. That is 60–100 scans, and 1.6–2.8× the cost of sorting everything at the edge. The probe fails here.The board records
ISS-ORDER-BY-RANK-SELECTand the measurement on the D-QRY-3 row and in LATEST_STATE. The rank-select /ORDER BYrequest goes to lance-graph on EXO-50 (message 019, corrected by a reply). HubSPO-rs builds nothing in its place.🤖 Generated with Claude Code
https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z