fix(query): expose pulsetime param in q2_flood - #142
Merged
ErikBjare merged 1 commit intoJul 21, 2026
Conversation
The Work Time Report generates flood(bucket, 300) where 300 is the break time in seconds. The underlying flood() transform already accepts pulsetime as an optional kwarg (default 5s), but q2_flood only accepted one argument, causing a QueryInterpreterException on every Work Time Report query. Fixes ActivityWatch/activitywatch#1361
Greptile SummaryThis PR exposes the flood pulse-time parameter in the query language. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(query): expose pulsetime param in q2..." | Re-trigger Greptile |
Contributor
Author
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Work Time Report in aw-webui generates queries like:
where
300is the user-configured break time in seconds. The query language wrapperq2_floodonly accepted one argument, causing:{"type": "QueryInterpreterException", "message": "Tried to call function flood with invalid amount of arguments"}This breaks the Work Time Report completely (ActivityWatch/activitywatch#1361).
Fix
The underlying
flood()transform inaw_transform/flood.pyalready acceptspulsetime: float = 5as an optional parameter. This PR exposes it in the query language:The default is unchanged (5 seconds), so all existing single-argument
flood()calls are unaffected.Test
Added
test_query2_flood_with_pulsetimewhich verifies:flood(events)with the default 5s pulsetime leaves a 60s gap unfilled (2 events remain)flood(events, 300)with a 300s pulsetime fills the 60s gap (1 merged event)Fixes ActivityWatch/activitywatch#1361